Commit Graph

2957 Commits

Author SHA1 Message Date
Christoph Wurst 28f8eb5dba
Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
John Molakvoæ 732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
Christoph Wurst 85e369cddb
Fix multiline comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
Robin Appelman 2340f4f2d5
update icewind/smb to 3.2.3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 17:30:47 +02:00
Nextcloud bot 8146e1988c
[tx-robot] updated from transifex 2020-04-08 02:18:45 +00:00
Roeland Jago Douma 1d62b9786f
Merge pull request #20276 from nextcloud/files-external-param-tooltop
allow setting tooltips for external storage config options
2020-04-06 16:42:39 +02:00
Nextcloud bot cac1480bf8
[tx-robot] updated from transifex 2020-04-05 02:18:04 +00:00
Robin Appelman 857957b45e
allow setting tooltips for external storage config options
allows explaining non-obvious config options a bit more

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 15:44:53 +02:00
Nextcloud bot 4e8bbc4e34
[tx-robot] updated from transifex 2020-04-03 12:08:12 +00:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
John Molakvoæ fa4162e86f
Merge pull request #20208 from nextcloud/smb-folder-contents-normalize-path
normalize smb path while listing folder contents
2020-03-30 10:06:39 +02:00
John Molakvoæ 20ecbd60fd
Merge pull request #20207 from nextcloud/smb-3.2.1
update icewind/smb to 3.2.1
2020-03-30 10:05:48 +02:00
Nextcloud bot 89710bbdcf
[tx-robot] updated from transifex 2020-03-29 02:20:14 +00:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +01:00
Robin Appelman ef7bb5225a
normalize smb path while listing folder contents
currently when listing `'/'`, it will include a double slash in the paths used for the listing logic
this causes unneeeded cache misses in the statCache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 17:04:53 +01:00
Robin Appelman b41e62db99
update icewind/smb to 3.2.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 16:57:55 +01:00
Nextcloud bot f680f19364
[tx-robot] updated from transifex 2020-03-27 02:18:20 +00:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Christoph Wurst 2ee65f177e
Use the shorter phpunit syntax for mocked return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
Christoph Wurst 74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
Nextcloud bot e4d85fa284
[tx-robot] updated from transifex 2020-03-25 02:18:27 +00:00
Nextcloud bot be4cf8992d
[tx-robot] updated from transifex 2020-03-23 02:19:02 +00:00
Christoph Wurst c5cb3bb665
Do not use the deprecated service name
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-19 15:04:23 +01:00
Roeland Jago Douma 0eb3c3ed18
Merge pull request #19932 from nextcloud/remove-placeholder-check
remove the requirement that everything that looks like a placeholder …
2020-03-17 21:34:08 +01:00
Nextcloud bot 82d4bdd770
[tx-robot] updated from transifex 2020-03-17 02:18:42 +00:00
Nextcloud bot 0d6c8a3476
[tx-robot] updated from transifex 2020-03-15 02:19:16 +00:00
Robin Appelman db49ae3cb6
fix external storage controller tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:33:47 +01:00
Robin Appelman 59082661ca
remove the requirement that everything that looks like a placeholder is substituted
While maybe not common, `$` is a valid option in config fields

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:29:14 +01:00
Joas Schilling 17bc35e4f1
Merge pull request #19915 from nextcloud/external-storage-password-placeholders
Use placeholder values for password fields in external storage webui
2020-03-13 10:54:40 +01:00
Robin Appelman 0d112d7901
Use placeholder values for password fields in external storage webui
This prevents the password from being sent to the webui.

While an admin will always be able to retrieve the passwords (as they
can do arbitrairy code execution by design) this prevents casual
password snooping

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-12 19:45:23 +01:00
Nextcloud bot 99aa7adaef
[tx-robot] updated from transifex 2020-03-12 02:19:02 +00:00
Robin Appelman 223ee42a53
faster implementation of SFTP write stream
using mostly the same techniques as the read stream

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-10 16:18:40 +01:00
Robin Appelman fe4e80093e
Faster implementation of sftp read stream
- Keeps a single file handle open instead of creating a new one for
every stream_read
- Read from sftp in large chunks instead of the 8k internal php size
- Request a read for the next chunk while we're still processing the
current one

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-06 16:57:18 +01:00
Nextcloud bot 48b374f683
[tx-robot] updated from transifex 2020-03-05 02:18:19 +00:00
Nextcloud bot dccecf822d
[tx-robot] updated from transifex 2020-02-28 02:18:36 +00:00
Nextcloud bot 0e7163c7c1
[tx-robot] updated from transifex 2020-02-26 02:18:20 +00:00
Nextcloud bot 9d122c39ab
[tx-robot] updated from transifex 2020-02-23 02:19:29 +00:00
Nextcloud bot eb28572f9b
[tx-robot] updated from transifex 2020-02-19 02:18:14 +00:00
Nextcloud bot 8a841fc331
[tx-robot] updated from transifex 2020-02-14 02:18:09 +00:00
Nextcloud bot c34570faf8
[tx-robot] updated from transifex 2020-02-13 02:19:26 +00:00
Nextcloud bot 29ec5e6c96
[tx-robot] updated from transifex 2020-02-11 02:18:33 +00:00
Nextcloud bot 6a82bb1f00
[tx-robot] updated from transifex 2020-02-08 02:18:22 +00:00
Nextcloud bot 1afe8906bc
[tx-robot] updated from transifex 2020-02-07 02:20:10 +00:00
Roeland Jago Douma d2d7e37b7b
Merge pull request #19312 from nextcloud/fix/18195/do-not-overwrite-user-glob-auth
do not overwrite global user auth credentials with empty values
2020-02-06 10:20:56 +01:00
Nextcloud bot 698cfbd9cb
[tx-robot] updated from transifex 2020-02-06 02:18:41 +00:00
Arthur Schiwon 7e1d14d9a5
do not overwrite global user auth credentials with empty values
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-06 00:14:29 +01:00
Roeland Jago Douma f11e4c9ec4
Merge pull request #19300 from nextcloud/rakekniven-patch-1
l10n: Triple dot to ellipsis
2020-02-05 14:22:46 +01:00
rakekniven e1bc815813
l10n: Triple dot to ellipsis
Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-02-05 06:31:42 +01:00
Nextcloud bot 23fc654fc4
[tx-robot] updated from transifex 2020-02-05 02:18:06 +00:00
Nextcloud bot 750181d283
[tx-robot] updated from transifex 2020-02-03 02:16:46 +00:00
Nextcloud bot f39c1a21f8
[tx-robot] updated from transifex 2020-02-02 02:17:40 +00:00
Nextcloud bot 0585c76d16
[tx-robot] updated from transifex 2020-01-29 02:18:13 +00:00
Nextcloud bot 22e3a74f90
[tx-robot] updated from transifex 2020-01-24 02:16:52 +00:00
Nextcloud bot 2a01308d5c
[tx-robot] updated from transifex 2020-01-23 02:18:24 +00:00
John Molakvoæ (skjnldsv) 53516032f7
Compile templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-21 16:26:05 +01:00
Roeland Jago Douma 8728eab9d7
Fix app updates
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-21 14:00:58 +01:00
Nextcloud bot 53c37a170d
[tx-robot] updated from transifex 2020-01-21 02:17:28 +00:00
Nextcloud bot 4c1e631be9
[tx-robot] updated from transifex 2020-01-20 02:17:27 +00:00
Nextcloud bot 434fd438d9
[tx-robot] updated from transifex 2020-01-19 02:17:21 +00:00
Nextcloud bot 46706d01e0
[tx-robot] updated from transifex 2020-01-05 02:30:34 +00:00
Nextcloud bot 797b603a1f
[tx-robot] updated from transifex 2020-01-04 02:27:44 +00:00
Nextcloud bot 67b14cc0bd
[tx-robot] updated from transifex 2020-01-02 02:27:10 +00:00
Nextcloud bot 1d8da461d5
[tx-robot] updated from transifex 2019-12-23 02:27:33 +00:00
Nextcloud bot c81e05db98
[tx-robot] updated from transifex 2019-12-22 02:28:34 +00:00
Christoph Wurst 1b46621cd3
Update license headers for 18
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
Sascha Wiswedel f63156976b
fix credentials saving success message notification color
was red, now green

Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-18 15:32:39 +01:00
Nextcloud bot c60955f436
[tx-robot] updated from transifex 2019-12-12 02:26:32 +00:00
Nextcloud bot 98e2291f7a
[tx-robot] updated from transifex 2019-12-10 02:16:43 +00:00
Roeland Jago Douma 0360ab408e
Merge pull request #18256 from nextcloud/files-aditional-scripts-new-events
Use non-depricated events for loading additional scripts in files app
2019-12-09 21:24:55 +01:00
Robin Appelman 1c585d2c50
use OCP\EventDispatcher\GenericEvent in more places
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-12-09 14:24:57 +01:00
Arthur Schiwon 43efa40864
rejig right to left join for sqlite's satisfaction
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-12-06 11:37:31 +01:00
Nextcloud bot da84b36186
[tx-robot] updated from transifex 2019-12-06 02:16:59 +00:00
Christoph Wurst 5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Nextcloud bot fae3ae8a2d
[tx-robot] updated from transifex 2019-12-05 02:16:52 +00:00
Joas Schilling 254d4e0964
Merge pull request #17920 from nextcloud/fix/15258/ext-storage-respect-deletion
when a user was deleted remove them from applicable list, unless...
2019-12-04 15:28:57 +01:00
Nextcloud bot 7f80859ce4
[tx-robot] updated from transifex 2019-12-04 09:24:13 +00:00
Nextcloud bot 4cbaf69bc3
[tx-robot] updated from transifex 2019-12-03 02:16:46 +00:00
Nextcloud bot 6725a4b746
[tx-robot] updated from transifex 2019-11-30 02:16:49 +00:00
Arthur Schiwon 4baab51f4c
extend with group deletion handling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-28 17:03:33 +01:00
Arthur Schiwon be85d00a38
when a user was delete remove them from applicable list, unless
it is the only user, then remove the mount

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-28 17:03:33 +01:00
Roeland Jago Douma 669302e570
Merge pull request #18064 from nextcloud/feature/php74
Add php7.4 support
2019-11-28 08:36:10 +01:00
Nextcloud bot 563f9153a2
[tx-robot] updated from transifex 2019-11-28 02:16:54 +00:00
Roeland Jago Douma e3e782b63d
Fix external storagestests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:28:34 +01:00
Roeland Jago Douma 3a7cf40aaa
Mode to modern phpunit
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
Roeland Jago Douma c007ca624f
Make phpunit8 compatible
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
Roeland Jago Douma 7015501a74
Merge pull request #18005 from nextcloud/fix/manual-app-instances
Remove some more direct app instance creations
2019-11-26 09:20:14 +01:00