Commit Graph

19241 Commits

Author SHA1 Message Date
Nextcloud bot e0f700b1bd
[tx-robot] updated from transifex 2021-04-29 02:26:26 +00:00
Roeland Jago Douma 758a662b23 Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-28 14:27:46 +02:00
Christoph Wurst 6a5d89c1ac
Merge pull request #26758 from J0WI/more-strict
Some more strict_types
2021-04-28 09:28:19 +02:00
Nextcloud bot be4f665d2d
[tx-robot] updated from transifex 2021-04-28 02:25:44 +00:00
Christoph Wurst 99f0b10421
Merge pull request #26591 from nextcloud/techdebt/noid/less-ilogger
Less ILogger
2021-04-27 15:38:12 +02:00
Joas Schilling 48c50277a9
Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-template
Fix ratelimit template
2021-04-27 15:18:02 +02:00
Joas Schilling c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid
Throw "401 Unauthenticated" when authentication is provided but invalid
2021-04-27 14:37:28 +02:00
Joas Schilling 2d75868935
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:33 +02:00
Joas Schilling 29a66a5e49
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling 167efa19d7
Fix psalm errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling df47445c01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling 56ae87c281
Less ILogger
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling 13b37a5255
Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:35 +02:00
Joas Schilling 174f4dd043
Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:34 +02:00
Joas Schilling bf1c875425
Merge pull request #26764 from nextcloud/feature/noid/add-geo-location-as-ROS-type
Add geo location as ROS type
2021-04-27 13:54:28 +02:00
Nextcloud bot 2aad4bbed6
[tx-robot] updated from transifex 2021-04-27 02:25:33 +00:00
Joas Schilling 7d3c135146
Add geo location as ROS type
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:47:01 +02:00
Joas Schilling 21ed3419f3
Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:19:03 +02:00
Joas Schilling 8d9e5e0b91
Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 14:18:18 +02:00
Joas Schilling aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
Lukas Reschke e1a3000cbe
Merge pull request #26747 from nextcloud/php8-libxml
Fix installer deprecation warnings for PHP 8
2021-04-26 12:44:38 +02:00
J0WI a369933084 Fix ini_set() type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:44:05 +02:00
J0WI efc5c57a79 Some more strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:33:45 +02:00
Roeland Jago Douma bf9ed2d3cd
Merge pull request #26721 from nextcloud/fix/noid/final-private
private cannot be final
2021-04-26 09:04:18 +02:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +00:00
acsfer 3d900b1e58
PHP 8+ deprecates openssl_free_key 2021-04-25 13:50:23 +02:00
acsfer 5882648cac
Only use libxml_disable_entity_loader on PHP<8 2021-04-25 13:45:14 +02:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +00:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +00:00
Maxence Lange bb32880ec4 private cannot be final
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-23 11:00:10 -01:00
Daniel Calviño Sánchez 7159a70894 Guard against null phone number value
"parsePhoneNumber()" expects a string, so a TypeError would be thrown if
the phone number value is null.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00
Nextcloud bot 539c065e8e
[tx-robot] updated from transifex 2021-04-23 02:26:10 +00:00
Morris Jobke 012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated
"Symfony\Component\Translation\PluralizationRules" is deprecated
2021-04-22 21:20:16 +02:00
Joas Schilling d80cc76ee7
Validate the website field input to be a valid URL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
Arthur Schiwon e7691ef6ab
remove undefined parameter, add description
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-22 16:23:01 +02:00
Joas Schilling 521bb30541
Throw "401 Unauthenticated" when authentication is provided but invalid
E.g. with an AppToken that has been revoked

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 15:28:43 +02:00
Morris Jobke 393309b98f
Merge pull request #25714 from nextcloud/fix/23197/explicitly_check_hex2bin_input
Explicitly check hex2bin input
2021-04-22 13:23:39 +02:00
Robin Appelman effb7dc8ba
set mimetype for objects uploaded to object storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 15:25:58 +02:00
Robin Appelman 0d5f4edc22
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 14:09:07 +02:00
Robin Appelman e8221303e9
use search query for Folder::getRecent
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 13:56:04 +02:00
Nextcloud bot e58344fb2a
[tx-robot] updated from transifex 2021-04-21 02:25:58 +00:00
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 5ee9e1f784 Move 2FA registration to IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +02:00
Roeland Jago Douma 46872e3921
Merge pull request #26617 from nextcloud/fix/oracle-column-check-unrelated-migrations
Do not check Oracle column constraints in unrelated migrations
2021-04-20 20:49:06 +02:00
Roeland Jago Douma f31d24dd7a
Merge pull request #26647 from nextcloud/bugfix/noid/empty-filename
Fail when creating new files with an empty path
2021-04-20 20:47:16 +02:00
Joas Schilling 3cf447ac44
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +02:00
Joas Schilling 2b8e47dcac
Correclty use plural for share exception
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +02:00
Joas Schilling 5a514a9a41
Correctly replace all PHP placeholders with the parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +02:00
Joas Schilling 439457d2b4
Fix languages that miss a string in the translation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Joas Schilling a4c6749b02
Add a check for the pipe character
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Joas Schilling 157147cb8e
"Symfony\Component\Translation\PluralizationRules" is deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +02:00
Arthur Schiwon f8d1ee5cfa
ignore mail shares of related remote share results
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +02:00
Julius Härtl 8398762d78
Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 11:20:20 +02:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +00:00
J0WI ca7b37ce5a Make Security module strict
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-19 17:31:12 +02:00
Christoph Wurst 2ab8268128
Do not check Oracle column constraints in unrelated migrations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-19 13:05:34 +02:00
Roeland Jago Douma fc11617222 Deprecate the old way
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Roeland Jago Douma 808e589035 Allow registering NotifierServices trough IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Joas Schilling 25d11b5197
Fix constraint violation detection in QB Mapper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 10:12:17 +02:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00
Roeland Jago Douma f031dd61c1
Merge pull request #26551 from nextcloud/fix/noid/redis-exists-bool
ensure redis returns bool for hasKey
2021-04-14 13:37:23 +02:00
Roeland Jago Douma 644ce9e4f0
Merge pull request #26529 from J0WI/getSystemValue-type
Use correct getSystemValue type
2021-04-14 13:36:56 +02:00
Nextcloud bot 7081c63d09
[tx-robot] updated from transifex 2021-04-14 02:26:51 +00:00
Arthur Schiwon 9f5480eef4
ensure redis returns bool for hasKey
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-13 23:07:54 +02:00
Joas Schilling 421914b4d0
Merge pull request #26467 from nextcloud/feature/noid/allow-apps-to-log-to-audit
Allow apps to log actions into the audit_log
2021-04-13 08:52:08 +02:00
Nextcloud bot bab06b9abb
[tx-robot] updated from transifex 2021-04-13 02:24:57 +00:00
J0WI 74a7c2eefc Use correct getSystemValue type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +02:00
Roeland Jago Douma 789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking
Improve networking checks
2021-04-12 12:42:33 +02:00
Joas Schilling 6d502041e0
Fix version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-12 10:31:10 +02:00
Joas Schilling 99e5367208
Move to another namespace and class name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 12:51:57 +02:00
Joas Schilling ca939214bd
Allow apps to log actions into the audit_log
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 10:32:45 +02:00
Nextcloud bot 9de329a4c2
[tx-robot] updated from transifex 2021-04-09 02:25:11 +00:00
Roeland Jago Douma 2bedbc1793
Merge pull request #26439 from nextcloud/increase-subnet-matcher
Increase subnet matcher
2021-04-08 14:48:27 +02:00
Lukas Reschke 2befac662c Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-08 11:55:51 +02:00
Lukas Reschke e5a4236e68 Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-07 12:28:59 +00:00
Nextcloud bot c391e8692b
[tx-robot] updated from transifex 2021-04-07 02:24:14 +00:00
Lukas Reschke 4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1
avoid fread on directories and unencrypted files
2021-04-06 13:45:10 +02:00
Lukas Reschke 5fe1f134f9 Strictify null check
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:39:24 +00:00
Lukas Reschke d5c7bb2188 Generate autoload files
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +00:00
Lukas Reschke 5f3abffe6f Improve networking checks
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +00:00
Nextcloud bot e9075b02cd
[tx-robot] updated from transifex 2021-04-06 02:25:33 +00:00
Nextcloud bot bb3ba96b37
[tx-robot] updated from transifex 2021-04-05 02:24:46 +00:00
Nextcloud bot bfd926938f
[tx-robot] updated from transifex 2021-04-04 02:24:48 +00:00
Nextcloud bot 6f55d2e293
[tx-robot] updated from transifex 2021-04-03 02:25:32 +00:00
Nextcloud bot 4bea123c7a
[tx-robot] updated from transifex 2021-04-02 02:26:04 +00:00
Morris Jobke 5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false
Enforce no notnull for boolean to store false
2021-04-01 18:30:26 +02:00
Julius Härtl 6fd571461c
Properly handle creating the template directory in a subfolder (fixes #25787)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +02:00
Julius Härtl 37591f05dc
Get the parent directory before creating a file from a template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +02:00
Julius Härtl bbc64cfabc
Merge pull request #26394 from nextcloud/feature/noid/updatable-account-data
Allow apps to write/update account data
2021-04-01 08:05:54 +02:00
Robin Appelman 65b78515bd
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-31 15:23:33 +02:00
Joas Schilling fcedbc85d0
Allow apps to write/update account data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 15:18:25 +02:00
Joas Schilling f9d4fa2d38
Rename the method to match what it does
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +02:00
Joas Schilling 3696ef5b96
Don't allow Notnull for boolean columns
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
Joas Schilling 133a6f4fe4
Document the constraints we test against
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +02:00
Joas Schilling c98cab137c
Fix exception messages spacing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:10 +02:00
Nextcloud bot 855b5fc638
[tx-robot] updated from transifex 2021-03-31 02:24:50 +00:00
kesselb 2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +02:00
Roeland Jago Douma f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
Set umask before operations that create local files
2021-03-30 21:55:50 +02:00