Commit Graph

57616 Commits

Author SHA1 Message Date
Valdnet ba1e966439 l10n: Add word user in ShareByMailProvider.php
Standardizing text strings with other Nextcloud applications.
2021-03-22 10:30:49 +00:00
Nextcloud bot 2e2d2e79e8
[tx-robot] updated from transifex 2021-03-22 02:23:56 +00:00
Morris Jobke 476c30b807
Merge pull request #26227 from nextcloud/backport/26213/stable21
[stable21] Removed unnecessary padding
2021-03-21 20:57:42 +01:00
Nextcloud bot 89319b995f
[tx-robot] updated from transifex 2021-03-21 02:23:20 +00:00
Sascha Wiswedel a52482246b Removed unnecessary padding
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2021-03-20 09:57:08 +00:00
Roeland Jago Douma b3bf640111
Merge pull request #26215 from nextcloud/backport/26145/stable21
[stable21] add (hidden) option to always show smb root as writable
2021-03-20 10:53:40 +01:00
Nextcloud bot 798eff0161
[tx-robot] updated from transifex 2021-03-20 02:23:52 +00:00
Robin Appelman 7f066931e4 add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:01 +00:00
Morris Jobke eaae526ba7
Merge pull request #26211 from nextcloud/backport/23718/stable21
[stable21] expand 'path is already shared' error message
2021-03-19 15:21:17 +01:00
Morris Jobke 06a9463e11
Merge pull request #26204 from nextcloud/backport/26200/stable21
[stable21] Update user share must use correct expiration validation
2021-03-19 15:19:19 +01:00
Vincent Petry 0e5379a7b3
Merge pull request #26119 from nextcloud/backport/26003/stable21
[stable21] Add getID function to the simplefile implementation
2021-03-19 13:59:00 +01:00
Robin Appelman def56ca0cd expand 'path is already shared' error message
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 12:45:40 +00:00
Vincent Petry 695ccecf26 Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 09:54:47 +00:00
Morris Jobke 682df0b788
Merge pull request #26124 from nextcloud/backport/25533/stable21
[stable21] send share notification instead of erroring on duplicate share
2021-03-19 09:18:49 +01:00
Nextcloud bot 942b40583c
[tx-robot] updated from transifex 2021-03-19 02:25:05 +00:00
Roeland Jago Douma 8942d76f72
Merge pull request #26122 from nextcloud/backport/26004/stable21
[stable21] Allow overwriting isAuthenticated
2021-03-18 16:20:46 +01:00
Vincent Petry 15cb3f0624
Merge pull request #26192 from nextcloud/backport/25331/stable21
[stable21] Fix valid storages removed when cleaning remote storages
2021-03-18 11:23:51 +01:00
Daniel Calviño Sánchez 7e87b12271 Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:05:04 +00:00
Daniel Calviño Sánchez 388110a35e Add integration tests for "sharing:cleanup-remote-storages" OCC command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:05:04 +00:00
Vincent Petry 73d2f42d41
Merge pull request #26087 from nextcloud/backport/26049/stable21
[stable21] limit constructing of result objects in file search
2021-03-18 08:21:50 +01:00
Nextcloud bot 4ebf9c2d1a
[tx-robot] updated from transifex 2021-03-18 02:25:13 +00:00
Morris Jobke 0e642a5f5e
Merge pull request #26062 from nextcloud/backport/25915/stable21
[stable21] Add appconfig to always show the unique label of a sharee
2021-03-17 20:13:07 +01:00
Morris Jobke c1c377f609
Merge pull request #26090 from nextcloud/backport/25722/stable21
[stable21] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:50 +01:00
Morris Jobke a70bdb962b
Merge pull request #26175 from nextcloud/backport/26076/stable21
[stable21] adds ldap user:reset command
2021-03-17 20:06:29 +01:00
Morris Jobke 95ebe5e819
Merge pull request #26146 from nextcloud/backport/26013/stable21
[stable21] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-17 20:03:58 +01:00
Arthur Schiwon 4cd15b7815 adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
  guarded
- ensures that the user is not being deleted on LDAP through a plugin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-17 13:38:55 +00:00
Morris Jobke 4b3684fbc4
Merge pull request #25943 from nextcloud/backport/25659/stable21
[stable21] catch notfound and forbidden exception in smb::getmetadata
2021-03-17 13:50:39 +01:00
Morris Jobke aa8a31b3ec
Merge pull request #26166 from nextcloud/backport/26131/stable21
[stable21] Fix default missing initial state for templates
2021-03-17 13:50:32 +01:00
Morris Jobke a2d17c3c02
Merge pull request #26167 from nextcloud/backport/26072/stable21
[stable21] remove explicit fclose from S3->writeStream
2021-03-17 13:47:03 +01:00
kesselb 5ecbfa4f20
Merge pull request #26162 from nextcloud/backport/26153/stable21
[stable21] Use correct exception type hint in catch statement
2021-03-17 11:09:19 +01:00
Robin Appelman 0532f64aa8 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:02 +00:00
John Molakvoæ (skjnldsv) 1be574319c Fix default missing initial state for templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 09:20:38 +00:00
Vincent Petry 215967db96
Merge pull request #26151 from nextcloud/backport/26137/stable21
[stable21] dont allow creating users with __groupfolders as uid
2021-03-17 09:46:37 +01:00
Morris Jobke 162e763e26 Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:44:29 +00:00
Nextcloud bot fd29c1d72a
[tx-robot] updated from transifex 2021-03-17 02:24:31 +00:00
Robin Appelman 1089d8545b dont allow creating users with __groupfolders as uid
Fixes https://github.com/nextcloud/groupfolders/issues/338

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 18:51:55 +00:00
Robin Appelman 44d4957548 verify that cache entry is valid
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:59 +00:00
Robin Appelman f6f92e8bc6 also implement for FailedCache and NullCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:58 +00:00
Robin Appelman 719db4cee9 use returned file id for object store copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:57 +00:00
Robin Appelman bb180a95bb add ICopyFromCache trait to expose existing implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:56 +00:00
Morris Jobke 120aefb795
Merge pull request #26133 from nextcloud/backport/25136/stable21
[stable21] do cachejail search filtering in sql
2021-03-16 16:59:29 +01:00
Christoph Wurst e09d59aa81
Merge pull request #26128 from nextcloud/backport/26115/stable21
[stable21] Log exceptions when creating share
2021-03-16 11:09:13 +01:00
Nextcloud bot 8d6a4bef6c
[tx-robot] updated from transifex 2021-03-16 02:24:53 +00:00
Robin Appelman e5ffb96c36 only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:34 +00:00
Robin Appelman c727879073 adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:34 +00:00
Robin Appelman ec0985ba68 fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:33 +00:00
Robin Appelman eb56b1d0bd fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:32 +00:00
Robin Appelman 046638abeb do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:32 +00:00
Vincent Petry f109677856 Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:16 +00:00
Robin Appelman f2a35cd3f8 send share notification instead of erroring on duplicate share
when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 14:13:04 +00:00