13abee2836
[tx-robot] updated from transifex
2018-10-28 00:12:49 +00:00
0092e3adec
[tx-robot] updated from transifex
2018-10-27 00:12:35 +00:00
05f909dcf3
fixes wrong variable usage
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
a226f65aa2
Fix off-by-one bugs
...
This fixes warnings from LGTM:
Off-by-one index comparison against length may lead
to out-of-bounds read.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
31c3814b0a
Merge pull request #12038 from nextcloud/assemblystream_size
...
Implement the size of an assembly stream
2018-10-26 17:02:16 +02:00
70e4884e02
Implement the size of an assembly stream
...
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
7aa76a82bc
Merge pull request #12053 from nextcloud/enhancement/10923/remove-unncessary-check
...
remove LDAP::hasPagedResultSupport() from PHP < 5.4 days
2018-10-26 10:28:47 +02:00
aff53d6e34
[tx-robot] updated from transifex
2018-10-26 00:12:48 +00:00
bbe44108b5
only write when the displayname differs, but then announce it
...
refs #5212 and fixes #9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
...
* so the check from older days is really not necessary anymore
* resolves #10923
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
6ad7f32938
Merge pull request #12016 from nextcloud/wip/noid/icon-base64
...
Directly embed icons into the icon-vars css file
2018-10-25 16:04:23 +02:00
0a2476fcb3
Merge pull request #11988 from nextcloud/docs/jsdoc-build
...
JSdoc build fixes and move build script out of the root folder
2018-10-25 15:49:27 +02:00
661756b02a
Set error expected by the DAV client for a failed move
...
A revert triggers a move in the DAV client, and the DAV client expects a
DAV error message to be provided by the server in case of failure; if
no error message is given the client ends trying to get an attribute
from an undefined object and "crashes".
Besides that, if the revert fails the "done" callback of the promise
(the first parameter of "then") is never called, so a "fail" callback
should be used instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 13:07:06 +02:00
24abfd8869
Wait for the promise to be fulfilled before running the next test
...
In Jasmine 2.5 the "it" function takes an optional parameter that should
be called when the async work is completed (returning a promise was
introduced in Jasmine 2.7, so it is not supported yet in the tests). If
the parameter is not declared then the next test is executed without
waiting for the asynchronous work in the previous one to finish, which
could cause that asynchronous work to finish while a different test is
being run.
Note that if that happens the test could still work as expected if it
relied only in local variables. However, in the case of the successful
revert tests, the stubs being checked are not the ones created when that
test was initialized, but the ones created when the next test, the
failed revert test, was initialized and the previous variables were
replaced (although the model itself calls the proper stubs, as they are
set through parameters in function calls).
Besides all that, the checks in the failed revert test were never
executed due to a different problem which will be fixed in the next
commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 12:25:41 +02:00
d21ded67a7
Keep list of icons in a separate file for use in the accessibility app
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 12:16:10 +02:00
58fde16226
[tx-robot] updated from transifex
2018-10-25 00:13:01 +00:00
88904200e0
Merge pull request #11889 from stweil/lgtm
...
Remove replace call which does not replace anything
2018-10-24 23:55:55 +02:00
5c51d84a67
Calendar invitation: use system default instead of sender's language as fallback
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-24 18:39:30 +02:00
87657fffd8
skip already encrypted files on encrypt all command
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-24 16:53:39 +02:00
d14434fa2e
Adjust some jsdocs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 16:24:16 +02:00
5d888984a0
Fix jsdocs build on server repo
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
37782b1084
Merge pull request #11573 from nextcloud/gridview-table
...
Files grid view
2018-10-24 15:31:23 +02:00
2ec5d2a6de
Merge pull request #11533 from nextcloud/accessibility-cache-fixes
...
Added cache override to ensure an always up-to-date accessibility css
2018-10-24 15:04:29 +02:00
a13c80062d
Remove replace call which does not replace anything
...
The original code replaced / by /.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-24 14:53:52 +02:00
b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
...
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
ded746f821
[tx-robot] updated from transifex
2018-10-24 00:12:31 +00:00
b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
...
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
41fbda00ed
Merge pull request #11928 from stweil/fix
...
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
530e39b061
Merge pull request #11778 from nextcloud/versions-webui-dav
...
move versions webui over to the dav api
2018-10-23 20:21:05 +02:00
ede6472e52
Fix FF performance and recals issues
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
4ad27260a9
Merge pull request #11439 from nextcloud/trash-modular-api
...
Modular trashbin api
2018-10-23 17:11:16 +02:00
8013dab044
Allow focus on input with keyboard
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
a9fb21f9fc
[tx-robot] updated from transifex
2018-10-23 14:54:28 +00:00
cf57df6e73
Restore table head
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
...
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00
869df2ee7a
Merge pull request #11980 from nextcloud/assemblly-stream-lazy
...
lazy open first source stream in assemblystream
2018-10-23 16:17:49 +02:00
9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app
...
Fix opening a section again in the Files app
2018-10-23 15:29:55 +02:00
b04ebd8553
Round off buttons 'pill style' like on the website
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 15:18:37 +02:00
171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
...
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
d11609a152
Merge pull request #11974 from nextcloud/bugfix/noid/lax-csp-on-talk-shares
...
Use lax CSP when the share is a talk share
2018-10-23 14:29:52 +02:00
ade50d3b71
Remove font-specifics from high contrast theme because we are now on regular+bold anyway
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:13:07 +02:00
0158703590
Fix font-face in dyslexia-friendly theme
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:32 +02:00
d9aa484641
Fix font-face on LDAP tooltip
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
26ca7a0e2f
Add filepicker toggle
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
31d1179c41
Merge pull request #11973 from nextcloud/bug/accessibility/get_js_without_uid
...
If there is no UID do not explode accessibility javascript
2018-10-23 10:18:45 +02:00
bf6a1650ce
Use preview-x & preview-y on public pages
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:59:34 +02:00
ec05e5d048
Fix public background override
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:54:09 +02:00
e0dde083d0
Public fixes, request & default to grid
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:43:02 +02:00
8652ada561
Tooltip on hover only
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:27:27 +02:00
efdb535a5d
Fix grey background over thumbnail
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:23:22 +02:00
b662977862
Fix table hidden on empty folder
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:18:14 +02:00
0ee610f012
Bump webpack from 4.20.2 to 4.22.0 in /apps/updatenotification
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-22 20:43:17 +00:00
a887c6e77b
Fix use of undeclared variable
...
This fixes a warning from LGTM:
Variable 'data' is used before its declaration.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-22 21:07:52 +02:00
2f518b6ac8
lazy open first source stream in assemblystream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-22 16:11:13 +02:00
5cfb5ec176
allow group principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
218253db76
allow user principal search for dav displayname property
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
10f0296ad6
overwrite Sabre/DAV's handler for calendar-user-type to report correct user type
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
325e366b58
add correct calendar-user-type to resource and room backend
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:13 +02:00
f737ae719d
Merge pull request #11960 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.22.0
...
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
2018-10-22 15:31:09 +02:00
3ac15a45ea
If there is no UID do not explode accessibility javascript
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-22 11:26:21 +02:00
3febeb6ca7
Use lax CSP when the share is a talk share
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-22 10:57:55 +02:00
0426ba6de5
Remove event handler no longer needed
...
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.
The file list for tags uses the handler for a different purpose, though,
so that one was kept.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:59 +02:00
449349e901
Fix opening a section again in the Files app
...
When a section is open in the Files app a "show" event is triggered.
File list objects handle that event by reloading themselves, but only
if the file list was shown at least once. However, the file list objects
of plugins are created when the "show" event is triggered for the first
time for their section; as the file list objects register their handler
for the "show" event when they are created they never handle the first
triggered "show" event, as the handler is set while that event is being
already handled. Therefore, from the point of view of the handler, the
second time that a "show" event was triggered it was seen as if the file
list was shown for the first time, and thus it was not reloaded. Now the
"shown" property is explicitly set for those file lists that are created
while handling a "show" event, which causes them to be reloaded as
expected when opening their section again.
Note that it is not possible to just reload the file list whenever it is
shown; the file list is reloaded also when the directory changes, and
this can happen when the web page is initially loaded and the URL is
parsed. In that case, if file lists were reloaded when shown for the
first time then it could be reloaded twice, one with the default
parameters due to the "show" event and another one with the proper
parameters once the URL was parsed, and the files that appeard in the
list would depend on which response from the server was received the
last.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:19 +02:00
f4353a9acd
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:36:20 +00:00
3ea326f811
Bump webpack from 4.20.2 to 4.22.0 in /apps/accessibility
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:35:11 +00:00
f544c9fec9
Merge pull request #11927 from stweil/clean
...
Remove duplicate condition
2018-10-19 21:15:04 +02:00
81c0f2a9a7
Remove duplicate condition
...
This fixes a warning from LGTM:
Operands additionnalShares and additionnalShares are identical.
Fix also the typo in the parameter name.
2018-10-19 20:19:08 +02:00
c5d3febf37
Add missing variable declarations
...
This fixes errors from LGTM like the following one:
Variable i is used like a local variable,
but is missing a declaration.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 20:17:55 +02:00
543c863434
Merge pull request #11931 from nextcloud/bug/do_not_emit_pre_hooks_twice_objectstore
...
Do not emit preHooks twice on non-part-storage
2018-10-19 19:56:42 +02:00
97717ae3a7
Merge pull request #11905 from nextcloud/design/noid/tab-icons
...
Add icon to file sidebar tabs
2018-10-19 16:53:56 +02:00
851f525889
Merge pull request #11668 from nextcloud/bugfix/7726/convert_caldav_subscription_source_to_long_text
...
convert source column in calendarsubscription table to (long) text
2018-10-19 15:49:17 +02:00
6a979a0ba0
Merge pull request #11823 from lex111/fix-illegible-text-color-in-size-and-modified-columns
...
Fix illegible text color in columns Size and Modified on dark theme
2018-10-19 15:31:51 +02:00
b51e503aea
Do not emit preHooks twice on non-part-storage
...
The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 12:19:53 +02:00
d35b6513cd
Merge pull request #11922 from stweil/semicolons
...
Add missing semicolons
2018-10-19 12:07:59 +02:00
08476297c3
Merge pull request #11917 from nextcloud/csp/files_external
...
Move files_external to compiled handlebars
2018-10-19 12:06:42 +02:00
2ad38200fb
Add missing semicolons
...
This fixes some recommendations from LGTM:
Avoid automated semicolon insertion (90% of all statements
in the enclosing function have an explicit semicolon).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
1226c13201
Add .l10nignore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:41:37 +02:00
1b44bdfb58
Add .l10nignore files for compiled assets
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:29:36 +02:00
c43e0d6e28
Move files_external to compiled handlebars
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 08:41:01 +02:00
30cbd137e8
Fix illegible text color in columns Size and Modified on dark theme: rework after review
...
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-18 20:49:46 +03:00
5daa4f27e1
Merge pull request #11882 from nextcloud/feature/noid/consider-net-connection
...
Do not try to contact lookup server without internet connection or URL
2018-10-18 18:24:41 +02:00
8e4ae23c48
Do not try to contact lookup server without internet connection or URL
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-18 17:49:28 +02:00
45804b5bef
Add icon to file sidebar tabs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-18 15:54:17 +02:00
0f299d1077
Revert "Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show"
...
This reverts commit fb7fb1cebae5af129c4474a380e0f5e55f79569f.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:11 +02:00
8614693e9a
Reduce bottom whitespace on share link page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
25ae3ea296
More space for filename on public share page since there is no share icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
d979da3755
In "Deleted files", do not show "Restore" text next to icon as there is no space
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
bdfece12b2
Fix tabbability to view-toggle, action on Enter to be fixed
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
35ef2b2737
Adjustments for public share page, actions menu, view toggle
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
c0648efe3a
Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
1d486673f6
If there is a comment, show it instead of the share icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
64607f5491
If an avatar is present, show that instead of the icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:08 +02:00
b532c95162
Border radius
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
1f1dddcc5e
Fix spacing
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
184c1b03e3
Default to grid
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
07224da3d4
Fix focus background
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
cd1cfe002d
Improve default visual and selection + default to file link
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
872b866a69
Tooltip
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
c4cce14134
Remember toggle and events handler
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
Nextcloud bot
Arthur Schiwon
Stefan Weil
Morris Jobke
Roeland Jago Douma
Daniel Calviño Sánchez
Julius Härtl
Georg Ehrke
Bjoern Schiessle
Roeland Jago Douma
John Molakvoæ (skjnldsv)
Jan-Christoph Borchardt
dependabot[bot]
Robin Appelman
Joas Schilling
Alexey Pyltsyn