3d2600b039
Add Phan plugin to check for SQL injections
...
This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues.
As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections.
The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-07-20 22:48:13 +02:00
d8ec399454
Run phan over code base
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-07-19 10:28:11 +02:00
711d861d8b
Merge pull request #5556 from nextcloud/files_external_sftp_2048_4096
...
[Files external] Add support for 2048 and 4096 bit RSA key generation
2017-07-04 17:37:25 +02:00
e3127b8899
Remove unused member
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-06-30 09:13:36 +02:00
25e08bc8a0
Allow 2048 and 4096 bit SFTP keys
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-06-29 09:32:24 +02:00
0dcce5a835
move personal external storage settings to it's own section
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-06-23 12:37:42 +02:00
0baeec170e
use the correct param type when getting external storages for groups
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-05-22 17:39:56 +02:00
3eba37ac14
Merge pull request #4527 from nextcloud/downstream-27504
...
Adjust SMB permissions on the root
2017-05-01 12:53:49 -03:00
ab9a36e872
allow apps to set custom mount types
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-28 09:38:21 +02:00
acb0903514
remove duplicate method
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-26 16:45:04 +02:00
43970b93d1
remove excessive logging
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-26 16:41:48 +02:00
71012b3432
Adjust SMB permissions on the root
2017-04-26 16:23:52 +02:00
4c2c08f376
Merge pull request #4416 from gvmura/avoid-duplicate-files-google
...
Avoid duplicate files in google with the same name
2017-04-26 01:26:04 -03:00
c54a59d51e
Remove unused use statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-22 19:23:31 -05:00
0d063c316a
avoid duplicate files in google with the same name
...
Signed-off-by: gvmura <gvmura@uniss.it>
2017-04-21 11:30:02 +02:00
8a743e0359
Merge pull request #4404 from Ardinis/master
...
Remove json handling for files_external:config
2017-04-20 17:59:35 -05:00
71118214f9
reviewed
2017-04-20 11:31:04 +02:00
1c0bffe87f
Fix translations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-18 16:40:53 -05:00
3db84ed90a
Remove json handling for files_external:config
...
#4347
2017-04-14 15:42:45 +02:00
49d8716eaa
Merge pull request #4312 from nextcloud/cleanup-name
...
Update comments to Nextcloud
2017-04-12 10:54:20 +02:00
83864d465e
[files_external] Remove unneeded update steps
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-12 00:45:19 -05:00
1729e4471f
Update comments to Nextcloud
...
* based on PR by @Ardinis
* see #4311
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-11 23:16:27 -05:00
30c95b51fb
fix fseek against string not resource by removing append support
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-04-04 20:25:59 +02:00
57020a0c36
Merge pull request #3438 from nextcloud/external-storage-user-folder
...
Allow using '/' as external storage mountpoint
2017-03-31 15:07:39 +02:00
76d8699c0f
Allow using '/' as external storage root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-03-23 14:03:22 +01:00
9eca1da1dd
allow configuring authType for DAV backend
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-22 18:13:42 -06:00
718d1f3f15
fix typo in sftp public key
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-19 22:44:09 -06:00
5acebb911b
fix self test for non leading slash
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-02-10 18:04:59 +01:00
d9a6353bc1
Make the notify self test for subfolders more reliable
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-02-10 17:38:29 +01:00
5bad417e57
Merge pull request #2044 from nextcloud/login-credential-store
...
Login credential store
2017-01-30 19:30:04 -06:00
687e38c409
Merge pull request #2970 from nextcloud/notify-self-test
...
Add self-test for files_external:notify
2017-01-30 17:15:57 -06:00
64e9a1aec0
Merge pull request #3176 from nextcloud/default-value-datadir
...
Add proper default value for datadir
2017-01-30 13:01:24 +01:00
d14ff70050
add unit tests for smb notify backend
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-27 10:44:45 +01:00
72eeb8fd22
add notify self test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-27 10:44:41 +01:00
c7536f7877
switch occ files_external:notify to new notify mechanism
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-27 10:44:37 +01:00
269747985e
Add a more powerful notify mechanism
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-27 10:44:33 +01:00
a4ad8af6e3
Add proper default value for datadir
...
* better safe than sorry
* fixes #3091
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-01-19 19:49:41 -06:00
17a7eaabcd
Add the icons for shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-01-19 10:42:22 +01:00
6f74ecd94a
use login hook credentials as fallback
...
If no session token is available, we can use the credentials provided
by the login hook.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-01-11 19:20:11 +01:00
e4abb9cb6e
migrate 'password::sessioncredentials' extern storage auth to credential store
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2017-01-11 19:20:11 +01:00
5774d3e82c
replace close:// streamwrapper with CallBackWrapper
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-06 15:33:32 +01:00
8429687788
Update icewind/smb to 2.0.0
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-01-05 09:16:03 +01:00
00b4dedef5
Merge pull request #2550 from nextcloud/smb-notify-rename
...
Fix order of parameters when getting notified of smb renames
2016-12-16 16:11:39 +01:00
511056dd3f
Merge pull request #1678 from nextcloud/smb-stat-root
...
Fix mtimes for share root
2016-12-16 13:41:33 +01:00
b5401adc00
Fix order of parameters when getting notified of smb renames
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-12-07 16:25:10 +01:00
0a246f9852
split off s3 connection logic
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-11-16 15:30:36 +01:00
85bd5589cb
Fix mtimes for share root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2016-10-11 11:09:05 +02:00
e8e950a4d2
more efficient querying of numeric storage ids
2016-09-07 17:22:40 +02:00
59e5ebf330
Cleanup files_external command imports
2016-09-06 21:36:03 +02:00
b573c5b8f8
get files_external mounts more efficiently
2016-09-05 14:34:20 +02:00
c51e2eb3ba
fix error when not logged in
2016-08-18 16:06:25 +02:00
2332ed3292
change remote cloud naming to Nextcloud
2016-08-18 12:57:47 +02:00
5dd20a55e8
dont register personal files_external setting if it's empty
2016-08-18 12:57:47 +02:00
9a7193ce83
Fix casing of external storage app
2016-08-17 10:44:00 +02:00
27796a4077
layout refinements
2016-08-17 10:40:59 +02:00
717e22267a
Merge branch 'master' into implement_712
2016-08-16 18:31:59 +02:00
b204af2f0f
Fix oracle support of external storage app
2016-08-15 12:03:53 +02:00
158d78e1ab
move mail settings and file handling to additional ones, thus files_external gets its own section
2016-08-13 01:02:25 +02:00
30ff3ad45b
adjust files app, and integrate files_external into that section
2016-08-11 18:39:16 +02:00
a2f752bcf3
adjust files_external
2016-08-11 15:50:31 +02:00
e1807ed0a4
Merge pull request #465 from nextcloud/fix_smb_attributes
...
Fix file permissions for SMB (read-only folders will be writeable) (#…
2016-08-04 19:48:21 +02:00
0215b004da
Update with robin
2016-07-21 18:13:58 +02:00
813f0a0f40
Fix apps/
2016-07-21 18:13:57 +02:00
e2abe70514
Merge pull request #470 from nextcloud/sftp-renameoverwritedir
...
Fix overwriting folders on rename with SFTP
2016-07-20 18:31:06 +02:00
d372836efc
Fix overwriting folders on rename with SFTP
...
This aligns the behavior with other storages and also fixes the failing
unit test testRenameOverWriteDirectory
2016-07-20 15:12:27 +02:00
c376eb9f90
Fix file permissions for SMB (read-only folders will be writeable) ( #25301 )
...
* Fix file permissions for SMB (read-only folders will be writeable)
* Read-only folders won't be deletable
* Added comment for the read-only behaviour for folders
2016-07-20 14:45:42 +02:00
e34ee9099d
add files_external:notify command
2016-07-14 16:00:57 +02:00
e1fa314b18
add notify support to smb storage
2016-07-14 14:46:01 +02:00
29eeeb2273
Save the files external mount id in the mount cache table
2016-07-13 16:34:08 +02:00
c2d88a08b7
Remove unneeded checks if it runs on a Windows machine
...
* the setup check is still there
2016-07-08 15:55:17 +02:00
f98cb9efa0
Fix type hinting
2016-07-08 12:35:50 +02:00
8f84c99e3f
Fix undefined properties
2016-07-08 12:35:16 +02:00
ba16fd0d33
Merge branch 'master' into sync-master
2016-07-07 11:29:46 +02:00
9fb92b56ec
show configuration options for authentication backends while listing storage
...
Fixes #22447
2016-06-30 15:50:14 +02:00
f982d104f3
hide hidden parameters from list backend/auth parameters
2016-06-30 15:44:42 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
cee2f5dc65
Merge pull request #233 from nextcloud/allow-users-to-change-global-credentials
...
Allow regular users to specify global credentials password
2016-06-27 17:03:19 +02:00
341dabf300
Merge pull request #190 from nextcloud/add-wnd-1
...
Add "Login credentials" and "User Provided"
2016-06-27 16:15:31 +02:00
1cd255af56
Allow regular users to specify global credentials password
...
While the UI is existent the feature simply doesn't work because admin privileges are required for the controller. This adds proper permission checks and also unit tests.
To test this:
1. Enable external storage
2. Login as non-admin user
3. Go to personal page and try to change global credentials
2016-06-27 12:29:27 +02:00
0d3de20b02
Quickfix: do not lazy load auth mechanisms for ext storages
...
Some auth mechanisms like SessionCredentials need to register hooks
early, so they cannot be lazy loaded.
2016-06-27 10:50:10 +02:00
7a9d60d87e
Merge remote-tracking branch 'upstream/master' into master-upstream-sync
2016-06-26 12:55:05 +02:00
bac1a3a623
Add option to `occ files_external:list` to show all configured mounts
2016-06-23 13:12:03 +02:00
eed1c52aec
Hide more default options in occ files_external:list
2016-06-22 13:34:55 +02:00
d5dd30c3a0
Add "Login credentials" and "User Provided"
...
This adds the "Login Credentials" and "User Provided" option to the external storage implementation, it is basically done by reverting 176fb191b7https://github.com/owncloud/core/pull/22432 .
This was taken from owncloud/core which is AGPL licensed.
2016-06-21 14:58:35 +02:00
6affbdc6e7
Add "Global Auth" option to external storage
...
This adds the "Global Auth" option to the external storage implementation, it is basically done by reverting c2c6caee93https://github.com/owncloud/core/pull/22468 .
This was taken from owncloud/core which is AGPL licensed. Commited with "icewind@owncloud.com" to keep the license header signature in sync.
2016-06-21 14:16:45 +02:00
ef5217d6e8
Merge pull request #25173 from owncloud/fix_conversion_issues
...
Fix conversion issues
2016-06-20 17:15:45 +02:00
bb24e40bf4
Fix conversion issues
...
Change to phpdoc type for automatic conversion
2016-06-20 14:51:36 +02:00
09261fca86
Merge pull request #25010 from owncloud/gdrive-fix-tests
...
Fix GDrive test rename overwrite folder
2016-06-20 11:02:24 +02:00
e325209291
Convert Dropbox Forbidden exception to StorageNotAvailableException
2016-06-14 17:38:32 +02:00
c51bdd1809
Fix GDrive test rename overwrite folder
2016-06-10 14:53:37 +02:00
ac163426ef
Merge pull request #25008 from owncloud/externals_test_with_origin
...
Add support to know where the storage test comes from
2016-06-09 16:21:05 +02:00
7d85bed1fc
Change the default value to true instead of null
2016-06-08 12:48:33 +02:00
fa9c96ac4f
Fix GDrive file size when mime type doesn't match contents
...
Uploading a txt file with XML contents makes GDrive return the XML mime
type.
This fix makes sure the logic that returns "SPACE_UNKNOWN" for the size
properly rely on the Google Docs mime types.
2016-06-08 09:46:49 +02:00
110edd3d3c
Rename variable
2016-06-07 18:25:17 +02:00
8526bbb347
Add support to know where the storage test comes from
2016-06-07 16:53:16 +02:00
15fffb2b10
Fix GDrive upload file which name might match the one of a folder
...
Whenever a file is uploaded to GDrive, there is a check for that file
with and without extension, due to Google Docs files having no
extension. This logic now only kicks in whenever the detected
extensionless file is really a Google Doc file, not a folder.
This makes it possible again to upload a file "test.txt" in a folder
that also has a folder called "test"
2016-06-07 16:29:23 +02:00
c9132261c8
implement specific rename handling for SMB
2016-05-31 13:32:11 +02:00
4ea7a349d2
Fix SMB backend registration
2016-05-30 21:25:10 +01:00
aba539703c
Update license headers
2016-05-26 19:57:24 +02:00
ae4ee56997
Merge pull request #24814 from owncloud/fix-psr4-external-maste
...
Move Stuff to PSR-4 again
2016-05-25 09:12:17 +02:00
e8c3794308
Merge pull request #7897 from owncloud/ext-swiftcaching
...
Added object cache for Swift ext storage
2016-05-24 16:21:30 +02:00
794c566244
Move Stuff to PSR-4 again
2016-05-24 16:10:22 +02:00
f7d102ccc5
Merge pull request #24799 from owncloud/altyr-117-upstream
...
Update google-api-php-client to 1.1.7
2016-05-24 14:46:10 +02:00
648fc8d916
skip google map files ( #24807 )
2016-05-24 14:45:29 +02:00
8a40003169
fix phpdoc
2016-05-24 13:58:08 +02:00
c031eafd84
Fix cert bundle path
2016-05-24 13:44:43 +02:00
f77a11a876
Added object cache for Swift ext storage
...
This avoid calling the remote API for repeated calls to is_dir,
filetype, etc
2016-05-24 13:29:29 +02:00
4635ed7748
Fix autoloading for new google SDK lib
2016-05-24 12:22:30 +02:00
49bec94959
enable autoload of lib in google storage
2016-05-24 12:22:30 +02:00
3eba0c479f
Fix import path for 3rdparty dropbox autoloader
...
We moved the file by one level
2016-05-24 12:15:53 +02:00
64538740ec
Fix missing imports
2016-05-24 08:41:22 +02:00
f14dff680d
Move remaining classes to PSR-4
2016-05-24 08:41:22 +02:00
4576891f10
Move Lib\Storage to PSR-4
2016-05-24 08:41:22 +02:00
b9fd7d4cc7
Move Config to PSR-4
2016-05-24 08:41:21 +02:00
6ea54e73e8
Move Lib\Backend to PSR-4
2016-05-24 08:41:21 +02:00
6d7a1b9bd4
Move Lib\Auth to PSR-4
2016-05-24 08:41:21 +02:00
328b3c47d7
Move stuff from outside lib/ to PSR-4
2016-05-24 08:41:20 +02:00
4728308a9e
Merge pull request #24585 from owncloud/files_external_lazy
...
Load external storage backends/auth mechanisms lazily
2016-05-19 18:08:17 +02:00
5585fa0a68
Merge pull request #24630 from owncloud/one-shall-adjust-the-path
...
Use proper path
2016-05-17 10:11:21 +02:00
af0930fe59
Introduce backend/auth mechanism providers
...
Direct registration of backends/auth mechanisms is now deprecated
2016-05-11 21:16:26 +01:00
0d8393178b
Use proper path
...
Fixes https://github.com/owncloud/core/issues/24407
2016-05-03 14:37:50 +02:00
43abe2b648
Add links to load GDrive/Dropbox configuration pages
2016-05-03 11:30:02 +01:00
de98a6e54c
Allow multiple custom JS files
2016-05-03 11:30:02 +01:00
4326d73ff6
Fix SMB storage to not normalize UTF8
...
This makes sure that even if a NFD file name exists, it is found by the
storage and will be visible to higher layers. Even though the file will
be discarded anyway there, it gives the scanner a chance to display a
warning at least.
2016-04-29 16:19:53 +02:00
baff79cc63
Fix loading the dropbox autoloader
2016-04-15 12:46:47 +02:00
9a78cac2eb
Fix OCA\Files\External\Api namespace
2016-04-14 00:49:47 +01:00
4717605d22
Fix storage backend class namespaces and move to subdir
...
All classes that were previously \OC\Files\Storage\FooBar are now
\OCA\Files_External\Lib\Storage\FooBar
2016-04-14 00:44:28 +01:00
690eef26dd
Merge pull request #23274 from Senorsen/add-urlencode-ftp-sftp
...
Add urlencode to username part of ftp and sftp links
2016-03-31 23:18:10 +02:00
6d40e69e29
Merge pull request #23517 from owncloud/gdrive-stream-download
...
GDrive stream download with RetryWrapper
2016-03-31 21:17:10 +02:00
dea3985e86
Merge pull request #23516 from owncloud/dropbox-stream-download
...
Dropbox stream download with RetryWrapper
2016-03-31 20:07:36 +02:00
8394985e14
Merge pull request #23672 from owncloud/use-retry-wrapper-for-sftp
...
Use RetryWrapper for SFTP storage
2016-03-31 11:24:47 +02:00
3dc5c59e57
Use RetryWrapper for SFTP storage
...
Equivalent to https://github.com/owncloud/core/pull/23442
Required for making encryption work with external storage reliable.
2016-03-30 22:45:09 +02:00
7be541bda1
GDrive stream download with RetryWrapper
2016-03-30 18:39:41 +02:00
bd93722e12
Use the shipped cacerts.pem instead of the global one
...
The one we ship may cause problems since Equifax is not included anymore (SHA-1 certs) are deprecated. We should just be consistent here and also use the certificate file which is used by the other calls in the library.
2016-03-30 16:58:39 +02:00
02c2568442
Dropbox stream download with RetryWrapper
2016-03-23 18:06:01 +01:00
5e4f9b8627
Merge pull request #23440 from owncloud/fix_22286
...
apply retry wrapper to make sure that we always read/write a complete block
2016-03-22 09:50:05 +01:00
2357bbf80a
Merge pull request #23439 from owncloud/smb-permissions
...
properly use smb permissions
2016-03-21 18:05:45 +01:00
736b80f0cb
Merge pull request #23323 from owncloud/gdrive-chunkupload
...
Chunk upload for GDrive
2016-03-21 18:02:55 +01:00
f761733f17
apply retry wrapper to make sure that we always read/write a complete block
2016-03-21 17:39:43 +01:00
8ab70b1231
properly use smb permissions
2016-03-21 14:35:41 +01:00
0bc51b9118
Merge pull request #23272 from owncloud/dropbox-downloadnotthefullfileinmemory
...
Fix dropbox storage to not store the whole file in memory
2016-03-17 20:52:41 +01:00
5db41dfbed
Only use GDrive chunks when needed
2016-03-17 12:36:47 +01:00
aa2674e7e2
Chunk upload for GDrive
...
Instead of storing the WHOLE file in memory in a PHP variable, use the
library's chunk upload support.
2016-03-16 17:57:54 +01:00
d498282e12
handle connection errors as storage not available in smb
2016-03-16 13:15:54 +01:00
a6631eceb4
Add urlencode to username part of ftp and sftp links
...
according to #17796
2016-03-16 01:49:40 +08:00
ab50ba7a58
Fix dropbox storage to not store the whole file in memory
...
Since the library can only store the full response in memory on
download, we use an alternate client lib and set the correct headers to
be able to stream the content to a temp file.
2016-03-15 18:05:27 +01:00
a8db587b1f
move failedstorage to core
2016-03-11 13:15:45 +01:00
3bd6fc797d
dont break when there is an invalid share
2016-03-11 13:15:45 +01:00
d14adb2351
Fix compatibility with PHP 5.4
...
Fixes https://github.com/owncloud/core/issues/22960
2016-03-08 18:04:24 +01:00
4255dd2b39
Properly set exception in FailedStorage
2016-03-03 14:37:23 +01:00
Lukas Reschke
Morris Jobke
Roeland Jago Douma
Robin Appelman
Juan Pablo Villafáñez
gvmura
Ardinis
Joas Schilling
Björn Schießle
Arthur Schiwon
Roeland Jago Douma
Jörn Friedrich Dreyer
Martin
Christoph Wurst
Vincent Petry
Robin Appelman
Lukas Reschke
Arthur Schiwon
Robin McCorkell
Joas Schilling
Francesco Rovelli
Robin McCorkell
Thomas Müller
Frank Karlitschek
Bjoern Schiessle
Senorsen
