Commit Graph

19017 Commits

Author SHA1 Message Date
Michael Weimann 72533658fe
Fixes file/folder move/copy buttons
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-10-01 23:16:56 +02:00
Jan-Christoph Borchardt 0f827ea1f4
Fix buttons wrapping on long folder names
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 23:16:45 +02:00
Jan-Christoph Borchardt 1b92ec06b0
Ellipsize long filenames and sharee names in public share page header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-01 15:23:53 +02:00
EASY f2a5a4d622
Used CSS Variables 2018-10-01 10:25:01 +02:00
EASY d5876fe98a
Update theming.scss 2018-10-01 10:24:57 +02:00
Robin Appelman e3dab24a2a
AssemblyStream is also eof if we have no more source stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-09-28 15:41:25 +02:00
Morris Jobke 5d84475e11
Merge pull request #11399 from nextcloud/stable14-11112-do-not-hide-the-progress-bar-while-the-chunked-upload-is-being-assembled
[stable14] Do not hide the progress bar while the chunked upload is being assembled
2018-09-27 14:05:48 +02:00
blizzz 6eab0d0ece
Merge pull request #11389 from nextcloud/backport/11383/stable14
[stable14] do not explode when getting permissions from a FailedStorage
2018-09-27 10:51:43 +02:00
Arthur Schiwon 5a20ac9863
do not explode when getting permissions from a FailedStorage
for instance if a user of an external user backend is not available
currently, the whole Files UI would be frozen.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-09-26 13:33:59 +02:00
Daniel Calviño Sánchez e82fe088c8 Do not hide the progress bar while the chunked upload is being assembled
Large files are not uploaded in a single operation, but uploaded in
several chunks; once all the chunks are uploaded then the server needs
to assemble them to get the final file.

Before, once the chunks were uploaded the progress bar was hidden.
However, this was confusing for the users, as the file could still need
some time to appear in the file list due to the assembling. Now once all
the chunks are uploaded the text in the progress bar changes to inform
the user that there are still some pending operations, and only when the
file is finally assembled the progress bar is hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-26 12:35:50 +02:00
Daniel Calviño Sánchez c274344160 Fix position of contacts menu shown on mentions
There are no default CSS rules for the contacts menu, as its position
depends on the element on which it is shown. Note, however, that if no
explicit rules are provided the contacts menu on mentions is affected by
the rules for the contacts menu on shares from the sharing tab.

The contacts menu is now positioned to show the tip of the arrow
horizontally aligned with the center of the avatar, and with the top of
the menu slightly below the bottom border of the mention.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-24 09:58:23 +02:00
Daniel Calviño Sánchez d0c3b45f0f Fix contacts menu not triggered on certain areas of a mention
The contacts menu was triggered only when the avatar or the name of the
user were clicked. Due to this, clicking on certain (small) areas of a
mention (like the right end, or the space between the avatar and the
name) did not show the contacts menu. Now the contacts menu is shown
when any area of the mention is clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-24 09:58:23 +02:00
Joas Schilling 1f714124bb
Merge pull request #11259 from nextcloud/fix/11144/backport14
[14] Fixes empty favorite names for trailing slashes
2018-09-20 13:43:24 +02:00
blizzz 0c85cb1ea9
Merge pull request #11077 from nextcloud/stable14-11064-fix-markup-and-style-of-mentions-in-comments
[stable14] Fix markup and style of mentions in comments
2018-09-20 10:37:23 +02:00
Joas Schilling 9a4ad9cd17
Merge pull request #11287 from nextcloud/backport/11041/get_permission_of_storage_for_shares
[stable14] Get permission of storage for shares
2018-09-20 10:25:34 +02:00
Michael Weimann 43889d1a49
Fixes empty favorite names for trailing slashes
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-19 17:44:54 +02:00
Joas Schilling c02c63f53a
Merge pull request #11282 from nextcloud/backport/11183/fix-link-for-update-notifications
[stable14] Fix the link and anchor for the update notifications
2018-09-19 15:59:25 +02:00
Roeland Jago Douma 5e13368299
Update test now that we check permissions properly
Now that we actually check thepermissions properly we have to update the
tests.

* We checked an invalid path
* We checked from wrong permissions (files never have CREATE permissions
for example)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:21 +02:00
Roeland Jago Douma b66b2de6ff
Properly check share permissions
isCreatable only works on folders
isUpdatable if the file is not there but it is a part file also has to
be checked on the folder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:13 +02:00
Roeland Jago Douma 43f73ad808
Fix shared cache
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:28:04 +02:00
Roeland Jago Douma 4cc8cdc276
Check the permission of the underlying storage
Else shares might expose more permissions than the storage actually
providers.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-09-19 13:27:57 +02:00
Joas Schilling d50fa1bdb8
Fix the link and anchor for the update notifications
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-19 12:12:13 +02:00
Daniel Calviño Sánchez 896c8df6ad Prevent comment being composed from overlapping the submit button
The submit button is placed in the text area using absolute positioning,
so it is not taken into account when calculating the text layout. Due to
this it is necessary to add an explicit padding to the right of the text
area to prevent the text from overlapping the submit button.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-19 08:51:42 +02:00
Patrik Kernstock 5058333445 Remove filter_var flags due to PHP 7.3 deprecation, fixes #10894
Signed-off-by: Patrik Kernstock <info@pkern.at>
2018-09-16 04:45:15 +02:00
Joas Schilling 73e870bd78
Fix user and group listing with users that have an integer user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-12 11:54:22 +02:00
Roeland Jago Douma b580ef18c8
Merge pull request #11039 from nextcloud/backport/fix/10968/upload-progress
Fixes the upload progress bar layout - 14 backport
2018-09-07 13:58:58 +02:00
Daniel Calviño Sánchez 51b978d3f0 Add new line at the end of file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 2e424d84a4 Ensure that the avatar and the user name will be kept together
Otherwise a line break could be added between the avatar and the user
name when the wrapper is close to the right border of the message.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez e7d4d3a34b Remove unneeded CSS rule for mentions
Most of the properties of the rule are not needed for mentions, so the
rule is no longer applied to them; the only needed property was moved to
the main rule for mentions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 7c851b5b77 Fix pointer cursor not shown on avatars
When the cursor is on an avatar wrapper the cursor is shown as a pointer
to inform the user that it can be clicked (which will either show the
contacts menu or insert a mention, depending on the case); the cursor
must be explicitly defined for the "img" element that shows the avatar
too, or otherwise the default cursor would be shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez b14425ef6f Highlight mentions to the current user
Like done in Talk, mentions to the current user are now shown with the
primary colors to make them more prominent.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 3c63850117 Ensure that the user name is shown in bold in mentions
Different browsers use different font weights for strong elements
(Chromium uses "bold", but Firefox uses "bolder", which is relative to
the font weight of the parent), so now the user name in mentions is
explicitly shown with a bold weight.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 6b7e049288 Reformat embedded HTML code to resemble HTML code
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez 3ee07ac770 Remove space between avatar and user name
The avatar should be shown immediately after the avatar to be able to
accurately define the space between them using only CSS rules.

Note that in the case of the "atwho" menu it is not really needed, as a
whitespace removal seems to be done automatically by the plugin, but it
was modified for its displayed elements too for consistency.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Daniel Calviño Sánchez da75c7ff6d Show avatar using "span" instead of "div"
Visually it makes no difference, but as the ".avatar" element is inside
a "span" element it can not be a block element to be compliant with the
HTML specification.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 20:59:02 +02:00
Georg Ehrke 2bdc407a82
remove LogicException, because it's also triggered with legitimate parameters
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-09-05 14:12:27 +02:00
Michael Weimann 209b3bee68
Fixes the upload progress bar layout
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-09-03 21:13:28 +02:00
Nextcloud bot 2a22615879
[tx-robot] updated from transifex 2018-08-31 00:12:09 +00:00
Morris Jobke 8ea2f8dea4
Merge pull request #10910 from nextcloud/customproperties-ignored-list
use the same ignored properties list for both CustomerPropertiesBackends
2018-08-30 21:23:36 +02:00
Morris Jobke ab9672a32f
Merge pull request #10913 from nextcloud/do-not-parse-html-in-user-id-and-display-name
Do not parse HTML in user id and display name
2018-08-30 20:52:20 +02:00
Julius Härtl 25857c4900
Merge pull request #10924 from nextcloud/bugfix/10901/theming-bugfix-primary
Fix SCSS variable management with the theming app
2018-08-30 17:35:40 +02:00
Julius Härtl a791bdb3ab
Fix capabilities test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-30 14:45:06 +02:00
Julius Härtl 5bae5bf3eb
Make the default element color for bright theming colors lighter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-30 10:37:05 +02:00
Nextcloud bot 4da9a15b32
[tx-robot] updated from transifex 2018-08-30 00:12:07 +00:00
Julius Härtl 3a62890a13
Merge pull request #10876 from nextcloud/bugfix/10873/theming-settingsbutton
Theming: apply proper size to the remove background button
2018-08-29 17:24:05 +02:00
Julius Härtl 2bdc3b1d27
Remove border from primary button when color is bright
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-29 16:47:39 +02:00
Julius Härtl e8938df198
Move SCSS variable fetching before the variables.scss to properly calculate color values
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-29 16:47:39 +02:00
Nextcloud bot 27141a960f
[tx-robot] updated from transifex 2018-08-29 00:12:07 +00:00
Joas Schilling 5ba881ba41 Do not parse HTML in user id and display name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-28 18:57:07 +02:00
Robin Appelman 3806ecb242
use the same ignored properties list for both CustomerPropertiesBackends
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-28 18:27:53 +02:00
Morris Jobke e9dd6aec61
Merge pull request #10871 from cviereck/patch-1
cast timestamps older than unix epoch to 0
2018-08-28 16:52:20 +02:00
John Molakvoæ 90581a44c0
Merge pull request #10892 from nextcloud/fix-drag-shadow-in-files-app
Fix drag shadow in Files app
2018-08-28 13:13:52 +02:00
Julius Härtl a14fddc2d5
Merge pull request #10875 from nextcloud/bugfix/10024/theming-footer-link
Theming: Only link Entity in footer if a url is set
2018-08-28 13:01:20 +02:00
Nextcloud bot a768550177
[tx-robot] updated from transifex 2018-08-28 00:13:06 +00:00
Daniel Calviño Sánchez c3610d1d17 Remove limit on "max-width" for file names in drag shadow
The general file list sets "max-width: 0" in the file names, which
causes the file names in the drag shadow to have no width for their
content and thus to overlap with the file size.

As that limit is needed for proper layout in the general file list it is
removed only for file names in drag shadows.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-27 18:12:50 +02:00
Daniel Calviño Sánchez 8824af324d Increase z-index of drag shadow for files
The drag shadow is a sibling of "#content" so its z-index must be higher
than the z-index of the content children (navigation bar, app content
and app sidebar) to appear in front of them.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-27 18:08:45 +02:00
Julius Härtl c4f34ccc4c
Theming: Fix footer tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 15:22:49 +02:00
Julius Härtl 5175e33e31
Theming: Only Entity in footer if a url is set
fixes #10024

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 13:59:16 +02:00
Julius Härtl e94c2bbb3b
Theming: apply proper size to the remove background button
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-27 12:35:02 +02:00
Christian e2a64c713f
cast timestamps older than unix epoch to 0
This change solves issues #10870, which is caused by method castValue of class FileSearchBackend: It casts the timestamps older than the unix epoch to false., see my comment https://github.com/nextcloud/server/pull/10835#discussion_r212806153.
2018-08-27 07:44:24 +02:00
Nextcloud bot 8b47f45afa
[tx-robot] updated from transifex 2018-08-27 00:12:14 +00:00
John Molakvoæ 2ea820cd6e
Merge pull request #10856 from nextcloud/bugfix/noid/comments-contactsmenu
Fix contactsmenu for mentioned users in comments
2018-08-26 14:32:45 +02:00
Nextcloud bot d8147cbba7
[tx-robot] updated from transifex 2018-08-26 00:12:33 +00:00
Julius Härtl e312766783
Fix contactsmenu for mentioned users in comments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-25 18:25:47 +02:00
Nextcloud bot d644cafae7
[tx-robot] updated from transifex 2018-08-25 00:12:33 +00:00
Morris Jobke 8761856a71
Merge pull request #10838 from nextcloud/header-fixes-and-public-note
Header fixes and public note
2018-08-24 22:21:55 +02:00
Morris Jobke c850b3ac20
Merge pull request #10820 from nextcloud/fix/noid/emptydefaultprefix
[LDAP] The WebUI Wizard also should not assign empty config IDs
2018-08-24 21:37:00 +02:00
Roeland Jago Douma ede9e38be7
Merge pull request #10834 from nextcloud/add-support-for-room-shares
Add support for room shares
2018-08-24 21:15:54 +02:00
Morris Jobke 29f215a90d
Merge pull request #10835 from nextcloud/dav-search-no-negative-mtime
disallow negative mtime in dav search
2018-08-24 20:32:26 +02:00
John Molakvoæ (skjnldsv) 719f9288b9
Tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 20:31:29 +02:00
Morris Jobke b1410df18e
Merge pull request #10803 from nextcloud/smb-dir-instead-of-allinfo
prefer using dir instead of allinfo for getting smb file info
2018-08-24 19:30:30 +02:00
Roeland Jago Douma 79a88ed458
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-24 18:20:04 +02:00
Daniel Calviño Sánchez 5c07f9c2ec
Add rooms in the default candidate types to look for when sharing
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-24 18:06:46 +02:00
Morris Jobke 7bc9b9a76e
Merge pull request #10773 from nextcloud/collapsible-dark-fix
Accessibility theme fixes
2018-08-24 17:56:00 +02:00
Robin Appelman 4ff1d287d2
fix missing import
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 17:34:36 +02:00
Morris Jobke d8e876c0da
Merge pull request #10828 from nextcloud/bugfix/fac-108/mimetype-detection-broken-for-junked-uploads
Fix mimetype detection for junked uploads
2018-08-24 17:22:56 +02:00
Morris Jobke e8817ed3ea
Merge pull request #10724 from nextcloud/large-share-count-performance
Improve performance when dealing with large numbers of shares
2018-08-24 17:10:17 +02:00
John Molakvoæ (skjnldsv) ac2c925231
Fix mobile view and add public share note view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 16:45:40 +02:00
Robin Appelman b76e6be441 disallow negative mtime in dav search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-24 16:20:07 +02:00
John Molakvoæ (skjnldsv) 3cb52b868a
Fix header calculation and better public design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 15:45:39 +02:00
Joas Schilling c574212422
Fix mimetype detection for junked uploads
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-24 10:42:59 +02:00
Morris Jobke 8563ab94aa
Merge pull request #10589 from nextcloud/smb-stat-retry
retry smb stat on timeout
2018-08-24 07:00:40 +02:00
Nextcloud bot 503fbc953e
[tx-robot] updated from transifex 2018-08-24 00:12:20 +00:00
Arthur Schiwon 7807add02d
[LDAP] The WebUI Wizard also should not assign empty config IDs
With 689df9a843 the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 17:58:35 +02:00
Robin Appelman bf7fb2b0a2 assume the same timezone when using local domain names for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-23 16:09:33 +02:00
Robin Appelman 50463e2d13 improved fallback of timezone detection
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-23 16:09:33 +02:00
Morris Jobke 2219d35207
Merge pull request #10815 from nextcloud/fix/noid/missingreturnval
returning of $tr is expected, otherwise ending up in a JS error
2018-08-23 14:53:00 +02:00
Nextcloud bot c0f48a7b40
[tx-robot] updated from transifex 2018-08-23 00:12:59 +00:00
Arthur Schiwon 78f61b2ade
returning of $tr is expected, otherwise ending up in a JS error
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 00:28:03 +02:00
Robin Appelman c1389070fa use dir instead of allinfo where possible 2018-08-22 14:16:33 +02:00
Nextcloud bot 65410ab1cb
[tx-robot] updated from transifex 2018-08-22 00:12:11 +00:00
blizzz 1a7516dd93
Merge pull request #10775 from nextcloud/fix/10431/ldap-groups
Resolve all group memberships properly
2018-08-21 17:05:12 +02:00
Morris Jobke 04d6cefaa1
raise version to trigger migration
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 11:08:14 +02:00
Morris Jobke 3d8f174774
Resolve all group memberships properly
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 10:57:50 +02:00
Christoph Wurst 2f34df4982
Fix integration test execution on Dron
Apparently the Nextcloud server ignores tests that have `Integration` in their
fully-qualified class name, hence the backup codes integration tests were removed.
This moves them up one directory (out of `Integration`) to fix that.
Real unit tests remain in the `Unit` directory.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 09:09:15 +02:00
Christoph Wurst 82748a482e
Fix backup codes column length to fix Argon2 hash values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 06:53:37 +02:00
Christoph Wurst 42035cab9d
Add an integration test that inserts long back codes values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-21 06:49:26 +02:00
Nextcloud bot be3438ca97
[tx-robot] updated from transifex 2018-08-21 00:12:16 +00:00
John Molakvoæ (skjnldsv) 2e57324629
Update contrast theme to better readability on icons and files action
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-20 22:12:55 +02:00
Morris Jobke 6d749bf021
Merge pull request #10700 from nextcloud/fix/10516/sharepermissions
Fix share dialog sidebar in share views
2018-08-20 17:14:12 +02:00
blizzz 1b1c8b3e76
Merge pull request #10738 from nextcloud/fix/10669/store-sorting-only-for-loggedin-users
Only send an update sort order request if there is an user
2018-08-20 14:54:50 +02:00
Morris Jobke 1c13e78633
Merge pull request #10697 from nextcloud/smb-log-removed-entries
log entries that are hidden during file listing
2018-08-20 14:48:48 +02:00
Morris Jobke 9cf11bd73c
Merge pull request #10687 from nextcloud/fix/noid/false-positive-change-mention
don't blame randome people for background email updates
2018-08-20 14:37:41 +02:00
Nextcloud bot 1958a710d8
[tx-robot] updated from transifex 2018-08-20 00:12:26 +00:00
Julius Härtl de119eefd6
Merge pull request #10707 from nextcloud/dark-theme-fixes
Fix public pages background
2018-08-18 11:41:39 +02:00
Nextcloud bot 82854b5042
[tx-robot] updated from transifex 2018-08-18 00:12:35 +00:00
Michael Weimann 2de34d7778
Improves the tests
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:35:23 +02:00
Michael Weimann 887737f706
Stores the sorting only if there is an user
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:09:11 +02:00
Michael Weimann f18fc851c0
Adds a test to check that the sorting isn't stored without an user
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-17 20:08:57 +02:00
Björn Schießle 3a44cce5cc
Merge pull request #10718 from nextcloud/occ-recover-encryption
add occ command to recover encrypted files in case of password lost
2018-08-17 10:07:16 +02:00
Robin Appelman 67f3d6f0a6
cache parent exists status during share setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:28:01 +02:00
Robin Appelman 720b27d60b
only determine is sharing is disabled for a user once
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:54 +02:00
Robin Appelman b5217b6f63
don't check if target dir exists when using the default share target directory
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:51 +02:00
Robin Appelman b79f338e71
re-use view instances for shared storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:48 +02:00
Robin Appelman bc4f10ad83
more efficient way to detect added and removed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 21:27:45 +02:00
Robin Appelman 3155c1bd9a
more efficient unique share target generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 19:54:42 +02:00
Bjoern Schiessle 3adc2aca53
add occ command to recover encrypted files in case of password lost
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-08-16 15:51:01 +02:00
Arthur Schiwon e4720b6056
and the user popover needs a higher z-index, to make it visible again
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 13:26:51 +02:00
Arthur Schiwon 6645c014e9
fix wrong return value of filtered whats new info
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 12:50:44 +02:00
Julius Härtl a4e042c706
Merge pull request #10695 from nextcloud/sharing-public-settings-fixes
Fix password enforce on public links
2018-08-16 09:38:58 +02:00
Roeland Jago Douma 2b5ec3755e
Merge pull request #10692 from nextcloud/deleted-share-remove-actions
Do not show action menu if no actions are available
2018-08-16 08:32:19 +02:00
John Molakvoæ (skjnldsv) 5647f85a3c
Object.values polyfill
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:43:57 +02:00
John Molakvoæ (skjnldsv) c435bfe703
Disabled checkboxes and design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:31:17 +02:00
John Molakvoæ (skjnldsv) 7299eb3e20
Fix public pages background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:17:28 +02:00
Nextcloud bot b0af604d0e
[tx-robot] updated from transifex 2018-08-16 00:12:17 +00:00
Robin Appelman bdc6d0b5a1
log entries that are hidden during file listing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-16 01:20:05 +02:00
Arthur Schiwon 2b903aa267
fix unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 16:11:07 +02:00
Arthur Schiwon 7f58f36b18
remove unexecutable code
OCA.Sharing.SharedFileInfo was never defined and that stopped execution.
Interestingly, FF never showed me an error.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 15:20:41 +02:00
Julius Härtl f7ae4771c8
Merge pull request #10691 from nextcloud/various-beta14-design-fixes
Various beta14 design fixes
2018-08-15 14:46:45 +02:00
John Molakvoæ (skjnldsv) b082278f04
Do not show action menu if no actions are available
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 09:39:12 +02:00
John Molakvoæ (skjnldsv) 0e23193b32
Added feedback on autocomplete ui
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:59:06 +02:00
John Molakvoæ (skjnldsv) 3d169ae4f8
Typo
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:46:40 +02:00
John Molakvoæ (skjnldsv) a95dc4d3a7
Ellipsis long username/mails in share view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 08:45:07 +02:00
John Molakvoæ (skjnldsv) f014d31551
Undo button fix in theming
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 07:31:04 +02:00
John Molakvoæ (skjnldsv) a7c426aa5c
Add default theming into accessibility compiler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 07:25:31 +02:00
Nextcloud bot 62a9ec12bc
[tx-robot] updated from transifex 2018-08-15 00:13:40 +00:00
Arthur Schiwon b497b06867
don't force LDAP updates on userExists anymore
and remove some deprecated code

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:57:24 +02:00
Arthur Schiwon 6f24865bf8
don't blame email address changers
the information is being collected with admin_audit

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:25:46 +02:00
blizzz d05c815796
Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
Nextcloud bot ba4c42abaa
[tx-robot] updated from transifex 2018-08-14 00:12:05 +00:00
Nextcloud bot ccb040ee01
[tx-robot] updated from transifex 2018-08-13 00:12:09 +00:00
Nextcloud bot 4cdad9b69f
[tx-robot] updated from transifex 2018-08-11 00:12:30 +00:00
Roeland Jago Douma e22d15c3a1
Merge pull request #10642 from nextcloud/bump/autoloaders
Bump autoloaders
2018-08-10 16:18:00 +02:00
Roeland Jago Douma 80dd312e74
Merge pull request #10615 from nextcloud/fix-trashbin-actions
Fix trashbin file actions
2018-08-10 15:09:28 +02:00
Roeland Jago Douma 90a656305b
Bump autoloaders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:03:22 +02:00
Roeland Jago Douma 7aad5b7721
Merge pull request #10543 from nextcloud/ignore-deactivated-users
Do not show deactivated users in sharees and contacts
2018-08-10 15:01:14 +02:00
Nextcloud bot 103a2c30fb
[tx-robot] updated from transifex 2018-08-10 00:12:26 +00:00
Arthur Schiwon 59e35e3bf7
tests for user storage location
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
Arthur Schiwon b069b13226
convert pagination tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 0f6d98eed2
convert connection tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon eaf352b8d1
integration test to ensure entries without displayname don't cause trouble
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 4e8db8aa11
convert LDAP offline and backup server integration tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon a39c995083
FIX: emit assignedUserId only for users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 3450ed4536
integration test checking the group filter
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Roeland Jago Douma 7dc4fadc21
Merge pull request #10626 from nextcloud/bugfix/noid/quickaccess-spaces
Fix quickaccess active indicator for folders with spaces
2018-08-09 19:44:17 +02:00
Julius Härtl d54635fc7d
Fix quickaccess active indicator for folders with spaces
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 18:31:02 +02:00
Robin Appelman 16909f04c2
Fix trashbin file actions
Fixes #10491

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-09 14:31:02 +02:00
Björn Schießle 6aa6d2186c
Merge pull request #10255 from nextcloud/add-support-for-room-shares
Add support for room shares
2018-08-09 10:44:11 +02:00
Roeland Jago Douma ca0f2f63eb
Merge pull request #10537 from MartB/mselect_fix
Fix multiSelectMenu for public shares #10536
2018-08-09 10:41:38 +02:00
Roeland Jago Douma a21c93a3cf
Merge pull request #8690 from nextcloud/feature/8565/make-thunderbird-and-outlook-addons-identifyable
[Part2] Make thunderbird and outlook addons identifyable
2018-08-09 09:55:26 +02:00
Roeland Jago Douma 7648bb05e9
Merge pull request #10548 from nextcloud/fix/10430/update_icewind_streams
Update icewind/streams
2018-08-08 20:18:59 +02:00
Björn Schießle 11e99859ef
Merge pull request #10397 from nextcloud/encryption-s3-fix
make file cache updates more robust
2018-08-08 18:27:18 +02:00
Robin Appelman 24aaa3bc97
retry stat on timeout
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-08-08 16:07:41 +02:00
Daniel Calviño Sánchez e2e6f23b67 Suppress Phan warnings about calling undeclared class methods
The DeletedShareAPIController and ShareAPIController helpers for room
shares are defined in Talk, so the classes do not exist when Talk is not
installed. Due to this when the object returned by "getRoomShareHelper"
is used Phan complains that the class is not declared.

This is not a problem, though, because when the class is not available
"getRoomShareHelper" throws an exception, which is then caught where
that method was called. Therefore now those warnings from Phan are
suppressed (it would be better to use "@phan-suppress-next-line"
instead, but it is not yet available in our Phan version).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
Daniel Calviño Sánchez 0fab46c817 Log sharing and unsharing with a room in the auditing app
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 30d8e3ee05 Transfer room shares too with the "files:transfer-ownership" command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 523fdb612c Add room shares to DAV and recent files "share-types" property
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 1ccc99ed83 Add support for room shares to the share owner updater
A user can move her own shares into a received share. When that happens
she is effectively handing over the ownership of the file, so the share
needs to be updated to reflect the new owner.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 8084ba516f Add room shares to the MountProvider for shares
The MountProvider for shares creates mount points for the files shared
with the user, which makes possible to use the received shared files and
folders as regular files and folders.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 382b27d035 Add support for room shares to DeletedShareAPIController
In some cases, the DeletedShareAPIController requires explicit handling
of each type of share (for example, to format a share for a
DataResponse). Room shares are implemented in an external app (Nextcloud
Talk), so in order to keep the controller as isolated as possible from
room share specifics all that explicit handling is done in a helper
class provided by the Talk app.

In other cases it is just enough to call the share manager specifying a
room share type; note that the share manager is guarded against share
types for which there is no provider, so it is not necessary to
explicitly check that before passing room shares to the share manager.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
Daniel Calviño Sánchez 4ed7131e26 Add support for room shares to ShareAPIController
In some cases, the ShareAPIController requires explicit handling of each
type of share (for example, to format a share for a DataResponse). Room
shares are implemented in an external app (Nextcloud Talk), so in order
to keep the controller as isolated as possible from room share specifics
all that explicit handling is done in a helper class provided by the
Talk app.

In other cases it is just enough to call the share manager specifying a
room share type; note that the share manager is guarded against share
types for which there is no provider, so it is not necessary to
explicitly check that before passing room shares to the share manager.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
John Molakvoæ (skjnldsv) 91737b591e
js fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-08 11:24:13 +02:00
fnuesse 7a78e0c641
Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-08 09:23:54 +02:00
Nextcloud bot 1cb8fe3cb0
[tx-robot] updated from transifex 2018-08-08 00:13:19 +00:00
Björn Schießle f8de12c014
Merge pull request #10558 from nextcloud/fix/noid/failing_sync_job_is_no_error
A failing federation sync job is not an error
2018-08-07 10:09:24 +02:00
Nextcloud bot 35342b4b7d
[tx-robot] updated from transifex 2018-08-07 00:12:06 +00:00
Roeland Jago Douma dd5862e270
A failing federation sync job is not an error
This is an INFO warning at best. Else it spams the logs continiously.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-06 21:07:15 +02:00
blizzz db941a3f2e
Merge pull request #10523 from janLo/fix-8825
Adding test for table schedulingobjects and fixing postgres LOB
2018-08-06 17:17:47 +02:00
Thomas Müller c05a0b9fa6
Adding test for table schedulingobjects and fixing postgres LOB
(cherry picked from commit afd4ebf0404e8bcd7cba0bec2dce177e97632f8a)

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
2018-08-06 13:53:32 +02:00
Roeland Jago Douma db4235d587
Update icewind/streams
Fixes #10430

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-06 13:14:08 +02:00
MartB 5109743383 Fix multiSelectMenu for public shares #10536
Signed-off-by: Martin Böh (MartB) <mart.b@outlook.de>
2018-08-06 12:42:13 +02:00
Thomas Citharel c800495169 Test sync service when user is deactivated
I feel like this could probably be handled better :/

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 12:34:56 +02:00
Thomas Citharel a311798674 Remove users from system addressbook when user deactivated
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-08-06 09:30:21 +02:00
Nextcloud bot ca54166e35
[tx-robot] updated from transifex 2018-08-06 00:12:21 +00:00
Nextcloud bot a625a4d704
[tx-robot] updated from transifex 2018-08-05 00:12:29 +00:00
Nextcloud bot 752ee28b1b
[tx-robot] updated from transifex 2018-08-04 00:12:38 +00:00
Julius Härtl 16f6c07173
Always call render to replace the app-sidebar if the detail view is updated
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 11:47:53 +02:00
Julius Härtl bcdbc4e19e
Fix return value of change directory
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-03 11:47:10 +02:00
Nextcloud bot bf88448f87
[tx-robot] updated from transifex 2018-08-03 00:12:22 +00:00
Roeland Jago Douma 01298cfa72
Merge pull request #10480 from nextcloud/bugfix/10420/settings
Settings design polishing
2018-08-02 20:23:21 +02:00
Julius Härtl 84f99db7ab
files_external: Fix jsunit tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-02 11:45:04 +02:00
Julius Härtl 0dd519cff1
Fix encryption admin section tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-02 10:26:09 +02:00
Roeland Jago Douma e194dc7139
Merge pull request #10465 from nextcloud/fix/backup-codes-state-propagation
Fix state propragation of the backup codes provider
2018-08-02 10:13:59 +02:00
Nextcloud bot 62af5bf033
[tx-robot] updated from transifex 2018-08-02 00:12:37 +00:00
Christoph Wurst f8fe7488a5
Fix state propragation of the backup codes provider
Starting with Nextcloud 14, the server knows the enabled/disabled
state of 2fa providers. While it will query that information if it's
unknown (on first use), it won't notice any changes. Thus, providers
have to propagate that information themselves.

Ref https://github.com/nextcloud/twofactor_totp/pull/263
Ref https://github.com/nextcloud/twofactor_u2f/pull/210

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-08-01 21:21:30 +02:00
Julius Härtl b46b7d7591
systemtags: Submit input on enter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:45:34 +02:00
Julius Härtl 03971d3695
Move encryption settings to security
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:09 +02:00
Julius Härtl 10de5f219c
files_external: Add description to settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:09 +02:00
Julius Härtl 635575f271
files_external: Move delete option to 3-dots menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Julius Härtl 9b46814320
Rename CalDAV to Calendar settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-01 09:41:08 +02:00
Nextcloud bot 6a9bee478d
[tx-robot] updated from transifex 2018-08-01 00:11:59 +00:00
Roeland Jago Douma 411387d37d
Merge pull request #9242 from nextcloud/fix-display-name-ignored-when-creating-new-user
Fix display name ignored when creating new user
2018-07-31 19:59:38 +02:00
Julius Härtl cfcb90214f
Revert to regular buttons in system tags management
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-31 15:35:57 +02:00
Daniel Calviño Sánchez 36326e38a0 Add optional "displayName" parameter to add user endpoint
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 13:33:55 +02:00
Bjoern Schiessle a9e22c5f1c
make file cache updates more robust
only update the encrypted version after the write operation is finished and the stream is closed

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-31 12:24:38 +02:00
Roeland Jago Douma b16f1093af
Merge pull request #10460 from nextcloud/bugfix/10443/theming-icons
Use icon mixins for the theming scss
2018-07-31 11:50:21 +02:00
Nextcloud bot 5e43f3c6a6
[tx-robot] updated from transifex 2018-07-31 00:12:12 +00:00
Julius Härtl 5d7c0b8cd2
Use icon mixins for the theming scss
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-31 00:10:34 +02:00
Joas Schilling 168d6f7c44
Merge pull request #10435 from nextcloud/rakekniven-patch-1
Typo fix: Triple dot to ellipsis
2018-07-30 20:12:17 +02:00
rakekniven 6c5670f6d2
Update IMipPlugin.php
Added space before ellipsis
2018-07-30 15:05:55 +02:00
Nextcloud bot 566800b29c
[tx-robot] updated from transifex 2018-07-30 00:12:08 +00:00
rakekniven c94ac53e60
Typo fix: Triple dot to ellipsis
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2018-07-29 10:15:02 +02:00
Nextcloud bot 0c7a17795b
[tx-robot] updated from transifex 2018-07-28 00:12:07 +00:00
Roeland Jago Douma 5edab3b311
Merge pull request #10416 from nextcloud/bugfix/10414/fix-preview-url
Use OC.generateUrl to properly prefix preview images
2018-07-27 09:33:00 +02:00
Nextcloud bot 6ccc34f5af
[tx-robot] updated from transifex 2018-07-27 00:12:20 +00:00
Julius Härtl 093799f4b0
Use OC.generateUrl to properly prefix preview images
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-26 22:41:41 +02:00
Morris Jobke 6514bf1e18
Merge pull request #10406 from nextcloud/bugfix/10405/undefined-index-classes
Not all sidebar entries have the "classes" attribute
2018-07-26 16:05:34 +02:00
Roeland Jago Douma 309ae6d9c0
Set the favorites to the empty array on failure
Else it will start throwing errors because null is not iteratable.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-26 15:14:28 +02:00
Morris Jobke 68ba96a7d5
Not all sidebar entries have the "classes" attribute
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-26 15:05:00 +02:00
Nextcloud bot e98f4de66a
[tx-robot] updated from transifex 2018-07-26 00:12:01 +00:00
Morris Jobke 61397ee091
Merge pull request #9222 from nextcloud/feature/noid/search-for-files-by-comments
Allow to search files by comments
2018-07-25 20:30:00 +02:00
Morris Jobke 2dd55b0550
Brighter comments icon
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-25 20:28:49 +02:00
Joas Schilling ac2314e3d0 Add pagination support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 18:53:45 +02:00
Joas Schilling 8c7969e730 Allow to search by comments
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 18:53:44 +02:00
Julius Härtl 6d29b36200
Limit small avatar rendering only to inline mentions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 14:26:04 +02:00
Joas Schilling 80207d72fa Correctly register everything via the Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-25 10:26:06 +02:00
Nextcloud bot fb77ff9da4
[tx-robot] updated from transifex 2018-07-25 00:12:34 +00:00
Morris Jobke a96137ef0b
Merge pull request #10310 from nextcloud/accessibility-header
Accessibility fixes for header and global elements
2018-07-25 00:07:37 +02:00
Morris Jobke f5e4fcadd9
Merge pull request #10378 from nextcloud/bugfix/noid/fix-icon-name-14
Fix icon file names
2018-07-25 00:05:13 +02:00
Kevin Ndung'u 1cdf808197 Trigger upload actions only for Enter & Space keys
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-07-24 19:02:56 +02:00
Jan-Christoph Borchardt d06e00ffe3 Trigger upload action also with keyboard navigation on enter
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-24 19:02:56 +02:00
Jan-Christoph Borchardt a2ad1b9aa9 Fix ability to open file or folder via keyboard, fix #10008
Before, the file or folder was opened when clicking on the name span,
but not when clicking on the link that contains the name; clicking on
the link highlighted the file and opened the sidebar, just like clicking
on the file size or date. Now clicking on the link opens the file or
folder, so the unit tests that tested clicks on the link were changed to
test clicking on the file size instead.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-24 18:58:35 +02:00
Julius Härtl a66481932d
Add group icon
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:48:25 +02:00
Julius Härtl 1a156c298e
Replace contacts-dark icon with contacts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-24 18:47:54 +02:00
Morris Jobke 9b9d729acf
Merge pull request #10238 from nextcloud/add-support-for-sending-the-password-for-a-share-by-nextcloud-talk
Add support for sending the password for a share by Nextcloud Talk
2018-07-24 17:06:56 +02:00
Daniel Calviño Sánchez b7474ed482
Fix transfering ownership of a share to user with same id as receiver
When the ownership of a user share is transfered to the receiver the
share is removed, as the receiver now owns the original file. However,
due to a missing condition, any share with a group, link or remote with
the same id as the user was removed, not only the user shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 15:05:42 +02:00
Morris Jobke 5cfac8ecea
Merge pull request #10353 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/webpack-4.16.2
Bump webpack from 4.16.0 to 4.16.2 in /apps/updatenotification
2018-07-24 14:34:12 +02:00
Daniel Calviño Sánchez 96108ab858 Add event to load additional scripts in the auth page for public shares
Before the public share authentication page is rendered now an event to
load additional scripts is dispatched. Thanks to this any app can load
its own scripts that, when run on the browser, adjust as needed the page
generated by the server.

Note, however, that during the handling of the event apps are only able
to add scripts or styles to be loaded; they can not render arbitrary
content on the page, or change how the content is rendered by the
original template; all those changes have to be done by the scripts at
run-time.

This implies that the scripts of the apps can use only those parameters,
like the token of the share, added to the page when it is generated by
the "publicshareauth" template. Due to this, and given that the event is
being introduced to be used by Talk to inject the UI needed to request
the password for a share, the token of the share is now provided in the
generated page, just like done in the public share page.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:04:22 +02:00
Daniel Calviño Sánchez 7849630cef Add support for sending the password by Talk to ShareAPIController
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:04:17 +02:00
Daniel Calviño Sánchez d582a66bea Honour "sendPasswordByTalk" property in mail shares
When a password was set for a mail share an e-mail was sent to the
recipient with the password. Now the e-mail is no longer sent if the
password is meant to be sent by Talk.

However, before the e-mail was not sent when the share was updated but
the password was not changed. Now an e-mail is sent in that case too if
switching from a password sent by Talk to a password sent by mail.

On the other hand, when switching from a password sent by mail to a
password sent by Talk it is mandatory to change the password; otherwise
the recipient would already have access to the share without having to
call the sharer to verify her identity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:29 +02:00
Daniel Calviño Sánchez dd0c5e297e Store "sendPasswordByTalk" property of mail shares in the database
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 13:56:28 +02:00
Morris Jobke f7c7ff5f85
Merge pull request #10326 from nextcloud/svg-api-suf-fixes
Fix regex of iconsCacher
2018-07-24 13:36:39 +02:00
John Molakvoæ (skjnldsv) 52af49ead5
Fixed comments design
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:34:03 +02:00
John Molakvoæ (skjnldsv) b7317a35e7
Focus the comment input on tab select/loading
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:34:02 +02:00
John Molakvoæ (skjnldsv) a9e554beec
Fix header controls sticky positioning
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 12:08:31 +02:00
Roeland Jago Douma c8b476c9cd
Rebuild updatenotifications
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-24 11:19:43 +02:00
dependabot[bot] 97c874161d
Bump webpack from 4.16.0 to 4.16.2 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.16.0 to 4.16.2.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.16.0...v4.16.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-24 11:19:21 +02:00
John Molakvoæ (skjnldsv) 84bc30200e
Phpunit tests fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
John Molakvoæ (skjnldsv) 440b5c944f
Fixed scrolling container
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
John Molakvoæ (skjnldsv) 0274507cb1
Acceptance and mobile navigation fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
Morris Jobke 262cb04c3a
Merge pull request #10331 from weeman1337/fix-10330-files-multi-select-header
Adjusts the files multi select header width
2018-07-24 10:48:55 +02:00
Roeland Jago Douma b41d0d32e2
Merge pull request #10218 from nextcloud/share-comments
allow to add a personal note to a share
2018-07-24 09:12:03 +02:00
Nextcloud bot 241e5705cb
[tx-robot] updated from transifex 2018-07-24 00:12:01 +00:00
Morris Jobke 1e431bf6ba
Merge pull request #10338 from nextcloud/dependabot/npm_and_yarn/apps/updatenotification/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/updatenotification
2018-07-23 22:14:34 +02:00
Morris Jobke fa0f98059b
Merge pull request #10342 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/vue-loader-15.2.6
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/oauth2
2018-07-23 22:14:12 +02:00
Morris Jobke 89211d5e9b
Merge pull request #10344 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-cli-3.1.0
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/accessibility
2018-07-23 22:13:52 +02:00
Morris Jobke b91e758baa
Merge pull request #10356 from nextcloud/bugfix/noid/dont-call-getuid-on-null
Don't call getUID on null when the app is loaded for a guest
2018-07-23 22:12:39 +02:00
dependabot[bot] 44811b52b8
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/oauth2
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:19:15 +00:00
dependabot[bot] 7509bd224f
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/updatenotification
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:17:14 +00:00
dependabot[bot] 09373b1f41
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/accessibility
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 19:17:11 +00:00
dependabot[bot] a3fd5cebc0
Bump vue-loader from 15.2.4 to 15.2.6 in /apps/accessibility
Bumps [vue-loader](https://github.com/vuejs/vue-loader) from 15.2.4 to 15.2.6.
- [Release notes](https://github.com/vuejs/vue-loader/releases)
- [Changelog](https://github.com/vuejs/vue-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/vue-loader/compare/v15.2.4...v15.2.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 17:57:14 +00:00
Michael Weimann 9977b1415d Uses a variable for the multiselect header offset
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-23 18:59:00 +02:00
Joas Schilling 3cac54b955
Don't call getUID on null when the app is loaded for a guest
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-23 16:39:03 +02:00
dependabot[bot] eeab309515
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/oauth2
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 14:14:22 +00:00
Roeland Jago Douma 08395b8338
Update map
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-23 15:24:28 +02:00
dependabot[bot] 0119546a3a
Bump webpack-cli from 3.0.8 to 3.1.0 in /apps/updatenotification
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.0.8 to 3.1.0.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-cli/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-23 01:12:53 +00:00
Nextcloud bot 4d060755e5
[tx-robot] updated from transifex 2018-07-23 00:12:05 +00:00
Michael Weimann 353bd8ee8a Adjusts the files multi select header width
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-07-22 11:44:06 +02:00
Nextcloud bot 8ac1f4168d
[tx-robot] updated from transifex 2018-07-22 00:12:42 +00:00
John Molakvoæ (skjnldsv) e6ded2ad5e
Design fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 18:31:06 +02:00
John Molakvoæ (skjnldsv) da0bdd1391 Design structure fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 16:09:13 +02:00
John Molakvoæ (skjnldsv) 58debbe42c
Tests fixes and design bump
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
Bjoern Schiessle 977c462698
move the note up, so that it is also visible in the file drop view
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:21 +02:00
John Molakvoæ (skjnldsv) 3a11c26cb4
Public fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) c71d3dc9bf
Public share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle e951ad5034
fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) 0a7e34f6c8
Popovermenu migration
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle fa44300016
unit tests updated
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
John Molakvoæ (skjnldsv) 4e08d8342e
UI set share note!
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
Bjoern Schiessle 72d2455577
return the as well note if we fetch a share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 660b5d1af6
fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle eab4d96c4c
some small template fixes
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle b81962e3e8
fix unit tests
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:19 +02:00
Bjoern Schiessle 1ce519ad38
add direct link to the share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle a29261175d
fix mail templates
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle 4f59c8e8ae
show note on public link page
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle 73b88deeb8
add note to share object when reading it from the db
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle c116d116fa
improve mail template and escape html code
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
Bjoern Schiessle a93f2a648b
allow to add a personal note to a share
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:18 +02:00
John Molakvoæ (skjnldsv) 89ee10a536
Jsunit fixes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:49 +02:00
John Molakvoæ (skjnldsv) 8d3f58c391
Jsunit fixes 1
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) 43ab2082db
Fixed filestable min-width
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) ecaf4d7008
Fix sidebar close button
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) e27e430f1f
use flex for main content
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
John Molakvoæ (skjnldsv) fe6f444928
Fixed sticky controls
since controls are not directly into the scollable element (app-content)
we need to make the parent the scrollable element (app-content-files)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
John Molakvoæ (skjnldsv) d6b718584e
Sidebar fix
Fix sidebar and scrollbar on content
Sidebar fixes, and sidebar-width + header-height variables

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
John Molakvoæ (skjnldsv) 842583038b
Cleanup structure
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:35:21 +02:00
Jan-Christoph Borchardt e9581f2126
Make Upload entry in +Menu focusable
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
Roeland Jago Douma a2df728fb8
Merge pull request #9581 from nextcloud/dav-acl-no-files
disable dav acl plugin for files resource
2018-07-20 12:16:45 +02:00
Nextcloud bot a927d2fc08
[tx-robot] updated from transifex 2018-07-20 00:12:09 +00:00