830a4348f9
Merge pull request #23087 from nextcloud/backport/23013/stable19
...
[stable19] Show federation and email results also with exact user match unless c…
2020-10-01 09:01:25 +02:00
12abb5d2d3
Merge pull request #23090 from nextcloud/backport/23074/stable19
...
[stable19] Do not match sharees on an empty email address
2020-10-01 09:01:08 +02:00
99e5940a7f
[tx-robot] updated from transifex
2020-10-01 02:18:43 +00:00
4fec3d09a0
Generate exception to log on php errors
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-29 08:17:23 +00:00
1c65d33e9f
Do not match sharees on an empty email address
...
When asking for sharees we compare not only UID and displayname but also
the email address. And if that matches we return the sharee as an exact
match. This logic had a flaw as in that it also matched the empty string
to users with no email address.
This is most noticeable when you disable sharee enumeration and open the
ownership transfer dialog. It suggested other users of the instance
before. This has stopped now.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-29 07:31:46 +00:00
679aa21075
Show federation and email results also with exact user match unless containing @
...
Before when you have a user "smith" and a federated user "smith@example.com"
you could see the federation result with "smit" but not with "smith" anymore.
With most LDAP configurations and local backend setups this is disturbing and
causes issues.
The idea of not showing the email and federation on a matching user was with:
Local user registered with "smith@example.com" user id and having that same
email / cloud id in your contacts addressbook. So we now only hide those
"side results" when the search does contain an @
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:19:18 +00:00
164096aa26
Merge pull request #22804 from nextcloud/backport/stable19/22116-22648-22761
...
[stable19] Fix share transfer of single files and on the transfered node
2020-09-28 19:15:12 +02:00
ed22e1bf3b
Merge pull request #22904 from nextcloud/backport/22636/stable19
...
[stable19] Make sure that getConfig is still called for browsers that do not support CSPv3
2020-09-28 19:14:00 +02:00
1681e74d2d
[tx-robot] updated from transifex
2020-09-20 02:17:17 +00:00
c8f9fa1830
[tx-robot] updated from transifex
2020-09-18 19:05:38 +00:00
14c3f1ebd8
Transfer shares of the transferred root node
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 19:03:07 +02:00
9b33e3caee
Make sure that getConfig is still called for browsers that do not support CSPv3
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-17 10:18:30 +02:00
bd24021efc
fix: file quota was not applied in all cases
2020-09-17 07:13:18 +00:00
8c2c8fd831
[tx-robot] updated from transifex
2020-09-17 02:27:15 +00:00
871d9a614e
[tx-robot] updated from transifex
2020-09-15 10:48:39 +00:00
9e88559e94
Merge pull request #22775 from nextcloud/fix/noid/stable19-ldap-group-update-events
...
[stable19] makes LDAP's group updater dispatch type events
2020-09-11 08:45:49 +02:00
7a4a0dca22
Use user mount with matching shared storage only
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 14:20:59 +00:00
51fa743c7a
makes LDAP's group updater dispatch type events
...
* fixes group share updates on added users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-10 15:18:47 +02:00
407fb28cb6
Annotate that writeStream can throw a GenericFileException
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 13:18:11 +00:00
24b69b2402
Fix reading empty files from objectstorage
...
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-09 19:47:23 +00:00
b6c04b35c8
Merge pull request #22742 from nextcloud/backport/22589/stable19
...
[stable19] Allow additional personal settings via normal registration
2020-09-09 15:32:08 +02:00
968a756067
Merge pull request #22745 from nextcloud/backport/22646/stable19
...
[stable19] Fix detecting text/x-php mimetype and secure mimetype mapping
2020-09-09 15:31:46 +02:00
554fab45aa
Properly add both mimetypes to secure mimetype mapping
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-09 12:17:26 +00:00
9e9ed6c251
Allow additional personal settings via normal registration
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-09 11:25:40 +00:00
1031170f35
Warn about adding NotNull columns with nullable default
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-07 18:57:56 +00:00
c3a6f50206
[tx-robot] updated from transifex
2020-09-07 02:16:49 +00:00
55bad53353
[tx-robot] updated from transifex
2020-09-06 02:17:02 +00:00
dc60a81284
Merge pull request #22515 from nextcloud/backport/22472/stable19
...
[stable19] Fix writing BLOBs to postgres with recent contacts interaction
2020-09-04 12:38:16 +02:00
c1b971ec63
Merge pull request #22579 from nextcloud/backport/22550/stable19
...
[stable19] Use the correct root to determinate the webroot for the resource
2020-09-04 12:35:21 +02:00
757a35bd01
Merge pull request #22442 from nextcloud/backport/22421/stable19
...
[stable19] show better quota warning for group folders and external storage
2020-09-04 12:34:15 +02:00
6117a82ae3
Merge pull request #22569 from nextcloud/backport/22524/stable19
...
[stable19] Fix app password updating out of bounds
2020-09-04 09:04:15 +02:00
fc0cdbb4a0
Use the correct root to determinate the webroot for the resource
...
Since all the compiled routes are based on the server webroot,
we have to use this, independent from which app this belongs to.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-04 07:01:26 +00:00
4c7db572fd
[tx-robot] updated from transifex
2020-09-04 02:17:28 +00:00
ebd2b0d3dd
Fix app password updating out of bounds
...
When your password changes out of bounds your Nextcloud tokens will
become invalid. There is no real way around that. However we should make
sure that if you successfully log in again your passwords are all
updates
* Added event listener to the PostLoggedInEvent so that we can act on it
- Only if it is not a token login
* Make sure that we actually reset the invalid state when we update a
token. Else it keeps being marked invalid and thus not used.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-03 20:03:47 +00:00
2b4bc5b6df
Only disable zip64 if the size is known
...
Else we might run into the issue that for an external storage where the
size is not known yet we do not use zip64. Which then of course fails on
large zip files.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-01 13:42:49 +00:00
568f68856f
Merge pull request #22519 from nextcloud/backport/22517/stable19
...
[stable19] set the mount id before calling storage wrapper
2020-08-31 21:51:59 +02:00
952ec3370e
Only update the filecache entry once the file has been written to S3
...
If we already update before we have no way to revert if the upload
fails.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-31 17:08:27 +00:00
704f515175
Don't lose filecache entry on s3 overwrite error
...
If the object store errors we should not always delete the filecache
entry. As this might lead to people losing access to their files.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-31 17:08:27 +00:00
fc8c5965fa
set the mount id before calling storage wrapper
...
this allows the storage wrapper to use the mount id for it's own logic
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-31 15:23:13 +00:00
7ada6e5ab0
Fix writing BLOBs to postgres with recent contacts interaction
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-31 13:09:40 +00:00
fba73a5c39
[tx-robot] updated from transifex
2020-08-28 02:16:32 +00:00
1d25b9972f
Remove @package annotations from public namespace
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 09:16:52 +02:00
6ae83a72cd
Remove wrongly annotated package names
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 09:16:52 +02:00
348525426c
[tx-robot] updated from transifex
2020-08-27 02:16:52 +00:00
4025b95e03
show better quota warning for group folders and external storage
...
instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-26 19:17:43 +00:00
c9a1379bdf
Merge pull request #22410 from nextcloud/backport/22359/stable19
...
[stable19] fix possible leaking scope in Flow
2020-08-26 20:22:37 +02:00
d3efe74f12
[tx-robot] updated from transifex
2020-08-26 02:16:39 +00:00
f8417cca0f
adjust since for 19
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 13:05:15 +02:00
7f6e2c5953
fix possible leaking scope in Flow
...
- a configured flow can be brought into consideration, despite its event
was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 08:42:24 +00:00
d8c958907f
Make legacy cipher opt in
...
* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-24 11:50:04 +02:00
9aac6d9251
Merge pull request #22355 from nextcloud/backport/20772/stable19
...
[stable19] Properly search for users when limittogroups is enabled
2020-08-24 09:12:13 +02:00
0ed1d67c7f
[tx-robot] updated from transifex
2020-08-23 02:16:53 +00:00
556440471a
Properly search for users when limittogroups is enabled
...
Searching just for the uid is not enough.
This makes sure this done properly again now.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-21 11:23:15 +00:00
db324278b5
[tx-robot] updated from transifex
2020-08-20 02:17:50 +00:00
d7aa1c00ed
Merge pull request #21983 from nextcloud/backport/21628/stable19
...
[stable19] fix moving files from external storage to object store trashbin
2020-08-19 21:29:01 +02:00
16021c93ed
Allow to disable share emails
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-19 11:04:29 +02:00
fd9ebeefa2
[tx-robot] updated from transifex
2020-08-19 02:17:21 +00:00
6bcb656c5d
[tx-robot] updated from transifex
2020-08-18 02:17:38 +00:00
6bdafb1aa9
[tx-robot] updated from transifex
2020-08-17 02:16:48 +00:00
a6760c2b1c
Silence duplicate session warnings
...
Fixes #20490
Basically restroring the old behavior.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-14 07:24:53 +00:00
10ee9791ff
Merge pull request #21975 from nextcloud/backport/21658/stable19
...
[stable19] allow admin to configure the max trashbin size
2020-08-14 05:58:57 +02:00
92d0f5e7a3
Merge pull request #22121 from nextcloud/backport/22008/stable19
...
[stable19] Ensured large image is unloaded from memory when generating previews
2020-08-13 05:23:01 +02:00
fe8ea5390f
Merge pull request #22208 from nextcloud/backport/21676/stable19
...
[stable19] Fix chmod on file descriptor
2020-08-13 05:17:13 +02:00
baa64827d3
Merge pull request #22209 from nextcloud/backport/21677/stable19
...
[stable19] Do clearstatcache() on rmdir
2020-08-13 05:07:36 +02:00
6327b8a6fb
[tx-robot] updated from transifex
2020-08-13 02:16:48 +00:00
659fb3cf06
[tx-robot] updated from transifex
2020-08-12 02:16:59 +00:00
be73fd90fc
Only clear the realpath cache
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:33 +00:00
6f72871ca5
clearstatcache() on rmdir
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:32 +00:00
9b028a619a
Fix chmod on file descriptor
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:10 +00:00
9aff51eb52
Use class that actually has the destroy() method in preview generator
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 20:41:25 +00:00
66bb6fdbb0
fix memory leak caused by not destroying image in Preview/Generate.php
...
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
2020-08-05 20:41:25 +00:00
74e98940ef
Search also the email and displayname in user mangement for groups
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:11:41 +00:00
dc98aaa224
contactsmanager shall limit number of results early
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-03 13:18:14 +00:00
4e6719b28c
dont update mimetype when moving to trash
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-31 17:21:02 +02:00
e2fa284bd9
Merge pull request #22053 from nextcloud/backport/22015/stable19
...
[stable19] Correctly remove usergroup shares on removing group members
2020-07-31 15:31:33 +02:00
29d41ba061
Use old IServerContainer methods
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 10:03:59 +02:00
c69a709f21
Correctly remove usergroup shares on removing group members
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-30 07:51:10 +00:00
cf0bdfd8c1
parse_url returns null in case a parameter is not found
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-29 16:13:32 +00:00
73132b56d4
[tx-robot] updated from transifex
2020-07-29 02:17:02 +00:00
4ceda884ac
[tx-robot] updated from transifex
2020-07-27 02:16:42 +00:00
46715762ce
[tx-robot] updated from transifex
2020-07-25 02:16:45 +00:00
288ca45938
Ignore whitespace in sharing by mail
...
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
2020-07-24 11:43:24 +00:00
a05efb5217
[tx-robot] updated from transifex
2020-07-24 02:17:02 +00:00
142b6eb08f
fix renameFromStorage messing with folder mimetype
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
7ac4d57fd5
use exceptions for error signaling in writeStream
...
this remove the ambiguity when writing zero length files
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
c567b1d6b2
fix moving files from external storage to object store trashbin
...
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.
By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:22 +00:00
38db847164
allow admin to configure the max trashbin size
...
this allows an admin to configure the max trashbin size instead of always relying on the users quota.
The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 14:30:07 +00:00
7246ffff9b
[tx-robot] updated from transifex
2020-07-23 02:17:13 +00:00
45108b087e
Discourage webauthn user interaction
...
Else people might have the feeling this is also doing 2FA. And since it
is only prefered it can be ignored and hacked around.
Once we have proper 2FA with webauthn in one go this probably needs to
be revisted.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-20 07:31:37 +00:00
ec69ab4ed4
[tx-robot] updated from transifex
2020-07-19 02:17:16 +00:00
95093e4f27
[tx-robot] updated from transifex
2020-07-17 02:17:21 +00:00
1822eec68f
[tx-robot] updated from transifex
2020-07-16 02:19:41 +00:00
6c8cc35b28
[tx-robot] updated from transifex
2020-07-10 02:17:02 +00:00
b3c9b166a3
Merge pull request #21779 from nextcloud/backport/21499/stable19
...
[stable19] fix #21285 as oneliner
2020-07-09 19:27:21 +02:00
2f75ba1adb
Return correct loginname in credentials,
...
even when token is invalid or has no password.
Returning the uid as loginname is wrong, and leads to problems when
these differ. E.g. the getapppassword API was creating app token with
the uid as loginname. In a scenario with external authentication (such
as LDAP), these tokens were then invalidated next time their underlying
password was checked, and systematically ceased to function.
Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-07-09 14:37:05 +00:00
157f619812
ensure home storage is initialized on first setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 12:33:20 +00:00
f174fb91e0
Use the correct mountpoint to calculate
...
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 12:33:19 +00:00
b19525ebbc
[tx-robot] updated from transifex
2020-07-09 02:17:46 +00:00
667ca8dcb0
[tx-robot] updated from transifex
2020-07-08 02:17:07 +00:00
392df2eaf4
Fix releasing a shared lock multiple times
...
Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
2020-07-06 12:11:46 +00:00
Roeland Jago Douma
Nextcloud bot
Julius Härtl
Christoph Wurst
Joas Schilling
korelstar
Arthur Schiwon
Roeland Jago Douma
Morris Jobke
Robin Appelman
J0WI
Elijah Martin-Merrill
Joas Schilling
onehappycat
Lionel Elie Mamane
Jaakko Salo