3811a5ebad
Respect default share permissions
...
Else we'll always create new shares with the max permissions.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 08:55:55 +00:00
87be93126f
Fix share permission checkboxes enabled when permissions can not be set
...
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).
Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-29 20:16:03 +00:00
009432dee0
Pass the proper share permissions to the create share call
...
Fixes #21188
This way we do not run into the share permission issue
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-10 08:55:37 +00:00
01ccbe68ff
Restore previous state when failing to change video verification state
...
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-03 14:08:17 +00:00
c423a50938
Fix the Talk verification
...
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).
When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.
We'll have to backport to 18.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 13:51:42 +00:00
90a65f83e0
Do not process the same FileInfo twice
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
a26ca1e638
Do not filter id matching userId on non-user-share shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
edecd0931e
Fix filtering our owner & current user from shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
ff20da637e
Fix federated link sharing permissions
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
8dd23f9854
Fix expiry datepicker allowing all dates
...
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.
This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
31172a0cd9
Process shares only once, better debug and expiration date code
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
02b5ded840
Fix share expiration date not shown
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
d466a7b808
Allow to navigate to others with access from the sidebar
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
7eceba7dae
Fix Sharing recommendation user display
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-21 07:48:10 +00:00
47146a1992
Properly display share error messages
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-14 08:39:40 +00:00
a50698b3c3
Changing the translation catalog for "Share"
...
Change "files" to "files_sharing".
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-12 02:20:14 +00:00
e57f619e1e
Merge pull request #19763 from nextcloud/bugfix/noid/received-share-sidebar-broken
...
Fix "Error loading the shares list TypeError: "this is undefined"" fo…
2020-03-06 16:43:20 +01:00
275df5d233
Fix "Error loading the shares list TypeError: "this is undefined"" for conversation shares
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-03 20:22:39 +01:00
d612aeec2d
Fix regex to not take email uids as federated ids
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-03 18:19:46 +01:00
699cbeb2fc
Show the link password when it's set
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-02-23 12:38:28 +00:00
c47a0a0153
Add more tests for the new js modules
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-02-10 12:05:43 +01:00
60f49efe8a
Give the sharing tab a unique id so it also opens properly on other languages
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-29 16:44:52 +01:00
05742c083c
Migrate to @nextcloud/vue 1.x.x
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-22 17:33:49 +01:00
eb4c42d3d1
Make auto accepting the default and provide setting to enforce the share acceptance process
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-16 22:07:51 +01:00
9a0fa63a5c
Do not save on update, use submit
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-01-16 00:00:19 +01:00
aa9878e867
Only allow navigation to a folder if you have access
...
Fixes #18716
If you can delete the share then you have access yourself to that shares
location.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-15 07:40:41 +01:00
897111404a
Add "Password protected by Talk" option to shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-01-14 17:15:02 +01:00
3e43ae7bd6
Add placeholder
...
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-01-10 14:50:24 +00:00
8eded83d50
Fix sharing note placeholder
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-10 14:50:23 +00:00
d99bcf1f8b
Only show others with access if you have reshare permissions
...
Fixes #18711
If you do not have reshare permissions the others with access will throw
an error anyways. So better to just not show it ;)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-07 16:15:40 +01:00
1fc39196bf
Show message if no other users with access are found
...
Fixes #18632
Show a small subtitle if no other users with access are found.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 21:45:38 +01:00
d4ce8c9427
Don't show link shares in sidebar if disabled
...
Fixes #17799
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 12:23:06 +01:00
9a8b361911
Do not show e-mail suggestions if link shares are disabled
...
For #17774
This removes the e-mail suggestions from the share input if link shares
are disabled. As e-mail shares use just link shares.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 10:22:22 +01:00
272aa9231c
Fix style of the sharing setting checkbox
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-02 09:44:32 +01:00
ab50fee1e5
Change icon-delete to icon-close in others locations
...
Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr>
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-12-26 21:17:50 +08:00
d8ba5e5d57
Clarify "Delete share" action in sharing sidebar
...
- change "Delete share" to "Unshare"
- change icon-delete to icon-close
Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr>
2019-12-25 08:51:19 +00:00
455013c309
fix the folder share
...
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-19 16:14:47 +01:00
57997fefa2
add create and delete checkbox for sharesidebar
...
Signed-off-by: Greta Doci <gretadoci@gmail.com>
2019-12-19 16:12:11 +01:00
ec01e0a790
Bump eslint-config-nextcloud from 0.0.6 to 0.1.0
...
Bumps [eslint-config-nextcloud](https://github.com/nextcloud/eslint-config-nextcloud ) from 0.0.6 to 0.1.0.
- [Release notes](https://github.com/nextcloud/eslint-config-nextcloud/releases )
- [Commits](https://github.com/nextcloud/eslint-config-nextcloud/compare/v0.0.6...v0.1.0 )
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-19 11:55:33 +01:00
8cd86f110b
Wiswedel/inherited shares/design polishing ( #18447 )
...
Wiswedel/inherited shares/design polishing
2019-12-19 08:45:16 +01:00
f4f69da4b8
removed inherited shares counter
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-17 13:47:10 +00:00
4d1a3a34d0
clarifying share source folder link string
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-17 14:38:38 +01:00
73b1011d17
Streamline "unshare" wording
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-17 14:36:23 +01:00
08b34aa4e3
replace "invited by" with "added by"
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-17 14:34:27 +01:00
c810b531be
Don't overwrite the settings from files
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-17 14:17:07 +01:00
e7dc91002f
Allow users to specify to accept (internal) shares by default
...
Fixes #18255
A new user setting allows a user to always accept (internal) shares. For
example if they don't like accepting shares manually ;)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-17 10:49:29 +01:00
f8a36630e7
Cleanup old log and fix share icon sidebar opening in breadcrumbs
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-16 12:08:26 +01:00
9b82225966
Use lookup by default
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-05 08:38:33 +01:00
46ce797197
Properly query files
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-04 09:57:55 +01:00
cd71ad0e50
Merge pull request #17930 from nextcloud/rakekniven-patch-1
...
l10n: Triple dot to ellipsis
2019-12-03 15:40:03 +01:00
Roeland Jago Douma
Daniel Calviño Sánchez
Christoph Wurst
John Molakvoæ (skjnldsv)
Gary Kim
Valdnet
Joas Schilling
Joas Schilling
Julius Härtl
John Molakvoæ
Alexandre Guiot--Valentin
GretaD
dependabot-preview[bot]
Sascha Wiswedel