c3f1eb4f7f
Remove Redundantcasts
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:44:04 +01:00
b14be34689
Type Entry and IEntry
...
* Fixed a docblock
* Typed the entries
Psalm happier, Roeland happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:30:21 +01:00
76a6328d10
Add executeQuery and executeUpdate
...
Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.
This should make static analysis a bit more happy. Which in turn makes
me more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:03:31 +01:00
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +01:00
365d31743f
[tx-robot] updated from transifex
2021-03-04 02:22:10 +00:00
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
...
Remove deprecated \OCP\API
2021-03-03 21:57:34 +01:00
a58b4ceaab
Merge pull request #25889 from nextcloud/techdept/psalm/fix_group_manager_function_return_type
...
Fix types in the Group Manager
2021-03-03 20:55:52 +01:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
68ec18323d
Fix types in the Group Manager
...
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
a6246be34c
Merge pull request #25656 from nextcloud/enh/type/expressionbuilder
...
Type the experssionbuilders
2021-03-03 11:37:16 +01:00
11858a3d66
Merge pull request #25816 from nextcloud/iquerybuilder-join-conditions
...
allow non string join conditions in query builder
2021-03-03 11:34:56 +01:00
74f36173bc
Merge pull request #25882 from nextcloud/bug/25748/filter-other-tables
...
Filter out tables that does not belong to Nextcloud
2021-03-03 11:24:47 +01:00
4bdf9f5849
Type the experssionbuilders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 10:44:09 +01:00
47dd8e54b5
allow non string join conditions in query builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-03 10:43:15 +01:00
e11be3b693
[tx-robot] updated from transifex
2021-03-03 02:21:24 +00:00
bc91eb7c64
Filter tables with other table prefix
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-03-02 21:09:33 +01:00
1531414e8d
Fix docblock return type for IShareProvider
...
All the implementations already returned an array of array of shares. So
better to make sure the docblock also doesn't lie.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:12:46 +01:00
19e2136963
Update autoloader files
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
3d62233cab
Merge pull request #25869 from nextcloud/fix/imanager-namespacing
...
Fix namespacing
2021-03-02 11:05:14 +01:00
1a724cb57f
Merge pull request #25758 from nextcloud/enh/include_RichObject_forms
...
Include RichObject for forms
2021-03-02 10:56:40 +01:00
f9083ef7bf
Fix namespacing
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-03-02 09:37:34 +01:00
7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
...
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
63f68e0412
[tx-robot] updated from transifex
2021-03-02 02:22:18 +00:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +01:00
f02362e029
Include RichObject for forms
...
Ref. https://github.com/nextcloud/forms/pull/789
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
2021-03-01 14:00:33 +01:00
91f260fe29
Merge pull request #25804 from nextcloud/bugfix/noid/fread-0
...
Do not attempt to read 0 bytes when manually iterating over a non-seekable file
2021-03-01 09:54:33 +01:00
24d5afb1b1
[tx-robot] updated from transifex
2021-02-28 02:19:54 +00:00
19eb48b8a3
Properly end iterating over the file once the target has been reached
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-26 11:29:01 +01:00
b4ccadea2b
[tx-robot] updated from transifex
2021-02-26 02:21:45 +00:00
ce082dd49b
Merge pull request #25786 from nextcloud/fix/register-aliases-params-once
...
Register service aliases und parameters just once
2021-02-25 09:47:27 +01:00
c8f7a808fd
[tx-robot] updated from transifex
2021-02-25 02:21:21 +00:00
6a9b693540
Register service aliases und parameters just once
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-24 17:30:10 +01:00
b89fbaf52d
[tx-robot] updated from transifex
2021-02-24 02:22:06 +00:00
ff54a0481b
[tx-robot] updated from transifex
2021-02-23 02:39:25 +00:00
e5a0219133
Merge pull request #25680 from nextcloud/taint-expressionbuilder
...
Add expression taint source and sanitizer
2021-02-22 12:26:48 +01:00
3ff92423e2
[tx-robot] updated from transifex
2021-02-21 02:39:59 +00:00
f99f463834
token login: emit preLogin event with LoginName
...
to bring it in line with normal (non-token) login.
Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
2021-02-19 22:27:46 +01:00
c222bac9ed
[tx-robot] updated from transifex
2021-02-19 02:20:56 +00:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
d79cc8ea6d
Merge pull request #25706 from nextcloud/bugfix/noid/when-it-kicks-in
...
When coding style kicks in
2021-02-18 11:30:06 +01:00
1de3b8b0ec
When it kicks in
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-18 10:14:12 +01:00
5f194dad24
[tx-robot] updated from transifex
2021-02-18 02:21:54 +00:00
82f4bb0eba
Merge pull request #25700 from nextcloud/fix/zipresponse-initialize-array
...
Initialize \OCP\AppFramework\Http\ZipResponse::$resources
2021-02-17 22:26:06 +01:00
d7590a6190
Add expression taint source and sanitizer
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-17 21:38:15 +01:00
08d4458542
Initialize \OCP\AppFramework\Http\ZipResponse::$resources
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-17 19:59:27 +01:00
9d96b0b7fb
bump applicable version due to an intermediate release
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:37:45 +01:00
644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
...
Cache the user backend info for 5mins
2021-02-17 08:56:55 +01:00
f0c8f7421f
Merge pull request #25678 from nextcloud/drop/defaults-logo-claim
...
Drop \OCP\Defaults::getLogoClaim
2021-02-16 16:14:04 +01:00
24e035dfc8
Drop \OCP\Defaults::getLogoClaim
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-16 11:46:06 +01:00
0c5adaddf8
Drop \OC\Memcache\Factory::create
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-16 11:43:05 +01:00
2ea3cb7c93
Drop redundant indes
...
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
0363af3790
move AbstractCacheEvent into OCP
...
otherwise we have concrete cache events in OCP extending non OCP classes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-15 19:12:30 +01:00
19f1cc6dde
Merge pull request #25646 from nextcloud/fix/psalm/markdown
...
Markdown: remove redundant int cast
2021-02-15 12:04:21 +01:00
645f83121e
Cache the user backend info for 300s
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +01:00
4d7c4b3d2f
Markdown: remove redundant int cast
...
For #25641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:29:54 +01:00
11a9bd3e19
Some OCS result psalm fixes
...
For #25641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:03:48 +01:00
24d4c3eeab
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop
...
Make the app code checker a NOOP
2021-02-13 15:51:41 +01:00
69f0d7d5d4
[tx-robot] updated from transifex
2021-02-13 02:20:27 +00:00
361f160d0d
[tx-robot] updated from transifex
2021-02-12 02:20:18 +00:00
37199c1da0
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation
...
Micro-optimize validation of empty email addresses
2021-02-11 19:51:06 +01:00
d45692ee96
Migrate custom loggers to PSR
...
This will help phase out the deprecated ILogger interface.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 16:16:34 +01:00
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +01:00
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +01:00
cc554890c1
Fix WebP availability check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-11 11:31:38 +01:00
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +01:00
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
1cc23c6e6e
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
...
Deprecate the GenericEvent wrapper
2021-02-10 18:57:07 +01:00
847ee4041a
Merge pull request #25566 from nextcloud/fix/25359/followup
...
Fix remaining #25359
2021-02-10 18:02:24 +01:00
039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
...
Make our event base class independent of Symfony and follow PSR
2021-02-10 16:13:06 +01:00
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +01:00
0a28440bf6
Make our event base class independent of Symfony and follow PSR
...
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 15:15:29 +01:00
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
f76ec25e58
Deprecate the GenericEvent wrapper
...
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 08:54:08 +01:00
decb70b9ac
[tx-robot] updated from transifex
2021-02-10 02:20:59 +00:00
3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
...
Deprecate all remaining event constants
2021-02-09 20:19:04 +01:00
f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
...
Deprecate the internal IDBConnection event name constants
2021-02-09 18:50:55 +01:00
f8808e260d
Move app_password_created to a typed event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +01:00
111fa47f10
remove ReconnectWrapper
...
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
...
Fix the legacy dispatcher argument order
2021-02-09 14:39:12 +01:00
4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
...
Improve exception when auto-wiring fails
2021-02-09 14:27:43 +01:00
4fc0b2c639
Deprecate all remaining event constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 13:53:41 +01:00
ec875227ec
forward query exception when fallback construction fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
3d075c370a
Deprecate the internal IDBConnection event name constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 11:27:59 +01:00
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
9eea1e56dc
[tx-robot] updated from transifex
2021-02-09 02:20:45 +00:00
3401be216d
forward original query exception when querying by name fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
26a20ed13f
[tx-robot] updated from transifex
2021-02-08 02:20:05 +00:00
f19287ae57
[tx-robot] updated from transifex
2021-02-07 02:20:51 +00:00
98032425b4
Fix linter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
ef7ed47f14
Make Psalm happy
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
1344c61145
Improve mention matches
...
The previous regex didn't correctly match users with . ' or -
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:05 +01:00
cd77b1f238
Merge pull request #25499 from nextcloud/test/symfony-adapter
...
Test the symfony adapter / fix missing return object
2021-02-06 13:01:23 +01:00
8bb6bb53ad
[tx-robot] updated from transifex
2021-02-06 02:20:50 +00:00
6e461248e0
Merge pull request #25500 from Worteks/fix-sharemanager-genericshareexception
...
fix(translation): replace static error message
2021-02-05 16:17:34 +01:00
3a077a3903
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 13:27:37 +01:00
5f8dfa8e4c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:52:59 +01:00
f6ddda8dad
Test the symfony adapter
...
To prevent regression in the future.
And make sure we always return an object …
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +01:00
59e43b4828
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:06:35 +01:00
Roeland Jago Douma
Nextcloud bot
Roeland Jago Douma
Joas Schilling
Robin Appelman
Daniel Kesselberg
Anna Larch
Christoph Wurst
Johannes Leuker
Jonas Rittershofer
Julius Härtl
Christoph Wurst
Lukas Reschke
Lionel Elie Mamane
dependabot-preview[bot]
Joas Schilling
Arthur Schiwon
Samuel