dc175d4ecc
Fix typo in variable name and make check more accurate
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:48:38 +02:00
e2100856ad
Add another test for exact matching of a user in group restriction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:06:50 +02:00
cdcd61d4c8
Use empty for the OCP @since checker
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-09 08:49:24 +02:00
b192c04dc2
Add integration tests for video verification
...
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.
When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +02:00
a2f80d4f4c
Add integration tests for creating and updating a mail share
...
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.
To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.
In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.
For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +02:00
7817f8578b
Generalize integration test steps to download last share
...
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
6e49d3bb94
Remove unused variables
...
The step names were adjusted accordingly.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
bd0a1b6e7d
Merge pull request #20586 from nextcloud/techdebt/noid/make-image-optimization.sh-better-readable
...
Improve build/image-optimization.sh
2020-05-21 09:48:55 +02:00
108faf25c0
Update public link share permission code
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +02:00
c84a82bc0c
Bump node-sass from 4.14.0 to 4.14.1 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.14.0...v4.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 01:16:27 +00:00
d9e5925201
Merge pull request #20655 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.14.0
...
Bump node-sass from 4.13.0 to 4.14.0 in /build
2020-04-29 16:15:04 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
b836bcf040
Bump node-sass from 4.13.0 to 4.14.0 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.13.0...v4.14.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-29 08:27:58 +00:00
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
...
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
7a9469f282
Adjust integration tests to new permissions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 16:22:48 +02:00
3fc66a65f8
Revert "Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.3 in /build/integration"
2020-04-22 16:40:11 +02:00
e9f0a388d9
Allow to specify a directory and skip node_modules and tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:50:26 +02:00
e49b6c576d
Don't error when the directory is broken
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:33:11 +02:00
f354a4f17f
FIx glob usage to avoid problems with directories that contain spaces
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:32:11 +02:00
4651ff5a50
Make the script better readable
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:30:53 +02:00
792c520774
Revert "Bump karma-coverage from 2.0.1 to 2.0.2 in /build"
2020-04-19 11:21:48 +02:00
a95d6463b4
Bump karma-coverage from 2.0.1 to 2.0.2 in /build
...
Bumps [karma-coverage](https://github.com/karma-runner/karma-coverage ) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/karma-runner/karma-coverage/releases )
- [Changelog](https://github.com/karma-runner/karma-coverage/blob/master/CHANGELOG.md )
- [Commits](https://github.com/karma-runner/karma-coverage/compare/v2.0.1...v2.0.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:43 +00:00
e650c6366f
Update guzzlehttp/guzzle requirement in /build/integration
...
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.3/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.2...6.5.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:23 +00:00
8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1
...
do not use deprecated API for LDAP paged results
2020-04-15 15:02:51 +02:00
4e846dda4d
Allow local remotes in integration tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:24:18 +02:00
84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
...
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +02:00
0ccaec9841
Fix jsunit tests
...
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 11:55:12 +02:00
7440868acd
Fix app not listed in provisioning integration test
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-04-13 15:07:59 +02:00
e1f8666f84
Bump jsdoc from 3.6.3 to 3.6.4 in /build
...
Bumps [jsdoc](https://github.com/jsdoc/jsdoc ) from 3.6.3 to 3.6.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases )
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.4/CHANGES.md )
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.3...3.6.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-12 01:13:41 +00:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
bcd13296de
Make sure every file ends with an empty newline
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
bbba7bc45a
Merge pull request #20321 from nextcloud/enh/noid/check-translation-for-triple-dot
...
Check for triple dots in translations in CI
2020-04-08 20:10:05 +02:00
283b8a5e74
Check for triple dots in translations in CI
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-07 12:06:40 +08:00
d7eac53ee1
Bump handlebars from 4.7.3 to 4.7.6 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.7.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-05 10:57:12 +00:00
dbdd30d4d4
Merge pull request #20216 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.6
...
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
2020-04-03 08:51:27 +02:00
32577f2f57
Merge pull request #20209 from nextcloud/techdebt/php-cs-config
...
Add a shared php coding style fixer config
2020-04-01 13:25:16 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
3eac89d448
Add shared php-cs config
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 13:45:10 +02:00
aaaabd1678
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
...
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport ) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases )
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG )
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.5...1.0.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-29 01:13:34 +00:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
97949109ef
Merge pull request #19368 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.3
...
Bump handlebars from 4.5.3 to 4.7.3 in /build
2020-03-24 21:47:36 +01:00
ec63327472
Force compatible EventDispatcher version in integration tests
...
Nextcloud requires EventDispatcher from Symfony 4.4. Behat required
Symfony 4.x until Behat 3.5, but since Behat 3.6 it supports Symfony 5.x
too. However, as the EventDispatcher version was not restricted in the
"composer.json" file Composer installed the latest compatible version
with all the dependencies, which happened to be Symfony 5.x. To prevent
that now the EventDispatcher is explicitly limited to Symfony 4.4 only.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-12 10:45:23 +01:00
d3d6d8de3a
Bump handlebars from 4.5.3 to 4.7.3 in /build
...
Bumps [handlebars](https://github.com/wycats/handlebars.js ) from 4.5.3 to 4.7.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases )
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md )
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.3...v4.7.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-10 19:14:40 +00:00
Joas Schilling
Christoph Wurst
Daniel Calviño Sánchez
Roeland Jago Douma
Roeland Jago Douma
dependabot-preview[bot]
Morris Jobke
Julius Härtl
blizzz
Daniel Kesselberg
Joas Schilling
Gary Kim
Christoph Wurst