Commit Graph

42087 Commits

Author SHA1 Message Date
Roeland Jago Douma de5d7aa331
Strict ISecure random
* Declare strict
* Scalar arguments
* Return type
* Use fully qualified name for strlen

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 21:39:34 +01:00
Roeland Jago Douma c14af47fd9
Bump version number
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 20:16:38 +01:00
Roeland Jago Douma 758cb4d008
Make the capabilities manager strict
* Add return types
* Add scalar type hints
* Use [] instead of array_push (PHPStromg inspection recommendation)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:53:31 +01:00
Roeland Jago Douma 5ca0ad4f67
Remove deprecated constants
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:46:19 +01:00
Roeland Jago Douma dffa922c0b
Remove deprecated functions for OCP\Util
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:41:34 +01:00
Roeland Jago Douma 704133d732
Remove deprecated functions from DI Container
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:29:52 +01:00
Roeland Jago Douma 21a720e026
Removed deprecated search function from ISearch
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:27:25 +01:00
Roeland Jago Douma 60f38d37fe
Merge pull request #7825 from nextcloud/add-type-hinting-for-ICrypto-decrypt
Adds type hinting for scalar types in ICrypto->decrypt
2018-01-13 15:11:16 +01:00
Roeland Jago Douma 647ce91395
Update autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:31:07 +01:00
Roeland Jago Douma 8a41d05761
Remove deprecated \OCP\Config
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:25:04 +01:00
Roeland Jago Douma 8d1dd1945f
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 13:58:06 +01:00
Morris Jobke 1faef0c459
Merge pull request #7832 from nextcloud/update-composer
Update composer
2018-01-13 00:45:00 +01:00
Morris Jobke ca28df6fcc
Adds type hinting for scalar types in ICrypto->decrypt
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-13 00:06:03 +01:00
Morris Jobke 16f4d71efd
Merge pull request #7824 from nextcloud/fix-type-in-CryptoSessionData
Fix type in CryptoSessionData
2018-01-13 00:01:52 +01:00
Morris Jobke 24bc8c44da
Add casts to XML parser in DatabaseSchemaChecker
Preparation for strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:38:10 +01:00
Morris Jobke c739ca3c50
Fix casting in app code checker
Found while adding strict typing for PHP7+. This adds type hinting to all methods in CodeChecker.php and fixes one implicit cast.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:24:11 +01:00
Morris Jobke f578b69729
Update composer
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:16:10 +01:00
Morris Jobke fe0dbe7fb7
Fix type in CryptoSessionData
Found while adding strict typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 22:41:03 +01:00
Roeland Jago Douma 3dc7d0fb90
Merge pull request #7822 from nextcloud/check-if-realpath-returns-false
Check if realpath() returns false
2018-01-12 22:29:10 +01:00
Morris Jobke 1efde41333
Check if realpath() returns false
realpath() returns false in case the directory does not exist. Found it while preparing strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 19:40:25 +01:00
Morris Jobke e4e39910f3
Merge pull request #7819 from nextcloud/fix-explode-in-legacy-helper.php
Fix explode() call in legacy/helper.php to have correct types
2018-01-12 17:59:15 +01:00
Morris Jobke b6e4f34a79
Merge pull request #7820 from nextcloud/13-7818
[stable13] Log full exception in cron instead of only the message
2018-01-12 17:58:31 +01:00
Morris Jobke 1a93e57316
Merge pull request #7818 from nextcloud/log-full-exception-in-cron
Log full exception in cron instead of only the message
2018-01-12 17:42:37 +01:00
Morris Jobke 84a17f0821
Merge pull request #7815 from nextcloud/php7-and-higher
Raise PHP version number to PHP 7.0
2018-01-12 17:07:17 +01:00
Roeland Jago Douma 15bbf08774
Merge pull request #7816 from nextcloud/fix-strpos-for-current-app
Fix strpos if needle is not found
2018-01-12 16:55:27 +01:00
Roeland Jago Douma 9d508a022e
Merge pull request #7814 from nextcloud/base.php-strict-typing
Fix strict typing issues in lib/base.php
2018-01-12 16:32:23 +01:00
Roeland Jago Douma daa33938a6
Merge pull request #7811 from nextcloud/fix-clearstatcache
Fix call to clearstatcache to actually use the file path
2018-01-12 15:35:49 +01:00
Morris Jobke 7bc1001309
Log full exception in cron instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:31:43 +01:00
Roeland Jago Douma 1993eb05cc
Merge pull request #7812 from nextcloud/make-sure-the-arrays-are-arrays
Make sure the arrays are arrays
2018-01-12 15:30:59 +01:00
Morris Jobke b356d0dfc4
Fix explode() call in legacy/helper.php to have correct types
Found while enabling strict_typing for PHP7+.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:26:49 +01:00
Morris Jobke e70edb33db
Log full exception in cron instead of only the message
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:24:28 +01:00
Morris Jobke e3c0fd6882
Fix strpos if needle is not found
Found while testing strict_typing for PHP 7+. If `$script` does not contain a `/` then it should extract a string of the length 0.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 15:01:45 +01:00
Morris Jobke 6d95f90361
Raise PHP version number to PHP 7.0
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 14:26:10 +01:00
Morris Jobke 6bf1fca6f0
Fix strict typing issues in lib/base.php
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 14:22:31 +01:00
Joas Schilling 91d3677446
Make sure the arrays are arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-12 14:08:00 +01:00
Morris Jobke 01040daf02
Fix call to clearstatcache to actually use the file path
* found while adding the strict_typing for PHP 7+ migration
* first argument is a boolean - second one is the path
* see http://php.net/manual/en/function.clearstatcache.php

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 13:59:58 +01:00
Nextcloud bot 33a6e265b2
[tx-robot] updated from transifex 2018-01-12 01:11:34 +00:00
Morris Jobke 4f30c2fbe4
Merge pull request #7764 from nextcloud/13rc1
13.0.0 RC1
2018-01-11 20:34:42 +01:00
Morris Jobke b66117583d
13.0.0 RC1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-11 17:22:27 +01:00
Morris Jobke 9898ec95c1
Merge pull request #7796 from nextcloud/ldap-sync-fixes
LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0
2018-01-11 17:22:00 +01:00
Morris Jobke 33b82f34be
Merge pull request #7709 from nextcloud/fix-password-displayed-as-username-in-password-manager
Fix password displayed as username in Firefox password manager dialog
2018-01-11 15:21:35 +01:00
Arthur Schiwon f84ec92563
revert resolving of recursion (3628d4d65d)
without recursion we have issues with internal states. paged search status
are set to false, cookies are not being set. In the end we have  endless
requests which pile up enormously with a high initial offset.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 15:17:18 +01:00
Morris Jobke aab39ba5bd
Merge pull request #7776 from nextcloud/theming-capabilties-enhancements
More detailed theming capabilities
2018-01-11 14:56:58 +01:00
Arthur Schiwon 9031ae0281
fix return value when ldapPagingSize returns null
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:47:51 +01:00
Morris Jobke f3eb9eeb1d
Merge pull request #7791 from nextcloud/bugfix/noid/fix-update-notification
Fix displaying of the HTML update notification
2018-01-11 14:23:33 +01:00
Arthur Schiwon 15a3f4659f
enrich log message with backtrace, but level it down to DEBUG
The message is not helpful anyway for an admin, and oftentimes is just
valid (e.g. when searching with an offset beyond users in LDAP).

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:17:14 +01:00
Daniel Calviño Sánchez b83204bf2c
Add strengthify bar after plain text input clone of password input
To show the password in plain text "showPassword" adds a text input
after the password input and swaps their visibility depending on whether
the password has to be shown in plain text or not. In a similar way,
"strengthify" by default adds the strength bar after the input element
it was called on. Due to this, if "showPassword" is called before
"strengthify" on the same password input then the strength bar ends
between the password input and the text input, and when the text input
is shown it appears below the strength bar.

To fix this now the strength bar is added after the text input in those
places in which "strengthify" was called after "showPassword" on the
same element.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 14:08:47 +01:00
Morris Jobke cc410fb9ab
Merge pull request #7790 from nextcloud/usermanagement-fixes
Fix popover and styling in user management
2018-01-11 14:01:33 +01:00
Morris Jobke a987f39565
Merge pull request #7650 from rpirritano/master
made small changes to login screen
2018-01-11 13:55:39 +01:00
Arthur Schiwon f292f98060
when paged results are turned off, all (max possible) users are returned
thus hasMoreResult should return false

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 13:20:17 +01:00