Commit Graph

57587 Commits

Author SHA1 Message Date
kesselb 5ecbfa4f20
Merge pull request #26162 from nextcloud/backport/26153/stable21
[stable21] Use correct exception type hint in catch statement
2021-03-17 11:09:19 +01:00
Robin Appelman 0532f64aa8 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:02 +00:00
John Molakvoæ (skjnldsv) 1be574319c Fix default missing initial state for templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 09:20:38 +00:00
Vincent Petry 215967db96
Merge pull request #26151 from nextcloud/backport/26137/stable21
[stable21] dont allow creating users with __groupfolders as uid
2021-03-17 09:46:37 +01:00
Morris Jobke 162e763e26 Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:44:29 +00:00
Nextcloud bot fd29c1d72a
[tx-robot] updated from transifex 2021-03-17 02:24:31 +00:00
Robin Appelman 1089d8545b dont allow creating users with __groupfolders as uid
Fixes https://github.com/nextcloud/groupfolders/issues/338

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 18:51:55 +00:00
Robin Appelman 44d4957548 verify that cache entry is valid
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:59 +00:00
Robin Appelman f6f92e8bc6 also implement for FailedCache and NullCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:58 +00:00
Robin Appelman 719db4cee9 use returned file id for object store copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:57 +00:00
Robin Appelman bb180a95bb add ICopyFromCache trait to expose existing implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:17:56 +00:00
Morris Jobke 120aefb795
Merge pull request #26133 from nextcloud/backport/25136/stable21
[stable21] do cachejail search filtering in sql
2021-03-16 16:59:29 +01:00
Christoph Wurst e09d59aa81
Merge pull request #26128 from nextcloud/backport/26115/stable21
[stable21] Log exceptions when creating share
2021-03-16 11:09:13 +01:00
Nextcloud bot 8d6a4bef6c
[tx-robot] updated from transifex 2021-03-16 02:24:53 +00:00
Robin Appelman e5ffb96c36 only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:34 +00:00
Robin Appelman c727879073 adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:34 +00:00
Robin Appelman ec0985ba68 fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:33 +00:00
Robin Appelman eb56b1d0bd fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:32 +00:00
Robin Appelman 046638abeb do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 17:51:32 +00:00
Vincent Petry f109677856 Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:16 +00:00
Robin Appelman f2a35cd3f8 send share notification instead of erroring on duplicate share
when creating a share that already exists, instead of erroring, resend the notifications

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 14:13:04 +00:00
Roeland Jago Douma 8806bbe6fe Allow overwriting isAuthenticated
* Some implementations might check for different things
* IT will not change how the current ones work

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-15 13:59:05 +00:00
Roeland Jago Douma 7059b0b21f Add getID function to the simplefile implementation
Sometimes it is useful to get the actual fileid

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-15 13:44:45 +00:00
Nextcloud bot 7c21fba61f
[tx-robot] updated from transifex 2021-03-15 02:24:10 +00:00
Nextcloud bot 0ea077ae1f
[tx-robot] updated from transifex 2021-03-14 02:23:50 +00:00
Nextcloud bot 5b923eee03
[tx-robot] updated from transifex 2021-03-13 02:23:05 +00:00
Robin Appelman 6308267aff apply object store copy optimization when 'cross storage' copy is within the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:01 +00:00
Robin Appelman a5ceded17f implement PagedProvider for file search
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 12:38:37 +00:00
Robin Appelman b6af62fd24 limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 12:38:37 +00:00
Roeland Jago Douma 7f0f9fcd93
Merge pull request #26081 from nextcloud/backport/26080/stable21
[stable21] Only clear known users when we had at least one phonebook entry
2021-03-12 12:44:41 +01:00
Roeland Jago Douma 3ac6dc3b50
Merge pull request #26084 from nextcloud/backport/26079/stable21
[stable21] Chunk the array of phone numbers
2021-03-12 12:44:25 +01:00
Joas Schilling 2d92f1117b Fix Test class name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 10:23:13 +00:00
Joas Schilling 6951c4ef56 Chunk the array of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 10:23:13 +00:00
Joas Schilling 3efb2d2208 Only clear known users when we had at least one phonebook entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 09:48:14 +00:00
Nextcloud bot 6e2f7ddc7a
[tx-robot] updated from transifex 2021-03-12 02:22:52 +00:00
Julius Härtl cd5e27e3f3
Add appconfig to always show the unique label of a sharee
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-11 15:32:26 +01:00
Vincent Petry 04dd7b234e
Merge pull request #26058 from nextcloud/backport/25911/stable21
[stable21] Only clear share password model when actually saved
2021-03-11 15:15:40 +01:00
Vincent Petry ec443159af Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 10:05:31 +00:00
Vincent Petry 1d0b210d00
Merge pull request #26039 from nextcloud/backport/25916/stable21
[stable21] Remove trash items from other trash backends when deleting all
2021-03-11 10:31:30 +01:00
Roeland Jago Douma 0e8ada1a8a
Merge pull request #26056 from nextcloud/backport/26031/stable21
[stable21] Allow autocomplete based on phone sync
2021-03-11 09:31:44 +01:00
Joas Schilling 62ef45028e
Clean up the logic of the contacts store a bit
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:42:19 +01:00
Joas Schilling 5fa52d492a
Rename some parameters and methods to make the API more clear
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:42:09 +01:00
Joas Schilling 99c1eda9c5
Bump version to run migration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:41:43 +01:00
Joas Schilling 490bfa7330
Also clear the knownUser when changing via the settings endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:59 +01:00
Joas Schilling 49f7d08b38
Also execute the new tests on drone
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:49 +01:00
Joas Schilling 72fb176ec9
Change label also in the acceptance tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:38 +01:00
Joas Schilling 5afaf3d06c
Fix CS hopefully
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:32 +01:00
Joas Schilling 77f6d768bc
Add a setting to restrict returning a full match unless in phonebook or same group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:26 +01:00
Joas Schilling 8069c52a85
Add a hint that the settings are OR based
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:20 +01:00
Joas Schilling 30610aa615
Add integration tests for autocomplete/get (similar to sharees API)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-11 08:40:10 +01:00