66f2b155ce
Fix empty mime type filter
...
When the mime type is an empty array no filter should be applied.
However, the filter was loosely compared to an empty array, but as
arrays are objects then it became an implicit strict equality comparison
which always failed due to being different objects. Now the length of
the array is compared instead, and also moved outside the loop as it is
not needed to check it for each file.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 14:02:50 +02:00
4508a12188
Prevent default action from being executed when the button is disabled
...
When "enter" is pressed in the file picker a "click" event is triggered
on the primary action button. However, in some cases, like when the file
picker is in "Choose" mode and the current directory in the file picker
is the root folder, the primary action button is disabled. In those
cases pressing enter should not trigger a click action on the button and
be ignored instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-30 10:25:09 +02:00
1edf345d4d
Use empty alt tag for avatars since there is always the name next to it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-08-26 18:29:02 +02:00
006e150c87
Change check if secure randomness is possible.
...
Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>
2018-08-24 23:12:02 +02:00
8761856a71
Merge pull request #10838 from nextcloud/header-fixes-and-public-note
...
Header fixes and public note
2018-08-24 22:21:55 +02:00
13230f180a
Fix jsunit
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 22:05:48 +02:00
7ce520e83e
Add support for rooms in the list of candidates to share with UI
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-24 18:06:48 +02:00
421daf6ab0
Fix public share link order
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 17:40:05 +02:00
ddd18aa375
Fix public link order and fix skip to content
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 16:54:01 +02:00
3cb52b868a
Fix header calculation and better public design
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-24 15:45:39 +02:00
ba66cad1b4
Fix keyboard menu element event detection
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-22 09:54:40 +02:00
2bab916c53
Adds license to files. Updates the branch.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 20:46:23 +02:00
6d749bf021
Merge pull request #10700 from nextcloud/fix/10516/sharepermissions
...
Fix share dialog sidebar in share views
2018-08-20 17:14:12 +02:00
37869d9b2f
Merge pull request #10628 from nextcloud/feature/10154/app-directory-permission-check
...
Adds a permission check for app directories
2018-08-20 17:08:18 +02:00
7aed47f776
Adds tests for the memory checks
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
c164409ee7
Adds a memory limit warning for console commands if the limit is below the recommended value
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
1d2bc9c45e
Adds tests for the setup memory limit checks
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
c2fced4463
Adds a setup check for the memory limit
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-20 15:24:10 +02:00
be873c234b
adapt jsunit test
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-16 23:08:15 +02:00
d79943f498
Merge pull request #10608 from nextcloud/header-menu-fixes
...
Fix header menu & contact popover
2018-08-16 09:50:25 +02:00
c435bfe703
Disabled checkboxes and design fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-16 07:31:17 +02:00
e89567eb53
Take base permissions from DAV, fixes #10516
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 15:27:31 +02:00
b9c448d855
Fix password enforce on public links
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-15 11:51:25 +02:00
846b8572ed
Tests fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-10 13:54:21 +02:00
7191d676ab
Merge pull request #10619 from nextcloud/bugfix/4550/redirect-page-update
...
Redirect to the same page after an update
2018-08-10 11:14:03 +02:00
ebcfe33d0d
Extends the setup check js tests
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:48:39 +02:00
b2e60e365d
Adds a setup check for app directory permissions.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2018-08-09 19:47:55 +02:00
46d340045d
Merge pull request #10598 from schoonc/patch-1
...
Removed unused variable isFile
2018-08-09 17:00:03 +02:00
4823b2746e
Redirect to the same page after an update
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-09 15:19:58 +02:00
fc4f122881
Align to the left
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-08-09 12:47:50 +02:00
b0917dfac9
Removed unused variable isFile
2018-08-09 00:30:42 +03:00
e1561f0e8f
Add custom handling for room shares to the resharer information
...
Like done with group shares, received room shares are described as such
in the UI.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:44 +02:00
2d062daa11
Add custom handling for room shares to the list of sharees
...
Like done for other types of shares, room shares are now explicitly
described as such in the UI.
The avatar used is the image provided in the "shareWithAvatar" property
of the share. If none is given then the avatar is the first letter of
the display name of the room share with a coloured background seeded
from the room token. If the display name of the room is empty then no
letter is shown in the avatar; no special handling is done in that case.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
7292a986a0
Add type for room shares
...
This type represents shares with a Nextcloud Talk conversation.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-08-08 14:25:43 +02:00
6d7bf81421
Fix HTML on update error page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-03 13:30:49 +02:00
4574698443
Fix double container on 'Possible CSRF attack' page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-08-01 18:54:48 +02:00
369a6c13eb
Merge pull request #10474 from danielkesselberg/bugfix/10379/no-files-in-here
...
Set emptyText depending on filepicker type
2018-08-01 12:56:08 +02:00
6b9093ce6d
Set emptyText depending on filepicker type
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-07-31 22:49:01 +02:00
3f45ab97da
Improve URL detection
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-31 17:11:46 +02:00
bc83656604
Reword share comment feature
...
Fixes #10403
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-31 14:20:22 +02:00
1f635bb892
Use small loading indicator for avatars smaller than 32px
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-25 14:26:27 +02:00
a96137ef0b
Merge pull request #10310 from nextcloud/accessibility-header
...
Accessibility fixes for header and global elements
2018-07-25 00:07:37 +02:00
fe25092312
Remove deprecated keyboard events & properties
...
Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>
2018-07-24 19:02:56 +02:00
911093549e
Make possible to enable "sending password by Talk" from the share menu
...
Until now the password to be sent by mail was set by enabling a checkbox
in the share menu and then entering the password in an input field shown
below. Now, when Talk is enabled, another item is added to the share
menu to do the same for a password to be sent by Talk.
Sending the password by mail and sending it by Talk are mutually
exclusive actions, so when one of the checkboxes is enabled the other
one is automatically disabled.
Note that the icon set for the field, "icon-passwordtalk", does not
currently exist; it simply mimics the "icon-passwordmail" (which does
not exist either) used for the field of the password protect by mail to
get the right padding in the menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-24 14:45:42 +02:00
0274507cb1
Acceptance and mobile navigation fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-24 11:01:11 +02:00
b41d0d32e2
Merge pull request #10218 from nextcloud/share-comments
...
allow to add a personal note to a share
2018-07-24 09:12:03 +02:00
705439ca7b
Do not bind reset password link if an url is set
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-23 15:01:03 +02:00
da0bdd1391
Design structure fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 16:09:13 +02:00
58debbe42c
Tests fixes and design bump
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
e302cadae2
Don't use shorthand syntax for functions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-21 15:02:21 +02:00
d4de77afb9
No remote note and various fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:21 +02:00
3a11c26cb4
Public fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
c71d3dc9bf
Public share
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
967a97904f
fix post url
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-21 15:02:20 +02:00
fc2767bbbb
Autoresize + autoloader
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
0a7e34f6c8
Popovermenu migration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
4e08d8342e
UI set share note!
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-21 15:02:20 +02:00
8d3f58c391
Jsunit fixes 1
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:38:04 +02:00
d6b718584e
Sidebar fix
...
Fix sidebar and scrollbar on content
Sidebar fixes, and sidebar-width + header-height variables
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:37:00 +02:00
7f0d60fefc
Enter key on menu registration
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-07-20 23:19:55 +02:00
6d083c4de9
Make left sidebar toggle also work with keyboard
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-07-20 23:19:55 +02:00
07271087b0
Fix style of the user facing whats new popup
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-17 14:02:14 +02:00
82021b2b1b
Merge pull request #5280 from nextcloud/shared-with-display-name
...
sharedWithDisplayName & sharedWithAvatar
2018-07-13 17:29:57 +02:00
14314584ba
Merge pull request #10110 from nextcloud/feature/100500/whats-new-info-users
...
Display What's New info to users
2018-07-13 17:25:51 +02:00
83b1de4493
Fix unit tests - follow up to #10197
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 22:02:45 +02:00
3036b1d03d
Merge pull request #9895 from nextcloud/fed-group-shares
...
implement federated group sharing
2018-07-11 21:44:48 +02:00
5262d60e94
Merge pull request #10197 from nextcloud/feature/9410/improve-opcache-feedback
...
Improve opcache feedback
2018-07-11 19:27:09 +02:00
72d17ff02c
Improve url detection in comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-07-11 16:23:56 +02:00
f6f49c77f7
opcache module check
...
Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-11 16:08:40 +02:00
f0aaf62b24
fix js tests
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:49 +02:00
2abc705632
start to get fed group shares into the share dialog
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-07-11 10:11:47 +02:00
ca6094f390
wire the frontend
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 20:29:00 +02:00
772bbd99be
Backend work to provide NC whats New info to users
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 14:33:08 +02:00
6a0c54d5bf
Add warning to setup checks if the default mailer is still php
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-07-04 08:28:33 +02:00
f824ff500d
Fix code integrity check-warning link
...
Signed-off-by: Marius Blüm <marius@lineone.io>
2018-06-29 11:33:29 +02:00
61842f66ee
Merge pull request #5623 from nextcloud/locale-setting
...
Add user locale/region setting
2018-06-29 08:03:43 +02:00
fd41192bb4
fix OC.getLocale()
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-06-27 13:19:49 +02:00
bf6bfad76b
OC.getLocale() now returns Locale and no longer Language
...
Added OC.getLanguage() to get Language
<html lang=''> still gets language, though according to IETF BCP47 locale should be good.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-06-27 13:19:40 +02:00
e1936a49e7
Fix "parsing" of email-addresses in comments and chat messages
...
\\b matches any non-word character, including \@ and \-
In order to not detect urls in the middle of email-addresses,
we need to check for white space characters and beginning of the
message instead.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-06-27 13:04:05 +02:00
8ed50d4b63
prefill userid for login after password reset
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-06-21 15:18:07 +02:00
8ebc3d90a0
Merge pull request #9518 from nextcloud/feature/5986/public_share_controller_middleware
...
Public share middleware & controller
2018-06-21 10:09:20 +02:00
938553ab07
IE11 css vars compatibility
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-20 19:21:54 +02:00
31392c2443
Move public auth page over
...
Now this is in core so the basics (that 99% of the app will want to
use) looks always the same.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-20 08:53:37 +02:00
d82ef72161
Merge pull request #9197 from nextcloud/fix-avatar-center
...
Fix avatar generator centering
2018-06-15 16:16:13 +02:00
ed4309ce41
Unify colour algorithm output
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-06-13 18:46:04 +02:00
9c4aecb539
Merge all setup checks into one controller
...
* renamed hasMissingIndexes to missingIndexes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 15:25:08 +02:00
cd87a40eb3
Merge pull request #9836 from nextcloud/feature/noid/merge-tips-and-tricks-into-setup-checks
...
Merge tips & tricks section into setup checks
2018-06-13 13:18:40 +02:00
4a0b7aaf6c
Merge tips & tricks section into setup checks
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 12:05:38 +02:00
624d191ef6
Fix wrong hint about missing indexes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-13 11:56:43 +02:00
393d9aae74
Add a hint that some indexes are not added yet
...
* gives the admin a chance to discover the missing indexes and improve the performance of the instance without digging through the manual
* nicely integrated in the setup checks where this kind of hints belong to
* also adds an option to integrate this from an app based on events
* fix style of setting warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-06 16:55:01 +02:00
4b70c9f89d
Add referrer policy setup check
...
Fixes #9122
Based on https://www.w3.org/TR/referrer-policy/ and
https://scotthelme.co.uk/a-new-security-header-referrer-policy/
Setting a sane Referrer-Policy will tell the browser if/when to send
referrer headers when accessing a link from Nextcloud. When configured
properly this results in less tracking and less leaking of (possibly)
sensitive urls
* Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-04 09:21:35 +02:00
10b33cd5d0
Add placeholder to input in OCdialog prompt
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:02:25 +02:00
33b65faba0
Allow to specify custom text on admin password confirmation dialogs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-24 14:01:58 +02:00
2e3517eb00
display details on sharing panel
...
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
2018-05-21 01:24:45 +02:00
0009adae80
SharedWithDisplayName + SharedWithAvatar
...
Signed-off-by: Maxence Lange <maxence@nextcloud.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-05-21 01:24:45 +02:00
d607e7b924
Move the webui over to the new dav endpoint
...
We should use the new dav endpoint everywhere now.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-08 23:02:19 +02:00
43c1e51a5f
Merge pull request #9151 from UncleAlbie/dialog-sort
...
Sort files in dialog by name.
2018-05-07 18:39:24 +02:00
0771dad57f
Do not add sharePermission logic in JS
...
We have a dedicated dav property. We should do all the magic in 1 place.
Not several.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-26 12:14:37 +02:00
0bae516c66
Merge pull request #9224 from nextcloud/accessibility-improvements
...
Add labels for Contacts menu and Settings, thanks to @MarcoZehe
2018-04-19 14:47:17 +02:00
f8e3b572c8
Remove no longer needed escaping of special characters
...
The escaping of special characters was needed when the ids of the
permission checkboxes for shares were based on the "shareWith" field.
Since they are based on the "shareId" field the escaping is no longer
needed, as the "sharedId" is expected to always contain compatible
characters.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-18 17:03:45 +02:00
Daniel Calviño Sánchez
Joas Schilling
Timo Förster
Morris Jobke
John Molakvoæ (skjnldsv)
Michael Weimann
Arthur Schiwon
Julius Härtl
Roeland Jago Douma
schoonc
Jan-Christoph Borchardt
Daniel Kesselberg
Roeland Jago Douma
Kevin Ndung'u
Bjoern Schiessle
Cthulhux
Marius Blüm
Georg Ehrke
Thomas Citharel
Robin Appelman
Maxence Lange