3372bcc7fc
fixes possible override of uniqueMember by autodetection
...
* uniqueMember was the default so we did not know whether this setting is
desired or the initial value
* autodetection of the user-group association attribute runs only when it
was not set (as far as we knew)
* the default is now empty
* thus LDAPProvider might return this value as well (in exceptional cases)
* if a group base is given (edge case), use this instead of general base
* resolves #12682
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-17 16:19:23 +02:00
c60f6716b4
[tx-robot] updated from transifex
2019-05-07 00:12:58 +00:00
5e8cedab9f
[tx-robot] updated from transifex
2019-05-01 00:12:41 +00:00
01410491b9
[tx-robot] updated from transifex
2019-04-29 00:12:39 +00:00
16b8017fc9
[tx-robot] updated from transifex
2019-04-18 00:12:48 +00:00
9302e1b8dd
[tx-robot] updated from transifex
2019-04-16 00:17:30 +00:00
4c19b3b2c6
Bump versions of server and the requirements of apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-11 14:02:23 +02:00
36618b111f
Pass old value to user triggerChange hook
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-04-11 10:03:38 +02:00
7641a1589f
[tx-robot] updated from transifex
2019-04-11 00:12:59 +00:00
9c9c410094
[tx-robot] updated from transifex
2019-04-06 00:13:10 +00:00
518998093f
set the loglevel in context, save the condition
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-02 22:52:12 +02:00
a541443be7
[tx-robot] updated from transifex
2019-03-26 10:41:31 +00:00
61572a5b2e
LDAP plugin: force createUser to return new user's DN
...
LDAP plugins must change the createUser method to return the DN, as we
need this to update the cache.
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
a2c38148e7
Cache cleaning when subadmin adds user to group
...
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.
This just forces the cache to be reset after an user is added to a
group.
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
c4dbc428f9
fix user creation using LDAP Plugin
...
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
6ea5beccd7
[tx-robot] updated from transifex
2019-03-21 01:13:49 +00:00
3ed1d158bc
LDAP Password Modify Extended Operation support
...
Signed-off-by: Peter Kubica <peter@kubica.ch>
2019-03-19 01:58:46 +01:00
219fb1a855
Fix showpassword loads
...
This is bundled by default. So trying to load it throws a warning in the
logs.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-18 14:38:44 +01:00
f8988c257c
[tx-robot] updated from transifex
2019-03-16 01:12:34 +00:00
6fcf729545
[tx-robot] updated from transifex
2019-03-14 16:08:31 +00:00
e36cede994
remove unused use statement
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-06 00:34:29 +01:00
5dd2207c95
fix nested group retrieval also for 2 other cases
...
and also consolidate logic in one method
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-05 11:07:40 +01:00
459b8a4845
Fixed unit test: groupsMatchFilter will not be called multiple times anymore.
...
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
e7c506cff1
Reduce queries to LDAP by caching nested groups
...
Nested groups are now cached in a CappedMemoryCache object to reduce
queries to the LDAP backend.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
afb182650e
user_ldap: really resolve nested groups
...
The previous patch fixed the problem only for one level of indirection
because groupsMatchFilter() had been applied on each recursive call (and
thus there would be no second level if the first level fails the check).
This new implementation replaces the recursive call with a stack that
iterates all nested groups before filtering with groupsMatchFilter().
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
c2d8a36d9a
user_ldap: Filter groups after nexted groups
...
Currently groupsMatchFilter is called before nested groups are resolved.
This basicly breaks this feature since it is not possible to inherit
membership in a group from another group.
Minimal example:
Group filter: (&(objectClass=group),(cn=nextcloud))
Nested groups: enabled
cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local
objectClass: group
cn=IT,ou=groups,dn=company,dn=local
objectClass: group
memberOf: cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local
cn=John Doe,ou=users,dn=company,dn=local
objectClass: person
memberOf: cn=IT,ou=groups,dn=company,dn=local
Since 'cn=IT,ou=groups,dn=company,dn=local' doesn't match the group
filter, John wouldn't be a member of group 'nextcloud'.
This patch fixes this by filtering the groups after all nested groups
have been collected. If nested groups is disabled the result will be the
same as without this patch.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:35 +01:00
6ee7286b41
Fix tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:57:01 +01:00
374f89aba1
[tx-robot] updated from transifex
2019-03-01 01:12:36 +00:00
057e81a1e2
[tx-robot] updated from transifex
2019-02-28 01:12:39 +00:00
36b01e3c2d
[tx-robot] updated from transifex
2019-02-27 01:12:05 +00:00
876e2792d0
[tx-robot] updated from transifex
2019-02-26 01:12:12 +00:00
5df6400e28
[tx-robot] updated from transifex
2019-02-25 01:12:18 +00:00
73473de5de
Fixed grammar
...
Reported at Transifex.
Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2019-02-22 19:49:36 +01:00
10388eab34
[tx-robot] updated from transifex
2019-02-21 01:12:02 +00:00
ad0b67cbce
[tx-robot] updated from transifex
2019-02-19 01:12:10 +00:00
0b7b938a60
[tx-robot] updated from transifex
2019-02-18 01:12:09 +00:00
1374183f92
[tx-robot] updated from transifex
2019-02-17 01:13:29 +00:00
685c13e091
add GUI option to set the $home placeholder
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
792bcb82ae
add LDAP ConfigHandler for external storages and "$home" var
...
* handler registered upon OCA\\Files_External::loadAdditionalBackends
event as user_ldap is loaded before files_external
* new configuration field "ldapExtStorageHomeAttribute" (not in GUI yet)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
5c10a46445
ensure attribute names are lower cased
...
otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 14:13:32 +01:00
4d8c42a4fb
[tx-robot] updated from transifex
2019-02-14 01:12:26 +00:00
45777abce0
[tx-robot] updated from transifex
2019-02-08 01:12:39 +00:00
0df5110127
[tx-robot] updated from transifex
2019-02-06 11:27:29 +00:00
18ae9d267a
Comment fix.
2019-01-30 23:23:09 +01:00
c868892d2d
iterate over bases instead of doing parallel search
...
parallel search is not compatible with paged search, but the letter is
usually always applied.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-28 23:00:59 +01:00
4611ad5a9c
[tx-robot] updated from transifex
2019-01-26 01:12:19 +00:00
2277c21f3e
[tx-robot] updated from transifex
2019-01-24 01:12:02 +00:00
2ba75ac9b0
[tx-robot] updated from transifex
2019-01-23 01:12:05 +00:00
e35a5ef387
[tx-robot] updated from transifex
2019-01-16 01:12:34 +00:00
56ad07b85e
[tx-robot] updated from transifex
2019-01-15 01:12:14 +00:00
8edd9b0e33
[tx-robot] updated from transifex
2019-01-14 01:12:00 +00:00
363c0c31f4
[tx-robot] updated from transifex
2019-01-13 01:12:53 +00:00
208788173d
Npmize (vendor) scripts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +01:00
a1b6333712
[tx-robot] updated from transifex
2019-01-05 01:11:57 +00:00
c1ddd2fec9
Merge pull request #13138 from nextcloud/enhancement/noid/ldap-remnants-detected-field
...
register and show when an LDAP user was detected as unavailable/deleted
2019-01-04 22:48:05 +01:00
925043c60c
ensure db is pristine before starting the tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-04 22:10:22 +01:00
a1f9ed1d7d
[tx-robot] updated from transifex
2019-01-04 01:12:28 +00:00
8d5b74b6b6
[tx-robot] updated from transifex
2018-12-31 01:11:41 +00:00
760c502f3c
[tx-robot] updated from transifex
2018-12-28 01:11:49 +00:00
1c3f468d56
[tx-robot] updated from transifex
2018-12-27 01:11:41 +00:00
9d5f7c7f62
[tx-robot] updated from transifex
2018-12-24 01:11:46 +00:00
85f14bc591
LDAP: extend remnants output with "detected on" field
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:28 +01:00
fbd4e9e651
add tests for the DUI
...
as they are interact with the DB they are more integraiton than unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:23 +01:00
8bacbffe28
do not forgot to store the second displayname portion
...
otherwise it causes a chain reaction of system addressbook updates
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-20 23:11:00 +01:00
3d53398d07
[tx-robot] updated from transifex
2018-12-19 01:11:46 +00:00
f36082838e
[tx-robot] updated from transifex
2018-12-18 01:11:34 +00:00
e7950a5bd6
Merge pull request #12693 from nextcloud/fix/11474/fix-first-ldap-login
...
fix exception on LDAP mapping during login
2018-12-17 13:07:21 +01:00
feb5366a42
LDAP clear cache on config modification also when done via API or CLI
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-17 00:31:27 +01:00
51f13a7e9c
[tx-robot] updated from transifex
2018-12-14 01:12:32 +00:00
7034df7d77
[tx-robot] updated from transifex
2018-12-13 01:11:56 +00:00
95d33cd889
[tx-robot] updated from transifex
2018-12-04 01:12:05 +00:00
68f04686a0
[tx-robot] updated from transifex
2018-11-29 01:11:34 +00:00
c32cc4a194
cache users as existing after mapping
...
during login they might be cached as non-existing and cause an Exception
in the long run
reduces some duplication, too
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-27 17:07:59 +01:00
6ce849f7b8
Add return type
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-25 12:30:54 +01:00
d17b32afd7
Fix count on string
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-24 22:06:45 +01:00
1751c28c28
Bump versions of server and the requirements of apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-23 10:28:40 +01:00
d664a9b37b
[tx-robot] updated from transifex
2018-11-23 01:12:51 +00:00
def8af3e7e
[tx-robot] updated from transifex
2018-11-16 01:12:14 +00:00
159d75945a
Merge pull request #12292 from nextcloud/fix/2947/lapse-sizelimit-error
...
avoid logging of "Partial search results returned: Sizelimit exceeded…"
2018-11-15 10:48:57 +01:00
aa88254f64
Shorten index name of calendar changes table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +01:00
deec5a70a0
avoid logging of "Partial search results returned: Sizelimit exceeded at"
...
LDAP servers respond with that even if a limit was passed with the
request. Having this statement logged causes a lot of confusion.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-07 13:15:55 +01:00
9d7f02ec47
[tx-robot] updated from transifex
2018-11-04 01:14:02 +00:00
0c5d9127e8
remove app specific IUserTools and consolidate test
...
Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 22:44:50 +01:00
8b2b238d86
Merge pull request #12054 from nextcloud/fix/5212/interact-with-userobject
...
LDAP: announce display name changes so that addressbook picks it up
2018-10-30 13:38:16 +01:00
49456e42f9
do not run into UniqueConstraintViolationException
...
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 12:12:03 +01:00
31ccf8580a
Merge pull request #12070 from nextcloud/fix/noid/announce-chosen-uid
...
announce the chosen uid (fixes wrong variable usage)
2018-10-30 10:12:04 +01:00
d47e1513bc
remove unneeded empty search attribute values, fixes #12086
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
05f909dcf3
fixes wrong variable usage
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
a226f65aa2
Fix off-by-one bugs
...
This fixes warnings from LGTM:
Off-by-one index comparison against length may lead
to out-of-bounds read.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
bbe44108b5
only write when the displayname differs, but then announce it
...
refs #5212 and fixes #9112
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
...
* so the check from older days is really not necessary anymore
* resolves #10923
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
a9fb21f9fc
[tx-robot] updated from transifex
2018-10-23 14:54:28 +00:00
171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
...
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
d9aa484641
Fix font-face on LDAP tooltip
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
2ad38200fb
Add missing semicolons
...
This fixes some recommendations from LGTM:
Avoid automated semicolon insertion (90% of all statements
in the enclosing function have an explicit semicolon).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
b458ed9c82
Properly escape column name in "createFunction" call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
d9fe68ed12
[tx-robot] updated from transifex
2018-10-05 00:12:56 +00:00
b6e86121bc
[tx-robot] updated from transifex
2018-10-01 00:12:39 +00:00
dafd708075
[tx-robot] updated from transifex
2018-09-30 00:12:06 +00:00
73aabbd3c0
[tx-robot] updated from transifex
2018-09-29 00:12:16 +00:00
2ace0df82a
[tx-robot] updated from transifex
2018-09-27 00:12:26 +00:00
2f45045c96
[tx-robot] updated from transifex
2018-09-26 00:12:23 +00:00
bdb01064e2
[tx-robot] updated from transifex
2018-09-25 00:12:07 +00:00
bd89af478e
[tx-robot] updated from transifex
2018-09-22 00:12:06 +00:00
0211e17e3f
[tx-robot] updated from transifex
2018-09-21 00:12:08 +00:00
d9247f7640
Merge pull request #11245 from nextcloud/bugfix/8288/userldap-getusername-on-null
...
Check if user is null before getUsername
2018-09-18 11:38:16 +02:00
2a51572cc4
[tx-robot] updated from transifex
2018-09-17 00:12:30 +00:00
2d30511fa6
Check if user is null before getUsername
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-16 19:33:03 +02:00
40bb45225a
[tx-robot] updated from transifex
2018-09-16 00:12:29 +00:00
6112adfe06
[tx-robot] updated from transifex
2018-09-14 00:12:27 +00:00
10351cb9da
[tx-robot] updated from transifex
2018-09-13 00:12:08 +00:00
3653a2c889
[tx-robot] updated from transifex
2018-09-08 00:12:33 +00:00
3a08f71981
[tx-robot] updated from transifex
2018-09-06 00:12:53 +00:00
47cc5e5895
Update version requirements and versions of shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-05 14:27:06 +02:00
bcaf9a48bb
[tx-robot] updated from transifex
2018-09-05 00:12:50 +00:00
021dad53be
[tx-robot] updated from transifex
2018-09-01 00:12:17 +00:00
4da9a15b32
[tx-robot] updated from transifex
2018-08-30 00:12:07 +00:00
8b47f45afa
[tx-robot] updated from transifex
2018-08-27 00:12:14 +00:00
d644cafae7
[tx-robot] updated from transifex
2018-08-25 00:12:33 +00:00
c850b3ac20
Merge pull request #10820 from nextcloud/fix/noid/emptydefaultprefix
...
[LDAP] The WebUI Wizard also should not assign empty config IDs
2018-08-24 21:37:00 +02:00
503fbc953e
[tx-robot] updated from transifex
2018-08-24 00:12:20 +00:00
7807add02d
[LDAP] The WebUI Wizard also should not assign empty config IDs
...
With 689df9a843#3270 .
The web UI creates now also a full configuration on first load. This fixes
#5094 .
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 17:58:35 +02:00
c0f48a7b40
[tx-robot] updated from transifex
2018-08-23 00:12:59 +00:00
65410ab1cb
[tx-robot] updated from transifex
2018-08-22 00:12:11 +00:00
3d8f174774
Resolve all group memberships properly
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 10:57:50 +02:00
9cf11bd73c
Merge pull request #10687 from nextcloud/fix/noid/false-positive-change-mention
...
don't blame randome people for background email updates
2018-08-20 14:37:41 +02:00
2b903aa267
fix unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 16:11:07 +02:00
62a9ec12bc
[tx-robot] updated from transifex
2018-08-15 00:13:40 +00:00
b497b06867
don't force LDAP updates on userExists anymore
...
and remove some deprecated code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:57:24 +02:00
d05c815796
Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
...
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
90a656305b
Bump autoloaders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:03:22 +02:00
103a2c30fb
[tx-robot] updated from transifex
2018-08-10 00:12:26 +00:00
59e35e3bf7
tests for user storage location
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
b069b13226
convert pagination tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
0f6d98eed2
convert connection tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
eaf352b8d1
integration test to ensure entries without displayname don't cause trouble
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
4e8db8aa11
convert LDAP offline and backup server integration tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
a39c995083
FIX: emit assignedUserId only for users
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
3450ed4536
integration test checking the group filter
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
6a9bee478d
[tx-robot] updated from transifex
2018-08-01 00:11:59 +00:00
0c7a17795b
[tx-robot] updated from transifex
2018-07-28 00:12:07 +00:00
4d060755e5
[tx-robot] updated from transifex
2018-07-23 00:12:05 +00:00
a927d2fc08
[tx-robot] updated from transifex
2018-07-20 00:12:09 +00:00
858bd67eff
Fix tests for backup ldap server connection
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 09:16:57 +02:00
c2616df541
Only bind if configuration for the first server is available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 08:25:10 +02:00
8ccb99f416
Merge pull request #10098 from nextcloud/feature/noid/ldap-image-attribute
...
allow admin to disable fetching of avatars as well as a specific attribute
2018-07-11 12:19:58 +02:00
0e0dd2a90b
[tx-robot] updated from transifex
2018-07-11 00:12:15 +00:00
a22bc0e787
[tx-robot] updated from transifex
2018-07-10 08:21:14 +00:00
846ab25fc0
adjust and add more unit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:50:49 +02:00
343036e55c
allow admin to disable fetching of avatars as well as a specific attribute
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:12:51 +02:00
a4dda465c2
let user set avatar in nextcloud von LDAP provides invalid image data
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 01:45:07 +02:00
552da85df8
Iron User_LDAP tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 00:29:34 +02:00
28e64afb8c
Merge pull request #10034 from nextcloud/fix/noid/ldap-silence-quota-logmsgs
...
lower log level for quota manipulation cases
2018-06-28 23:06:23 +02:00
cc51a00c93
lower log level for quota manipulation cases
...
and simplify the forest of ifs a little bit
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-28 21:10:07 +02:00
7a728f2154
LDAP backup server should not be queried when auth fails
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-27 23:12:07 +02:00
e4551106f5
[tx-robot] updated from transifex
2018-06-22 00:12:11 +00:00
f9c98d8621
[tx-robot] updated from transifex
2018-06-21 00:12:47 +00:00
cad8824a8e
[tx-robot] updated from transifex
2018-06-20 00:12:26 +00:00
db9ad32d75
[tx-robot] updated from transifex
2018-06-16 00:13:15 +00:00
84a1c915e6
[tx-robot] updated from transifex
2018-06-15 00:12:49 +00:00
d91bed9490
[tx-robot] updated from transifex
2018-06-12 00:12:46 +00:00
36d74047f7
[tx-robot] updated from transifex
2018-06-03 00:12:47 +00:00
d9238b810a
[tx-robot] updated from transifex
2018-06-02 00:12:30 +00:00
9ac36dc30b
[tx-robot] updated from transifex
2018-05-31 00:12:36 +00:00
7df563ee39
[tx-robot] updated from transifex
2018-05-30 00:12:08 +00:00
c0ed6f91a8
Merge pull request #9640 from nextcloud/fix/9502/missedstatecheck
...
check user state when fetching to avoid dealing with offline objects, fixes #9502
2018-05-29 16:55:14 +02:00
645eaaa434
[tx-robot] updated from transifex
2018-05-29 00:12:21 +00:00
73cacb8896
check user state when fetching to avoid dealing with offline objects
...
fixes #9502
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-05-29 01:10:03 +02:00
f0fdac8078
[tx-robot] updated from transifex
2018-05-26 00:13:01 +00:00
60734cd79d
[tx-robot] updated from transifex
2018-05-25 00:14:54 +00:00
4bbad8f88a
[tx-robot] updated from transifex
2018-05-23 00:15:44 +00:00
0d90c5ebc4
[tx-robot] updated from transifex
2018-05-22 00:13:31 +00:00
514b374923
[tx-robot] updated from transifex
2018-05-18 00:13:45 +00:00
ef665fde42
[tx-robot] updated from transifex
2018-05-17 00:13:46 +00:00
05df524472
[tx-robot] updated from transifex
2018-05-13 00:12:56 +00:00
d341a96701
Merge pull request #9288 from GitHubUser4234/ldap_password_renew_nc13fix
...
Ldap password renewal fixes for NC13
2018-05-12 10:46:57 +02:00
5fcb3dd1dc
[tx-robot] updated from transifex
2018-05-12 00:13:00 +00:00
4b1c315dca
[tx-robot] updated from transifex
2018-05-11 00:13:00 +00:00
58e4ddd638
Merge pull request #9360 from GitHubUser4234/ldap_password_renew_invarg_fix
...
Fix "Invalid argument supplied for foreach()"
2018-05-10 09:32:07 +02:00
01c21601e8
[tx-robot] updated from transifex
2018-05-10 00:13:09 +00:00
ced15ab756
adjust unit tests for \"Invalid argument supplied for foreach()\" fix
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-05-09 20:24:41 +08:00
1ce3a618a8
[tx-robot] updated from transifex
2018-05-05 00:11:47 +00:00
856164e578
Fix "Invalid argument supplied for foreach()"
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-05-02 18:17:21 +08:00
8637b90e15
unbound cloned connection fix
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-27 17:29:15 +08:00
9e3522af54
[tx-robot] updated from transifex
2018-04-27 00:11:53 +00:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
aa85418c68
Remove unneeded semicolon and parentheses
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-25 15:54:33 +08:00
cc40917e5e
css indent alignment
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-25 14:47:16 +08:00
571b337a5e
adjust css to nc13 core changes
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-24 15:53:48 +08:00
15fb3bb73a
remove reset password link
...
Signed-off-by: Roger Szabo <roger.szabo@web.de>
2018-04-24 15:47:31 +08:00
9339c7d20f
[tx-robot] updated from transifex
2018-04-24 00:11:53 +00:00
83b0ce0955
Merge pull request #9278 from nextcloud/bug/noid/ldap-wizard-newaccess
...
Access needs UserManager, missed to add in #8833
2018-04-23 17:49:07 +02:00
ed5f53bd49
Access needs UserManager, missed to add in #8833
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-23 15:58:50 +02:00
74b5ab8d39
[tx-robot] updated from transifex
2018-04-22 00:11:51 +00:00
6b5132502e
[tx-robot] updated from transifex
2018-04-21 00:11:39 +00:00
3c250b1a35
[tx-robot] updated from transifex
2018-04-17 00:13:08 +00:00
af53f48ce2
[tx-robot] updated from transifex
2018-04-12 00:19:20 +00:00
ecc3bc64aa
[tx-robot] updated from transifex
2018-04-11 00:21:34 +00:00
38961a725f
Merge pull request #8833 from nextcloud/feature/noid/add_ldap_user_hooks
...
add anounce- and (pre/|post)RevokeUser signals for non-native backends
2018-04-11 00:44:39 +02:00
323ee3cbdc
[tx-robot] updated from transifex
2018-04-10 00:12:10 +00:00
2620e16731
Merge pull request #9116 from nextcloud/rakekniven-patch-1
...
Update settings.php
2018-04-09 16:21:06 +02:00
cde721fd0b
Update settings.php
...
Changed according to discussion.
2018-04-09 13:26:28 +02:00
014446447b
Update settings.php
...
Tiny l10n improvement.
Reported at Transifex: https://www.transifex.com/nextcloud/nextcloud/translate/#de_DE/user_ldap/91002448
2018-04-07 09:29:10 +02:00
16d4ff4d39
parameter provided to L10N::n() could have been a string
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 14:50:28 +02:00
f1565336bd
DI for NC's user manager
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:24 +02:00
373a1d5391
more consistent naming
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:15 +02:00
8fe914f07e
LDAP backend to emit announce and revoke signals on mapping changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:39 +02:00
0c12c06325
[tx-robot] updated from transifex
2018-04-05 00:11:47 +00:00
0f398e7611
[tx-robot] updated from transifex
2018-03-31 00:13:51 +00:00
65908bacd2
[tx-robot] updated from transifex
2018-03-29 00:13:35 +00:00
b2e34167eb
Merge pull request #8976 from nextcloud/dep_user_code
...
Remove deprecated functions from OCP\User
2018-03-28 08:23:57 +02:00
f4fd0224db
Do not use \OCP\DB anymore
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:40:23 +02:00
74f0e37233
Remove deprecated \OCP\User::userExists
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:16:23 +02:00
7ebd96416c
Remove deprecated OCP\User::getDisplayname
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:42:03 +02:00
6c8caa1641
Remove deprecated \OCP\User::getUsers
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:33:24 +02:00
3b6a45b926
[tx-robot] updated from transifex
2018-03-24 01:12:19 +00:00
26073eac0c
Finally remove \OCP\JSON
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-23 08:50:17 +01:00
3dac15a891
Move calls to \OCP\JSON to private \OC_JSON
...
They should be properly fixed at some point.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 13:19:29 +01:00
cbf60f2e91
existence check works without attribute (like with users)
...
cn is not necessarily given everywhere
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-15 15:47:44 +01:00
7f00de841b
[tx-robot] updated from transifex
2018-03-14 01:11:29 +00:00
3cae276149
[tx-robot] updated from transifex
2018-03-13 01:12:01 +00:00
8195b17ed7
Remove deprecated and unsused methods of OCP\DB
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 15:13:37 +01:00
4e56a02450
[tx-robot] updated from transifex
2018-03-12 01:12:21 +00:00
f4bcf2db60
Use variable for proper translations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-10 13:00:25 +01:00
746022ce46
Update wizardTabElementary.js
...
Fixed grammar.
Reported at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/91002422?issue=yes
2018-03-10 12:57:09 +01:00
a20e9d7891
[tx-robot] updated from transifex
2018-03-09 01:12:12 +00:00
cccf6f4d5f
Merge pull request #8221 from Cybso/8220_applyLdapUserFilter_on_members
...
Apply ldapUserFilter on members of group
2018-03-08 13:19:02 +01:00
2472b93fd9
dn2ocname: also apply group filter to readAttribute()
...
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-03-07 12:18:46 +01:00
c2320aea22
Merge pull request #8634 from nextcloud/ldap-no-empty-names
...
do not create empty userid when attribute does not have allowed chars
2018-03-05 19:37:17 +01:00
47a10bd25a
treat iconv issues
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-05 14:03:08 +01:00
4f8c724318
typo + phpdoc
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-05 13:30:28 +01:00
c85c64c787
Merge pull request #8630 from nextcloud/ldap-cachekey-sha256
...
use hash algo that's robust against collisions
2018-03-05 12:34:07 +01:00
6975cef00b
[tx-robot] updated from transifex
2018-03-04 01:12:42 +00:00
8607992e85
do not create empty userid when attribute does not have allowed chars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 17:44:06 +01:00
04f7252fc4
use hash algo that's robust against collisions
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-03-02 16:26:36 +01:00
533e8351ad
[tx-robot] updated from transifex
2018-02-28 01:12:31 +00:00
238c3a5201
fix retrieving group members with numerical uids from LDAP
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:05:50 +01:00
72af741e78
tests for retrieving group members with numerical uids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-23 12:04:48 +01:00
68187e6036
[tx-robot] updated from transifex
2018-02-23 01:12:16 +00:00
930aad5aaa
Merge pull request #8499 from nextcloud/avoid-fruitless-login-attempts
...
Avoid fruitless login attempts
2018-02-22 19:19:40 +01:00
9bc75307e7
track the state of the bind result
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 13:05:33 +01:00
49ec5ff4e4
2nd parameter to t() must be array
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-22 12:10:30 +01:00
6591a3bc36
[tx-robot] updated from transifex
2018-02-21 01:12:10 +00:00
ac63c207a9
Merge pull request #8411 from nextcloud/add-strict-types-to-oc_app
...
Add strict types to OC_App
2018-02-17 21:34:20 +01:00
edee243b27
OC_App::loadApps now only accepts an array as type list
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-17 15:27:43 +01:00
f095001e4b
Fix info.xml files of shipped apps
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-02-16 10:24:03 +01:00
01623d4aca
[tx-robot] updated from transifex
2018-02-14 21:37:31 +00:00
236086c457
Merge pull request #8335 from nextcloud/remove-unused-import
...
Remove unused import statements
2018-02-14 22:23:07 +01:00
d3d045dd5c
Remove unused import statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-14 16:55:43 +01:00
e2974f1133
Simplify return statement
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-02-13 21:55:24 +01:00
3fc6d6234e
[tx-robot] updated from transifex
2018-02-13 10:48:27 +00:00
71382daf67
[tx-robot] updated from transifex
2018-02-08 01:10:28 +00:00
cf4ec7a4b6
Apply ldapUserFilter on members of group
...
Refers to issue #8220
user_ldap configured with custom filters for active directory access
(group-member-association is "member"). Then it can happen that the
members of a group contain members that don't belong to the users
available in Nextcloud (the most trivial reason is that the user filter
contains "(!(UserAccountControl:1.2.840.113556.1.4.803:=2))" to exclude
disabled users from being imported).
This can be fixed by applying the ldapUserFilter when resolving the UID
for a DN fetched from the group's member list.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2018-02-07 12:02:58 +01:00
6428cf552c
Merge pull request #8122 from nextcloud/fix-6851
...
fix reading the ldapIgnoreNamingRule config value
2018-02-02 09:34:03 +01:00
b78da27d0a
[tx-robot] updated from transifex
2018-02-01 18:28:02 +00:00
8f29f9a59b
typo
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 21:50:55 +01:00
8753a816d8
fixes reading the sysconfig value
...
settings without the entry in the translation array are computed
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-31 13:46:13 +01:00
cb26f6d014
[tx-robot] updated from transifex
2018-01-31 01:10:51 +00:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
1d8b90b8d3
[tx-robot] updated from transifex
2018-01-29 01:10:53 +00:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
2ad2eb38e8
Use type casting instead of *val() method
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 15:01:27 +01:00
ca493ab5b1
Merge pull request #8069 from nextcloud/no-catch-serverdown
...
do not catch and ignore ServerNotAvailable in the wrong spot
2018-01-26 14:01:07 +01:00
b61b906abe
do not catch ServerNotAvailable
...
might cause the user to be unavailable (race condition).
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-26 12:47:19 +01:00
6bbea33133
Simplify ternary operator statements
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 12:36:25 +01:00
c1e4f9f305
Use type casting instead of *val() method
...
It should be up to 6x faster
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 11:35:42 +01:00
0a56d2185e
Return value immediately instead of assigning to a one-time variable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 00:02:03 +01:00
bf2be08c9f
Fix risky tests without assertions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-25 11:33:25 +01:00
2a38605545
Properly log the full exception instead of only the message
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
55532f19d9
Cleanup OC_User and OCP\User
...
* mainly removes deprecated methods and old static code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:39:11 +01:00
419de27b6d
Merge pull request #7840 from nextcloud/dep_config
...
Remove deprecated \OCP\Config
2018-01-14 22:21:37 +01:00
7d9146db38
Merge pull request #7846 from nextcloud/this_is_14
...
Bump version number
2018-01-14 20:54:16 +01:00
db411f8771
Bump apps
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-14 11:40:53 +01:00
dffa922c0b
Remove deprecated functions for OCP\Util
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 19:41:34 +01:00
8a41d05761
Remove deprecated \OCP\Config
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-13 14:25:04 +01:00
f578b69729
Update composer
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 23:16:10 +01:00
9898ec95c1
Merge pull request #7796 from nextcloud/ldap-sync-fixes
...
LDAP Sync fixes: revert recursion resolution, fixed handling of pagingsize of 0
2018-01-11 17:22:00 +01:00
33b82f34be
Merge pull request #7709 from nextcloud/fix-password-displayed-as-username-in-password-manager
...
Fix password displayed as username in Firefox password manager dialog
2018-01-11 15:21:35 +01:00
f84ec92563
revert resolving of recursion ( 3628d4d65d)
...
without recursion we have issues with internal states. paged search status
are set to false, cookies are not being set. In the end we have endless
requests which pile up enormously with a high initial offset.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 15:17:18 +01:00
9031ae0281
fix return value when ldapPagingSize returns null
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:47:51 +01:00
15a3f4659f
enrich log message with backtrace, but level it down to DEBUG
...
The message is not helpful anyway for an admin, and oftentimes is just
valid (e.g. when searching with an offset beyond users in LDAP).
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 14:17:14 +01:00
b83204bf2c
Add strengthify bar after plain text input clone of password input
...
To show the password in plain text "showPassword" adds a text input
after the password input and swaps their visibility depending on whether
the password has to be shown in plain text or not. In a similar way,
"strengthify" by default adds the strength bar after the input element
it was called on. Due to this, if "showPassword" is called before
"strengthify" on the same password input then the strength bar ends
between the password input and the text input, and when the text input
is shown it appears below the strength bar.
To fix this now the strength bar is added after the text input in those
places in which "strengthify" was called after "showPassword" on the
same element.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-01-11 14:08:47 +01:00
f292f98060
when paged results are turned off, all (max possible) users are returned
...
thus hasMoreResult should return false
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-11 13:20:17 +01:00
cf915b0f75
extend test for rotating prefixes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:46:07 +01:00
7c3db54ff6
fix changing to next cycle
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:45:06 +01:00
0d3f945209
add tests for whole run command
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:44:45 +01:00
b17c5fec40
add unit test for qualifies to run
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 13:08:59 +01:00
e4310648df
add unit test for determining next cycle
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-08 12:57:14 +01:00
a565bf0b9f
fix offset is never being reset
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-05 14:29:11 +01:00
82da4fde18
create failing test for this case
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-05 14:27:36 +01:00
0280cff66f
Composer updated
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-04 16:31:16 +01:00
298b79410d
[tx-robot] updated from transifex
2018-01-04 09:48:31 +00:00
e9eccf34f9
removes invalid tests, adapts another one
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-03 21:44:30 +01:00
4d0315ceae
Merge pull request #7599 from nextcloud/quieter-debug-log
...
don't show recurring log msg when paged result was turned off
2018-01-03 00:40:46 +01:00
c8851e24a8
throw ServerNotAvailableException when LDAP is caught shutting down
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-02 12:20:44 +01:00
82fd09c294
don't show recurring msg when pages result was turned off
...
and only as debug level otherwise.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-21 14:29:56 +01:00
d2d73f1ce8
Also replace all other occurences
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-18 20:57:11 +01:00
5ce943aa85
don't use deprecated method for requesting memcache
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-12-18 20:57:11 +01:00
49b095b78e
Use proper authorative-autoloader for app autoloaders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-12-14 08:31:31 +01:00
Arthur Schiwon
Nextcloud bot
Joas Schilling
Morris Jobke
Vinicius Cubas Brand
Peter Kubica
Roeland Jago Douma
Roland Tapken
Julius Härtl
rakekniven
Filis Futsarov
Christoph Wurst
Daniel Kesselberg
Roeland Jago Douma
Stefan Weil
Jan-Christoph Borchardt
Roger Szabo
Daniel Calviño Sánchez