Roeland Jago Douma
2e6cab4d82
Move initialstate bootstrap to proper types classes
...
For more type safety
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:19:23 +01:00
Roeland Jago Douma
30e096f3f5
Allow overwriting isAuthenticated
...
* Some implementations might check for different things
* IT will not change how the current ones work
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:17:30 +01:00
Roeland Jago Douma
7198bed22d
Merge pull request #26018 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-03-09 08:54:53 +01:00
Nextcloud-PR-Bot
d49630e850
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-03-09 04:34:03 +00:00
Nextcloud bot
73bf04c2f5
[tx-robot] updated from transifex
2021-03-09 02:23:53 +00:00
Roeland Jago Douma
3e72d29f67
Merge pull request #26012 from nextcloud/dependabot/npm_and_yarn/elliptic-6.5.4
...
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 20:44:04 +01:00
dependabot-preview[bot]
95bddaf36f
[Security] Bump elliptic from 6.5.3 to 6.5.4
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-08 18:47:16 +00:00
Christoph Wurst
db1e117da7
Merge pull request #25839 from nextcloud/dependabot/composer/vimeo/psalm-4.6.2
...
Bump vimeo/psalm from 4.2.1 to 4.6.2
2021-03-08 19:42:32 +01:00
Roeland Jago Douma
bf5d5c57a3
Merge pull request #26005 from nextcloud/techdept/psalm/fix_invalid_check
...
Fix invalid check after constructing DateTime
2021-03-08 19:38:31 +01:00
Roeland Jago Douma
0c33fc706c
Merge pull request #26007 from nextcloud/docs/config/session_lifetime
...
Add hint about possible limit when setting a session_lifetime
2021-03-08 19:30:05 +01:00
Lukas Reschke
bb590347d2
Merge pull request #25996 from nextcloud/dependabot/composer/sabre/dav-4.1.5
...
Bump sabre/dav from 4.1.4 to 4.1.5
2021-03-08 17:19:35 +01:00
Julius Härtl
296332efa3
Add hint about possible limit when setting a session_lifetime
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-08 16:49:30 +01:00
Lukas Reschke
7ba89c13e7
Merge pull request #25960 from nextcloud/techdept/admin_audit
...
Pimp admin audit
2021-03-08 16:48:36 +01:00
Roeland Jago Douma
c38069fab3
Update baseline
...
The rest we will just fix as we go
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:34:15 +01:00
dependabot-preview[bot]
10ec495682
Bump vimeo/psalm from 4.2.1 to 4.6.2
...
Bumps [vimeo/psalm](https://github.com/vimeo/psalm ) from 4.2.1 to 4.6.2.
- [Release notes](https://github.com/vimeo/psalm/releases )
- [Commits](https://github.com/vimeo/psalm/compare/4.2.1...4.6.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 16:34:15 +01:00
Roeland Jago Douma
988b9f49c5
Fix invalid check after constructing DateTime
...
We construct an object. Either that works on not.But the result can't be
false.
Found by psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +01:00
Roeland Jago Douma
a63b709bed
Merge pull request #25910 from nextcloud/enh/allow_login_block
...
Allow admins to hide the login form
2021-03-08 16:27:47 +01:00
Roeland Jago Douma
4076dfb019
Allow admins to disable the login form
...
In case they want to not allow this because they use SSO (and do not
want the users to enter their credentials there by accident).
?direct=1 still works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 15:36:47 +01:00
Lukas Reschke
43b333331d
Merge pull request #25997 from nextcloud/techdept/psalm/redundantcast
...
Fix some redundant casts
2021-03-08 14:28:11 +01:00
dependabot-preview[bot]
c386e59446
Bump @nextcloud/vue-dashboard from 1.0.1 to 1.1.0
...
Bumps [@nextcloud/vue-dashboard](https://github.com/nextcloud/nextcloud-vue-dashboard ) from 1.0.1 to 1.1.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue-dashboard/releases )
- [Changelog](https://github.com/nextcloud/nextcloud-vue-dashboard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/nextcloud-vue-dashboard/compare/v1.0.1...v1.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-08 11:54:04 +00:00
Roeland Jago Douma
e44be839bb
Fix some types in the Settings Personal pages
...
* Fix types
* Typed the code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 11:05:41 +01:00
kesselb
2ddf3c9df0
Merge pull request #25990 from nextcloud/do-not-try-to-add-an-existing-user-again-in-acceptance-tests
...
Do not try to add an existing user again in acceptance tests
2021-03-08 10:18:46 +01:00
Christoph Wurst
1730f2ca3b
Bump sabre/dav from 4.1.4 to 4.1.5
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-08 10:16:07 +01:00
Roeland Jago Douma
615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore
...
Pimp ActionProviderStore
2021-03-08 09:20:45 +01:00
Roeland Jago Douma
109b84b025
Add return type to functions
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:56:53 +01:00
Roeland Jago Douma
43c8298dec
Merge pull request #25948 from nextcloud/techdebt/noid/depreate-getHTMLName
...
Deprecate getHTMLName on \OCP\Defaults
2021-03-08 08:54:42 +01:00
Roeland Jago Douma
f8c7ce5d48
Merge pull request #25975 from nextcloud/add-missing-waits-and-asserts-in-acceptance-tests
...
Add missing waits and asserts in acceptance tests
2021-03-08 08:52:08 +01:00
Roeland Jago Douma
69b26c73f3
Fix some redundant casts
...
Happier psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +01:00
Roeland Jago Douma
e148a151c1
Merge pull request #25988 from nextcloud/ci/fixup/action
...
Move fixup check to action
2021-03-08 07:18:24 +01:00
Nextcloud bot
e8f087d7d1
[tx-robot] updated from transifex
2021-03-08 02:23:08 +00:00
Roeland Jago Douma
da652ded26
Move fixup check to action
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-07 19:42:40 +01:00
Daniel Calviño Sánchez
c51c3c771f
Remove unneeded steps to add already existing user
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:34:10 +01:00
Daniel Calviño Sánchez
0e6401933b
Fix acceptance test for searching just added users in contacts menu
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests. As the test verifies that just added
users can be searched in the contacts menu a new user should be actually
added.
The test did not fail because it assumed that "user1" did not exist and
just checked that it existed after "adding" it, but not whether adding
it failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:27:45 +01:00
Nextcloud bot
c28542ef7f
[tx-robot] updated from transifex
2021-03-07 02:22:07 +00:00
dependabot-preview[bot]
5db40a37a1
Merge pull request #25966 from nextcloud/dependabot/npm_and_yarn/babel/plugin-proposal-class-properties-7.13.0
2021-03-06 09:52:03 +00:00
Roeland Jago Douma
e72f92b777
Merge pull request #25959 from nextcloud/techdept/logger/AccessibilityController
...
AccessibilityController to LoggerInterface
2021-03-06 10:51:34 +01:00
Roeland Jago Douma
28d963cd86
Merge pull request #25972 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-03-06 08:41:25 +01:00
Nextcloud-PR-Bot
a0ac2dd80c
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-03-06 04:33:39 +00:00
dependabot-preview[bot]
97d6609273
Merge pull request #25969 from nextcloud/dependabot/npm_and_yarn/chai-4.3.3
2021-03-06 03:07:49 +00:00
Nextcloud bot
41f9fdab1c
[tx-robot] updated from transifex
2021-03-06 02:22:22 +00:00
dependabot-preview[bot]
bb29621297
Bump chai from 4.3.0 to 4.3.3
...
Bumps [chai](https://github.com/chaijs/chai ) from 4.3.0 to 4.3.3.
- [Release notes](https://github.com/chaijs/chai/releases )
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md )
- [Commits](https://github.com/chaijs/chai/compare/4.3.0...4.3.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-06 02:21:11 +00:00
dependabot-preview[bot]
3b29c4b320
Bump @babel/plugin-proposal-class-properties from 7.12.13 to 7.13.0
...
Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-proposal-class-properties ) from 7.12.13 to 7.13.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.13.0/packages/babel-plugin-proposal-class-properties )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-06 02:17:12 +00:00
Daniel Calviño Sánchez
ee1f8104a0
Find directly the label instead of falling back to it
...
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez
7b6946d2d2
Assert also element visibility instead of just finding it
...
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez
78faf0105d
Add explicit locator for "Enable all" bundle button
...
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez
f87473e410
Find elements through the actor rather than the driver
...
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
Daniel Calviño Sánchez
6d145ea54a
Add locator for apps list
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +01:00
Daniel Calviño Sánchez
4c23d24277
Fix identation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +01:00
Daniel Calviño Sánchez
bc084070c8
Fix delete user acceptance test
...
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.
The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:29:54 +01:00
Daniel Calviño Sánchez
d5586ec437
Verify WaitFor::element... results with an assertion
...
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +01:00