fe2cbc3795
Merge pull request #15744 from owncloud/fix-inverted-path-in-resourcenotfound
...
Fix wrong path generation
2015-04-20 16:55:36 +02:00
9bc48451b9
Adjust tests and statuscode
2015-04-20 13:00:02 +02:00
21f0476d31
Fix files
2015-04-20 13:00:02 +02:00
20a6073a9f
Migrate personal certificate handling into AppFramework controllers
...
Also added unit-tests and better error-handling
2015-04-20 12:58:58 +02:00
9f61cf60d4
Verify if returned object is an array
...
The error has to be thrown at this point as otherwise errors and notices are thrown since the time cannot be parsed in L60 and L61
2015-04-20 12:58:57 +02:00
ed0b465cf9
Use 403 instead a 50x response
2015-04-20 12:53:40 +02:00
ddcd79132d
Add tests for correct path
2015-04-20 12:31:35 +02:00
0cf13e9b78
Fix phpStorm complains and namespace
2015-04-20 12:31:07 +02:00
4ea205e262
Block old legacy clients
...
This Pull Request introduces a SabreDAV plugin that will block all older clients than 1.6.1 to connect and sync with the ownCloud instance.
This has multiple reasons:
1. Old ownCloud client versions before 1.6.0 are not properly working with sticky cookies for load balancers and thus generating sessions en masse
2. Old ownCloud client versions tend to be horrible buggy
In some cases we had in 80minutes about 10'000 sessions created by a single user. While this change set does not really "fix" the problem as 3rdparty legacy clients are affected as well, it is a good work-around and hopefully should force users to update their client
2015-04-20 11:12:17 +02:00
8f51efc49e
get rid of OC_Geo
2015-04-19 20:16:56 +02:00
758b2332f0
Use data provider instead of hand-crafted for loops
...
* reduces scrutinizer complains
* uses PHPUnit functionality
2015-04-18 15:19:33 +02:00
7d4b1b52d0
always create a new instance of the encryption module
2015-04-17 10:31:33 +02:00
b25c06f576
detect system wide mount points correctly
2015-04-16 14:15:04 +02:00
e3d77c4b01
add migration script from old encryption to new one
2015-04-16 14:15:04 +02:00
903d52d45f
Merge pull request #15809 from owncloud/view-null-root
...
dont allow using null as view root
2015-04-22 18:10:26 +02:00
e302213248
add unit tests for null handling in view
2015-04-22 16:24:25 +02:00
225cde2183
pass KeyStorage via ctor
2015-04-22 13:09:42 +02:00
987bc138df
calling renameKeys() on directory level as well - fixes #15778
2015-04-22 12:12:27 +02:00
fc4127dd62
add $encryptionModuleId to methods of Keys/IStorage
2015-04-22 11:53:05 +02:00
e33e5b425a
Merge pull request #12006 from owncloud/dav-put-storage
...
Work directly on the storage when uploading over webdav
2015-04-15 03:08:52 +02:00
1aa368effe
Merge pull request #15592 from owncloud/fix-15590-master
...
Avoid php message "Invalid argument supplied for foreach()"
2015-04-15 00:14:08 +02:00
4f0437fbde
Merge pull request #15598 from owncloud/fix-enc-file-size-master
...
Fix file size of encrypted files
2015-04-14 16:48:04 +02:00
717723b83e
Remove unneeded comments
2015-04-14 16:44:24 +02:00
308af8b909
pass a stream to the tests
2015-04-14 15:25:52 +02:00
82cab25762
Merge pull request #13360 from owncloud/cross-storage-move
...
Proper copy/move between multiple local storages
2015-04-14 14:35:08 +02:00
cbe30f740e
remove calculateUnencryptedSize() - not needed
2015-04-14 13:08:59 +02:00
88cc52c408
Avoid php message "Invalid argument supplied for foreach()" - refs #15590
2015-04-14 11:00:20 +02:00
5f66f867b6
Merge pull request #15581 from owncloud/deduplicate-oc-repair-namespace
...
Fix namespace duplication and other issues in repairlegacystorages
2015-04-13 21:51:38 +02:00
01da6be4d6
upda tests
2015-04-13 17:10:02 +02:00
d7b3a1a35a
preserve cache data when doing a cross storage move
2015-04-13 17:10:01 +02:00
71de1d58cd
Fix namespace duplication and other issues in repairlegacystorages
2015-04-13 16:34:10 +02:00
0772e3b4c1
Properly handle copy/move failures in cross storage copy/move
2015-04-13 15:13:03 +02:00
31e94708f8
Improve cross storage copy between local storages
2015-04-13 15:13:02 +02:00
2822d0579e
Properly add trailing slash to mount point
...
Fixes resolving mount points when shared mount point's target name has
the same prefix as the source name
2015-04-13 12:36:47 +02:00
906b6b7337
Prevent php message: "Trying to get property of non-object at /xxx/lib/private/ocsclient.php#282"
2015-04-13 09:43:45 +02:00
84041a4fa2
Merge pull request #15541 from owncloud/add-reply-to-support
...
Add "Reply-To" support for sharing mails as well as refactor code and add unit-tests
2015-04-12 22:30:35 +02:00
e3ad99d252
Add "Reply-To" support to sharing mails and refactor code
2015-04-10 17:30:07 +02:00
fafecd1c05
fix cherrypicking
2015-04-10 11:08:24 +02:00
a85bc5538f
fix filesystem and encryption tests
...
Conflicts:
apps/files_encryption/lib/util.php
apps/files_encryption/tests/hooks.php
2015-04-10 09:12:37 +02:00
5abbf6d5b0
Merge pull request #13920 from owncloud/sharing_no_user_entry_for_group_shares
...
only create a db entry for the user in case of a name conflict on group share
2015-04-09 23:37:02 +02:00
0bad8f644a
Merge pull request #15511 from owncloud/fix-typos
...
Fix typos and some other adjustments
2015-04-09 19:23:27 +02:00
06a5a9d0c2
Fix mock object to return proper type
2015-04-09 18:30:45 +02:00
11c3741526
Fix mock object to return proper type
2015-04-09 17:45:57 +02:00
cbcee34eb0
update tests
2015-04-09 14:46:25 +02:00
1d9bd3d31e
Merge pull request #15496 from owncloud/enc-check-if-key-exists-before-deleting
...
Check if the key exists, before trying to delete it
2015-04-09 14:45:40 +02:00
332ea77865
only create a db entry for the user in case of a name conflict on group share
2015-04-09 11:16:08 +02:00
45575d0135
Check if the key exists, before trying to delete it
2015-04-09 10:28:02 +02:00
ba52f6f8fc
Merge pull request #15314 from owncloud/app-categories-15274
...
Add different trust levels to AppStore interface
2015-04-09 10:07:32 +02:00
9c76d068c3
Merge pull request #15196 from owncloud/limit-file-activities-to-favorites
...
Limit file activities to favorites
2015-04-09 00:18:31 +02:00
103d451459
Merge pull request #14987 from rullzer/ocs_password_fix2
...
OCS Fixes to allow setting of password without removing additional settings
2015-04-08 14:44:17 +02:00
f8cfc03f36
Replace originalStorage in tests with a proper teardown
...
The purpose of $originalStorage in unit tests was to remount the old
root.
However that storage itself is already wrapped by storage wrapper, so
remounting it would rewrap the storage several times.
This fix makes use of "loginAsUser()" and "logout()" from the TestCase
class to properly initialize and cleanup the FS as expected.
2015-04-08 12:45:38 +02:00
6c327f8331
Merge pull request #14879 from oparoz/fix-preview-caching
...
Introducing the maximum size preview
2015-04-07 18:16:24 +02:00
1fbf5d86df
Merge pull request #14472 from owncloud/feature/wipencryptionapp
...
encryption 2.0 app
2015-04-07 16:46:45 +02:00
74bf9806b0
Introducing the maximum size preview
...
The first time we're asked to generate a preview we'll generate one of the maximum dimension indicated in the configuration and all future resizing requests will be done on that preview in order to not waste time converting the same file over and over.
One of the fixes required for #12465
2015-04-07 16:45:59 +02:00
2d2cb09715
fixing unit test - expected value change due to different size being stored in cache table
2015-04-07 14:30:01 +02:00
6cc3fd9270
Merge pull request #15426 from owncloud/issue/15420-remove-hardcoded-docs-link
...
Remove hardcoded link to performance docs
2015-04-07 13:47:35 +02:00
54a3bdf1c5
fixing unit test execution related to trashbin
2015-04-07 13:30:31 +02:00
268d346b36
fixing unit tests
2015-04-07 13:30:31 +02:00
fce42a3161
fixing unit test execution - test dummy module was behaving wrong
2015-04-07 13:30:31 +02:00
870c53ee37
fixing unit test execution
2015-04-07 13:30:31 +02:00
3d7404fe68
add unit tests to the keystorage
2015-04-07 13:30:31 +02:00
fe74a0cb4f
implement webdav copy
2015-04-07 13:30:31 +02:00
3e3226da4c
Properly set size and unencrypted size in the stream unit tests
2015-04-07 13:30:31 +02:00
b3c5ef3afe
Adding unit test for read and write of big file
2015-04-07 13:30:31 +02:00
104d11ec4c
Fixing encryption storage wrapper tests
2015-04-07 13:30:30 +02:00
e8e5bd61ae
fixing unit tests for encryption stream wrapper seek
2015-04-07 13:30:30 +02:00
8ffa6db110
fixing unit tests for stream wrapper
2015-04-07 13:30:30 +02:00
e0ab2c34ea
update unit tests after ctor signature change of \OC\Encryption\Util
2015-04-07 13:30:28 +02:00
1b42b492dc
kill OC_FileProxy 💥
2015-04-07 13:30:28 +02:00
dbdd754c3f
Further cleanup of files_encryption
2015-04-07 13:30:28 +02:00
00338f9dca
Removing files_encryption left overs
2015-04-07 13:30:28 +02:00
0eee3a2618
remove unencrypted_size from the cache, size will contain the unencrypted size
2015-04-07 13:30:28 +02:00
498625ea3a
adding unit tests for stream wrapper
2015-04-07 13:30:28 +02:00
a905f641b3
various fixes & start to unit test the encryption storage wrapper
2015-04-07 13:30:28 +02:00
4aa125cc0a
fix unit test execution
2015-04-07 13:30:28 +02:00
8dde932546
Comment duplicate test methods
2015-04-07 13:30:27 +02:00
7ffd77fac9
enable encryption unit test execution
2015-04-07 13:30:27 +02:00
e2f714263f
fix encryption manager to handle more than one encryption module
2015-04-07 13:30:27 +02:00
39733c8da1
Initial commit
2015-04-07 13:30:27 +02:00
81ec1c8a1a
Remove hardcoded link to performance docs
2015-04-07 12:25:30 +02:00
0fcd273714
Select the timezone on the right timestamp and assert it
2015-04-07 10:13:51 +02:00
25531bad88
Make user names clickable
2015-04-03 13:36:03 +02:00
0816cf9142
Add experimental applications switch
...
Allows administrators to disable or enabled experimental applications as well as show the trust level.
2015-04-03 13:21:24 +02:00
70ec74e88b
Introducing media types for yml, yaml, cnf, conf
2015-04-02 21:37:57 +02:00
aa6573cf54
Adjust tests and check whether clear() is called
2015-04-01 17:19:44 +02:00
730efe25a4
Make scrutinizer happy
2015-04-01 12:13:49 +02:00
5c9998179f
Properly quote file names in listFiles query for GDrive
2015-03-31 15:14:03 +02:00
53f67fc65d
Revert "Properly quote file names in listFiles query for GDrive"
2015-03-31 15:12:35 +02:00
b216b3fad0
Merge pull request #15215 from owncloud/ext-gdrivelistfilequoting
...
Properly quote file names in listFiles query for GDrive
2015-03-31 09:08:59 -04:00
3b1f0e6019
Fix unit test
2015-03-30 21:18:24 +02:00
bf17ac929d
Merge pull request #15169 from rullzer/fix_displayNamesInGroup
...
Groupmanagers displayNamesInGroup should actually search in displaynames
2015-03-30 17:04:09 +02:00
dd535968e8
Add tests from getCurrentUserId() method and fix the constructor
2015-03-30 15:23:10 +02:00
b0aa17b13f
OCS Fixes to allow setting of password without removing additional settings
...
- Added setPassword to share.php
- Fixed OCS API call
- Added unit tests
2015-03-30 14:00:50 +02:00
65202d2a18
Add check for activated local memcache
...
Also used the opportunity to refactor it into an AppFramework controller so that we can unit test it.
Fixes https://github.com/owncloud/core/issues/14956
2015-03-28 13:59:22 +01:00
1511a42da7
Check for relative datadirectory path
2015-03-27 23:29:46 +00:00
f4dc9e6bf3
Merge pull request #15155 from owncloud/share-donotreturntrashedfiles
...
Do not return shares for files outside "files"
2015-03-27 17:05:14 +01:00
4d12c4a38b
Merge pull request #13938 from owncloud/deprecate-iappconfig
...
Deprecated \OCP\IAppConfig - add missing methods to IConfig
2015-03-27 16:07:41 +01:00
23cb8112fc
Add logout in share test to avoid nasty side effects
2015-03-27 15:54:29 +01:00
722e50a112
Merge pull request #15240 from owncloud/storage-wrapper-priority
...
add priority to storage wrappers
2015-03-27 15:18:44 +01:00
5db932d1e4
Merge pull request #15261 from owncloud/fix-14268-master
...
use StreamResponse to download the log file
2015-03-27 15:07:50 +01:00
98bc1ad70a
Merge pull request #15265 from owncloud/enc2_fixes
...
core improvements for Encryption 2.0
2015-03-27 14:58:33 +01:00
80f83ab5e0
Do not return shares for files outside "files"
2015-03-27 13:25:23 +01:00
7ad4dfa201
Merge pull request #15227 from owncloud/ocetag-header
...
Copy Etag header to OC-Etag for sabre calls
2015-03-27 13:10:27 +01:00
c6be1ba8d3
fix check if a file is excluded from encryption or not
2015-03-27 11:51:50 +01:00
b5545932e7
use StreamResponse to download the log file - fixes #14268
2015-03-27 11:30:32 +01:00
fb8994603b
Merge pull request #15252 from owncloud/prevent-directory-characters-in-temporary-path
...
Filter potential dangerous characters in path name
2015-03-27 01:19:55 +01:00
f72939df91
Merge pull request #15255 from owncloud/test-namespacesforrepairtests
...
Fix namespace for repair step tests
2015-03-27 00:16:47 +01:00
cf2fd2a825
Fix namespace for repair step tests
2015-03-26 23:19:27 +01:00
9622fbdf29
Filter potential dangerous characters in path name
...
We should not allow / or \ in the postfix here.
2015-03-26 23:17:18 +01:00
746be98e03
Merge pull request #13654 from oparoz/tmpfile-with-extension
...
Keep the extension in temp files
2015-03-26 23:08:08 +01:00
e8109f0bc3
Merge pull request #13802 from owncloud/share-partfilepermissions
...
Fix share permission checks
2015-03-26 22:01:05 +01:00
cb9ead7dde
add priority to storage wrappers
2015-03-26 21:26:38 +01:00
232518ac54
Merge pull request #15234 from owncloud/encryption2_core
...
core part of encryption 2.0
2015-03-26 21:14:59 +01:00
ff9c85ce60
implement basic encryption functionallity in core to enable multiple encryption modules
2015-03-26 20:56:51 +01:00
74a9fc29b4
Merge pull request #14399 from owncloud/ignore-empty-plurals
...
Ignore empty plurals just like with singulars
2015-03-26 20:15:33 +01:00
c8c722bc6d
Merge pull request #15129 from owncloud/version-command-bus
...
expire versions in a background command
2015-03-26 19:55:13 +01:00
70e64822b9
Merge pull request #14665 from owncloud/fileid-increment
...
SQLite autoincrement test
2015-03-26 19:36:18 +01:00
ddd6a67d2a
Handle exceptions thrown during hooks when running unit tests
2015-03-26 17:07:02 +01:00
3ed6ed3c36
Force test cases using background commands to handle setting up the filesystem
2015-03-26 17:07:02 +01:00
70acd58336
Copy Etag header to OC-Etag for sabre calls
2015-03-26 16:06:43 +01:00
daceb1a9ac
Revert "adding unit tests"
...
This reverts commit 8d327c94a8
2015-03-26 15:04:36 +01:00
cda7f7fd61
Merge pull request #15168 from owncloud/oc-etag-master
...
adding OC-ETag header
2015-03-26 13:52:43 +01:00
43588fe2f7
Properly quote file names in listFiles query for GDrive
2015-03-26 12:15:02 +01:00
f056558b72
Add repair step to fix SQLite autoincrement
...
Force Doctrine to generate alter table SQL statements for SQLite to make
sure the code from OCSqlitePlatform is triggered.
2015-03-26 11:00:22 +01:00
8d327c94a8
adding unit tests
2015-03-26 10:49:26 +01:00
ec2d7cff2f
SQLite autoincrement test
2015-03-25 18:33:21 +01:00
5f044ebf1b
Add wrapper for Guzzle
2015-03-25 16:04:41 +01:00
b1c513f000
Fix unit tests
...
Altough more are required to make sure this does not happen again
2015-03-24 21:42:40 +01:00
5a9c9b86f8
Merge pull request #15153 from owncloud/uniquename-node
...
Add `getNonExistingName()` to the node api
2015-03-24 15:51:12 +01:00
d11f01fa0f
Add `getNonExistingName()` to the node api
2015-03-24 15:00:36 +01:00
92791bb8ba
Merge pull request #15126 from owncloud/sabre-storagenotavailable
...
Soft fail in CustomPropertiesBackend whenever storage not available
2015-03-24 14:01:47 +01:00
eb894e6625
Soft fail in CustomPropertiesBackend whenever storage not available
...
When a storage is not available, it will not fail the whole call any
more but still return a usable file list.
2015-03-23 17:41:32 +01:00
1686653fdd
The iran timezone removed the DST handling which breaks the timezone lib
2015-03-23 14:08:47 +01:00
f3fe46685b
Introducing 3D images support (media type)
...
So that people with 3D images can at least see a 2D picture
Full 3D support is possible via an app
2015-03-20 22:11:42 +01:00
afa8872955
Merge pull request #14857 from owncloud/preview-provider-registration-in-manager
...
Preview provider registration in manager
2015-03-20 16:34:22 +01:00
e44ab2dcfe
Merge pull request #11884 from owncloud/ext-appframework
...
Cleanup ext storage CRUD code, introduce storage config id
2015-03-20 14:17:32 +01:00
a87cc90d1e
Merge pull request #14993 from owncloud/stop-on-missing-deps
...
Stop executing, when 3rdparty is missing or apps directory is invalid
2015-03-20 11:36:02 +01:00
eef5851a67
Fix share permission related unit tests
2015-03-20 11:30:51 +01:00
1de6fa19de
Merge pull request #15035 from owncloud/assocmapper
...
If the execute method on the mapper receives an assoc array, it binds by...
2015-03-20 08:53:14 +01:00
2a8c3798a8
Merge pull request #14947 from oparoz/repairmimetypes-sql
...
Make repairmimetypes compatible with case sensitive SQL backends
2015-03-19 17:22:25 +01:00
df24a014b8
If the execute method on the mapper receives an assoc array, it binds by value instead of index
2015-03-19 17:08:46 +01:00
857b22c61b
Merge pull request #15025 from rullzer/ocs_respect_enforced_date
...
Ocs respect enforced date
2015-03-19 17:06:04 +01:00
73874ca27f
Merge pull request #14704 from owncloud/storage-wrapper-mount
...
pass mountpoint to storage wrapper callback
2015-03-19 16:20:38 +01:00
f890c3ffb1
Make the method compatible with all types of extensions
...
Fix existing tests
2015-03-19 16:09:16 +01:00
0868e49663
Merge pull request #14980 from owncloud/fix-fileglobalgc
...
Fix fileglobalgc unlink parameter warnings
2015-03-19 14:17:20 +01:00
dd3307dd19
Added unit test
...
Tests added to make sure that removing an expire date when this is
enforced is not allowed.
2015-03-19 10:47:09 +01:00
4a13a84cab
Do not add apps2/ directory if it does not exist
2015-03-19 09:07:29 +01:00
fe8002a7db
Merge pull request #14995 from owncloud/remove-unrequired-backtick-removal
...
Remove unrequired backtick removal
2015-03-18 19:34:49 +01:00
693ca9a92f
Add unit tests for gc() for \OC\Cache\FileGlobalGC
2015-03-18 16:19:04 +00:00
f2f7f178a5
Add test for backticks in path and etag
2015-03-18 13:29:39 +01:00
50194c31b4
Soft fail in custom properties backend
...
This makes it possible for clients to still receive a file list (minus
the broken files) instead of getting no list at all
2015-03-18 12:36:37 +01:00
c69cd28a73
Merge pull request #14968 from owncloud/files-reallowsinglequote
...
Reallow single quote in file names
2015-03-17 23:50:16 +01:00
e50f13d46b
Add positive test for path verification
2015-03-17 18:17:30 +01:00
fbea83d4eb
fix failing unit test
2015-03-17 17:26:03 +01:00
bd91546db8
Adding test cases where the extension is using capital letters
2015-03-17 13:25:39 +01:00
9e2ebf2dce
Cache \OC\URLGenerator::imagePath
...
\OC\URLGenerator::imagePath is a really expensive operation due to all the I/O handling and can really benefit from caching.
2015-03-17 12:35:47 +01:00
98a42dbccc
Merge pull request #14927 from oparoz/raw-mimetypes
...
Introducing the Raw media types
2015-03-17 11:32:09 +01:00
e4c6b0abf5
Merge pull request #14931 from owncloud/issue/14881-closures-for-navigation-entries
...
Issue/14881 closures for navigation entries
2015-03-17 11:28:27 +01:00
b1c19f74a1
Merge pull request #12085 from owncloud/add-swift-mailer
...
Migrate OC_Mail to SwiftMailer
2015-03-17 11:15:39 +01:00
ec1d5011b6
Add tests for the navigation manager (closure) behaviour
2015-03-16 16:46:17 +01:00
bef12488c3
Introducing the Raw mimetypes
2015-03-16 16:25:04 +01:00
7ab919256b
fix test
2015-03-16 14:13:56 +01:00
d7c7808a5e
Add debug log message back
2015-03-16 13:01:17 +01:00
e32f1582c7
Show more detailed error message
2015-03-16 12:47:06 +01:00
dfd70337d6
Adjust unit test
2015-03-16 12:47:05 +01:00
f92f3a1a6e
Incorporate review changes
2015-03-16 12:47:05 +01:00
283476a2f7
Use new IMailer and add unit-tests for lostcontroller
2015-03-16 12:47:05 +01:00
13486a5ada
Migrate to SwiftMail
...
Replaces the OC_Mail and phpmailer with SwiftMail allowing us to mock it properly.
Fixes the unit test execution on master on local machines and https://github.com/owncloud/core/issues/12014
Conflicts:
3rdparty
lib/private/server.php
lib/public/iservercontainer.php
tests/lib/mail.php
tests/settings/controller/mailsettingscontrollertest.php
Conflicts:
3rdparty
lib/private/mail.php
lib/private/server.php
lib/public/iservercontainer.php
settings/ajax/lostpassword.php
settings/application.php
2015-03-16 12:47:05 +01:00
8ed27d2ce0
Create an interface for OC_Image and OCP\Image for the public API
2015-03-16 12:45:15 +01:00
1075914f8a
Merge pull request #14883 from owncloud/imagepng_expects_resource_issue
...
validate resource's integrity before using it
2015-03-16 12:22:27 +01:00
09b05373ed
validate resource's integrity before using it
2015-03-16 10:57:01 +01:00
997a7a2668
Merge pull request #14766 from owncloud/fix-insertifnotexists-poc
...
Allow specifying the compare-array for insertIfNotExists()
2015-03-16 10:31:36 +01:00
bbaf97ca43
Merge pull request #14644 from owncloud/trash-expire-command
...
Expire files from the trash in the background
2015-03-16 10:04:05 +01:00
6927773648
Merge pull request #14776 from owncloud/fix-14629-master
...
verify the file name length not to exceed 255 characters + verify path d...
2015-03-16 09:58:41 +01:00
b159c7f274
Merge pull request #14848 from owncloud/kill-curl-fallback-master
...
drop any fallback code related to curl
2015-03-16 09:56:31 +01:00
30357aaac0
No user no avatar easy as that
2015-03-13 17:35:34 +01:00
61ec37431a
Fix order of expected and actual on assertEquals() calls
2015-03-13 15:29:52 +01:00
8304f5f508
Fix getting the avatar of a non-existing user
2015-03-13 15:29:52 +01:00
5855108e9b
drop any fallback code related to curl - refs https://github.com/owncloud/core/pull/14838#issuecomment-78586447
2015-03-12 21:43:41 +01:00
ce94a998dd
Use storage id + appframework for ext storage CRUD
...
- Added StorageConfig class to replace ugly arrays
- Implemented StorageService and StorageController for Global and User
storages
- Async status checking for storages (from Xenopathic)
- Auto-generate id for external storage configs (not the same as
storage_id)
- Refactor JS classes for external storage settings, this mostly
moves/encapsulated existing global event handlers into the
MountConfigListView class.
- Added some JS unit tests for the external storage UI
2015-03-12 18:51:02 +01:00
80ef53eff0
verify the file name length not to exceed 255 characters + verify path during rename
2015-03-12 10:47:47 +01:00
3560b32dfc
Fix the avatarcontroller cache needing the cache dir
...
This was removed in 82254ad5ef
2015-03-11 18:18:33 +01:00
f9fd1629da
Merge pull request #14705 from rullzer/avatarcontroller
...
Move AvatarController to AppFramework
2015-03-11 17:15:42 +01:00
1a0f9c375b
Avatar controller moved to AppFrameWork
...
* Original avatarcontroller migrated to the appframework
* Added DataDisplayResponse that show data inline in the browser (used
to retrun the image)
* Removed some unneeded code
* Added unit tests for the avatarcontroller
2015-03-11 16:37:42 +01:00
169031d1c5
fix factory test
2015-03-11 15:07:59 +01:00
e1f2a6df94
Allow setting the watcher policy as mount option
2015-03-11 15:07:23 +01:00
7adda88786
Copy mount options to the storage
2015-03-11 15:06:48 +01:00
82a62fd249
Add test for storage factory
2015-03-11 15:06:12 +01:00
dbade19362
Merge pull request #13839 from owncloud/issue/13678-improve-remote-domain-detection-in-sharedropdown
...
Better finding the remote URL from user input in share dropdown
2015-03-11 14:38:41 +01:00
ad97ceb787
Merge pull request #13513 from owncloud/repair-legacystoragenofatalfail
...
Do not abort when meeting unfixable legacy storages
2015-03-11 13:32:33 +01:00
8154ed4d2c
Merge pull request #14791 from owncloud/fix-14516
...
Adding a more meaningful message for sabre dav exception
2015-03-11 12:52:18 +01:00
0f3e36fdfd
Adding a more meaningful message for sabre dav exception - fixes #14516
2015-03-11 11:53:31 +01:00
6c1a1234f8
Properly handle available databases at runtime and respect setup checks in command line as well
2015-03-11 09:27:12 +01:00
6dc59019af
Merge pull request #14346 from owncloud/storage-based-path-validation
...
adding storage specific filename verification
2015-03-10 11:02:47 +01:00
214fa44400
Merge pull request #14534 from owncloud/add-child-src
...
Add support for 'child-src' directive
2015-03-10 10:30:44 +01:00
87431605b8
Add test for UniqueConstraintViolationException on wrong key
2015-03-10 09:26:45 +01:00
c8ed88f4d6
Merge pull request #14689 from owncloud/better-missing-resource-handling
...
Log errors and create 404 in network list when a css or js is missing
2015-03-09 23:33:25 +01:00
89be55a672
let insertIfNotExist() throw the native DBALException - no need to hide the real exception
2015-03-09 22:37:49 +01:00
b966a4eb17
Adding unit test which shows insertIfNotExists to fall apart in certain situations
2015-03-09 22:37:49 +01:00
d34662122d
Merge pull request #14429 from owncloud/issue/14176-validate-timezone-before-using
...
Etc timezones don't exist for .5 and .75 offsets
2015-03-09 16:16:16 +01:00
3623f14e73
no translation service in common storage class
2015-03-09 10:38:38 +01:00
49e1a81eba
fixing namespaces and PHPDoc
2015-03-09 10:38:37 +01:00
4bac595068
adding storage specific filename verification - refs #13640
2015-03-09 10:38:37 +01:00
9f5433c0c3
Merge pull request #13368 from owncloud/memcache_lowlatency
...
Refactor \OC\Memcache\Factory
2015-03-05 13:05:17 +01:00
0e4933e6d2
Refactor \OC\Memcache\Factory
...
Caches divided up into two groups: distributed and local. 'Low latency' is an
alias for local caches, while the standard `create()` call tries to get
distributed caches first, then local caches.
Memcache backend is set in `config.php`, with the keys `memcache.local` and
`memcache.distributed`. If not set, `memcache.distributed` defaults to the value
of `memcache.local`.
2015-03-05 11:36:34 +00:00
716ba49a82
Log errors and create 404 in network list when a css or js is missing
2015-03-04 17:56:33 +01:00
294724b5da
Add a test for ObjectStore\NoopScanner
2015-03-04 11:48:31 +01:00
f1d74e8803
Merge pull request #14651 from owncloud/add-some-headers-to-htaccess-for-my-best-friend-jenkins
...
Let users configure security headers in their Webserver
2015-03-04 09:36:01 +01:00
e12c83e3dc
Merge pull request #14674 from owncloud/fix-l10n-getlanguagecode-2
...
Jenkins #14650
2015-03-03 18:33:08 +01:00
5fc004f8ea
Add a test of what everyone thinks should be the result of this method
2015-03-03 16:47:31 +01:00
be27188649
Merge pull request #14574 from owncloud/fix-irequest-for-older-php-versions
...
Read from IRequest instead of reading twice
2015-03-03 14:22:56 +01:00
e30ca8198f
Merge pull request #14638 from owncloud/issue/14538-repairstep-drop-old-tables
...
Add a repair step to delete old tables
2015-03-03 13:37:54 +01:00
8df4077dd7
Add a test for dropping the tables
2015-03-03 11:27:06 +01:00
276d678080
Etc timezones don't exist for .5 and .75 offsets
2015-03-03 09:08:47 +01:00
d620fc8798
Merge pull request #14615 from kampka/cron-command
...
Allow configuring background job mode from the console
2015-03-02 21:35:57 +01:00
83e0f84fef
Allow configuring background job mode from the console
2015-03-02 20:51:40 +01:00
bbd5f28415
Let users configure security headers in their Webserver
...
Doing this in the PHP code is not the right approach for multiple reasons:
1. A bug in the PHP code prevents them from being added to the response.
2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud)
3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations.
This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
2015-03-02 19:07:46 +01:00
00568af74d
Allow running the async commands from unit tests
2015-03-02 15:25:31 +01:00
e61aa3723e
Merge pull request #14573 from owncloud/enc-migrate-disable-updater
...
Disable the cache updater when doing the encryption migration
2015-03-02 14:53:29 +01:00
b29940d956
Add support for 'child-src' directive
...
This is required when working with stuff such as PDF.js in the files_pdfviewer application. Opt-in only.
Master change only because the stable CSP policies has a failback that allows nearly anything 🙈
2015-02-28 12:27:46 +01:00
d0c6af2cb5
Disable bootstrap.php checks when HHVM is used
2015-02-28 10:11:12 +01:00
89735ab22b
add some tests for disabled updater
2015-02-27 17:14:17 +01:00
b4dfd043d7
Merge pull request #14575 from owncloud/cache-rename-overwrite
...
Fix cache update when doing a rename that overwrites the target
2015-02-27 17:11:37 +01:00
fc027bceb7
Fix cache update when doing a rename that overwrites the target
2015-02-27 16:39:58 +01:00
970b14d297
Merge pull request #13616 from owncloud/streamresponse
...
AppFramework StreamResponse
2015-02-27 15:43:01 +01:00
95239ad21e
AppFramework StreamResponse
...
First stab at the StreamResponse, see #12988
The idea is to use an interface ICallbackResponse (I'm not 100% happy with the name yet, suggestions?) that allow the response to output things in its own way, for instance stream the file using readfile
Unittests are atm lacking, plan is to
check if a mock of ICallbackResponse will be used by calling its callback (also unhappy with this name) method
Usage is:
$response = new StreamResponse('path/to/file');
rename io to output, add additional methods and handle error and not modified cases when using StreamResponse
fix indention and uppercasing, also handle forbidden cases
fix indention
fix indention
no forbidden, figuring out if a file is really readable is too complicated to get to work across OSes and streams
remove useless import
remove useless import
fix intendation
2015-02-27 15:42:33 +01:00
5c2fafa05f
Read from IRequest instead of reading twice
...
Potentially fixes https://github.com/owncloud/core/issues/14541 and https://github.com/owncloud/core/issues/14506
2015-02-27 14:22:35 +01:00
1750e7b76d
Fixed expected warning count on repair fail
2015-02-27 13:32:46 +01:00
32c9139ac2
Detect that the done flag was not set after repair fail
2015-02-27 13:16:38 +01:00
e6abe96374
Do not abort when meeting unfixable legacy storages
2015-02-27 12:03:22 +01:00
7fe07e93fe
Merge pull request #14437 from owncloud/node-check-fileinfo
...
Check if we have a proper fileinfo
2015-02-27 02:56:13 -08:00
1c6857d92c
Merge pull request #14529 from owncloud/intuitive-version-check
...
Make version check work on the lowest common version denominator
2015-02-27 02:16:23 -08:00
9baf758150
Merge pull request #14503 from owncloud/quota-preventdatalossforfailedmove
...
Fix file move/copy when storage space is not enough
2015-02-26 16:35:13 +01:00
232de3bdc0
Delete target file for unsuccessful copy/rename
2015-02-26 15:11:37 +01:00
0c1e6fad6c
Merge pull request #14300 from owncloud/commandbus
...
Add async command system to handle asynchronous operations
2015-02-26 15:10:13 +01:00
541c8c092d
Add unit test
2015-02-26 12:20:20 +01:00
2987d4aec8
make version check work on the lowest common version denominator
2015-02-26 11:42:08 +01:00
adc986f3e4
Merge pull request #14502 from owncloud/failing-mysql-master-tests
...
Failing mysql master tests
2015-02-26 01:48:37 -08:00
59bbf27253
remove IDb interface from core class usage
2015-02-25 22:21:24 +01:00
f993ed823e
fix tabs and spaces
2015-02-25 22:21:24 +01:00
aaf753bc9a
fix mappertestutility
2015-02-25 22:21:24 +01:00
7b2fdbfb0b
use IDBConnection and close cursors after insert/update/delete
2015-02-25 22:21:24 +01:00
9ee37169a6
Return null when requesting tags for null user
...
The TagManager->load() now returns null if the user is not authenticated
instead of failing with an error.
2015-02-25 17:20:26 +01:00
20738d287e
Properly detect streamCopy errors
...
Now checking whether the written bytes match the number of read bytes.
2015-02-25 16:03:15 +01:00
993d89b3cc
Extend the class so the Filesystem is cleaned up
2015-02-25 16:03:10 +01:00
9873ab20af
prevent phpunit from messing with the bound $this
2015-02-25 15:09:41 +01:00
a39c7bf464
Add FileAccess trait for commands
2015-02-25 15:09:41 +01:00
74ae7b8929
Add async command system to handle asynchronous operations
2015-02-25 15:08:40 +01:00
a848a6b1dd
Cleanup garbage collection for global file cache
2015-02-25 14:13:58 +01:00
bcf3704645
Merge pull request #14458 from owncloud/revive/11157
...
Get the real protocol behind several proxies
2015-02-25 02:51:46 -08:00
799e144b04
Merge pull request #14151 from owncloud/update-sabre2.1
...
Sabre Update to 2.1
2015-02-25 02:21:55 -08:00
fb87b746f0
Merge pull request #14213 from AW-UC/naturalsort_defaultcollator-patch-file-sorting
...
Update naturalsort_defaultcollator.php. Fixes #13982
2015-02-25 10:30:14 +01:00
0066c6f001
Add PHPunit test for DefaultCollator
...
This extends Test_NaturalSort to include a basic test for
\OC\NaturalSort_DefaultCollator()
2015-02-24 23:51:08 +01:00
d43d34c93f
Merge pull request #14195 from owncloud/activity-manager-performance-improvements
...
Activity manager performance improvements
2015-02-24 15:19:15 +01:00
1c6eae9017
Get the real protocol behind several proxies
...
X-Forwarded-Proto contains a list of protocols if ownCloud is behind multiple reverse proxies.
This is a revival of https://github.com/owncloud/core/pull/11157 using the new IRequest public API.
2015-02-24 12:24:55 +01:00
bbf7f56f94
3rd-party apps are disabled on upgrade - refs #14026
2015-02-24 12:02:36 +01:00
e87ada86d1
Merge pull request #14416 from owncloud/setup-command
...
Setup command
2015-02-23 22:41:10 +01:00
9f6dcb9d3e
Sabre Update to 2.1
...
- VObject fixes for Sabre\VObject 3.3
- Remove VObject property workarounds
- Added prefetching for tags in sabre tags plugin
- Moved oc_properties logic to separate PropertyStorage backend (WIP)
- Fixed Sabre connector namespaces
- Improved files plugin to handle props on-demand
- Moved allowed props from server class to files plugin
- Fixed tags caching for files that are known to have no tags
(less queries)
- Added/fixed unit tests for Sabre FilesPlugin, TagsPlugin
- Replace OC\Connector\Sabre\Request with direct call to
httpRequest->setUrl()
- Fix exception detection in DAV client when using Sabre\DAV\Client
- Added setETag() on Node instead of using the static FileSystem
- Also preload tags/props when depth is infinity
2015-02-23 22:27:23 +01:00
66e3211fd8
Merge pull request #13439 from owncloud/app-filter
...
Make the search box filter apps
2015-02-23 21:51:53 +01:00
1fd1b355e4
Fix namespace of OC_Setup -> \OC\Setup
2015-02-23 16:44:40 +01:00
4290e1990e
Merge pull request #13829 from owncloud/appmanager-list
...
Better caching for enabled apps
2015-02-23 16:03:32 +01:00
e144d3aa49
Added unit test for app filter
2015-02-23 15:29:25 +01:00
b180724cd0
Extract the remote host from user input in share dropdown
...
Fix #13678
2015-02-23 11:28:41 +01:00
9aeeb2605b
Check for PHP configuration before executing unit tests
2015-02-21 11:51:52 +01:00
fcc5f5a4f4
Merge pull request #13777 from owncloud/close-cursor
...
Close cursor for appframework and manipulation queries if applicable
2015-02-20 20:15:22 +01:00
ae60108692
Revert "Correctly fallback to english, if the plural case is not translated"
...
This reverts commit cbad5c998b
2015-02-20 11:51:36 +01:00
41e5850450
Prevent directory traversals in ctr of \OC\Files\View
...
This prevents a misusage of \OC\Files\View by calling it with user-supplied input. In such cases an exception is now thrown.
2015-02-18 18:17:33 +01:00
8d09cc3b91
Merge pull request #13989 from owncloud/enhancment/security/11857
...
Allow AppFramework applications to specify a custom CSP header
2015-02-18 10:27:29 -05:00
5542fafd36
allow overwriting the appmanager in oc_util by subclassing
2015-02-18 14:24:50 +01:00
5d7d2adcbf
Merge pull request #14207 from owncloud/propfind-optimize
...
Optimize quota calculation for propfind
2015-02-18 00:18:47 +01:00
04628cf368
better name for getAppsEnabledForUser
2015-02-17 15:05:29 +01:00
4d805b52cc
Test improvements
2015-02-17 15:05:29 +01:00
886bda5f81
Refactor OC_Request into TrustedDomainHelper and IRequest
...
This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed.
This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions.
Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though.
Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969
2015-02-16 22:13:00 +01:00
4910f3e202
fixing unit tests in UsersControllerTest
2015-02-16 19:45:40 +01:00
9271059195
Merge pull request #13750 from owncloud/enhanced-code-checker
...
Implement php code checker to detect usage of not allowed private ...
2015-02-16 16:55:57 +01:00
8eb804b1f6
Merge pull request #13269 from owncloud/issue/13211-cache-array-implementation
...
Add an array implementation of cache and use it if we are not debugging
2015-02-16 15:35:20 +01:00
23ab25e93a
Use the app manager from oc_app
2015-02-16 15:16:13 +01:00
2b58e8489f
Add getInstalledApps and getAppsForUser to the app manager
2015-02-16 15:15:35 +01:00
8848b5f067
Add an array implementation of cache and use it if we are not debugging
2015-02-16 14:55:50 +01:00
a9d1a01440
Rename to allowEval
2015-02-16 12:30:21 +01:00
b20174bdad
Allow AppFramework applications to specify a custom CSP header
...
This change allows AppFramework applications to specify a custom CSP header for example when the default policy is too strict. Furthermore this allows us to partially migrate away from CSS and allowed eval() in our JavaScript components.
Legacy ownCloud components will still use the previous policy. Application developers can use this as following in their controllers:
```php
$response = new TemplateResponse('activity', 'list', []);
$cspHelper = new ContentSecurityPolicyHelper();
$cspHelper->addAllowedScriptDomain('www.owncloud.org');
$response->addHeader('Content-Security-Policy', $cspHelper->getPolicy());
return $response;
```
Fixes https://github.com/owncloud/core/issues/11857 which is a pre-requisite for https://github.com/owncloud/core/issues/13458 and https://github.com/owncloud/core/issues/11925
2015-02-16 11:00:41 +01:00
7bfe476030
add unit test for webdav quota
2015-02-13 18:00:01 +01:00
6ecfcde954
update test
2015-02-13 15:01:05 +01:00
134243d3e5
Dont lower the mtime of a folder when propagating changes
2015-02-13 14:30:05 +01:00
12fc625885
Fix test with the invalid filter check being added
2015-02-13 13:08:57 +01:00
bd5440a8a3
Merge pull request #13780 from owncloud/cmreflector-inheritance
...
Additional controllermethodreflector inheritance tests
2015-02-12 18:34:07 +01:00
fbbb9fe0fd
Merge pull request #13979 from owncloud/group-share-collition-wrong-type-in-post-hook
...
Do not overwrite the shareType so the post hook is still correct
2015-02-11 15:23:13 +01:00
d74662df7d
implement php code checker to detect usage of not allowed private APIs - including console command to check local code to be used by developers
2015-02-10 11:51:24 +01:00
c60dabd11b
Request requires a second parameter
2015-02-09 23:06:55 +01:00
5296767393
Merge pull request #13921 from owncloud/ocs-af
...
Add a controller and reponse for ocs
2015-02-09 18:11:47 +01:00
c17b236c19
Add a test for the post_shared hook shareType
2015-02-09 13:12:34 +01:00
770fa761b8
Respect `mod_unique_id` and refactor `OC_Request::getRequestId`
...
When `mod_unique_id` is enabled the ID generated by it will be used for logging. This allows for correlation of the Apache logs and the ownCloud logs.
Testplan:
- [ ] When `mod_unique_id` is enabled the request ID equals the one generated by `mod_unique_id`.
- [ ] When `mod_unique_id` is not available the request ID is a 20 character long random string
- [ ] The generated Id is stable over the lifespan of one request
Changeset looks a little bit larger since I had to adjust every unit test using the HTTP\Request class for proper DI.
Fixes https://github.com/owncloud/core/issues/13366
2015-02-09 11:53:11 +01:00
90556cb70b
Merge pull request #12283 from oparoz/sfnt-fonts
...
Updated the media type of some font types
2015-02-07 13:33:49 +01:00
485e2a282b
Merge pull request #13753 from owncloud/use-403-instead-of-200
...
Use 403 instead of 200 response
2015-02-07 13:25:15 +01:00
4d91fa4c93
Normalize before processing
2015-02-06 15:03:29 +01:00
9873aa3d9e
fix license email
2015-02-05 14:10:16 +01:00
b89ddcfe41
fix license email
2015-02-05 14:09:01 +01:00
fdc64e370c
add a controller and reponse for ocs
2015-02-05 14:02:17 +01:00
21c45925fe
detect root of mountpoint also if the trailing slash is missed
2015-02-04 12:47:04 +01:00
2426bd1b9d
Merge pull request #13811 from owncloud/default-to-null
...
Default to `null` for lostpassword
2015-02-02 11:41:14 +01:00
Lukas Reschke
Joas Schilling
Georg Ehrke
Morris Jobke
Bjoern Schiessle
Vincent Petry
Robin Appelman
Thomas Müller
Björn Schießle
Jörn Friedrich Dreyer
Olivier Paroz
Clark Tomlinson
Frank Karlitschek
Roeland Jago Douma
Robin McCorkell
Bernhard Posselt
Robin Appelman
Joas Schilling
Christian Kampka
Bernhard Posselt
AW-UC