fe21b10de5
replace setcookie value with '' instead of null.
...
The php documentation states that an empty string should be used for a cookie when it has no real value.
null leads to the following error: expects parameter 2 to be string, null given
Signed-off-by: Martin Böh <mart.b@outlook.de>
2018-09-06 20:34:16 +02:00
a9b8fb090c
Fix remnants of refactoring
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-07-05 17:09:38 +02:00
b0a296e2e1
Do not use HTTP code OC_Response constants anymore
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +02:00
79d9841bce
Replace hardcoded status headers with calls to http_response_code()
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 16:14:15 +02:00
1399f6bece
Server exception error pages by default with a 500 status code
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +02:00
8c155cd51c
Server error/hint pages with a 500 error code to avoid it being seen instead of the actual resource
...
* found while reviewing #7205
* allow to specify a special status code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-26 11:44:24 +02:00
a34f70ce0a
Change status code when config is write protected
...
Add hint msg, you can make config file read only
If the config.php is not writable, print an error message: #6893
- set config writable
- or set option to keep it read only
Signed-off-by: Eric Masseran <rico.masseran@gmail.com>
2018-06-26 09:36:17 +02:00
c79dc0e08f
Configurable list for opt out from same site cookie protection
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-06-06 22:13:35 +02:00
948ab8a4d0
Use APCu caching of composer
...
Should potentially shave of a few ms when loading classes of apps that
don't ship their own autoloader.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-05-10 12:35:56 +02:00
38a90130ce
move log constants to ILogger
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-26 10:45:52 +02:00
0d5142be70
Show a link to the docs instead of a button on the untrusted domain page
...
Before there was a button to "quickly" add the untrusted domain to the config. This button often didn't worked, because the generated URL was often untrusted as well. Thus removing it and providing proper docs seems to be the better approach to handle this rare case.
Also the log should not be spammed by messages for the untrusted domain accesses, because they are user related and not necessarily an administrative issue.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-04-17 17:47:11 +02:00
f5d3d3f72a
Allow usage of Windows 10 WebDav Netdrive
...
Fixes #3523
As long as we don't have #8123 lets not leave our Window10 netdrive
users hanging.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-05 13:16:29 +02:00
3dac15a891
Move calls to \OCP\JSON to private \OC_JSON
...
They should be properly fixed at some point.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 13:19:29 +01:00
044d01d0e1
Use proper method to log exceptions
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-12 18:10:59 +01:00
55b9a5d886
Remove OC_App::disable method
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
2018-03-06 10:45:20 +01:00
4a41e0cc42
getIncompatibleApps needs a string not an array
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-02-21 13:00:41 +01:00
1429146083
Merge pull request #8096 from nextcloud/feature/6382/do-not-cache-settings-in-db-anymore
...
Do not cache the settings/sections in the database anymore
2018-01-31 12:49:45 +01:00
f23ed5e0ea
Make sure we don't query the AppManager before the installation started
...
Otherwise we end up with the database not being instantiated
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-01-30 19:05:49 +01:00
d971b104ed
Do not cache the settings/sections in the database anymore
...
This caused more troubles then it had benefits, especially
when an app got disabled or was removed without being disabled.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-29 15:47:37 +01:00
eb51f06a3b
Use ::class statement instead of string
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-29 12:03:47 +01:00
a661f043e1
Remove unneeded semicolon and parentheses
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-26 23:46:40 +01:00
abb17589b1
Merge pull request #7991 from nextcloud/show-trusted-domain-error-in-status.php
...
Send a proper response for status.php on trusted domain error
2018-01-24 15:05:49 +01:00
4537faa5da
Merge pull request #7918 from nextcloud/properly-log-exceptions
...
Properly log the full exception instead of only the message
2018-01-23 11:56:02 +01:00
2a38605545
Properly log the full exception instead of only the message
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-23 10:57:21 +01:00
c7d9e5fd63
Merge pull request #7354 from nextcloud/refacor-update-page-print
...
Refactor method to check if update is needed
2018-01-22 22:50:05 +01:00
37026d8b9d
Send a proper response for status.php on trusted domain error
...
* fixes #7732
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-22 15:58:57 +01:00
6bf1fca6f0
Fix strict typing issues in lib/base.php
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-12 14:22:31 +01:00
b19fae2629
Fix error log on PHP 7.2
...
Fixes following error in the logs: "ini_set(): A session is active. You cannot change the session module's ini settings at this time"
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-12-12 14:33:30 +01:00
0f35ef3727
Reuse systemconfig
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
f22e02cd79
Refactor method to check if update is needed
...
There was only one call, that actually needed the parameter to be set to true. So this change moved the print of the page to that location and replaces all other occurences with a direct call to the underlying OCP API.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-30 16:04:07 +01:00
8ccb486876
Merge pull request #7264 from nextcloud/cache-fetched-apps
...
Cache fetched apps in update check
2017-11-27 11:48:59 +01:00
0e2f00ec59
Get the Installer via DI
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-25 12:00:57 +01:00
5a270c2715
Reset bruteforce attempt table on successful login
...
* only clear the entries that come from the same subnet, same action and same metadata
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-24 14:58:57 +01:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +01:00
e2139d4b56
Add logrote as a default background job
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-10-24 08:28:06 +02:00
95cc831ed7
Remove SAML hack from base.php
...
This is no longer required now that
https://github.com/nextcloud/user_saml/pull/159 is in
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-27 08:28:09 +02:00
c257cd57d4
Handle SameSiteCookie check for index.php in AppFramework Middleware
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2017-09-24 21:07:16 +02:00
0f83cdc78e
Use the guest.css for the maintenance page as well
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-06-13 16:43:25 -05:00
b744639136
Reset opcache if update is detected
...
This even works if opcache_reset is in the disabled_functions php.ini setting.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-21 18:38:24 -05:00
8c5062794f
Merge pull request #4873 from nextcloud/check-whether-REQUEST-exists
...
Check whether the $_SERVER['REQUEST_*'] vars exist before using them
2017-05-15 09:49:11 -05:00
72c1b24844
Check whether the $_SERVER['REQUEST_*'] vars exist before using them
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-05-15 14:33:27 +02:00
3fa604cc5e
Allow to enforce update via web UI
...
* adds a disclaimer that an update via web UI is on own risk
* allows to skip the warning
* fixes #4353
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-11 10:22:44 -05:00
abe4a19cbc
Properly decide on actual users if instance is too big
...
* state the reason why NC thinks it is a big instance
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-10 22:32:42 -05:00
9309217ecb
Fix escaped HTML on error pages
...
* fixes #4655
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-05-08 21:16:08 -05:00
d925856787
dont spam log when request can't access filesystem
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2017-04-28 17:01:31 -03:00
d4ba8198fe
Make the emergency disable also accept arrays
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2017-04-26 20:07:51 +02:00
f23a36b0a6
Add activities when email or password is changed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2017-04-13 11:13:19 +02:00
5b4adf66e5
Move OC_Defaults to OCP\Defaults
...
* currently there are two ways to access default values:
OCP\Defaults or OC_Defaults (which is extended by
OCA\Theming\ThemingDefaults)
* our code used a mixture of both of them, which made
it hard to work on theme values
* this extended the public interface with the missing
methods and uses them everywhere to only rely on the
public interface
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-04-09 21:43:01 -05:00
edd55b0ea9
Use SystemConfig instead of AllConfig for DB stuff
...
* preparation for followup PRs to clean up the DB bootstrapping
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-03-19 15:53:49 -06:00
0024b67aaf
Check that set_time_limit is not disabled before calling it
...
Signed-off-by: Ko- <k.stoffelen@cs.ru.nl>
2017-03-11 17:04:21 +01:00
MartB
Morris Jobke
Eric Masseran
jaltek
Roeland Jago Douma
Arthur Schiwon
Tobia De Koninck
Roeland Jago Douma
Julius Härtl
Joas Schilling
Lukas Reschke
Robin Appelman
Ko-