Commit Graph

35107 Commits

Author SHA1 Message Date
Morris Jobke 49ffad8df1 Merge pull request #1677 from nextcloud/cleanup-tests
Cleanup test case
2016-10-10 23:45:54 +02:00
Roeland Jago Douma a81d045ef0 Merge pull request #1683 from nextcloud/issue-1437-installing-app-with-code-checker
Add app name to the call
2016-10-10 22:15:28 +02:00
Roeland Jago Douma 3c173378e8
Fix typehint
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 22:13:51 +02:00
Thomas Müller 2806a4bca7
Cleanup test case
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 22:13:47 +02:00
Roeland Jago Douma 1f0bc6936e Merge pull request #1679 from nextcloud/downstream-26282
Improve user list rendering perf by not resorting after every add (#2…
2016-10-10 22:10:46 +02:00
Roeland Jago Douma ada4d6cafc Merge pull request #1680 from nextcloud/downstream-26308
Remove PNG fallbacks from files app
2016-10-10 22:09:48 +02:00
Lukas Reschke d99ab1b038 Merge pull request #1675 from nextcloud/remove-unneeded-variable
remove unneeded variable & proper element creation
2016-10-10 20:28:30 +02:00
Morris Jobke f3fd0f4a62 Merge pull request #1674 from nextcloud/downstream-26183
Added test for 26182
2016-10-10 17:05:07 +02:00
Joas Schilling 356ac5d42f
Add app name to the call
Regression from 69b063f4c6

Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-10 16:34:14 +02:00
Morris Jobke 2c6913ff9f Merge pull request #1668 from nextcloud/user_ldap_use_appconfig
Do not query data that is already in the appconfig
2016-10-10 15:37:44 +02:00
Morris Jobke 75f23d97f6 Merge pull request #1673 from nextcloud/php7.1-rc3
Bump 7.1 CI to RC3
2016-10-10 15:32:29 +02:00
Roeland Jago Douma ad1eb8bd76 Merge pull request #1114 from nextcloud/display_all_reshares
Display link reshares
2016-10-10 15:27:00 +02:00
Morris Jobke 0497affc46
fix drag and drop icon for files app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-10-10 15:09:15 +02:00
Vincent Petry db472b20cc
Remove PNG fallbacks from files app (#26308) 2016-10-10 15:08:40 +02:00
Vincent Petry e3717fd466
Improve user list rendering perf by not resorting after every add (#26282)
The call to UserList.add() was wrong and was passing "user.lastLogin"
as the sort argument which would cause the list to be resorted over and
over again for every added item after loading the next page of users.
2016-10-10 14:51:13 +02:00
Morris Jobke 5158328190
remove unneeded variable & proper element creation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-10-10 14:06:43 +02:00
Sergio Bertolin f1c313b8bd
Added test for 26182 2016-10-10 13:48:14 +02:00
Roeland Jago Douma 7c48c5d8f7
Bump 7.1 CI to RC3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 13:17:19 +02:00
Roeland Jago Douma de69f7a899
Fix HTML
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 12:57:57 +02:00
Morris Jobke 2d507c4144
align layout of other link shares
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2016-10-10 12:53:14 +02:00
Roeland Jago Douma 8d1e6eb9b2
Display link reshares
* No longer filterout all other link shares
* Display link shares in shareelist (below normal shares)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 12:53:14 +02:00
Roeland Jago Douma 2dcd97bf14 Merge pull request #1672 from nextcloud/cache_non_exisiting_db_user
Cache non existing DB user
2016-10-10 10:52:07 +02:00
Roeland Jago Douma 7d2f70ef72
Use more IConfig and add unit tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 10:51:13 +02:00
Roeland Jago Douma bdf4bf4669
DI IConfig into ldap helper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 10:18:18 +02:00
Roeland Jago Douma 1ba2b7e5d4
Do not query data that is already in the appconfig
This is already available. We better use a simple regex.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 09:39:20 +02:00
Christoph Wurst a0cb809342 Merge pull request #1660 from nextcloud/add-notification-icon-to-api
Add an icon to the notification API
2016-10-10 09:32:34 +02:00
Roeland Jago Douma 1273d82e8b
Cache non existing DB user
We always query the database backend. Even if we use a different one
(ldap for example). Now we do this everytime we try to get a user object
so caching that a user is not in the DB safes some queries on each
request then (at least 2 what I found).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2016-10-10 09:30:36 +02:00
Morris Jobke e5fd9c1e1a Merge pull request #1640 from nextcloud/less_queries_group_share
More efficient group share resolving
2016-10-10 09:26:11 +02:00
Morris Jobke 195fc041da Merge pull request #1663 from nextcloud/dont-reparse-info-xml
Dont reparse info xml + cache AppInfo XML
2016-10-10 09:22:43 +02:00
Christoph Wurst ce9e33bd3c Merge pull request #1656 from nextcloud/appinfo-check-class-existance
Make sure all the jobs, command, provides and migrations are valid
2016-10-10 09:04:27 +02:00
Nextcloud bot 3f40bb69f8
[tx-robot] updated from transifex 2016-10-10 00:06:58 +00:00
Morris Jobke 8920c87dce Merge pull request #1658 from nextcloud/fix-log.condition
Default to empty string
2016-10-09 23:39:09 +02:00
Morris Jobke 38104241a2 Merge pull request #1665 from nextcloud/speed-up-is-subdirectory-test
Simplify isSubDirectory check
2016-10-09 23:36:42 +02:00
Nextcloud bot 9fc3209d2c
[tx-robot] updated from transifex 2016-10-09 00:06:49 +00:00
Lukas Reschke 90cb3e3cc6 Merge pull request #1661 from nextcloud/fix_1659
use older php array syntax in index.php
2016-10-08 18:44:55 +02:00
Nextcloud bot 0beecbf2c5
[tx-robot] updated from transifex 2016-10-08 00:06:50 +00:00
Arthur Schiwon a9671a4dc2
adjust wording of the notification
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-08 01:17:51 +02:00
Arthur Schiwon a35d4e7b44
remove notifications of deleted comments from the DB
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-08 01:10:49 +02:00
Lukas Reschke 0245dd7221
Simplify isSubDirectory check
Shaves off another 9ms per request as can be seen at https://blackfire.io/profiles/compare/dd54cef3-e58d-4a22-b8f4-c7c4b70697be/graph

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-07 21:56:43 +02:00
Lukas Reschke 0c2b17c80f
Cache AppInfo in Memory Cache if configured
This saves around 20ms on a bare-bone instance, on bigger ones more (depending on the number of installed apps).

See https://blackfire.io/profiles/compare/fc326ad3-100d-49b8-8ea9-8343240f53f3/graph

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2016-10-07 21:29:23 +02:00
Thomas Müller 67d3574bdf
Don't parse info.xml but reuse already cached app infos - fixes #25603 (#25968)
* Don't parse info.xml but reuse already cached app infos - fixes #25603

* Use === in InfoParser. Fixes test

* InfoParser should not depend on UrlGenerator - fixes issue with session being closed too early
2016-10-07 20:58:22 +02:00
Georg Ehrke a48aed2ee9
use older php array syntax in index.php 2016-10-07 20:24:47 +02:00
Arthur Schiwon 006da9afd7
use different files route/controller
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:27:33 +02:00
Arthur Schiwon 522b053466
update autoloading map
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:11:23 +02:00
Arthur Schiwon e1073cf442
Notificacations for simple @-mentioning in comments
(WIP) notify user when mentioned in comments

Fix doc, and create absolute URL for as notification link.

PSR-4 compatibility changes

also move notification creation to comments app

Do not notify yourself

unit test for controller and application

smaller fixes

- translatable app name
- remove doubles in mention array
- micro perf optimization
- display name: special label for deleted users, keep user id for users that could not be fetched from userManager

Comment Notification-Listener Unit Test

fix email adresses

remove notification when triggering comment was deleted

add and adjust tests

add missing @license tags

simplify NotificationsController registration

appinfo simplification, php docs

make string easier to translate

adjust test

replace dispatcher-based listeners with a registration method and interface

safer to not pass optional data parameter to setSubject for marking as processed. ID and mention suffices

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

update comment

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:11:19 +02:00
Joas Schilling c77933ca22
Add an icon to the notification API
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-07 17:00:24 +02:00
Lukas Reschke ab4353457d
Default to empty string
Otherwise `null` is returned which leads to a ton of similar error messages if the log condition setting is enabled.:

```
{"reqId":"3wVBarnDfOV3qkI1bVCU","remoteAddr":"89.98.78.41","app":"PHP","message":"hash_equals(): Expected user_string to be a string, null given at \/var\/www\/html\/lib\/private\/Log.php#275","level":3,"time":"2016-10-07T14:22:15+00:00","method":"PROPFIND","url":"\/remote.php\/webdav\/","user":"icewind"}
```
2016-10-07 16:23:05 +02:00
Joas Schilling c02a50a432
Make sure all the jobs, command, provides and migrations are valid
Signed-off-by: Joas Schilling <coding@schilljs.com>
2016-10-07 14:25:18 +02:00
Roeland Jago Douma 9e7824f3ed Merge pull request #1648 from nextcloud/bump_moment_js
Bump moment.js
2016-10-07 13:19:07 +02:00
Lukas Reschke 0dce8fdd63 Merge pull request #1651 from nextcloud/fix_bower_strengthify
Fix bower.json for strengthify
2016-10-07 13:06:18 +02:00