Commit Graph

18047 Commits

Author SHA1 Message Date
Christoph Wurst 7ada6e5ab0 Fix writing BLOBs to postgres with recent contacts interaction
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-31 13:09:40 +00:00
Nextcloud bot fba73a5c39
[tx-robot] updated from transifex 2020-08-28 02:16:32 +00:00
Julius Härtl 1d25b9972f
Remove @package annotations from public namespace
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 09:16:52 +02:00
Julius Härtl 6ae83a72cd
Remove wrongly annotated package names
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 09:16:52 +02:00
Nextcloud bot 348525426c
[tx-robot] updated from transifex 2020-08-27 02:16:52 +00:00
Robin Appelman 4025b95e03 show better quota warning for group folders and external storage
instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-26 19:17:43 +00:00
Roeland Jago Douma c9a1379bdf
Merge pull request #22410 from nextcloud/backport/22359/stable19
[stable19] fix possible leaking scope in Flow
2020-08-26 20:22:37 +02:00
Nextcloud bot d3efe74f12
[tx-robot] updated from transifex 2020-08-26 02:16:39 +00:00
Arthur Schiwon f8417cca0f
adjust since for 19
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 13:05:15 +02:00
Arthur Schiwon 7f6e2c5953 fix possible leaking scope in Flow
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-25 08:42:24 +00:00
Roeland Jago Douma d8c958907f
Make legacy cipher opt in
* Systems that upgrade have this enabled by default
* New systems disable it
* We'll have to add some wargning in the setup checks if this is enabled

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-24 11:50:04 +02:00
Roeland Jago Douma 9aac6d9251
Merge pull request #22355 from nextcloud/backport/20772/stable19
[stable19] Properly search for users when limittogroups is enabled
2020-08-24 09:12:13 +02:00
Nextcloud bot 0ed1d67c7f
[tx-robot] updated from transifex 2020-08-23 02:16:53 +00:00
Roeland Jago Douma 556440471a Properly search for users when limittogroups is enabled
Searching just for the uid is not enough.
This makes sure this done properly again now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-21 11:23:15 +00:00
Nextcloud bot db324278b5
[tx-robot] updated from transifex 2020-08-20 02:17:50 +00:00
Morris Jobke d7aa1c00ed
Merge pull request #21983 from nextcloud/backport/21628/stable19
[stable19] fix moving files from external storage to object store trashbin
2020-08-19 21:29:01 +02:00
Joas Schilling 16021c93ed
Allow to disable share emails
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-19 11:04:29 +02:00
Nextcloud bot fd9ebeefa2
[tx-robot] updated from transifex 2020-08-19 02:17:21 +00:00
Nextcloud bot 6bcb656c5d
[tx-robot] updated from transifex 2020-08-18 02:17:38 +00:00
Nextcloud bot 6bdafb1aa9
[tx-robot] updated from transifex 2020-08-17 02:16:48 +00:00
Roeland Jago Douma a6760c2b1c Silence duplicate session warnings
Fixes #20490

Basically restroring the old behavior.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-14 07:24:53 +00:00
Roeland Jago Douma 10ee9791ff
Merge pull request #21975 from nextcloud/backport/21658/stable19
[stable19] allow admin to configure the max trashbin size
2020-08-14 05:58:57 +02:00
Roeland Jago Douma 92d0f5e7a3
Merge pull request #22121 from nextcloud/backport/22008/stable19
[stable19] Ensured large image is unloaded from memory when generating previews
2020-08-13 05:23:01 +02:00
Roeland Jago Douma fe8ea5390f
Merge pull request #22208 from nextcloud/backport/21676/stable19
[stable19] Fix chmod on file descriptor
2020-08-13 05:17:13 +02:00
Roeland Jago Douma baa64827d3
Merge pull request #22209 from nextcloud/backport/21677/stable19
[stable19] Do clearstatcache() on rmdir
2020-08-13 05:07:36 +02:00
Nextcloud bot 6327b8a6fb
[tx-robot] updated from transifex 2020-08-13 02:16:48 +00:00
Nextcloud bot 659fb3cf06
[tx-robot] updated from transifex 2020-08-12 02:16:59 +00:00
J0WI be73fd90fc Only clear the realpath cache
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:33 +00:00
J0WI 6f72871ca5 clearstatcache() on rmdir
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:32 +00:00
J0WI 9b028a619a Fix chmod on file descriptor
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-08-12 01:26:10 +00:00
Morris Jobke 9aff51eb52 Use class that actually has the destroy() method in preview generator
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 20:41:25 +00:00
Elijah Martin-Merrill 66bb6fdbb0 fix memory leak caused by not destroying image in Preview/Generate.php
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
2020-08-05 20:41:25 +00:00
Morris Jobke 74e98940ef Search also the email and displayname in user mangement for groups
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:11:41 +00:00
Arthur Schiwon dc98aaa224 contactsmanager shall limit number of results early
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-03 13:18:14 +00:00
Robin Appelman 4e6719b28c
dont update mimetype when moving to trash
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-31 17:21:02 +02:00
Joas Schilling e2fa284bd9
Merge pull request #22053 from nextcloud/backport/22015/stable19
[stable19] Correctly remove usergroup shares on removing group members
2020-07-31 15:31:33 +02:00
Morris Jobke 29d41ba061
Use old IServerContainer methods
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 10:03:59 +02:00
Joas Schilling c69a709f21 Correctly remove usergroup shares on removing group members
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-30 07:51:10 +00:00
Joas Schilling cf0bdfd8c1 parse_url returns null in case a parameter is not found
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-29 16:13:32 +00:00
Nextcloud bot 73132b56d4
[tx-robot] updated from transifex 2020-07-29 02:17:02 +00:00
Nextcloud bot 4ceda884ac
[tx-robot] updated from transifex 2020-07-27 02:16:42 +00:00
Nextcloud bot 46715762ce
[tx-robot] updated from transifex 2020-07-25 02:16:45 +00:00
onehappycat 288ca45938 Ignore whitespace in sharing by mail
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
2020-07-24 11:43:24 +00:00
Nextcloud bot a05efb5217
[tx-robot] updated from transifex 2020-07-24 02:17:02 +00:00
Robin Appelman 142b6eb08f fix renameFromStorage messing with folder mimetype
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
Robin Appelman 7ac4d57fd5 use exceptions for error signaling in writeStream
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:23 +00:00
Robin Appelman c567b1d6b2 fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 21:01:22 +00:00
Robin Appelman 38db847164 allow admin to configure the max trashbin size
this allows an admin to configure the max trashbin size instead of always relying on the users quota.

The trashbin size can be configured using the `occ trash:size` command and can be set both globally and per-user

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 14:30:07 +00:00
Nextcloud bot 7246ffff9b
[tx-robot] updated from transifex 2020-07-23 02:17:13 +00:00
Roeland Jago Douma 45108b087e Discourage webauthn user interaction
Else people might have the feeling this is also doing 2FA. And since it
is only prefered it can be ignored and hacked around.

Once we have proper 2FA with webauthn in one go this probably needs to
be revisted.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-20 07:31:37 +00:00
Nextcloud bot ec69ab4ed4
[tx-robot] updated from transifex 2020-07-19 02:17:16 +00:00
Nextcloud bot 95093e4f27
[tx-robot] updated from transifex 2020-07-17 02:17:21 +00:00
Nextcloud bot 1822eec68f
[tx-robot] updated from transifex 2020-07-16 02:19:41 +00:00
Nextcloud bot 6c8cc35b28
[tx-robot] updated from transifex 2020-07-10 02:17:02 +00:00
Roeland Jago Douma b3c9b166a3
Merge pull request #21779 from nextcloud/backport/21499/stable19
[stable19] fix #21285 as oneliner
2020-07-09 19:27:21 +02:00
Lionel Elie Mamane 2f75ba1adb Return correct loginname in credentials,
even when token is invalid or has no password.

Returning the uid as loginname is wrong, and leads to problems when
these differ. E.g. the getapppassword API was creating app token with
the uid as loginname. In a scenario with external authentication (such
as LDAP), these tokens were then invalidated next time their underlying
password was checked, and systematically ceased to function.

Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
2020-07-09 14:37:05 +00:00
Robin Appelman 157f619812 ensure home storage is initialized on first setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-09 12:33:20 +00:00
Roeland Jago Douma f174fb91e0 Use the correct mountpoint to calculate
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-09 12:33:19 +00:00
Nextcloud bot b19525ebbc
[tx-robot] updated from transifex 2020-07-09 02:17:46 +00:00
Nextcloud bot 667ca8dcb0
[tx-robot] updated from transifex 2020-07-08 02:17:07 +00:00
Jaakko Salo 392df2eaf4 Fix releasing a shared lock multiple times
Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
2020-07-06 12:11:46 +00:00
Roeland Jago Douma 4513342478
Merge pull request #21671 from nextcloud/revert-21095-backport/21090/stable19
Revert "[stable19] Do not read certificate bundle from data dir by default"
2020-07-06 10:39:02 +02:00
Nextcloud bot 4e21bc608c
[tx-robot] updated from transifex 2020-07-04 02:16:25 +00:00
Roeland Jago Douma 905fab3356
Revert "[stable19] Do not read certificate bundle from data dir by default" 2020-07-03 14:21:38 +02:00
Christoph Wurst 3201e7674f Fix static method call for s3 bucket compat check
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-03 08:26:00 +00:00
Joas Schilling d203f8f985
Merge pull request #21387 from nextcloud/backport/21380/stable19
[stable19] Increase timeout of the appstore requests
2020-07-03 10:04:55 +02:00
Nextcloud bot a5b279a488
[tx-robot] updated from transifex 2020-07-03 02:17:21 +00:00
Morris Jobke f70b2dba18
Merge pull request #21573 from nextcloud/backport/21558/stable19
[stable19] relax permissions mask check for detecting part file rename
2020-07-02 23:51:03 +02:00
Joas Schilling 9d541ccfd1
Increase timeout of the appstore requests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-02 23:36:24 +02:00
Joas Schilling a471dba6e1 Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-02 10:09:45 +00:00
Roeland Jago Douma c88402db47
Log deprecated events as debug
Since this can spam the log quite agressively we should log it as debug
and not info.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-02 10:49:11 +02:00
Roeland Jago Douma 7fd34d5d64
Merge pull request #21638 from nextcloud/backport/21588/stable19
[stable19] Update presign method to match with interface again.
2020-07-02 09:06:53 +02:00
Joas Schilling 9e9e74736d
Merge pull request #21538 from nextcloud/backport/21452/stable19
[stable19] Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
2020-07-01 10:13:19 +02:00
Nextcloud bot c0b3cd90a6
[tx-robot] updated from transifex 2020-07-01 02:16:24 +00:00
Daniel Kesselberg 4397e57201 Update presign method to match with interface again.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 18:39:08 +00:00
Nextcloud bot b7bab49eb8
[tx-robot] updated from transifex 2020-06-30 02:16:20 +00:00
Robin Appelman 654f5a2109 relax permissions mask check for detecting part file rename
with files drop uploads the original file name isn't always used for the '.ocTransferId' source path

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-24 19:11:18 +00:00
Joas Schilling 407e3df585 Fix language in share notes email for users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 21:29:49 +00:00
Roeland Jago Douma 6b5db20fc9
Merge pull request #21526 from nextcloud/backport/21479/stable19
[stable19] Allow to specify the cookie type for appframework responses
2020-06-23 14:04:53 +02:00
Joas Schilling d1df66f7af Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:50 +00:00
Joas Schilling 9ce288163c Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:50 +00:00
Joas Schilling 7a36a4b99c Move back to IGroupManager::displayNamesInGroup()
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 12:04:49 +00:00
Roeland Jago Douma 286f79c388
Merge pull request #21447 from nextcloud/backport/21406/stable19
[stable19] Disable Client-Side Monitoring on AWS storage
2020-06-22 16:29:05 +02:00
Arthur Schiwon 002e1f1ed2
available since 19.0.1
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-22 13:43:18 +02:00
Roeland Jago Douma c21a976bc4 Allow to specify the cookie type for appframework responses
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.

Helps with #21474

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-22 11:02:50 +00:00
Roeland Jago Douma adb5a80674
Merge pull request #21485 from nextcloud/backport/21482/stable19
[stable19] Don't log Keys
2020-06-21 09:19:35 +02:00
Roeland Jago Douma c62000c0bb
Merge pull request #21495 from nextcloud/backport/21483/stable19
[stable19] Give up after 10 seconds in SCSS timeout
2020-06-20 16:00:27 +02:00
Nextcloud bot b9c7865045
[tx-robot] updated from transifex 2020-06-20 02:16:46 +00:00
Roeland Jago Douma 88e121d684 Give up after 10 seconds in SCSS timeout
Else we keep idling for ages which leads to bad UX

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-19 19:29:56 +00:00
Joas Schilling 0ebbabebe8 Don't log Keys
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-19 13:11:18 +00:00
Nextcloud bot 085b076d84
[tx-robot] updated from transifex 2020-06-18 02:16:45 +00:00
Christoph Wurst 60a3bf8572 Disable Client-Side Monitoring on AWS storage
The S3 client enables this by default and then tries to read
`.aws/config`. This causes `open_basedir` restriction related error for
some setups. So this patch disables the CSM because it's most likely
unused anyway.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:00:28 +00:00
Christoph Wurst 1022db87db Clean up auth tokens when user is deleted
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-16 08:03:45 +00:00
Julius Härtl 21bc4b3cad Avoid duplicate matches in wide and exact results
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-15 17:52:59 +00:00
Florent 6280d09765 Upload part size as S3 parameter instead of constant value
Some S3 providers need a custom upload part size (500 MB static value in Nextcloud).
Here is a commit to change this value via S3 configuration, instead of using S3_UPLOAD_PART_SIZE constant.
A new parameter is added for an S3 connection : uploadPartSize

Signed-off-by: Florent <florent@coppint.com>
2020-06-15 08:40:02 +00:00
Roeland Jago Douma f37be3af96
Merge pull request #21352 from nextcloud/backport/21311/stable19
[stable19] Always sort shares in a reliable way
2020-06-11 13:23:07 +02:00
Nextcloud bot e146a2b7e6
[tx-robot] updated from transifex 2020-06-11 02:15:59 +00:00
Joas Schilling c63039bb83 Always sort shares in a reliable way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-10 06:55:29 +00:00
Nextcloud bot f40f7abbaf
[tx-robot] updated from transifex 2020-06-10 02:16:16 +00:00
Nextcloud bot d753435452
[tx-robot] updated from transifex 2020-06-09 02:16:05 +00:00
Nextcloud bot bcc63c0c2b
[tx-robot] updated from transifex 2020-06-06 02:16:09 +00:00
Nextcloud bot dfe70692d7
[tx-robot] updated from transifex 2020-06-05 02:16:44 +00:00
Joas Schilling 982f2fc21a Prevent harder to share your root
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 09:01:40 +00:00
Daniel Calviño Sánchez 6ca312eec9 Fix disabling send password by Talk without new password in mail shares
When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Daniel Calviño Sánchez 8e5aa03834 Fix enabling send password by Talk with same password in mail shares
When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Daniel Calviño Sánchez 9df3ea94b8 Fix enabling send password by Talk with empty password in link shares
When "send password by Talk" is enabled in a link share now a non empty
password is enforced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Roeland Jago Douma 9d2d3c4809 Clear the statscache before fetching the metadata
Else if a lot of writes happen. It might happen that an old stat result
is used. Resulting in a wrong file size for the file. For example the
text app when a lot of people edit at the same time.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-28 10:30:35 +00:00
Roeland Jago Douma 24e97c1a7c
Merge pull request #21095 from nextcloud/backport/21090/stable19
[stable19] Do not read certificate bundle from data dir by default
2020-05-26 11:43:46 +02:00
Morris Jobke 3bf0285840
Merge pull request #21068 from nextcloud/backport/20776/stable19
[stable19] Improve group queries
2020-05-26 10:38:17 +02:00
Julius Härtl abecd5696b Update hub bundle and add proxy rule to htaccess
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-25 19:52:22 +00:00
Morris Jobke ebbdd2de33 Do not read certificate bundle from data dir by default
Before the resources/config/ca-bundle.crt was only used when the list of custom
certificates was empty and the instance was not installed. But it should also
be used when the list is empty and the instance is installed.

This is inverting the logic to stop if the instance is not installed to use the
default bundle. And it also does this when the list is empty.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-25 17:51:03 +00:00
Roeland Jago Douma 444b28adf6 Improve group queries
Before we'd also get the diplayname for each group in the backend. In a
separate query. This is of course not ideal as this information is
obtained on each and every query. Now this is queried once and properly
cached.

Also added more caching to the manager.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-22 12:22:03 +00:00
Morris Jobke 745667e426 Compress the appstore requests by default
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 09:07:35 +00:00
Morris Jobke 5c0f06b259 Cache appstore requests for 60 instead of 5 minutes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 09:07:35 +00:00
Roeland Jago Douma b9cb5a74cc Copy over the ETag and LastModified when formatting a Dataresponse
This way the ETag checks etc are all working.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-19 12:51:06 +00:00
Joas Schilling e2357d5df1 Allow links to conversations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-13 20:14:39 +00:00
Clement Wong 203d85f045 Add public argument to Http cacheFor()
Signed-off-by: Clement Wong <git@clement.hk>
2020-05-13 06:34:22 +00:00
Clement Wong 1331eb1fb8 Proxy server could cache http response when it is not private
Signed-off-by: Clement Wong <git@clement.hk>
2020-05-13 06:34:22 +00:00
Roeland Jago Douma 8e9433aee9 Remember the webauthn name of devices
Fixes #20289
we should not reset to default once we have logged in with the device.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-12 12:08:38 +00:00
Roeland Jago Douma c37bb7745b
Merge pull request #20923 from nextcloud/backport/20915/stable19
[stable19] Use random_bytes
2020-05-11 21:00:16 +02:00
Roeland Jago Douma 387af7eb60 Use random_bytes
Since we don't care if it is human readbale.
The code is backwards compatible with the old format.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-11 12:23:02 +00:00
GretaD adbdecb1d6 Fix languages empty array
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
Roeland Jago Douma d5850eb28f
Merge pull request #18955 from adrb/swift_upload_large_objects
Large Object support for OpenStack Swift
2020-05-06 13:03:24 +02:00
Morris Jobke e102264299
Merge pull request #20787 from nextcloud/fix/resize_wrong_mime
Fix OC_Image new resize functions
2020-05-04 10:06:16 +02:00
Joas Schilling afc5966558
Merge pull request #20749 from nextcloud/bug/noid/is-not-setup-via-query-false-positive
PHP 7.4 excludes the arguments from stack traces by default.
2020-05-04 09:49:50 +02:00
Roeland Jago Douma 0c35aaba29
Fix OC_Image new resize functions
Else the wrong mimetype might be set. Resulting in continious
regeneration of previews when browsing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-02 21:57:34 +02:00
Roeland Jago Douma 8c023a6579
Merge pull request #20767 from nextcloud/enh/argon2id-options
Apply Argon2 options for Argon2id hashing as well
2020-05-01 15:39:13 +02:00
MichaIng 229570badf
Apply Argon2 options for Argon2id hashing as well
Signed-off-by: MichaIng <micha@dietpi.com>
2020-05-01 11:42:13 +02:00
Roeland Jago Douma a41ad78408
Update education bundle
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 09:52:58 +02:00
Roeland Jago Douma c724eb24d5
Merge pull request #20380 from nextcloud/design/notification-mails
Fix design and layout of notification mails
2020-05-01 08:53:39 +02:00
Nextcloud bot 9f448d864b
[tx-robot] updated from transifex 2020-05-01 02:16:47 +00:00
Jan-Christoph Borchardt e981669e89
Fix notification mail tests
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +02:00
Daniel Kesselberg 1ef77ef948
composer run cs:fix
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-30 17:37:20 +02:00
Daniel Kesselberg cba7219b25
PHP 7.4 excludes the arguments from stack traces by default.
That leads to a false positive is not setup via query() but directly warning for every app because
the check does not work anymore.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-30 17:00:56 +02:00
Robin Appelman 4e6d3d1880
Fix getDirectoryContent implementation for Jail wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-30 15:27:09 +02:00
Roeland Jago Douma 8d5404b750
Merge pull request #20710 from nextcloud/fix/argon2-options-checks
Fix Argon2 options checks
2020-04-30 14:42:33 +02:00
Roeland Jago Douma fa914f2e24
Merge pull request #20742 from nextcloud/fix/cs
Run the cs fixer for green ci
2020-04-30 14:41:50 +02:00
Joas Schilling 5b5550dbba
Merge pull request #20677 from nextcloud/followup/17718/scaling-user-provisioning
Scaling user provisioning for subadmins with many groups
2020-04-30 12:49:57 +02:00
Roeland Jago Douma f6b435d0d9
Run the cs fixer for green ci
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 10:28:44 +02:00
MichaIng ad60619655
Fix Argon2 options checks
The minimum for memory cost is 8 KiB per thread. Threads must be checked and set first to allow checking against the correct memory cost mimimum.
Options are now applied the following way:
- If config.php contains the setting with an integer higher or equal to the minimum, it is applied.
- If config.php contains the setting with an integer lower than the minimum, the minimum is applied.
- If config.php does not contain the setting or with no integer value, the PHP default is applied.

Signed-off-by: MichaIng <micha@dietpi.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 10:18:46 +02:00
Jan-Christoph Borchardt d582315c10
Notification mails: Fix some alignment details and remove shadow
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-04-30 10:15:19 +02:00
Jan-Christoph Borchardt fbef2708d0
Notification mails: Change font to native font stack
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-04-30 10:14:23 +02:00
Jan-Christoph Borchardt b38c3bfde3
Notification mails: Logo bar/box to circle so it stands nicely on its own
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-04-30 10:14:22 +02:00
Jan-Christoph Borchardt 43371c9f7c
Notification mails: Adjust vertical spacing
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-04-30 10:14:22 +02:00
Jan-Christoph Borchardt 1d5e7b3cee
Fix notification mails height issue in Nextcloud Mail
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-04-30 10:14:22 +02:00
Roeland Jago Douma a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
Roeland Jago Douma a1c1b354fc
Merge pull request #18883 from adrb/optimize_swift_14116
Optimize Openstack Swift files download
2020-04-30 09:06:19 +02:00
Roeland Jago Douma 4472777769
Merge pull request #20717 from nextcloud/fix/getconfig-param-definitions
Define getSystemValueBool/Int/String function default parameter with correct type
2020-04-30 09:02:58 +02:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
MichaIng 10a98f9f41
Define getSystemValueBool/Int/String function default parameter with correct type
Signed-off-by: MichaIng <micha@dietpi.com>
2020-04-29 14:19:52 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Adrian Brzezinski e107519295 Large Object support for OpenStack Swift.
Until now, you wouldn't be able to create
objects larger that 5GB.

It's somewhat related with pull #18883

Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl>
2020-04-27 14:23:59 +02:00
Adrian Brzezinski 354c0996d8 It's a fix for issue #14116,
Improves efficiency when downloading files from Swift storage.
Before, files were downloaded and then pushed back to user.
That behaevior causes all kinds of performance problems.

Now, files are streamed directly to user.

Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl>
2020-04-27 14:16:50 +02:00
Morris Jobke 2d7f71faca
Merge pull request #20650 from tekhnee/patch-1
Adhere to EMailTemplate interface in constructor call.
2020-04-27 11:10:38 +02:00
Morris Jobke 673267cd91
Merge pull request #19929 from nextcloud/bugfix/user-delete-avatar
Delete avatar if a user is deleted
2020-04-27 11:06:50 +02:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
Joas Schilling e24e9ec0a9
Don't loop over all groups to check for subadmins
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-27 08:37:53 +02:00
Thomas Citharel deb2ea9cea
Provide links to calendar in event creation/update activities
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
Tekhnee 7ee67339e0
Adhere to EMailTemplate interface in constructor call.
Email creation appears to have been refactored lately but it looks like custom template-based emails were left out.

Signed-off-by: Tekhnee <info@tekhnee.org>
2020-04-25 21:24:21 +03:00
Mikael Hammarin 6ffde74928
Patch to optimize for large installations (>5000 users >20000 groups) where subadmins have access to many of groups (>250)
- UsersController:editUser() calls isUserAccessible() even if the user is admin

This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.

Signed-off-by: Mikael Hammarin <mikael@try2.se>
2020-04-25 14:37:46 +02:00
Nextcloud bot 39f6f1ba34
[tx-robot] updated from transifex 2020-04-25 02:16:01 +00:00
Julius Härtl d74e9045ac
Delete avatar if a user is deleted
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 16:27:17 +02:00
Roeland Jago Douma f4b8623d33
Allow specifying a default expiration date
This overrides the max expiration date.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-24 16:18:20 +02:00
Morris Jobke defcbd9169
Merge pull request #20627 from nextcloud/cleanup/noid/remove-obsolete-repair-steps
Remove obsolete repair steps for logo and updater channel
2020-04-24 13:36:16 +02:00
blizzz d458fcddb5
Merge pull request #20298 from nextcloud/enh/noid/auto-logout
Allow to configure auto logout after browser inactivity
2020-04-24 13:20:27 +02:00
Morris Jobke 0bd79b96c5
Remove obsolete repair steps for logo and updater channel
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-04-24 09:57:52 +02:00
Nextcloud bot 84a3536159
[tx-robot] updated from transifex 2020-04-24 02:27:55 +00:00
blizzz 038045d55e
Merge pull request #18816 from nextcloud/bugfix/noid/paginate-contacts-search
Use paginated search for contacts
2020-04-23 22:20:58 +02:00
Julius Härtl 2eadf9d567
Do not create remember me cookie
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:12:54 +02:00
Julius Härtl cbd20867b5
Provide config though initial state service
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:12:53 +02:00
Julius Härtl 6709833dc7
Use paginated search for contacts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
Robin Appelman 436908ee3f
filter out blacklisted files in getDirectoryContent
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-23 13:34:55 +02:00
Roeland Jago Douma c870b6ab2e
Fix new routing in settings etc
Also prefix resources
Unify the prefix handling
Handle urls with and without slash

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:09:25 +02:00
Nextcloud bot ac57bbcf99
[tx-robot] updated from transifex 2020-04-22 02:17:06 +00:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Julius Härtl 5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +02:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
Nextcloud bot b1a90da347
[tx-robot] updated from transifex 2020-04-20 02:16:12 +00:00
Roeland Jago Douma 6c603e8e7d
Move to subfolders for preview files
Else the number of files can grow very large very quickly in the preview
folder. Esp on large systems.

This generates the md5 of the fileid. And then creates folders of the
first 7 charts. In that folder is then a folder with the fileid. And
inside there are the previews.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-19 10:30:56 +02:00
Joas Schilling 250467e842
Extend tests for root url
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling f93d55eebd
PHP CS fixes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling aad16c8508
Fix creation of legacy routes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Joas Schilling 3f8168b6e5
Allow some apps to have root URLs in their own routing file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Nextcloud bot 148bdabd58
[tx-robot] updated from transifex 2020-04-18 02:16:28 +00:00
John Molakvoæ 36f9ad32f2
Merge pull request #20447 from liamjack/fix/13287/welcome_email
Increase max-height on button in welcome email template
2020-04-17 09:42:49 +02:00
blizzz d55f4183b5
Merge pull request #20505 from nextcloud/fix/noid/system-creds
do not advertise nulled userId for for systemwide credentials
2020-04-16 11:53:24 +02:00
Roeland Jago Douma 8971403ada
Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap
PHP-CS-Fixer green
2020-04-16 10:37:49 +02:00
Roeland Jago Douma 79cf13e349
Merge pull request #16946 from exussum12/patch-1
Increase max read
2020-04-16 10:37:10 +02:00
Roeland Jago Douma fc2e17d33f
Merge pull request #20246 from nextcloud/fix/untranslated_mail_footer
Provide the proper language to the mailer
2020-04-16 10:06:55 +02:00
Roeland Jago Douma d9990b09b8
PHP-CS-Fixer green
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:25:17 +02:00
Roeland Jago Douma bb4dedb015
Provide the proper language to the mailer
Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:04:13 +02:00
Roeland Jago Douma e21d65e771
Merge pull request #20509 from nextcloud/revert-20050-bugfix/noid/mysql-equal-trims-shock
Revert "Make sure MySQL is not saying 'this' = 'this ' is true"
2020-04-16 08:46:18 +02:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Roeland Jago Douma cbcf072b23
Revert "Make sure MySQL is not saying 'this' = 'this ' is true" 2020-04-15 23:49:16 +02:00
Scott Dutton 65e134c13a
Update View.php 2020-04-15 19:10:06 +01:00
Arthur Schiwon 5437844b7e
fix credentialsManager documentation and ensure userId to be used as string
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-15 19:34:23 +02:00
Morris Jobke 7fe8477830
Run cs:fix and fix HashWrapper code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-04-15 14:08:56 +02:00
Morris Jobke d8557d0d8a
Merge pull request #19540 from jlutran/fixKeystoneV3Auth
Fix issues with Keystone auth v3 in files_external app
2020-04-15 14:05:32 +02:00
Morris Jobke c43174a7e6
Merge pull request #20050 from nextcloud/bugfix/noid/mysql-equal-trims-shock
Make sure MySQL is not saying 'this' = 'this ' is true
2020-04-15 12:57:27 +02:00