Commit Graph

2872 Commits

Author SHA1 Message Date
Christoph Wurst 9772dbd19e
Fix LDAP application class instance created directly
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-09 10:12:02 +01:00
Nextcloud bot b41112a023
[tx-robot] updated from transifex 2019-12-07 02:16:37 +00:00
Nextcloud bot da84b36186
[tx-robot] updated from transifex 2019-12-06 02:16:59 +00:00
Christoph Wurst 5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Christoph Wurst cc80339b39
Add typed create user events
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-03 08:03:57 +01:00
Roeland Jago Douma 669302e570
Merge pull request #18064 from nextcloud/feature/php74
Add php7.4 support
2019-11-28 08:36:10 +01:00
Nextcloud bot 563f9153a2
[tx-robot] updated from transifex 2019-11-28 02:16:54 +00:00
Roeland Jago Douma 17a9d5856f
TO REVERT LATER: disable some tests in UserTest
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:28 +01:00
Roeland Jago Douma 3a7cf40aaa
Mode to modern phpunit
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
Roeland Jago Douma 8d4346d656
Fix more tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
Roeland Jago Douma c007ca624f
Make phpunit8 compatible
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
Roeland Jago Douma 7015501a74
Merge pull request #18005 from nextcloud/fix/manual-app-instances
Remove some more direct app instance creations
2019-11-26 09:20:14 +01:00
Roeland Jago Douma c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
Some php-cs fixes
2019-11-25 14:07:00 +01:00
Christoph Wurst 97385cef33
Remove some more direct app instance creations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-11-25 08:42:16 +01:00
Nextcloud bot 573c800b00
[tx-robot] updated from transifex 2019-11-25 02:15:54 +00:00
Nextcloud bot 4f2837017c
[tx-robot] updated from transifex 2019-11-23 02:16:07 +00:00
Roeland Jago Douma 68748d4f85
Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
Nextcloud bot 0d7f55aae9
[tx-robot] updated from transifex 2019-11-22 02:16:16 +00:00
blizzz e7f225c013
Merge pull request #18016 from nextcloud/fix/noid/ldap-checkup-batchsize
make chunksize (used to check for gone LDAP users) configurable
2019-11-21 11:05:54 +01:00
John Molakvoæ b9dccf5929
uid can be false when the user record does not exit (#18030)
uid can be false when the user record does not exit
2019-11-21 07:08:33 +01:00
Nextcloud bot 37ef64d24e
[tx-robot] updated from transifex 2019-11-21 02:16:02 +00:00
Arthur Schiwon 213016f758
uid can be false when the user record does not exit
fixes not loading files app for users who got a share by the gone LDAP user

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-20 19:44:12 +01:00
Arthur Schiwon f990620e6b
make chunksize (used to check for gone LDAP users) configurable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-20 19:43:53 +01:00
Nextcloud bot afa0f2c0d8
[tx-robot] updated from transifex 2019-11-20 02:16:19 +00:00
Nextcloud bot 9707fcf4fe
[tx-robot] updated from transifex 2019-11-19 02:17:47 +00:00
Nextcloud bot c952bec11d
[tx-robot] updated from transifex 2019-11-14 02:16:16 +00:00
Nextcloud bot bf6fce483e
[tx-robot] updated from transifex 2019-11-13 02:16:08 +00:00
Nextcloud bot 9a460f9e39
[tx-robot] updated from transifex 2019-11-12 02:16:12 +00:00
Nextcloud bot 6ba2a608d0
[tx-robot] updated from transifex 2019-11-06 02:16:07 +00:00
Nextcloud bot e517ca0530
[tx-robot] updated from transifex 2019-11-04 02:15:26 +00:00
Nextcloud bot 827a3c545a
[tx-robot] updated from transifex 2019-11-03 02:16:06 +00:00
Christian Oliff f9d34b89e8
Remove unnedeed IE8 CSS
IE8 is not supported at all by Microsoft, has a tiny marketshare and doesn't work with Nextcloud anyway (as Nextcloud uses jQuery 2.x which doesn't work with IE8)
2019-10-30 16:18:56 +09:00
blizzz a7193ce781
Merge pull request #17595 from nextcloud/fix/noid/wrong-pwd-apple-open-dir
treat LDAP error 50 as auth issue, prevents lost server connection errors
2019-10-21 11:55:51 +02:00
Nextcloud bot 560d9c3006
[tx-robot] updated from transifex 2019-10-21 02:15:49 +00:00
Nextcloud bot dd0e73829c
[tx-robot] updated from transifex 2019-10-19 02:15:42 +00:00
Arthur Schiwon 38a8306e32
treat LDAP error 50 as auth issue, prevents lost server connection errors
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-10-18 18:55:10 +02:00
Nextcloud bot 2b0f49455d
[tx-robot] updated from transifex 2019-10-09 02:15:07 +00:00
Nextcloud bot 049628a3f5
[tx-robot] updated from transifex 2019-10-07 02:14:42 +00:00
blizzz e105d19585
Merge pull request #17002 from nextcloud/fix/noid/ldap-dont-process-known-avas
Don't process known avatars from LDAP
2019-10-02 16:32:52 +02:00
Nextcloud bot 74dcd84ee8
[tx-robot] updated from transifex 2019-10-02 02:15:09 +00:00
John Molakvoæ (skjnldsv) b9bc2417e7
Comply to eslint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-01 17:16:09 +02:00
Nextcloud bot f9870eec2c
[tx-robot] updated from transifex 2019-10-01 12:41:53 +00:00
blizzz 47ab961aa7
Merge pull request #17001 from nextcloud/fix/noid/addressbookchanges-avatar
reduce adressbook change events and handling
2019-10-01 12:17:35 +02:00
John Molakvoæ (skjnldsv) f737dc9a86 Remove input id on login form
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 08:15:03 +00:00
Nextcloud bot 61d22ff6cf
[tx-robot] updated from transifex 2019-09-24 02:14:41 +00:00
Nextcloud bot 365f30b05b
[tx-robot] updated from transifex 2019-09-08 02:16:42 +00:00
Roeland Jago Douma 04ef434af0
Development is 18 now!
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-09-05 11:26:35 +02:00
Nextcloud bot 8072e3e568
[tx-robot] updated from transifex 2019-09-05 02:16:14 +00:00
Arthur Schiwon 8d2f712420
Don't process known avatars from LDAP
* avoids useless FS operation
* avoids useless DB writes
* avoids useless addressbook updates
* addendum to #17001

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-09-04 14:44:48 +02:00
Arthur Schiwon 3ce5d4e545
reduce adressbook change events and handling
... from four to one on avatar updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-09-04 13:46:25 +02:00
Nextcloud bot cdd491c706
[tx-robot] updated from transifex 2019-08-28 02:15:26 +00:00
Nextcloud bot 182517e0b3
[tx-robot] updated from transifex 2019-08-22 02:14:34 +00:00
Nextcloud bot b3880452bb
[tx-robot] updated from transifex 2019-08-18 02:15:40 +00:00
Nextcloud bot cd73720637
[tx-robot] updated from transifex 2019-08-11 02:15:28 +00:00
Nextcloud bot 00c1389628
[tx-robot] updated from transifex 2019-08-08 02:14:43 +00:00
blizzz bc409167f2
Merge pull request #16525 from nextcloud/bugfix/external-user-substitution
files_external: proper user context for sharing
2019-08-02 14:07:39 +02:00
Arthur Schiwon ef237f8e36
fix check for null
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-08-02 13:09:38 +02:00
Arthur Schiwon a2c5ab2f8b
adjusts LDAP's home handler to use the correct user object
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-08-02 08:39:39 +02:00
Julius Härtl 72aaf2e5fb
files_external: Make sure the correct user context is used in substitution of variables
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-08-02 08:39:24 +02:00
Nextcloud bot 67f90cb682
[tx-robot] updated from transifex 2019-08-02 02:14:30 +00:00
Nextcloud bot a1afdac31a
[tx-robot] updated from transifex 2019-08-01 02:15:27 +00:00
Nextcloud bot 569cf31cd6
[tx-robot] updated from transifex 2019-07-25 02:14:40 +00:00
Nextcloud bot a024dcfc81
[tx-robot] updated from transifex 2019-07-22 02:15:59 +00:00
Nextcloud bot 9249a810fb
[tx-robot] updated from transifex 2019-07-21 02:15:10 +00:00
Nextcloud bot 602a48c411
[tx-robot] updated from transifex 2019-07-20 02:14:33 +00:00
Morris Jobke c00d6f4eac
Merge pull request #14540 from army1349/master
LDAP Password Modify Extended Operation support
2019-07-19 17:29:24 +02:00
Nextcloud bot d35f4a7645
[tx-robot] updated from transifex 2019-07-19 02:14:56 +00:00
Arthur Schiwon 40c9a743fa
adds an --update flag to check-user for manual sync of the ldap record
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-07-18 14:30:43 +02:00
Nextcloud bot 3d0e0f2353
[tx-robot] updated from transifex 2019-07-18 02:14:53 +00:00
Joas Schilling 55f5bc79a1
Keep the old method as a fallback and adjust the tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-16 11:36:32 +02:00
Joas Schilling 6d71e471e1
Update shipped implementations of the INotifier
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-15 15:15:00 +02:00
Nextcloud bot 8427ecf685
[tx-robot] updated from transifex 2019-07-05 02:14:09 +00:00
Morris Jobke 0d0850746e
Merge pull request #15741 from mxss/fix/phpdoc-fixes
misc phpdoc fixes
2019-07-02 22:25:41 +02:00
Arthur Schiwon d0f31c590d
Also invalidate groups after deletion
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-27 10:33:40 +02:00
Arthur Schiwon 108227ca6c
invalidates user when plugin reported deletion success
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-26 14:18:28 +02:00
Jan-Christoph Borchardt b466127b1f
Merge pull request #16055 from nextcloud/design/native-fonts
Use native font stack
2019-06-26 00:08:16 +02:00
Jan-Christoph Borchardt 97fbf91f29
Use native font stack
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-06-24 17:27:35 +02:00
Jan-Christoph Borchardt d14c0f2ed7
Move font from Nunito to Noto Sans
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-06-22 11:23:44 +02:00
Arthur Schiwon 5617785955
fixes LDAP Wizard forgetting groups on select with search
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-21 14:50:40 +02:00
blizzz c1eff72bdf
Merge pull request #15964 from nextcloud/enh/noid/user-creation-options
Opt-in for generation userid, requiring email addresses
2019-06-21 11:08:59 +02:00
Arthur Schiwon 660fbd64e3
ensures mapping of chosen userid
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-19 17:02:28 +02:00
Arthur Schiwon 0b34085f24
fixes return type in php doc
* the backend already expects and works with the string

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-19 13:40:07 +02:00
Arthur Schiwon 8a7b0a68a5
fixes returning the base when multiple are specified
* reading the config directly will return the value with line breaks
* using the proper accessor gives us all bases in an array
* returns the first matching one
* having user id provided for the group base is strange and does not let
  us operate like this. here we return the first one. might change in
  future, a backportable fix won't have an API change however.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-19 13:39:15 +02:00
Arthur Schiwon a1f2dbe29c
caches the displayname after an LDAP plugin set it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-18 12:42:03 +02:00
Arthur Schiwon 1d48c0313c
fix inGroup check, thus make integration tests succeed
there is not such strange return mode. Having invalid user ids caused this
check to fail, and as side effect share limitation to groups to not work.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-14 06:23:58 +02:00
Nextcloud bot 85767660ba
[tx-robot] updated from transifex 2019-06-14 02:14:26 +00:00
Nextcloud bot b32ee3a0bb
[tx-robot] updated from transifex 2019-05-29 02:13:44 +00:00
Nextcloud bot c3f779b97d
[tx-robot] updated from transifex 2019-05-28 02:13:42 +00:00
Arthur Schiwon c6c8a41d2f
group display name support (service level + ldap)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-27 12:03:05 +02:00
Max Kovalenko a83b79c5f8
misc phpdoc fixes
Signed-off-by: Max Kovalenko <mxss1998@yandex.ru>
2019-05-27 09:04:05 +03:00
blizzz 755611866e
Merge pull request #15604 from nextcloud/fix/12682/fix-possible-override-of-uniquemember
fixes possible override of uniqueMember by autodetection
2019-05-22 19:09:28 +02:00
Nextcloud bot af680f285e
[tx-robot] updated from transifex 2019-05-21 02:13:28 +00:00
Arthur Schiwon 3372bcc7fc
fixes possible override of uniqueMember by autodetection
* uniqueMember was the default so we did not know whether this setting is
  desired or the initial value
* autodetection of the user-group association attribute runs only when it
  was not set (as far as we knew)
* the default is now empty
* thus LDAPProvider might return this value as well (in exceptional cases)
* if a group base is given (edge case), use this instead of general base
* resolves #12682

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-17 16:19:23 +02:00
Nextcloud bot c60f6716b4
[tx-robot] updated from transifex 2019-05-07 00:12:58 +00:00
Nextcloud bot 5e8cedab9f
[tx-robot] updated from transifex 2019-05-01 00:12:41 +00:00
Nextcloud bot 01410491b9
[tx-robot] updated from transifex 2019-04-29 00:12:39 +00:00
Nextcloud bot 16b8017fc9
[tx-robot] updated from transifex 2019-04-18 00:12:48 +00:00
Nextcloud bot 9302e1b8dd
[tx-robot] updated from transifex 2019-04-16 00:17:30 +00:00
Joas Schilling 4c19b3b2c6
Bump versions of server and the requirements of apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-04-11 14:02:23 +02:00
Morris Jobke 36618b111f
Pass old value to user triggerChange hook
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-04-11 10:03:38 +02:00
Nextcloud bot 7641a1589f
[tx-robot] updated from transifex 2019-04-11 00:12:59 +00:00
Nextcloud bot 9c9c410094
[tx-robot] updated from transifex 2019-04-06 00:13:10 +00:00
Arthur Schiwon 518998093f
set the loglevel in context, save the condition
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-04-02 22:52:12 +02:00
Nextcloud bot a541443be7
[tx-robot] updated from transifex 2019-03-26 10:41:31 +00:00
Vinicius Cubas Brand 61572a5b2e
LDAP plugin: force createUser to return new user's DN
LDAP plugins must change the createUser method to return the DN, as we
need this to update the cache.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
Vinicius Cubas Brand a2c38148e7
Cache cleaning when subadmin adds user to group
This commit fix an error happening when the subadmin tries to create an
user, adding him/her to the group s/he is subadmin of, using a LDAP
User/Group plugin.

This just forces the cache to be reset after an user is added to a
group.

Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
Vinicius Cubas Brand c4dbc428f9
fix user creation using LDAP Plugin
Signed-off-by: Vinicius Cubas Brand <viniciuscb@gmail.com>
2019-03-21 10:20:46 +01:00
Nextcloud bot 6ea5beccd7
[tx-robot] updated from transifex 2019-03-21 01:13:49 +00:00
Peter Kubica 3ed1d158bc LDAP Password Modify Extended Operation support
Signed-off-by: Peter Kubica <peter@kubica.ch>
2019-03-19 01:58:46 +01:00
Roeland Jago Douma 219fb1a855
Fix showpassword loads
This is bundled by default. So trying to load it throws a warning in the
logs.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-03-18 14:38:44 +01:00
Nextcloud bot f8988c257c
[tx-robot] updated from transifex 2019-03-16 01:12:34 +00:00
Nextcloud bot 6fcf729545
[tx-robot] updated from transifex 2019-03-14 16:08:31 +00:00
Arthur Schiwon e36cede994
remove unused use statement
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-06 00:34:29 +01:00
Arthur Schiwon 5dd2207c95
fix nested group retrieval also for 2 other cases
and also consolidate logic in one method

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-03-05 11:07:40 +01:00
Roland Tapken 459b8a4845
Fixed unit test: groupsMatchFilter will not be called multiple times anymore.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
Roland Tapken e7c506cff1
Reduce queries to LDAP by caching nested groups
Nested groups are now cached in a CappedMemoryCache object to reduce
queries to the LDAP backend.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
Roland Tapken afb182650e
user_ldap: really resolve nested groups
The previous patch fixed the problem only for one level of indirection
because groupsMatchFilter() had been applied on each recursive call (and
thus there would be no second level if the first level fails the check).

This new implementation replaces the recursive call with a stack that
iterates all nested groups before filtering with groupsMatchFilter().

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:40 +01:00
Roland Tapken c2d8a36d9a
user_ldap: Filter groups after nexted groups
Currently groupsMatchFilter is called before nested groups are resolved.
This basicly breaks this feature since it is not possible to inherit
membership in a group from another group.

Minimal example:

  Group filter: (&(objectClass=group),(cn=nextcloud))
  Nested groups: enabled

  cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local
    objectClass: group

  cn=IT,ou=groups,dn=company,dn=local
    objectClass: group
    memberOf: cn=nextcloud,ou=Nextcloud,ou=groups,dn=company,dn=local

  cn=John Doe,ou=users,dn=company,dn=local
    objectClass: person
    memberOf: cn=IT,ou=groups,dn=company,dn=local

Since 'cn=IT,ou=groups,dn=company,dn=local' doesn't match the group
filter, John wouldn't be a member of group 'nextcloud'.

This patch fixes this by filtering the groups after all nested groups
have been collected. If nested groups is disabled the result will be the
same as without this patch.

Signed-off-by: Roland Tapken <roland@bitarbeiter.net>
2019-03-05 11:07:35 +01:00
Julius Härtl 6ee7286b41
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:57:01 +01:00
Nextcloud bot 374f89aba1
[tx-robot] updated from transifex 2019-03-01 01:12:36 +00:00
Nextcloud bot 057e81a1e2
[tx-robot] updated from transifex 2019-02-28 01:12:39 +00:00
Nextcloud bot 36b01e3c2d
[tx-robot] updated from transifex 2019-02-27 01:12:05 +00:00
Nextcloud bot 876e2792d0
[tx-robot] updated from transifex 2019-02-26 01:12:12 +00:00
Nextcloud bot 5df6400e28
[tx-robot] updated from transifex 2019-02-25 01:12:18 +00:00
rakekniven 73473de5de
Fixed grammar
Reported at Transifex.

Signed-off-by: Mark Ziegler <mark.ziegler@rakekniven.de>
2019-02-22 19:49:36 +01:00
Nextcloud bot 10388eab34
[tx-robot] updated from transifex 2019-02-21 01:12:02 +00:00
Nextcloud bot ad0b67cbce
[tx-robot] updated from transifex 2019-02-19 01:12:10 +00:00
Nextcloud bot 0b7b938a60
[tx-robot] updated from transifex 2019-02-18 01:12:09 +00:00
Nextcloud bot 1374183f92
[tx-robot] updated from transifex 2019-02-17 01:13:29 +00:00
Arthur Schiwon 685c13e091
add GUI option to set the $home placeholder
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
Arthur Schiwon 792bcb82ae
add LDAP ConfigHandler for external storages and "$home" var
* handler registered upon OCA\\Files_External::loadAdditionalBackends
  event as user_ldap is loaded before files_external
* new configuration field "ldapExtStorageHomeAttribute" (not in GUI yet)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 15:22:22 +01:00
Arthur Schiwon 5c10a46445
ensure attribute names are lower cased
otherwise they will be skipped when the results is being formatted and the
lower-cased result keys do not match.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-02-14 14:13:32 +01:00
Nextcloud bot 4d8c42a4fb
[tx-robot] updated from transifex 2019-02-14 01:12:26 +00:00
Nextcloud bot 45777abce0
[tx-robot] updated from transifex 2019-02-08 01:12:39 +00:00
Nextcloud bot 0df5110127
[tx-robot] updated from transifex 2019-02-06 11:27:29 +00:00
Filis Futsarov 18ae9d267a
Comment fix. 2019-01-30 23:23:09 +01:00
Arthur Schiwon c868892d2d
iterate over bases instead of doing parallel search
parallel search is not compatible with paged search, but the letter is
usually always applied.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-28 23:00:59 +01:00
Nextcloud bot 4611ad5a9c
[tx-robot] updated from transifex 2019-01-26 01:12:19 +00:00
Nextcloud bot 2277c21f3e
[tx-robot] updated from transifex 2019-01-24 01:12:02 +00:00
Nextcloud bot 2ba75ac9b0
[tx-robot] updated from transifex 2019-01-23 01:12:05 +00:00
Nextcloud bot e35a5ef387
[tx-robot] updated from transifex 2019-01-16 01:12:34 +00:00
Nextcloud bot 56ad07b85e
[tx-robot] updated from transifex 2019-01-15 01:12:14 +00:00
Nextcloud bot 8edd9b0e33
[tx-robot] updated from transifex 2019-01-14 01:12:00 +00:00
Nextcloud bot 363c0c31f4
[tx-robot] updated from transifex 2019-01-13 01:12:53 +00:00
Christoph Wurst 208788173d
Npmize (vendor) scripts
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-09 15:01:59 +01:00
Nextcloud bot a1b6333712
[tx-robot] updated from transifex 2019-01-05 01:11:57 +00:00
Morris Jobke c1ddd2fec9
Merge pull request #13138 from nextcloud/enhancement/noid/ldap-remnants-detected-field
register and show when an LDAP user was detected as unavailable/deleted
2019-01-04 22:48:05 +01:00
Arthur Schiwon 925043c60c
ensure db is pristine before starting the tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-04 22:10:22 +01:00
Nextcloud bot a1f9ed1d7d
[tx-robot] updated from transifex 2019-01-04 01:12:28 +00:00
Nextcloud bot 8d5b74b6b6
[tx-robot] updated from transifex 2018-12-31 01:11:41 +00:00
Nextcloud bot 760c502f3c
[tx-robot] updated from transifex 2018-12-28 01:11:49 +00:00
Nextcloud bot 1c3f468d56
[tx-robot] updated from transifex 2018-12-27 01:11:41 +00:00
Nextcloud bot 9d5f7c7f62
[tx-robot] updated from transifex 2018-12-24 01:11:46 +00:00
Arthur Schiwon 85f14bc591
LDAP: extend remnants output with "detected on" field
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:28 +01:00
Arthur Schiwon fbd4e9e651
add tests for the DUI
as they are interact with the DB they are more integraiton than unit tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-21 17:24:23 +01:00
Arthur Schiwon 8bacbffe28
do not forgot to store the second displayname portion
otherwise it causes a chain reaction of system addressbook updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-20 23:11:00 +01:00
Nextcloud bot 3d53398d07
[tx-robot] updated from transifex 2018-12-19 01:11:46 +00:00
Nextcloud bot f36082838e
[tx-robot] updated from transifex 2018-12-18 01:11:34 +00:00
blizzz e7950a5bd6
Merge pull request #12693 from nextcloud/fix/11474/fix-first-ldap-login
fix exception on LDAP mapping during login
2018-12-17 13:07:21 +01:00
Arthur Schiwon feb5366a42
LDAP clear cache on config modification also when done via API or CLI
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-12-17 00:31:27 +01:00
Nextcloud bot 51f13a7e9c
[tx-robot] updated from transifex 2018-12-14 01:12:32 +00:00
Nextcloud bot 7034df7d77
[tx-robot] updated from transifex 2018-12-13 01:11:56 +00:00
Nextcloud bot 95d33cd889
[tx-robot] updated from transifex 2018-12-04 01:12:05 +00:00
Nextcloud bot 68f04686a0
[tx-robot] updated from transifex 2018-11-29 01:11:34 +00:00
Arthur Schiwon c32cc4a194
cache users as existing after mapping
during login they might be cached as non-existing and cause an Exception
in the long run

reduces some duplication, too

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-27 17:07:59 +01:00
Daniel Kesselberg 6ce849f7b8
Add return type
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-25 12:30:54 +01:00
Daniel Kesselberg d17b32afd7
Fix count on string
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-24 22:06:45 +01:00
Joas Schilling 1751c28c28
Bump versions of server and the requirements of apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-23 10:28:40 +01:00
Nextcloud bot d664a9b37b
[tx-robot] updated from transifex 2018-11-23 01:12:51 +00:00
Nextcloud bot def8af3e7e
[tx-robot] updated from transifex 2018-11-16 01:12:14 +00:00
Morris Jobke 159d75945a
Merge pull request #12292 from nextcloud/fix/2947/lapse-sizelimit-error
avoid logging of "Partial search results returned: Sizelimit exceeded…"
2018-11-15 10:48:57 +01:00
Joas Schilling aa88254f64
Shorten index name of calendar changes table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
Joas Schilling bb352fb667
Use the defined func()->count() instead of manual counting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 15:44:45 +01:00
Arthur Schiwon deec5a70a0
avoid logging of "Partial search results returned: Sizelimit exceeded at"
LDAP servers respond with that even if a limit was passed with the
request. Having this statement logged causes a lot of confusion.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-11-07 13:15:55 +01:00
Nextcloud bot 9d7f02ec47
[tx-robot] updated from transifex 2018-11-04 01:14:02 +00:00
Arthur Schiwon 0c5d9127e8
remove app specific IUserTools and consolidate test
Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 22:44:50 +01:00
Roeland Jago Douma 8b2b238d86
Merge pull request #12054 from nextcloud/fix/5212/interact-with-userobject
LDAP: announce display name changes so that addressbook picks it up
2018-10-30 13:38:16 +01:00
Arthur Schiwon 49456e42f9
do not run into UniqueConstraintViolationException
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 12:12:03 +01:00
Morris Jobke 31ccf8580a
Merge pull request #12070 from nextcloud/fix/noid/announce-chosen-uid
announce the chosen uid (fixes wrong variable usage)
2018-10-30 10:12:04 +01:00
Arthur Schiwon d47e1513bc
remove unneeded empty search attribute values, fixes #12086
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
Arthur Schiwon 05f909dcf3
fixes wrong variable usage
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
Stefan Weil a226f65aa2 Fix off-by-one bugs
This fixes warnings from LGTM:

    Off-by-one index comparison against length may lead
    to out-of-bounds read.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
Arthur Schiwon bbe44108b5
only write when the displayname differs, but then announce it
refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
Arthur Schiwon 2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
Nextcloud bot a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
Morris Jobke 171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
Jan-Christoph Borchardt d9aa484641
Fix font-face on LDAP tooltip
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
Stefan Weil 2ad38200fb Add missing semicolons
This fixes some recommendations from LGTM:

    Avoid automated semicolon insertion (90% of all statements
    in the enclosing function have an explicit semicolon).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
Morris Jobke b458ed9c82
Properly escape column name in "createFunction" call
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
Nextcloud bot d9fe68ed12
[tx-robot] updated from transifex 2018-10-05 00:12:56 +00:00
Nextcloud bot b6e86121bc
[tx-robot] updated from transifex 2018-10-01 00:12:39 +00:00
Nextcloud bot dafd708075
[tx-robot] updated from transifex 2018-09-30 00:12:06 +00:00
Nextcloud bot 73aabbd3c0
[tx-robot] updated from transifex 2018-09-29 00:12:16 +00:00
Nextcloud bot 2ace0df82a
[tx-robot] updated from transifex 2018-09-27 00:12:26 +00:00
Nextcloud bot 2f45045c96
[tx-robot] updated from transifex 2018-09-26 00:12:23 +00:00
Nextcloud bot bdb01064e2
[tx-robot] updated from transifex 2018-09-25 00:12:07 +00:00
Nextcloud bot bd89af478e
[tx-robot] updated from transifex 2018-09-22 00:12:06 +00:00
Nextcloud bot 0211e17e3f
[tx-robot] updated from transifex 2018-09-21 00:12:08 +00:00
blizzz d9247f7640
Merge pull request #11245 from nextcloud/bugfix/8288/userldap-getusername-on-null
Check if user is null before getUsername
2018-09-18 11:38:16 +02:00
Nextcloud bot 2a51572cc4
[tx-robot] updated from transifex 2018-09-17 00:12:30 +00:00
Daniel Kesselberg 2d30511fa6
Check if user is null before getUsername
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-09-16 19:33:03 +02:00
Nextcloud bot 40bb45225a
[tx-robot] updated from transifex 2018-09-16 00:12:29 +00:00
Nextcloud bot 6112adfe06
[tx-robot] updated from transifex 2018-09-14 00:12:27 +00:00
Nextcloud bot 10351cb9da
[tx-robot] updated from transifex 2018-09-13 00:12:08 +00:00
Nextcloud bot 3653a2c889
[tx-robot] updated from transifex 2018-09-08 00:12:33 +00:00
Nextcloud bot 3a08f71981
[tx-robot] updated from transifex 2018-09-06 00:12:53 +00:00
Joas Schilling 47cc5e5895
Update version requirements and versions of shipped apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-05 14:27:06 +02:00
Nextcloud bot bcaf9a48bb
[tx-robot] updated from transifex 2018-09-05 00:12:50 +00:00
Nextcloud bot 021dad53be
[tx-robot] updated from transifex 2018-09-01 00:12:17 +00:00
Nextcloud bot 4da9a15b32
[tx-robot] updated from transifex 2018-08-30 00:12:07 +00:00
Nextcloud bot 8b47f45afa
[tx-robot] updated from transifex 2018-08-27 00:12:14 +00:00
Nextcloud bot d644cafae7
[tx-robot] updated from transifex 2018-08-25 00:12:33 +00:00
Morris Jobke c850b3ac20
Merge pull request #10820 from nextcloud/fix/noid/emptydefaultprefix
[LDAP] The WebUI Wizard also should not assign empty config IDs
2018-08-24 21:37:00 +02:00
Nextcloud bot 503fbc953e
[tx-robot] updated from transifex 2018-08-24 00:12:20 +00:00
Arthur Schiwon 7807add02d
[LDAP] The WebUI Wizard also should not assign empty config IDs
With 689df9a843 the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-23 17:58:35 +02:00
Nextcloud bot c0f48a7b40
[tx-robot] updated from transifex 2018-08-23 00:12:59 +00:00
Nextcloud bot 65410ab1cb
[tx-robot] updated from transifex 2018-08-22 00:12:11 +00:00
Morris Jobke 3d8f174774
Resolve all group memberships properly
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-08-21 10:57:50 +02:00
Morris Jobke 9cf11bd73c
Merge pull request #10687 from nextcloud/fix/noid/false-positive-change-mention
don't blame randome people for background email updates
2018-08-20 14:37:41 +02:00
Arthur Schiwon 2b903aa267
fix unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-15 16:11:07 +02:00
Nextcloud bot 62a9ec12bc
[tx-robot] updated from transifex 2018-08-15 00:13:40 +00:00
Arthur Schiwon b497b06867
don't force LDAP updates on userExists anymore
and remove some deprecated code

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-14 17:57:24 +02:00
blizzz d05c815796
Merge pull request #8855 from nextcloud/feature/noid/ldap-integration-autotests
behat integration tests for LDAP
2018-08-14 14:14:22 +02:00
Roeland Jago Douma 90a656305b
Bump autoloaders
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-08-10 15:03:22 +02:00
Nextcloud bot 103a2c30fb
[tx-robot] updated from transifex 2018-08-10 00:12:26 +00:00
Arthur Schiwon 59e35e3bf7
tests for user storage location
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-10 00:28:44 +02:00
Arthur Schiwon b069b13226
convert pagination tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon 0f6d98eed2
convert connection tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:12 +02:00
Arthur Schiwon eaf352b8d1
integration test to ensure entries without displayname don't cause trouble
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 4e8db8aa11
convert LDAP offline and backup server integration tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon a39c995083
FIX: emit assignedUserId only for users
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:11 +02:00
Arthur Schiwon 3450ed4536
integration test checking the group filter
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-08-09 23:45:10 +02:00
Nextcloud bot 6a9bee478d
[tx-robot] updated from transifex 2018-08-01 00:11:59 +00:00
Nextcloud bot 0c7a17795b
[tx-robot] updated from transifex 2018-07-28 00:12:07 +00:00
Nextcloud bot 4d060755e5
[tx-robot] updated from transifex 2018-07-23 00:12:05 +00:00
Nextcloud bot a927d2fc08
[tx-robot] updated from transifex 2018-07-20 00:12:09 +00:00
Julius Härtl 858bd67eff
Fix tests for backup ldap server connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 09:16:57 +02:00
Julius Härtl c2616df541
Only bind if configuration for the first server is available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-07-13 08:25:10 +02:00
Morris Jobke 8ccb99f416
Merge pull request #10098 from nextcloud/feature/noid/ldap-image-attribute
allow admin to disable fetching of avatars as well as a specific attribute
2018-07-11 12:19:58 +02:00
Nextcloud bot 0e0dd2a90b
[tx-robot] updated from transifex 2018-07-11 00:12:15 +00:00
Nextcloud bot a22bc0e787
[tx-robot] updated from transifex 2018-07-10 08:21:14 +00:00
Arthur Schiwon 846ab25fc0
adjust and add more unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:50:49 +02:00
Arthur Schiwon 343036e55c
allow admin to disable fetching of avatars as well as a specific attribute
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-05 11:12:51 +02:00
Arthur Schiwon a4dda465c2
let user set avatar in nextcloud von LDAP provides invalid image data
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 01:45:07 +02:00
Arthur Schiwon 552da85df8
Iron User_LDAP tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-07-03 00:29:34 +02:00
blizzz 28e64afb8c
Merge pull request #10034 from nextcloud/fix/noid/ldap-silence-quota-logmsgs
lower log level for quota manipulation cases
2018-06-28 23:06:23 +02:00
Arthur Schiwon cc51a00c93
lower log level for quota manipulation cases
and simplify the forest of ifs a little bit

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-28 21:10:07 +02:00
Arthur Schiwon 7a728f2154
LDAP backup server should not be queried when auth fails
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-06-27 23:12:07 +02:00
Nextcloud bot e4551106f5
[tx-robot] updated from transifex 2018-06-22 00:12:11 +00:00
Nextcloud bot f9c98d8621
[tx-robot] updated from transifex 2018-06-21 00:12:47 +00:00