5c03e2207b
Check array size, before using the 3rd element from it
2015-01-12 17:05:51 +01:00
7a393abdbd
Merge pull request #13210 from owncloud/use-isset
...
Check for existence of $_GET keys
2015-01-12 16:35:31 +01:00
f28235a7ef
fix retrieval of user groups
2015-01-12 16:25:11 +01:00
6daedaf344
Send the proper original name for uploaded files
2015-01-12 15:30:47 +01:00
5f7c115dfe
Merge pull request #13268 from owncloud/dnd-files-container
...
Allow dropping files on the table container
2015-01-12 13:27:53 +01:00
512ba327f7
Allow dropping files on the table container
...
Make it possible to drop files below the table even if the table is
smaller than the window height.
Added a check to make sure upload is not triggered on invisible lists.
2015-01-12 12:29:26 +01:00
331d73c3a3
Merge pull request #13182 from owncloud/download_versions
...
make versions of shared files downloadable
2015-01-12 12:03:21 +01:00
ddf81c2ed9
Merge pull request #13254 from owncloud/fixsharel10n
...
make Share/Download buttons localized again
2015-01-12 09:31:35 +01:00
9e550ab844
[tx-robot] updated from transifex
2015-01-12 01:55:52 -05:00
d8adc76125
l10n: delete permanently fix
2015-01-11 17:15:58 +01:00
691fab8be3
make Share button localized again
...
it seems we have forgotten to use named FileAction
2015-01-11 15:57:45 +01:00
f1aa8377fe
Merge pull request #13251 from owncloud/spaceoutside
...
keep spaces out of translation
2015-01-11 15:29:21 +01:00
8cd0962c6a
suggestion by transifex translator
2015-01-11 13:47:37 +01:00
2df331b6ed
keep spaces out of translation
...
otherwise translators cannot notice it on Transifex
2015-01-11 13:43:43 +01:00
3425c73815
[tx-robot] updated from transifex
2015-01-11 01:54:32 -05:00
33bb69e3e6
Merge pull request #13226 from owncloud/fix-encoding
...
Don't double encode string
2015-01-10 18:11:36 +01:00
22e5220c1f
[tx-robot] updated from transifex
2015-01-10 01:54:35 -05:00
e4840b5250
Don't double encode string
...
We already use `.text()` here which automatically properly encodes the string. Thus the string will be double-encoded and look ugly. (i.e. when you search for ">" you will see "No results found for >")
Fixes itself.
2015-01-10 01:19:37 +01:00
59a1d16d0f
Merge pull request #13204 from owncloud/enc_fix_key_lost
...
Encryption fix key lost if group share gets renamed
2015-01-09 18:40:51 +01:00
f65cf498f4
Check for existence of $_GET keys
...
Otherwise PHP errors are thrown in the error log.
2015-01-09 17:46:14 +01:00
b1031c6355
Merge pull request #13188 from owncloud/add-check-if-user-is-logged-in
...
Add check if user is logged-in
2015-01-09 16:45:53 +01:00
0500d3a506
unit tests
2015-01-09 15:49:44 +01:00
6cc40552b1
don't move encryption keys if a mount point was renamed
2015-01-09 15:39:36 +01:00
720fe858a3
fix rename field position, fix #12927
2015-01-09 13:05:22 +01:00
d699d31518
make versions of shared files downloadable
2015-01-09 12:46:24 +01:00
1cfcec8684
Add check if user is logged-in
...
Otherwise a fatal PHP error is thrown since the filesystem is not setup:
```
( ! ) Fatal error: Call to a member function getOwner() on null in /Users/lreschke/Programming/core/lib/private/files/filesystem.php on line 817
Call Stack
1 0.0004 247792 {main}( ) ../index.php:0
2 0.0946 5088776 OC::handleRequest( ) ../index.php:28
3 0.1423 7491280 OC\Route\Router->match( ) ../base.php:748
4 0.1664 8592152 call_user_func:{/Users/lreschke/Programming/core/lib/private/route/router.php:250} ( ) ../router.php:250
5 0.1664 8592216 __lambda_func( ) ../router.php:250
6 0.1665 8599064 require_once( '/Users/lreschke/Programming/core/apps/files_versions/ajax/getVersions.php' ) ../route.php(135) : runtime-created function:1
7 0.1801 9061096 OCA\Files_Versions\Storage::getUidAndFilename( ) ../getVersions.php:7
8 0.1801 9061144 OC\Files\Filesystem::getOwner( ) ../storage.php:45
```
Furthermore this adds the CSRF check as a nice-to-have addition, the requests accessing this are done via the jQuery AJAX methods and thus the header is automatically added to all requests already.
2015-01-09 11:55:18 +01:00
45a20744fc
add js tests for filelist filtering
2015-01-09 10:49:22 +01:00
a5099b01f9
Merge pull request #12984 from owncloud/ldap-user-cleanup-master
...
Ldap user cleanup master
2015-01-09 10:47:02 +01:00
b4606ec24f
Merge pull request #13184 from owncloud/fix-key
...
Verify existence of $_GET key
2015-01-09 10:39:22 +01:00
d4fc2f555b
[tx-robot] updated from transifex
2015-01-09 01:55:22 -05:00
199276bcbb
Verify existence of $_GET key
...
Otherwise when the file without any specified mimetype was accessed the error log was flooded with entries such as "Undefined index: mime", there can be multiple issues found about this in the forum and our bugtracker.
To test this access `/index.php/apps/files/ajax/mimeicon.php` with and without `$_GET['mime']`.
Fixes itself.
2015-01-09 02:31:59 +01:00
c1a79d24c5
fix order of initalizing instance properties, and paremeter order in a method call
2015-01-08 17:45:07 +01:00
6b0ae34de6
Merge pull request #13170 from owncloud/extstorage-fixsharedmountpointrootleadingslash
...
Fix source path when share is a mount point
2015-01-08 15:02:16 +01:00
c7f273040e
fix table name for getList
2015-01-08 14:21:40 +01:00
bdfb039e05
Merge pull request #13165 from mypetyak/typos-in-external-storage-xml
...
Minor typo updates to External Storage description
2015-01-08 14:00:00 +01:00
01c83158bb
Fix source path when share is a mount point
...
Whenever an external storage mount point is shared directly, its path is
empty which causes a leading slash to appear in the source path.
This fix removes the bogus leading slash in such situation.
2015-01-08 11:46:11 +01:00
6bda95037f
[tx-robot] updated from transifex
2015-01-08 01:56:00 -05:00
0f715708dc
Minor typo updates to External Storage description
...
This text is visible to admin users when they read the description of
the External Storage app.
2015-01-07 22:37:20 -06:00
edcba11a91
smb: rename textfield from root to subfolder
...
"root" or "subfolder" -> "Remote subfolder" on selected storages
missed ftp...
2015-01-07 20:54:05 +01:00
bfb6e350d5
Merge pull request #13016 from owncloud/sharing_fixes
...
don't delete share table entries for the unique name if re-share permission was removed
2015-01-07 18:14:53 +01:00
b6f63e9b3d
don't delete share table entries for the unique name if re-share permission was removed
2015-01-07 16:36:13 +01:00
0bb91cfcf3
don't show no files yet when mask is in place, fixes #13141
2015-01-07 15:59:39 +01:00
70dcebbf92
Correctly return false when translating a foreign activity
2015-01-07 15:02:25 +01:00
9668405ec7
doc fixes and removal of unnecessary use statements
2015-01-07 13:28:56 +01:00
5ce295907f
Merge pull request #12687 from owncloud/auto-escape-t-placeholders
...
Auto escape t placeholders
2015-01-07 12:57:33 +01:00
bfdf0db7c0
Autoescape of placeholders in t() and p() - for JS
...
* add disableEscape parameter to disable this functionality
* drop usage of escapeHTML() that is now done inside t()
* add unit test for escaped and not escaped placeholder
* proper JSDoc
2015-01-07 12:56:32 +01:00
6c335ee6fc
add test for mapping's getList method
2015-01-07 12:39:29 +01:00
fb37b3c687
Extend Test\TestCase and do not use uniqid()
2015-01-07 10:34:42 +01:00
2daf90dae6
[tx-robot] updated from transifex
2015-01-07 01:55:42 -05:00
b9235e2a24
inject DB Connection to user manager
2015-01-07 00:52:18 +01:00
64f0b055e6
inject IDateTimeFormatter to show-remnants command
2015-01-06 23:40:00 +01:00
40ecd30fba
inject oc config to User_LDAP
2015-01-06 23:28:49 +01:00
7528a1a475
Merge pull request #13130 from owncloud/getstoragestats-error-handling
...
Add error handling to getstoragestats.php
2015-01-06 18:35:09 +01:00
47eb0c59e6
Merge pull request #13128 from owncloud/files-scan-path
...
Fix check if a path argument is passed to occ files:scan
2015-01-06 18:17:19 +01:00
e724b78694
smaller fixes: coding style, PHPdoc, typos and few for DI
2015-01-06 17:50:06 +01:00
fe4592937a
Merge pull request #12653 from owncloud/full_content_search_results
...
Full content width search results
2015-01-06 16:44:58 +01:00
64e3ebae74
Add error handling to getstoragestats.php
2015-01-06 15:56:06 +01:00
5f6da758b7
Fix check if a path argument is passed to occ files:scan
2015-01-06 15:27:03 +01:00
357fbd88be
use class for no results div instead of id. the elements are not unique.
2015-01-06 14:34:35 +01:00
926737fdb7
clear search when navigating via breadcrumbs
2015-01-06 13:55:51 +01:00
6a3f69c2d0
[tx-robot] updated from transifex
2015-01-06 01:54:59 -05:00
7a812801db
correctly clear searchbox when switching filelists
2015-01-05 17:53:14 +01:00
10038640ae
fix onScroll breaking search, fix keyboard navigation, fix filter for files in other dirs
2015-01-05 14:28:09 +01:00
23900a5a39
filter trashbin and share views
2015-01-05 13:11:50 +01:00
28c8f5a0f9
Check for version before mounting a public link
...
* ownCloud 7.0.0 is needed - version of merge of server <-> server
sharing - https://github.com/owncloud/core/pull/8399
* adjust error message
2015-01-05 11:50:05 +01:00
a0023974e3
Merge pull request #13099 from owncloud/fix-provisioning-api
...
Remove unnecessary setUp method from provisioning_api
2015-01-05 10:35:24 +01:00
8776271103
[tx-robot] updated from transifex
2015-01-05 01:54:36 -05:00
f17f0ade7f
Remove unnecessary setUp method
2015-01-04 23:10:44 +00:00
84ed1034b4
[tx-robot] updated from transifex
2015-01-04 01:54:53 -05:00
fcae87170d
Merge pull request #13091 from owncloud/fix-provisioning-api
...
Fix remaining unit tests for provisioning_api
2015-01-03 22:41:44 +01:00
a20de1548d
Add proper group setup and teardown to all provisioning_api tests
2015-01-03 15:58:36 +00:00
5c0d7f2ee5
Create admin group before running provisioning_api tests
2015-01-03 15:39:42 +00:00
97d31946c3
Ensure admin group is present before running tests
2015-01-03 13:25:48 +00:00
92f062baac
Merge pull request #13082 from mmattel/rename_text_no_external_storages
...
adopt text "no external storage configured"
2015-01-03 11:59:22 +01:00
05ffa3ab7a
[tx-robot] updated from transifex
2015-01-03 01:54:29 -05:00
c44d41178a
adopt text "no ecternal storage configured"
...
storage -> storages
2015-01-02 21:00:02 +01:00
32d9563359
Change array element order to fix failing test
2015-01-02 19:07:31 +00:00
a4f270a9ce
Add placeholder app.php for provisioning_api so app is detected
2015-01-02 18:52:11 +00:00
ba235eb51d
delay hiding no results message until search is triggered
2015-01-02 16:13:15 +01:00
6f820b0209
use " to avoid escaping '
2015-01-02 14:59:55 +01:00
152c8b3969
text and icon fixes
2015-01-02 14:58:39 +01:00
2eec8dc156
correctly update search results when query is changed, show spinner when searching
2015-01-02 14:22:48 +01:00
0cca9e26c4
show no files found message
2015-01-02 12:50:21 +01:00
9e3f4e043f
make OCA.Search.Files available in tests and for other apps
2015-01-02 10:57:25 +01:00
6ba8881343
add file summary filter spec tests
2015-01-02 10:28:42 +01:00
f8700ec649
Fix rendering search results
2015-01-02 10:28:42 +01:00
457f5abf6c
fix count
2015-01-02 10:28:42 +01:00
4fdd626f0a
use correct visibilities
2015-01-02 10:28:42 +01:00
b45d0f03fc
fix js tests
2015-01-02 10:28:42 +01:00
8abd954d9a
instantiate file search
2015-01-02 10:28:42 +01:00
66cf17b32b
don't use full class name to register plugin
2015-01-02 10:28:42 +01:00
8bf048376c
allow getting the last query
2015-01-02 10:28:41 +01:00
80ded08ec4
hide irrelevant stuff in empty filelist
2015-01-02 10:28:41 +01:00
a6204efa0d
show audio icon & image previews
2015-01-02 10:28:41 +01:00
b93f2ddcb5
hide header when no files in list match
2015-01-02 10:28:41 +01:00
7e6c660b00
filter new rows
2015-01-02 10:28:41 +01:00
606f802b7b
move search results below filelist, show hint when results are off screen, use js plugin mechanism
2015-01-02 10:28:41 +01:00
4b357274bb
[tx-robot] updated from transifex
2015-01-02 01:54:28 -05:00
ec6e70889a
[tx-robot] updated from transifex
2015-01-01 01:54:30 -05:00
573be9092d
[tx-robot] updated from transifex
2014-12-31 01:54:33 -05:00
c8e946f633
[tx-robot] updated from transifex
2014-12-29 01:54:27 -05:00
9f327457dc
Merge pull request #13023 from owncloud/provisioning_api-2
...
[jenkins] Add provisioning_api app
2014-12-28 14:29:49 +01:00
85e02460c8
Merge pull request #13025 from lyonel/master
...
user_ldap is too verbose by default
2014-12-27 21:39:23 +01:00
688a4022df
Merge pull request #13012 from owncloud/small_fix
...
only send activity if we have a valid path and the file is readable
2014-12-27 21:38:47 +01:00
d2e53d1022
[tx-robot] updated from transifex
2014-12-27 01:54:33 -05:00
0836ce9cd8
[tx-robot] updated from transifex
2014-12-26 01:54:28 -05:00
e0fc26a5cb
[tx-robot] updated from transifex
2014-12-25 01:54:29 -05:00
dc85c20b18
Add provisioning_api app
...
enable unit tests for provisioning api
fix admin docu key
2014-12-24 22:15:20 +01:00
f94b300602
Be less verbose when using a paged search
...
Lower the priority from INFO to DEBUG
2014-12-24 16:35:36 +01:00
5a00b33a90
Be less verbose when disabling SSL cert validation
...
change log level from WARN to DEBUG
2014-12-24 16:32:27 +01:00
801b9e0494
[tx-robot] updated from transifex
2014-12-24 01:54:33 -05:00
8c48be453e
only send activity if we have a valid path and the file is readable
2014-12-23 13:32:54 +01:00
5352b4b2b8
Merge pull request #10292 from owncloud/external-share-delete
...
Fix trashbin when deleting a file over an external share
2014-12-23 11:21:06 +01:00
d8f04f5a97
[tx-robot] updated from transifex
2014-12-23 01:55:23 -05:00
711220e82d
Merge pull request #12997 from owncloud/sharing_activities
...
add activity if public shared file/folder was downloaded
2014-12-22 23:31:07 +01:00
3afcc71764
Make sure the path passed to the activity manager is normalized
2014-12-22 18:50:00 +01:00
393deb5961
add activity if public shared file/folder was downloaded
2014-12-22 18:50:00 +01:00
cf595ecc67
Merge pull request #12860 from owncloud/remove-apparently-unused-file
...
Remove unused file
2014-12-22 14:47:14 +01:00
eab4c029c2
Merge pull request #12961 from owncloud/try_to_cache_keys
...
cache keys to read them only once from the hard disc
2014-12-22 09:50:29 +01:00
92c8cd3933
[tx-robot] updated from transifex
2014-12-22 01:54:49 -05:00
510488ad3e
Merge pull request #12942 from owncloud/favs-missingsharedsubdirs
...
Fix issues with searchByTag in shared storage
2014-12-21 10:38:34 +01:00
312891c603
[tx-robot] updated from transifex
2014-12-21 01:54:36 -05:00
61ed363f82
planned refactorings for OC 8
2014-12-20 18:28:29 +01:00
3ca70d647a
move from \OC\Preferences to \OCP\IConfig
2014-12-20 16:33:37 +01:00
144d95de7d
basic adjustments for OC 8. I.e. no visible issues, LDAP tests pass.
2014-12-20 16:09:04 +01:00
5a54ca380d
[tx-robot] updated from transifex
2014-12-20 01:56:24 -05:00
4fa39250e7
LDAP User Cleanup: Port from stable7 without further adjustements
...
LDAP User Cleanup
background job for user clean up
adjust user backend for clean up
register background job
remove dead code
dependency injection
make Helper non-static for proper testing
check whether it is OK to run clean up job. Do not forget to pass arguments.
use correct method to get the config from server
methods can be private, proper indirect testing is given
no automatic user deletion
make limit readable for test purposes
make method less complex
add first tests
let preferences accept limit and offset for getUsersForValue
DI via constructor does not work for background jobs
after detecting, now we have retrieving deleted users and their details
we need this method to be public for now
finalize export method, add missing getter
clean up namespaces and get rid of unnecessary files
helper is not static anymore
cleanup according to scrutinizer
add cli tool to show deleted users
uses are necessary after recent namespace change
also remove user from mappings table on deletion
add occ command to delete users
fix use statement
improve output
big fixes / improvements
PHP doc
return true in userExists early for cleaning up deleted users
bump version
control state and interval with one config.php setting, now ldapUserCleanupInterval. 0 will disable it. enabled by default.
improve doc
rename cli method to be consistent with others
introduce ldapUserCleanupInterval in sample config
don't show last login as unix epoche start when no login happend
less log output
consistent namespace for OfflineUser
rename GarbageCollector to DeletedUsersIndex and move it to user subdir
fix unit tests
add tests for deleteUser
more test adjustements
Conflicts:
apps/user_ldap/ajax/clearMappings.php
apps/user_ldap/appinfo/app.php
apps/user_ldap/lib/access.php
apps/user_ldap/lib/helper.php
apps/user_ldap/tests/helper.php
core/register_command.php
lib/private/preferences.php
lib/private/user.php
add ldap:check-user to check user existance on the fly
Conflicts:
apps/user_ldap/lib/helper.php
forgotten file
PHPdoc fixes, no code change
and don't forget to adjust tests
2014-12-19 19:47:54 +01:00
8164415b45
Merge pull request #12749 from owncloud/server2server-sharing-ng
...
server to server sharing next generation
2014-12-19 19:04:44 +01:00
ad6814f920
Merge pull request #12101 from owncloud/ldap_split_mapping
...
Ldap split mapping from Access superclass
2014-12-19 18:52:30 +01:00
ec0f80fee9
Split mapping from Access and Helper classes into it's own. Fully test them, too.
...
remove unused methods
split mapping methods off from Access class
fix DB query handling
move 'clear mapping' methods from static helper to new mapping class
add tests
test directly with DB
finishing tests and fix return value from setDNbyUUID
add corresponding class for groups and make abstract test class neutral. helper tests is now obsolete as the tested functions were moved to the new mapper class.
add missing info to PHPDoc
add unmap method
fix namespaces
fix test inheritance
PHPDoc and a small code restructure for scrutinizer, no effective changes
PostgreSQL does not accept LIMIT in DELETE queries
phpdoc fixes, no code changes
2014-12-19 18:26:12 +01:00
aea991c22e
cache keys to read them only once from the hard disc
2014-12-19 16:04:13 +01:00
24993280ed
Next step in server-to-server sharing next generation, see #12285
...
Beside some small improvements and bug fixes this will probably the final state for OC8.
To test this you need to set up two ownCloud instances. Let's say:
URL: myPC/firstOwnCloud user: user1
URL: myPC/secondOwnCloud user: user2
Now user1 can share a file with user2 by entering the username and the URL to the second ownCloud to the share-drop-down, in this case "user2@myPC/secondOwnCloud".
The next time user2 login he will get a notification that he received a server-to-server share with the option to accept/decline it. If he accept it the share will be mounted. In both cases a event will be send back to user1 and add a notification to the activity stream that the share was accepted/declined.
If user1 decides to unshare the file again from user2 the share will automatically be removed from the second ownCloud server and user2 will see a notification in his activity stream that user1@myPC/firstOwnCloud has unshared the file/folder from him.
2014-12-19 15:20:24 +01:00
2d64797320
Merge pull request #12956 from owncloud/jenkins-user-backend-names
...
[jenkins only] introduce names for user backends - IUserBackend
2014-12-19 13:15:50 +01:00
678642a6a2
Merge pull request #12935 from owncloud/public-tagsmanagerissue
...
Only populate tags in main file list
2014-12-19 12:48:20 +01:00
6da33e1ea7
introduce names for user backends - IUserBackend
...
* LDAP with multiple servers also proved backendName
2014-12-19 10:17:17 +01:00
b32dc3f2a4
Merge pull request #12906 from owncloud/keyboardnav-feedback
...
Accessibility: Keyboard navigation feedback
2014-12-19 09:54:28 +01:00
39d6ddd38a
Merge pull request #12865 from owncloud/files-tags-webdav
...
Returns tags through WebDAV
2014-12-19 09:33:28 +01:00
028b0efd5c
[tx-robot] updated from transifex
2014-12-19 01:56:51 -05:00
7b2ae46762
first part of fixing feedback for file list when using keyboard
2014-12-19 00:34:06 +01:00
3036a8714d
Merge pull request #12941 from owncloud/wave-accessibility-compliance
...
Wave accessibility compliance
2014-12-19 00:30:56 +01:00
75e8b39826
Merge pull request #12879 from owncloud/mountconfig
...
Add mount specific options
2014-12-18 23:38:14 +01:00
891474b0d6
Merge pull request #12759 from owncloud/core-reduce-js-and-css
...
make sure styles and scripts are only loaded once
2014-12-18 23:18:37 +01:00
49318b4d93
Merge pull request #12896 from owncloud/drop-deprecated
...
first step to drop \OCP\Config:: in favour of IConfig
2014-12-18 23:01:49 +01:00
7798ea0cd7
show spinner on file upload in IE8, 9
2014-12-18 22:24:07 +01:00
11b3aa2dbe
Fix issues with searchByTag in shared storage
2014-12-18 17:27:56 +01:00
cd81687a38
properly escape variable
2014-12-18 17:19:23 +01:00
96ae18db59
get rid of unnecessary alt and title attributes
2014-12-18 17:05:27 +01:00
7faf3d17e5
fix accessibility for deleted files
2014-12-18 16:54:39 +01:00
1ef01de402
Merge pull request #12907 from owncloud/delete-invalid-external-share
...
Fix deleting invalid s2s shares
2014-12-18 16:38:13 +01:00
9009f5f727
add empty alt text to decorative preview of public share image
2014-12-18 16:00:55 +01:00
Joas Schilling
Morris Jobke
Arthur Schiwon
Robin Appelman
Lukas Reschke
Vincent Petry
Björn Schießle
Thomas Müller
Jenkins for ownCloud
Volkan Gezer
Volkan Gezer
Bjoern Schiessle
Jan-Christoph Borchardt
Jörn Friedrich Dreyer
Christopher Bunn
Martin
Tom Needham
Lyonel Vincent
Robin Appelman