Commit Graph

54785 Commits

Author SHA1 Message Date
Robin Appelman ec0ca19deb add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:09 +00:00
Morris Jobke ceed64154f
Merge pull request #26148 from nextcloud/backport/26013/stable19
[stable19] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-19 15:29:14 +01:00
Morris Jobke 64cfaf9a48
Merge pull request #26206 from nextcloud/backport/26200/stable19
[stable19] Update user share must use correct expiration validation
2021-03-19 15:20:30 +01:00
Vincent Petry ecaa02678a
Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.

To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 11:07:04 +01:00
Nextcloud bot 8670ef707f
[tx-robot] updated from transifex 2021-03-19 02:25:21 +00:00
Roeland Jago Douma 835d29a29e
Merge pull request #26095 from nextcloud/dependabot/npm_and_yarn/stable19/yargs-parser-5.0.1
[Security] Bump yargs-parser from 5.0.0 to 5.0.1
2021-03-18 19:39:25 +01:00
dependabot-preview[bot] 98eeceba52
[Security] Bump yargs-parser from 5.0.0 to 5.0.1
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 5.0.0 to 5.0.1. **This update includes a security fix.**
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/v5.0.1/CHANGELOG.md)
- [Commits](https://github.com/yargs/yargs-parser/compare/v5.0.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-18 15:22:49 +00:00
Morris Jobke eb749b3802
Merge pull request #26073 from nextcloud/search-file-limit-results-19
[19] limit constructing of result objects in file search
2021-03-18 13:54:10 +01:00
Morris Jobke 277994040c
Merge pull request #26191 from nextcloud/backport/25331/stable19
[stable19] Fix valid storages removed when cleaning remote storages
2021-03-18 13:09:05 +01:00
Daniel Calviño Sánchez 05cbdddb0d Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:28 +00:00
Daniel Calviño Sánchez 1e7e6c900c Add integration tests for "sharing:cleanup-remote-storages" OCC command
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:26 +00:00
Robin Appelman df77c7d37c
limit constructing of result objects in file search
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.

this saves about 40% of the time spend in the search request in my local testing

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:23:16 +01:00
Nextcloud bot 0e30c82f30
[tx-robot] updated from transifex 2021-03-18 02:25:29 +00:00
Morris Jobke f302616544
Merge pull request #26092 from nextcloud/backport/25722/stable19
[stable19] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:11 +01:00
Morris Jobke 9176410018
Merge pull request #26169 from nextcloud/backport/26072/stable19
[stable19] remove explicit fclose from S3->writeStream
2021-03-17 13:46:24 +01:00
kesselb 21b67e3b5b
Merge pull request #26164 from nextcloud/backport/26153/stable19
[stable19] Use correct exception type hint in catch statement
2021-03-17 11:08:46 +01:00
Robin Appelman 68fb72b028 remove explicit fclose from S3->writeStream
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:15 +00:00
Morris Jobke 10b024642f Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:49:42 +00:00
Nextcloud bot 709788e08f
[tx-robot] updated from transifex 2021-03-17 02:24:47 +00:00
kesselb 8daf30e278
Merge pull request #26135 from nextcloud/backport/25136/stable19
[stable19] do cachejail search filtering in sql
2021-03-16 17:41:19 +01:00
Robin Appelman 300c4dd6b8 verify that cache entry is valid
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:13 +00:00
Robin Appelman 53dcc7b1ca also implement for FailedCache and NullCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:11 +00:00
Robin Appelman cc1a5d5ced use returned file id for object store copy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:09 +00:00
Robin Appelman 603ec9be0c add ICopyFromCache trait to expose existing implementation
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:06 +00:00
Robin Appelman b2903064c9
only use share cacheentry when available
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 1d1d4de991
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman b9b2c6d2fa
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Robin Appelman 75a48fbc2a
fix cachjail searching for root
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Robin Appelman 564390e303
do cachejail search filtering in sql
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
Christoph Wurst f9c9e27e46
Merge pull request #26129 from nextcloud/backport/26115/stable19
[stable19] Log exceptions when creating share
2021-03-16 11:09:15 +01:00
Nextcloud bot 95b55423e8
[tx-robot] updated from transifex 2021-03-16 02:25:09 +00:00
Vincent Petry e43c93881e Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:34 +00:00
Christoph Wurst 3ac0601e26
Merge pull request #26060 from nextcloud/backport/25911/stable19
[stable19] Only clear share password model when actually saved
2021-03-15 09:48:23 +01:00
Nextcloud bot 901472a899
[tx-robot] updated from transifex 2021-03-15 02:24:26 +00:00
Nextcloud bot bbb616a604
[tx-robot] updated from transifex 2021-03-14 02:24:05 +00:00
Nextcloud bot 2a955bf864
[tx-robot] updated from transifex 2021-03-13 02:23:21 +00:00
Robin Appelman b39f9fb2c9 apply object store copy optimization when 'cross storage' copy is within the same object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:38 +00:00
Vincent Petry 20c16e21c2
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-12 12:23:36 +01:00
Nextcloud bot 54affce466
[tx-robot] updated from transifex 2021-03-12 02:23:09 +00:00
Roeland Jago Douma 586cbde4ba
Merge pull request #26041 from nextcloud/backport/25916/stable19
[stable19] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:44 +01:00
Nextcloud bot c750417f19
[tx-robot] updated from transifex 2021-03-11 02:23:35 +00:00
Roeland Jago Douma 0a7a401f95
Merge pull request #26028 from nextcloud/backport/25933/stable19
[stable19] Hide expiration date field for remote shares
2021-03-10 15:46:47 +01:00
Vincent Petry 6e394ac9d6 Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 08:45:54 +00:00
Julius Härtl 37b161b526 Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:05:03 +00:00
Nextcloud bot efcc3dd99f
[tx-robot] updated from transifex 2021-03-10 02:23:25 +00:00
Nextcloud bot 6db532444f
[tx-robot] updated from transifex 2021-03-09 02:24:20 +00:00
Roeland Jago Douma 1ca8eba6c8
Merge pull request #26010 from nextcloud/dependabot/npm_and_yarn/stable19/elliptic-6.5.4
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 20:42:02 +01:00
dependabot-preview[bot] 3f166960d8
[Security] Bump elliptic from 6.5.3 to 6.5.4
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 17:11:25 +00:00
Julius Härtl 594932c96c
Merge pull request #25964 from nextcloud/backport/25712/stable19
[stable19] Fix admin password strengthify tooltip
2021-03-08 10:29:33 +01:00
Nextcloud bot ad8a1bcc12
[tx-robot] updated from transifex 2021-03-08 02:23:37 +00:00