Commit Graph

47403 Commits

Author SHA1 Message Date
Daniel Calviño Sánchez 9a1d8eb0e5 Fix updating the password of a link share when passwords are enforced
The password input was shown in the popup menu when passwords were not
enforced, or when they were enforced but no password was set, which
prevented updating/changing the password once set. As the password input
should be shown too when password are enforced and a password is set no
condition is needed, so now the password input is always shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 23:37:54 +01:00
Daniel Calviño Sánchez 4321e0fc6d Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 14:46:07 +00:00
Roeland Jago Douma 95f4c21573
Merge pull request #13882 from nextcloud/backport/13866/stable15
[stable15] always use multipart uploader for s3 uploads
2019-01-29 15:17:34 +01:00
Arthur Schiwon 2b8a669d31 iterate over bases instead of doing parallel search
parallel search is not compatible with paged search, but the letter is
usually always applied.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-29 13:25:23 +00:00
Arthur Schiwon 3494f2794d integration test: pages search scenario with multiple bases
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-29 13:25:22 +00:00
Arthur Schiwon fe1500ff36 typo
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-29 13:25:20 +00:00
Robin Appelman ff5f28a65e always use multipart uploader for s3 uploads
the multipart uploader handles non seekable streams while `upload` does not

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-29 10:17:07 +00:00
Roeland Jago Douma 779fd2ea9c
Merge pull request #13821 from nextcloud/dependabot/npm_and_yarn/build/stable15/bower-1.8.8
[Security] Bump bower from 1.8.4 to 1.8.8 in /build
2019-01-28 13:42:16 +01:00
Morris Jobke 5820039160
Merge pull request #13852 from nextcloud/backport/13801/stable15
[stable15] Fix for high contrast theme
2019-01-28 11:13:09 +01:00
Jan-Christoph Borchardt 3f08f0066c Fix settings section divider being very visible below navigation bar
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-27 17:56:15 +00:00
Jan-Christoph Borchardt 8fa8f51ed5 Accessibility: Fix header icon opacity with high contrast theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-27 17:56:15 +00:00
Nextcloud bot fc0480282a
[tx-robot] updated from transifex 2019-01-26 01:12:28 +00:00
dependabot[bot] bf02927c7b
[Security] Bump bower from 1.8.4 to 1.8.8 in /build
Bumps [bower](https://github.com/bower/bower) from 1.8.4 to 1.8.8. **This update includes security fixes.**
- [Release notes](https://github.com/bower/bower/releases)
- [Changelog](https://github.com/bower/bower/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bower/bower/compare/v1.8.4...v1.8.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-25 11:40:45 +00:00
Nextcloud bot e4ea4061f6
[tx-robot] updated from transifex 2019-01-25 01:12:30 +00:00
Joas Schilling 87b7dd0af2 Merge the str_replacements
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 20:37:18 +00:00
Joas Schilling 63a1ef9154 Fix linear-gradient for long comments on dark-theme
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 20:37:17 +00:00
Morris Jobke d823f6fba8
Merge pull request #13792 from nextcloud/backport/13644/stable15
[stable15] ignore non existing users when retrieving details of group members
2019-01-24 19:17:22 +01:00
Morris Jobke 07ded47c22
Merge pull request #13794 from nextcloud/backport/13742/stable15
[stable15] Add icon to restore activity
2019-01-24 19:17:01 +01:00
Morris Jobke 61c2919225
Merge pull request #13793 from nextcloud/backport/13786/stable15
[stable15] Remove .css fileending from accessibility user css route
2019-01-24 19:16:07 +01:00
Roeland Jago Douma bb624724f6
Merge pull request #13761 from nextcloud/backport/15/13738
[stable15] Fix integration of social sharing into the link popover menu
2019-01-24 18:54:53 +01:00
Joas Schilling 4ab1970c43 Make the yellow favorite icon non-monochrome
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 13:46:54 +00:00
Joas Schilling d343873e7c Add icon to restore activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-24 13:46:53 +00:00
Julius Härtl 15e8a27338 Remove .css fileending from accessibility user css route
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-24 13:44:56 +00:00
Arthur Schiwon 922d35e0c3 ignore non existing users when retrieving details of group members
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-01-24 13:26:42 +00:00
Morris Jobke 266938da40
Merge pull request #13781 from nextcloud/backport/13772/stable15
[stable15] Show proper default locale
2019-01-24 10:59:58 +01:00
Morris Jobke c7ea554c62 Show proper default locale
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-01-24 07:32:26 +00:00
Roeland Jago Douma e6863782eb
Merge pull request #13769 from nextcloud/backport/13734/stable15
[stable15] Call proper function when fetching link shares in the breadcrumb view
2019-01-24 08:07:08 +01:00
Nextcloud bot 3079a88f03
[tx-robot] updated from transifex 2019-01-24 01:12:16 +00:00
Morris Jobke effc384c33
Merge pull request #13771 from nextcloud/stable15-13217-add-acceptance-tests-for-moving-and-copying-files
[stable15] Add acceptance tests for moving and copying files
2019-01-24 00:26:02 +01:00
Daniel Calviño Sánchez d4e1e9709f Add acceptance tests for moving and copying selections to another folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-23 21:05:54 +01:00
Daniel Calviño Sánchez f8473f4427 Add acceptance tests for moving and copying files to another folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-23 21:05:54 +01:00
Julius Härtl f861c84b97 Call proper function when fetching link shares in the breadcrumb view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-23 18:15:45 +00:00
Morris Jobke e086a5e7f9
Merge pull request #13758 from nextcloud/backport/13747/stable15
[stable15] Honor remember_login_cookie_lifetime
2019-01-23 15:31:05 +01:00
Morris Jobke 09db2bc701
Merge pull request #13740 from nextcloud/backport/13140/stable15
[stable15] Cache tokens when using swift's v2 authentication
2019-01-23 15:29:56 +01:00
Morris Jobke 51cd99d089
Merge pull request #13762 from nextcloud/backport/13730/stable15
[stable15] Respect user locale in natural sort comparator
2019-01-23 13:31:37 +01:00
Christoph Wurst 90e9877dd0 Respect user locale in natural sort comparator
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-01-23 11:20:19 +00:00
Julius Härtl cd79769921
Fix integration of social sharing into the link popover menu
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-23 12:07:59 +01:00
Roeland Jago Douma 4d3bb0a521 Honor remember_login_cookie_lifetime
If the remember_login_cookie_lifetime is set to 0 this means we do not
want to use remember me at all. In that case we should also not creatae
a remember me cookie and should create a proper temp token.

Further this specifies that is not 0 the remember me time should always
be larger than the session timeout. Because else the behavior is not
really defined.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-23 09:23:41 +00:00
Morris Jobke 703bb18fc9
Merge pull request #13744 from nextcloud/backport/13739/stable15
[stable15] cleanup shared lock if changing to exclusive lock failed
2019-01-23 08:18:06 +01:00
Nextcloud bot 34c1644714
[tx-robot] updated from transifex 2019-01-23 01:12:19 +00:00
Robin Appelman f7a4f1f128 cleanup shared lock if changing to exclusive lock failed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 15:12:46 +00:00
Roeland Jago Douma 581d908ace Bump autoloader
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-22 14:37:10 +00:00
Robin Appelman 6855c1594c Cache tokens when using swift's v2 authentication
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 14:37:09 +00:00
Nextcloud bot e1f917fd4c
[tx-robot] updated from transifex 2019-01-22 01:12:37 +00:00
Morris Jobke d908bf190c
Merge pull request #13670 from nextcloud/backport/13660/stable15
[stable15] Fix template paramter
2019-01-21 15:56:46 +01:00
Nextcloud bot c96e47b5ad
[tx-robot] updated from transifex 2019-01-21 01:12:02 +00:00
Nextcloud bot e9fae5e390
[tx-robot] updated from transifex 2019-01-20 01:12:42 +00:00
Nextcloud bot 2b577f5634
[tx-robot] updated from transifex 2019-01-19 01:12:32 +00:00
Roeland Jago Douma 16966ee5aa Fix template paramter
Else we get shown an error page instead of the correct 403.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-18 18:43:45 +00:00
Morris Jobke 3037e26948
Merge pull request #13665 from nextcloud/backport/13664/stable15
[stable15] Use warning background color & primary text color for setting warnings
2019-01-18 17:10:44 +01:00