Commit Graph

54746 Commits

Author SHA1 Message Date
Morris Jobke 34c027e443
Merge pull request #21940 from nextcloud/fix/14541/fix-fragile-acceptance-tests-part1
Revert "Disable fragile tests for now" partially
2020-07-24 01:04:13 +02:00
onehappycat e04525c186 Ignore whitespace in sharing by mail
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
2020-07-23 22:20:18 +02:00
Morris Jobke e84504c4d6
Use IBootstrap for the files_trashbin app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 22:03:14 +02:00
Morris Jobke ce314d9484
Merge pull request #21814 from nextcloud/techdebt/noid/federated_share_added-into-typed-event
Move federated_share_added into a typed event
2020-07-23 21:42:48 +02:00
Morris Jobke a169bd243f
Merge pull request #21972 from nextcloud/techdebt/noid/cleanup-phpunit-warnings
Fix PHPUnit deprecation warnings
2020-07-23 21:38:22 +02:00
Morris Jobke 173f8abc7e
Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix
fix moving files from external storage to object store trashbin
2020-07-23 21:35:18 +02:00
Morris Jobke 9275823a30
Merge pull request #21747 from simonspa/fix_mail_logosize
Fix header logo size in notification mails
2020-07-23 21:22:01 +02:00
Robin Appelman c8cf2e8a5b
fix renameFromStorage messing with folder mimetype
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 20:31:35 +02:00
Simon Spannagel d5b1297b55 Adjust tests to new e-mail layout
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-07-23 20:22:48 +02:00
Simon Spannagel 1fc54d3479 Fix header logo size in notification mails
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-07-23 17:52:21 +02:00
Morris Jobke 761cdf9877
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
Morris Jobke 1339ea15e2
Replace deprecated assertArraySubset with logic that does the same
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
Morris Jobke 7e6c0ec284
Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
Morris Jobke e4144e6b36
Remove deprecated test of internal attributes via assertAttributeEquals
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
Morris Jobke 0123cd0ae3
Use assertStringContainsString instead of assertContains on strings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 17:11:29 +02:00
Morris Jobke f8955bd0d1
Merge pull request #21973 from nextcloud/techdebt/noid/fix-risky-2fa-backup-code-test
Fix risky test in twofactor_backupcodes
2020-07-23 17:11:10 +02:00
Robin Appelman ad7798f9c9
use exceptions for error signaling in writeStream
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 15:24:52 +02:00
Robin Appelman fcad692b4a
rollback cache rename if trashbin move fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 15:24:48 +02:00
Robin Appelman 5949849322
fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.

By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-23 15:24:44 +02:00
Georg Ehrke cdf095d107
Merge pull request #21970 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.3.0
Bump @nextcloud/vue from 2.2.1 to 2.3.0
2020-07-23 15:09:33 +02:00
Morris Jobke 9af99a73dc
Merge pull request #21966 from nextcloud/enh/userbackend/custom_logout
Allow user backends to specify a custom logout url
2020-07-23 14:54:23 +02:00
Morris Jobke 49f33ee632
Fix risky test in twofactor_backupcodes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 14:32:58 +02:00
Georg Ehrke be20a494aa
Bump @nextcloud/vue from 2.2.1 to 2.3.0
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-23 14:12:28 +02:00
Roeland Jago Douma ba39d7adde
Merge pull request #21963 from nextcloud/fix/sharing/respect_default_share_permissions
Respect default share permissions
2020-07-23 10:53:36 +02:00
Roeland Jago Douma e0cc95f3aa
Allow user backends to specify a custom logout url
* Allows SSO backends to do a global logout

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 10:42:40 +02:00
Roeland Jago Douma df1fa52ee5
Respect default share permissions
Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 09:30:42 +02:00
Julius Härtl 8af979f56d
Merge pull request #21957 from nextcloud/techdebt/noid/bootstrap-testing
Use IBootstrap for the testing app
2020-07-23 08:50:25 +02:00
Morris Jobke 0763a17332
Move federated_share_added into a typed event
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 08:33:17 +02:00
Nextcloud bot 99d0ba5f7e
[tx-robot] updated from transifex 2020-07-23 02:17:03 +00:00
Morris Jobke 153337a5be
Use IBootstrap for the testing app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-22 22:28:04 +02:00
Roeland Jago Douma 94c74fb97b
Merge pull request #21946 from nextcloud/fix/webauthn/windows_hello
Do not double encode the userid in webauthn login
2020-07-22 21:29:21 +02:00
Roeland Jago Douma b573014e2d
Merge pull request #21949 from nextcloud/smb-3.2.6
update icewind/smb to 3.2.6
2020-07-22 21:19:14 +02:00
Roeland Jago Douma 686f369d66
Merge pull request #21950 from nextcloud/bugfix/noid/wipe-translation
Properly fetch translation for remote wipe confirmation dialog
2020-07-22 21:10:28 +02:00
Roeland Jago Douma 4c08b1754d Do not double encode the userid in webauthn login
* Else login fails with webauthn devices that send the userid
  - Like windows hello

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-22 18:56:42 +00:00
npmbuildbot[bot] 53088de52b Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-07-22 18:45:33 +00:00
Morris Jobke 346f647962
Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces
Make the bootstrap context return ContainerInterface instances
2020-07-22 20:38:50 +02:00
Julius Härtl cf3dd5b6bd
Properly fetch translation for remote wipe confirmation dialog
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-22 20:32:01 +02:00
John Molakvoæ c842678f0a
Merge pull request #21948 from nextcloud/bugfix/noid/accesibilityoca
Load accessibilityoca script
2020-07-22 17:47:33 +02:00
John Molakvoæ 5fea50b770
Merge pull request #21867 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.2.1 2020-07-22 17:47:18 +02:00
Daniel Calviño Sánchez 9303390b66
Hide share link menu before copying the share link in acceptance tests
The (old) Firefox version used in the acceptance tests does not properly
render the share link menu. As the menu is taller than it should
sometimes it covers the copy link button, so it is not possible to click
it without hiding the share link menu. Moreover, in those cases the
share menu button is also covered by the share menu, so the menu needs
to be closed by pressing the "Esc" key.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-22 15:59:35 +02:00
Georg Ehrke 387b1d7b13
Recompile JS assets
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-22 15:59:31 +02:00
Georg Ehrke f217b11443
Fix breaking changes of nc/vue update
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-22 15:55:59 +02:00
Georg Ehrke b73aedb81e
Bump @nextcloud/vue from 1.5.0 to 2.2.1
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-22 15:55:59 +02:00
Robin Appelman 7f7d361da2
update icewind/smb to 3.2.6
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-22 14:25:33 +02:00
Julius Härtl 57075fa54d
Load accessibilityoca script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-22 12:04:16 +02:00
Roeland Jago Douma cda6fad1e8
Merge pull request #21905 from nextcloud/dependabot/npm_and_yarn/babel/core-7.10.5
Bump @babel/core from 7.10.4 to 7.10.5
2020-07-22 09:44:08 +02:00
dependabot-preview[bot] cb363c6ab1
Bump @babel/core from 7.10.4 to 7.10.5
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.10.4 to 7.10.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.10.5/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-22 07:36:06 +00:00
Roeland Jago Douma 2166d718d9
Merge pull request #21904 from nextcloud/dependabot/npm_and_yarn/nextcloud/axios-1.3.3
Bump @nextcloud/axios from 1.3.2 to 1.3.3
2020-07-22 09:31:46 +02:00
Nextcloud bot 2e4cc6da17
[tx-robot] updated from transifex 2020-07-22 02:16:38 +00:00
Morris Jobke 7b250db60b
Merge pull request #21658 from nextcloud/trashbin-configurable-size
allow admin to configure the max trashbin size
2020-07-21 20:46:43 +02:00