d5b61f9afe
Prevent double slash in shareinfo request URL
2015-01-26 16:19:38 +01:00
5376b0b123
Add back exit()
2015-01-26 16:07:28 +01:00
f6e644b43f
Catch storage exception in scanner for remote shares
...
Whenever an exception occurs during scan of a remote share, the share is
checked for availability. If the storage is gone, it will be removed
automatically.
Also, getDirectoryContent() will now skip unavailable storages.
2015-01-26 13:59:49 +01:00
02b9bad81b
Fix bogus deletion on copy + unlink through rename
...
Cross-storage rename would cause copy + unlink. That unlink operation
must not trigger the trashbin.
2015-01-26 12:22:22 +01:00
d6939d67da
Remove duplicated definition of APIController
2015-01-26 10:20:01 +01:00
8605e84547
Fix #13632 and make new file menu more consistent with button
2015-01-25 20:15:08 +03:00
a698637e91
[tx-robot] updated from transifex
2015-01-25 01:54:38 -05:00
b8e1dd9c87
[tx-robot] updated from transifex
2015-01-24 01:54:51 -05:00
73a058e301
by default send mail for new server-to-server share
2015-01-23 21:59:07 +01:00
a1cc9eea56
Add trashbin storage wrapper unit test for versions
2015-01-23 18:39:21 +01:00
1f39a7aabe
Simplify trash storage unit tests
...
Needed to make it properly init the mount points
2015-01-23 18:08:59 +01:00
1a06edd712
Unregister trashbin storage wrapper at the end of tests
...
Some more tests that uses the storage wrapper now remove it afterwards
2015-01-23 15:36:09 +01:00
87a1b2bdc4
Preserve mtime when doing cross storage move
2015-01-23 15:11:27 +01:00
2e8c70327a
Remove storage wrapper for oc_trashbin in unit test
2015-01-23 14:55:38 +01:00
91f3952ac1
Only move files from the current user to the trashbin
2015-01-23 14:19:36 +01:00
67f1534e0f
Call final unlink in trash wrapper's storage
...
In the case of cross-storage delete, the files are copied to the trash,
then deleted. The final delete on the source storage would still reach
the trash wrapper.
This fix makes forwards that second call to the wrapped storage to make
the final delete work.
It fixes the issue with remote shares, local shares and external
storage.
Also, it uses a new function "renameRecursive" that renames the files
and preserves the mtimes (like "copy_recursive" did in the past))
2015-01-23 12:20:54 +01:00
7e6d2c73d2
Ignore favorites that are not available when creating the favorites list
...
Also correctly return the exception for all cases when adding/removing favos
2015-01-23 10:11:14 +01:00
bc93a8f140
[tx-robot] updated from transifex
2015-01-23 01:55:06 -05:00
9c7cd702c3
user fs must be setup up, so that the real user folder is mounted on the username based path
2015-01-22 19:16:28 +01:00
fc1865449d
adding console command to migrate encryption keys - refs #13450
2015-01-22 16:10:45 +01:00
5f3c6a97b2
[tx-robot] updated from transifex
2015-01-22 01:55:09 -05:00
c931eafc1f
Merge pull request #13517 from owncloud/keymanager-storage
...
Bypass the view when storing encryption keys
2015-01-22 00:41:48 +01:00
4dac664002
Merge pull request #13568 from owncloud/s2s_delete_shares_jenkins
...
[ignore] delete all server-to-server shares if a user gets deleted
2015-01-22 00:37:39 +01:00
762949afd9
Make naming of encryption app consistent
...
Fixes https://github.com/owncloud/core/issues/13580
2015-01-21 23:29:09 +01:00
7216983a08
delete all server-to-server shares if a user gets deleted
2015-01-21 17:11:34 +01:00
8ba42abbe4
Merge pull request #13432 from owncloud/animate_gifs_public_sharing
...
show animated gifs on public sharing page
2015-01-21 17:09:46 +01:00
9921308c62
Merge pull request #13540 from owncloud/s2s-fixpasswordfromdialog
...
External share dialog must properly read entered password
2015-01-21 16:51:56 +01:00
c48307027c
Fixed external cache test namespace
2015-01-21 15:52:56 +01:00
9fbdd1072e
Fix webdav mkdir for remote shares
2015-01-21 15:14:57 +01:00
f3d696599a
Add unit test for external share JS dialog
...
Moved external share JS code into a small plugin to make it testable.
Added unit test for the external share dialog logic + ajax calls.
2015-01-21 11:26:54 +01:00
23ea45760f
External share dialog must properly read entered password
2015-01-21 11:26:36 +01:00
b8ab21d3ad
[tx-robot] updated from transifex
2015-01-21 01:55:15 -05:00
2ed2a7c7a8
Merge pull request #13520 from owncloud/fix-comparison-op
...
this must be larger then (>), since buggy behaviour occurs when the para...
2015-01-20 20:15:04 +01:00
9cb1ef5675
this must be larger then (>), since buggy behaviour occurs when the parameter is a small number
2015-01-20 17:50:53 +01:00
750cff0e3e
Bypass the view when storing encryption keys
2015-01-20 16:20:49 +01:00
87a754c72e
avoid $this->cache being null - fixes #13491
2015-01-20 12:38:54 +01:00
e25a0303f4
Streamline CSRF and login check
...
Let's make this consistent with other pieces of the code to make it easier to auditable.
2015-01-20 12:24:13 +01:00
2ac015256f
[tx-robot] updated from transifex
2015-01-20 01:54:37 -05:00
870bc429b2
Merge pull request #13416 from owncloud/reauthenticate-if-session-differs-from-basic-auth
...
Prioritise Basic Auth header over Cookie
2015-01-19 22:23:02 +01:00
1c2cbf6fc6
Align checkbox configuration in external files
...
Modified CSS for files_external application to render labels around checkboxes at the same
width as other input elements, aligning them with other elements on the same page.
2015-01-19 17:01:25 +00:00
374ddbff55
show animated gifs on public sharing page
2015-01-19 16:20:06 +01:00
2229290cca
fix typo of blog -> changed to block
...
* fixes #13460
2015-01-19 15:57:53 +01:00
1810ea2d33
Merge pull request #13461 from owncloud/remove-strip-slashes
...
Remove stripslashes() from newfolder.php
2015-01-19 14:47:34 +01:00
003fc183a2
Remove stripslashes() from newfolder.php
2015-01-19 14:12:36 +01:00
cd4c7fd11f
Merge pull request #13377 from owncloud/trashbin_storage_wrapper
...
[trashbin] replace hook with storage wrapper
2015-01-19 13:17:52 +01:00
d75af7ddd2
Merge pull request #13362 from owncloud/fix-11442
...
LDAP Wizared: update user or group count only, when the multiselect is closed
2015-01-19 12:22:24 +01:00
15ae6b47ed
replace hook with storage wrapper
2015-01-19 09:16:15 +01:00
3404bd8cdd
[tx-robot] updated from transifex
2015-01-19 01:54:31 -05:00
aff22b3225
Merge pull request #13276 from Sugaroverdose/fix_#11348
...
fix safari rename button positioning #11348
2015-01-18 21:42:06 +01:00
48126c3f54
Merge pull request #13433 from owncloud/favoritesl10n
...
fix unlocalized favorites browser title and alttext
2015-01-18 20:36:19 +01:00
3d6f4ac24e
Merge pull request #13457 from owncloud/enc-skippartfiles
...
Skip stray part files during initial encryption
2015-01-19 14:40:21 +01:00
7a1ab3bb5e
Add class attribute types in encryption Util class
2015-01-19 13:01:52 +01:00
7c3c26ab94
Skip stray part files during initial encryption
2015-01-19 13:01:37 +01:00
31cd5185f1
[tx-robot] updated from transifex
2015-01-18 01:54:34 -05:00
d253ef51a5
fix unlocalized favorites browser title and alttext
2015-01-17 16:52:36 +01:00
dfbc405a45
Prioritise Basic Auth header over Cookie
...
There are a lot of clients that support multiple WebDAV accounts in the same application. However, they resent all the cookies they received from one of the accounts also to the other one. In the case of ownCloud this means that we will always show the user from the session and not the user that is specified in the basic authentication header.
This patch adds a workaround the following way:
1. If the user authenticates via the Sabre Auth Connector add a hint to the session that this was authorized via Basic Auth (this is to prevent logout CSRF)
2. If the request contains this hint and the username specified in the basic auth header differs from the one in the session relogin the user using basic auth
Fixes https://github.com/owncloud/core/issues/11400 and https://github.com/owncloud/core/issues/13245 and probably some other issues as well.
This requires proper testing also considering LDAP / Shibboleth and whatever instances.
2015-01-17 13:29:07 +01:00
60c4cb1dd6
[tx-robot] updated from transifex
2015-01-17 01:54:40 -05:00
141908bd9c
Add ie8 text-overflow: ellipsis support
...
minimum browser window width ≈ 1280px
2015-01-17 01:43:42 +03:00
b2879d3a99
use some magic to make 'popular browsers' work
...
as expected with inline-block span
2015-01-16 23:36:35 +03:00
2b99fc76ec
Cleanup of PHPDoc return types
2015-01-16 20:30:43 +00:00
48ad4ba9a0
Fixes shifted rename field
2015-01-16 17:32:18 +01:00
b81c89d400
compress icons of LDAP and WebDAV-Auth
2015-01-16 14:43:27 +01:00
7624b395f2
add icon for Provisioning API
2015-01-16 14:43:14 +01:00
1c4668f808
Merge pull request #13399 from owncloud/trashbin-fixpreviewroute
...
Fix preview route for trashbin
2015-01-16 13:48:02 +01:00
4d2ae71bf2
fix_#11348 Safari rename button positioning
2015-01-16 14:43:34 +03:00
a65f666834
[tx-robot] updated from transifex
2015-01-16 01:55:51 -05:00
a76f0a0ba7
Fix preview route for trashbin
2015-01-15 18:45:24 +01:00
7f24e77cfc
Disallow ctrl click to select when selection not allowed
2015-01-15 18:16:27 +01:00
d40301492d
Auto-blur when clicking on file to download
2015-01-15 18:08:36 +01:00
7d81299014
Fixed thumbnal z-index for when no checkbox is there
...
In file lists with no selection checkbox, the CSS selector is different.
The thumbnail also needs position:absolute and a z-index to be displayed
above the row's grey highlight.
2015-01-15 17:53:23 +01:00
56ba07aa5c
coding style
2015-01-15 12:25:36 +01:00
2fbe8bbcba
Merge pull request #13370 from Sugaroverdose/fix_#13322
...
Force browser to redraw favorite icon on src change
2015-01-15 11:20:22 +01:00
9b7c1a0093
Merge pull request #13347 from owncloud/share-scanpermissionsfromsource
...
Use source storage permissions when scanning shared storage
2015-01-15 11:15:15 +01:00
b2de3b3d8d
Force browser to redraw favorite icon
...
on src change
2015-01-15 12:26:55 +03:00
4c233fef2a
[tx-robot] updated from transifex
2015-01-15 01:54:41 -05:00
9d0915013b
Merge pull request #13352 from owncloud/hhvm-array-key
...
HHVM: Do not use key() on array as the result depends on the internal array pointer.
2015-01-15 01:06:45 +00:00
b4a52e889a
Do not use key() on array as the result depends on the internal array pointer.
2015-01-15 00:48:10 +01:00
7620af7550
Updated Dropbox and Google UI Javascript to create input elements instead of anchor.
2015-01-14 17:21:39 +00:00
02c6b72e25
Change from array() to [] style in files_external application info.
2015-01-14 17:16:12 +00:00
455ad005a0
Merge pull request #13350 from owncloud/autoload-translations
...
Autoload app's js translations
2015-01-14 18:12:05 +01:00
a9f0582e3e
Use source storage permissions when scanning shared storage
2015-01-14 18:11:23 +01:00
64f4f8fc84
Add support for SFTP key authentication
...
Add support for external files accessed via SFTP using public key exchange authentication.
Keys are generated automatically when the configuration is added, or can be regenerated on demand if a key is compromised.
Creation of a new configuration row now triggers focus on that row. This is used to trigger auto-configuration for SFTP keys.
Generated public keys are saved in user's data directory for easy retrieval by an external application.
Add controller for SFTP key generation AJAX
SFTP class initialisation no longer produces a warning if the password field is missing.
Add unit tests for SFTP with key authentication backend
2015-01-14 17:00:34 +00:00
3d94aa8953
update user or group count only, when the multiselect is closed
2015-01-14 17:31:20 +01:00
672bc28715
allow to read again objectclasses and groups under certain conditions
2015-01-14 15:15:55 +01:00
01304aa27e
Merge pull request #13351 from owncloud/check-for-existence
...
Check for existence of $_GET keys
2015-01-14 15:00:25 +01:00
87f81e5926
Remove unneeded addTranslations() calls
2015-01-14 14:36:23 +01:00
96cd7c017a
Check for existence of $_GET keys
...
`$dir` may for example very well not get passed at well.
2015-01-14 14:16:18 +01:00
25806346c2
remove deprecated code - fixes #13119
2015-01-14 13:56:49 +01:00
3a6d2fcc10
Merge pull request #13345 from owncloud/increase-files-external-versions
...
Increase files_externals oC required version and its own version
2015-01-14 13:24:08 +01:00
9b7421972b
Merge pull request #13332 from oparoz/fix-download-button
...
Download the current public folder only
2015-01-14 12:24:06 +01:00
f031a479ad
Increase files_externals oC required version and its own version
2015-01-14 12:21:47 +01:00
9a487f0445
Merge pull request #13286 from owncloud/sharing_upgrade
...
update script for new server-to-server sharing
2015-01-14 11:57:30 +01:00
64ee942e7d
Merge pull request #13288 from owncloud/enc_fix_public_download
...
[encryption] fix download of public shared files
2015-01-14 11:55:13 +01:00
e2a3547127
Merge pull request #13335 from owncloud/disable-rememberme-files-external
...
The files_external app might need the password so autologin must be disabled
2015-01-14 11:51:16 +01:00
5745b68fa9
Merge pull request #13311 from owncloud/fix_restore_keys
...
adapt decrypt all to the new folder structure
2015-01-14 11:40:22 +01:00
356bfb36dc
Download the current public folder only
...
From within a shared/public directory, when drilling down folders, some
users want to be able to download what they're currently looking at, not
the whole shared folder. The whole archive is always a click away anyway
since a user can click on the home button.
2015-01-14 11:28:36 +01:00
caaae1094f
The files_external app might need the password so autologin must be disabled
2015-01-14 10:19:22 +01:00
65ee2b1de8
Merge pull request #13325 from owncloud/kill-strip-slashes
...
Get rid of `stripslashes()`
2015-01-14 08:27:42 +01:00
f367bbb49d
[tx-robot] updated from transifex
2015-01-14 01:55:16 -05:00
51d783ca6e
JS cleanup
2015-01-13 18:39:37 +01:00
3ff3f641d6
Get rid of `stripslashes()`
...
This conversions are actually totally unneeded and probably left-overs from ages where the safe_mode was still a valid thing.
2015-01-13 17:43:36 +01:00
d50e70ba3a
set accept to 1 (=true) for all server-to-server shares on update, at this point in time all shares are created by the first version of server-to-server sharing and are accepted if they were added to the table
2015-01-13 17:24:00 +01:00
4766dac6f4
Fix PHP doc and enforce type
2015-01-13 14:47:54 +01:00
83574053a3
if we download a public shared file we need to retrieve the user from the path
2015-01-13 14:22:54 +01:00
6d73aff9ad
Merge pull request #13277 from owncloud/pasteurl
...
add https:// placeholder for From Link feature. closes #13255
2015-01-13 12:51:58 +01:00
89f17ef6fe
adapt decrypt all and restore/delete key backups to the new folder structure for encryption key introduced with OC8
2015-01-13 12:45:33 +01:00
c4aeb0b5b5
Merge pull request #13289 from owncloud/fav-keepfavoncancelrename
...
Properly update internal file info with updated tags
2015-01-13 08:28:30 +01:00
3ece0a7767
[tx-robot] updated from transifex
2015-01-13 01:56:58 -05:00
d20a1bbdbf
Merge pull request #13154 from owncloud/fix13141
...
don't show no files yet when mask is in place, fixes #13141
2015-01-12 22:48:25 +01:00
18b5966f3a
add https:// placeholder for From Link feature. closes #13255
2015-01-12 20:11:45 +01:00
ec70246be2
Merge pull request #13272 from owncloud/fav-renamekeepfav
...
Fixes issues when renaming favorite file
2015-01-12 19:12:31 +01:00
8cc13031e9
Return path attribute for ajax rename operations
...
This fixes an issue when renaming files from a flat list view like
"Favorites" or "Shared with you", in which case the path needs to be
present in the response to make sure the data-path attribute is properly
set in the JS side.
2015-01-12 18:15:31 +01:00
dac7828480
Return tags after rename
...
To make it possible for the web UI to correctly display the tag/favorite
information after a rename, this information is now returned in the
rename response
2015-01-12 18:14:17 +01:00
ef1dd3ea0a
Properly update internal file info with updated tags
...
Whenever tags are updated, they need to be updated in the file list's
file info array as well.
This commit also adds unit tests and makes sure that whichever tags are
sent back by the server after update are used when updating
attributes/fileinfo.
2015-01-12 17:58:57 +01:00
d36a2c8b04
Merge pull request #13285 from owncloud/fix-encryption-check-number-of-parts
...
Check array size, before using the 3rd element from it
2015-01-12 17:58:36 +01:00
2a03568623
Merge pull request #13279 from owncloud/upload-original-name
...
Send the proper original name for uploaded files
2015-01-12 17:48:12 +01:00
af4d60adb0
Merge pull request #13280 from owncloud/fix-12306
...
fix retrieval of user groups
2015-01-12 17:42:37 +01:00
5c03e2207b
Check array size, before using the 3rd element from it
2015-01-12 17:05:51 +01:00
7a393abdbd
Merge pull request #13210 from owncloud/use-isset
...
Check for existence of $_GET keys
2015-01-12 16:35:31 +01:00
f28235a7ef
fix retrieval of user groups
2015-01-12 16:25:11 +01:00
6daedaf344
Send the proper original name for uploaded files
2015-01-12 15:30:47 +01:00
5f7c115dfe
Merge pull request #13268 from owncloud/dnd-files-container
...
Allow dropping files on the table container
2015-01-12 13:27:53 +01:00
512ba327f7
Allow dropping files on the table container
...
Make it possible to drop files below the table even if the table is
smaller than the window height.
Added a check to make sure upload is not triggered on invisible lists.
2015-01-12 12:29:26 +01:00
331d73c3a3
Merge pull request #13182 from owncloud/download_versions
...
make versions of shared files downloadable
2015-01-12 12:03:21 +01:00
ddf81c2ed9
Merge pull request #13254 from owncloud/fixsharel10n
...
make Share/Download buttons localized again
2015-01-12 09:31:35 +01:00
9e550ab844
[tx-robot] updated from transifex
2015-01-12 01:55:52 -05:00
d8adc76125
l10n: delete permanently fix
2015-01-11 17:15:58 +01:00
691fab8be3
make Share button localized again
...
it seems we have forgotten to use named FileAction
2015-01-11 15:57:45 +01:00
f1aa8377fe
Merge pull request #13251 from owncloud/spaceoutside
...
keep spaces out of translation
2015-01-11 15:29:21 +01:00
8cd0962c6a
suggestion by transifex translator
2015-01-11 13:47:37 +01:00
2df331b6ed
keep spaces out of translation
...
otherwise translators cannot notice it on Transifex
2015-01-11 13:43:43 +01:00
3425c73815
[tx-robot] updated from transifex
2015-01-11 01:54:32 -05:00
33bb69e3e6
Merge pull request #13226 from owncloud/fix-encoding
...
Don't double encode string
2015-01-10 18:11:36 +01:00
22e5220c1f
[tx-robot] updated from transifex
2015-01-10 01:54:35 -05:00
e4840b5250
Don't double encode string
...
We already use `.text()` here which automatically properly encodes the string. Thus the string will be double-encoded and look ugly. (i.e. when you search for ">" you will see "No results found for >")
Fixes itself.
2015-01-10 01:19:37 +01:00
59a1d16d0f
Merge pull request #13204 from owncloud/enc_fix_key_lost
...
Encryption fix key lost if group share gets renamed
2015-01-09 18:40:51 +01:00
f65cf498f4
Check for existence of $_GET keys
...
Otherwise PHP errors are thrown in the error log.
2015-01-09 17:46:14 +01:00
b1031c6355
Merge pull request #13188 from owncloud/add-check-if-user-is-logged-in
...
Add check if user is logged-in
2015-01-09 16:45:53 +01:00
0500d3a506
unit tests
2015-01-09 15:49:44 +01:00
6cc40552b1
don't move encryption keys if a mount point was renamed
2015-01-09 15:39:36 +01:00
720fe858a3
fix rename field position, fix #12927
2015-01-09 13:05:22 +01:00
d699d31518
make versions of shared files downloadable
2015-01-09 12:46:24 +01:00
1cfcec8684
Add check if user is logged-in
...
Otherwise a fatal PHP error is thrown since the filesystem is not setup:
```
( ! ) Fatal error: Call to a member function getOwner() on null in /Users/lreschke/Programming/core/lib/private/files/filesystem.php on line 817
Call Stack
1 0.0004 247792 {main}( ) ../index.php:0
2 0.0946 5088776 OC::handleRequest( ) ../index.php:28
3 0.1423 7491280 OC\Route\Router->match( ) ../base.php:748
4 0.1664 8592152 call_user_func:{/Users/lreschke/Programming/core/lib/private/route/router.php:250} ( ) ../router.php:250
5 0.1664 8592216 __lambda_func( ) ../router.php:250
6 0.1665 8599064 require_once( '/Users/lreschke/Programming/core/apps/files_versions/ajax/getVersions.php' ) ../route.php(135) : runtime-created function:1
7 0.1801 9061096 OCA\Files_Versions\Storage::getUidAndFilename( ) ../getVersions.php:7
8 0.1801 9061144 OC\Files\Filesystem::getOwner( ) ../storage.php:45
```
Furthermore this adds the CSRF check as a nice-to-have addition, the requests accessing this are done via the jQuery AJAX methods and thus the header is automatically added to all requests already.
2015-01-09 11:55:18 +01:00
45a20744fc
add js tests for filelist filtering
2015-01-09 10:49:22 +01:00
a5099b01f9
Merge pull request #12984 from owncloud/ldap-user-cleanup-master
...
Ldap user cleanup master
2015-01-09 10:47:02 +01:00
b4606ec24f
Merge pull request #13184 from owncloud/fix-key
...
Verify existence of $_GET key
2015-01-09 10:39:22 +01:00
d4fc2f555b
[tx-robot] updated from transifex
2015-01-09 01:55:22 -05:00
199276bcbb
Verify existence of $_GET key
...
Otherwise when the file without any specified mimetype was accessed the error log was flooded with entries such as "Undefined index: mime", there can be multiple issues found about this in the forum and our bugtracker.
To test this access `/index.php/apps/files/ajax/mimeicon.php` with and without `$_GET['mime']`.
Fixes itself.
2015-01-09 02:31:59 +01:00
c1a79d24c5
fix order of initalizing instance properties, and paremeter order in a method call
2015-01-08 17:45:07 +01:00
6b0ae34de6
Merge pull request #13170 from owncloud/extstorage-fixsharedmountpointrootleadingslash
...
Fix source path when share is a mount point
2015-01-08 15:02:16 +01:00
Vincent Petry
Joas Schilling
Sugaroverdose
Jenkins for ownCloud
Bjoern Schiessle
Robin Appelman
Arthur Schiwon
Thomas Müller
Morris Jobke
Lukas Reschke
Ross Nicoll
Georg Ehrke
Volkan Gezer
Robin McCorkell
Jan-Christoph Borchardt
Andreas Fischer
Björn Schießle
Olivier Paroz
Volkan Gezer
Jörn Friedrich Dreyer