416f8b186d
Use @return instead of @returns
2014-05-11 16:27:18 +02:00
fc8be5abc3
Use proper PHPDoc and variable names in the LDAP lib
...
My IDE was so sad about this that it marked the whole file in red and yellow and forced me to fix this.
2014-05-11 15:17:27 +02:00
645ecb7644
Merge pull request #6297 from leo-b/fix_ldap_errors
...
only check ldap_errno if an ldap_* function actually fails
2014-04-23 16:26:43 +02:00
c1c2f2c49e
add additional comments, PHPdoc and check whether it's really applicable
2014-04-22 18:36:43 +02:00
1c71d5c444
LDAP: cache display names immediately on retrieval, saves tens of unecessary queries to LDAP server in the share dialog for example
2014-04-22 18:36:37 +02:00
36c8dec10a
Merge pull request #8220 from owncloud/type-hinting-ldap
...
Fix PHPdoc in user_ldap
2014-04-17 18:15:40 +02:00
bad41c05b8
Fix PHPdoc in user_ldap
...
using scrutinizer patch
2014-04-15 21:05:49 +02:00
ee3368d2ad
replace hardcoded limit of 400 with user controlled ldapPagingSize value
2014-04-09 11:38:51 +02:00
2e5adadad7
Put inner loop into own method, let's see whether it makes scrutinizer happier
2014-04-09 11:31:56 +02:00
bdc418d1f9
var count is assigned in the inner loop so it must be checked inside there to be properly used as part of the exit condition of the outer loop
2014-04-09 11:31:56 +02:00
43402c56dd
initialize variable
2014-04-09 11:31:56 +02:00
40f9875f11
LDAP: fix user report i.e. count for LDAP servers with really many users
2014-04-09 11:31:56 +02:00
8bb27551bd
LDAP: make sure cache key for paged result cookie matches when limit or offset is null or 0
2014-04-09 11:31:56 +02:00
7c3da27bf6
Fix duplicate ipauniqueid
2014-03-20 20:38:06 +00:00
ca595611f5
Add FreeIPA UUID compatibility, fixes #7796
...
Ability to use ipauniqueid for the UUID of a user
2014-03-19 20:30:24 +00:00
f850fcfac5
"reset" ldap pagedSearch control by setting it to a high value
2014-03-06 12:23:20 +01:00
8fcc29ee8b
only check ldap_errno if an ldap_* function actually fails
...
fix wizard errors
reset search paging right after the search, not before some of the possible next search operations
cookie contains binary characters, don't log it
(avoids json_encode(): Invalid UTF-8 sequence in argument errors)
2014-03-06 12:07:03 +01:00
c0328b4f0f
LDAP: improve compilation of filters
2014-02-19 13:13:01 +01:00
adaee6a5a1
Scrutinizer Auto-Fixes
...
This patch was automatically generated as part of the following inspection:
https://scrutinizer-ci.com/g/owncloud/core/inspections/cdfecc4e-a37e-4233-8025-f0d7252a8720
Enabled analysis tools:
- PHP Analyzer
- JSHint
- PHP Copy/Paste Detector
- PHP PDepend
2014-02-19 09:31:54 +01:00
9fac95c2ab
Merge branch 'master' into scrutinizer_documentation_patches
...
Conflicts:
lib/private/appconfig.php
2014-02-14 23:03:27 +01:00
e156f85bfb
Rephrase and clarify log message
2014-02-10 11:29:08 +01:00
2a6a9a8cef
polish documentation based on scrutinizer patches
2014-02-06 17:02:21 +01:00
b669e1a3c1
LDAP: implement userCount action. This required to (finally) clean up and refactor the search method, which will have a positive performance impact on paged search.
2014-01-08 12:07:57 +01:00
03375d6c52
LDAP: username2dn should only return DNs that belong to the current LDAP server. Might be not perfect. Easy perfect solution would increase communication with LDAP server. Let's see if it is good enough
2013-11-25 22:08:11 +01:00
ffb0e14d7b
replacing ownCloud by theme-able name or avoid it's usage
2013-10-29 23:29:16 +01:00
81dbe7dab7
Port PR #5457 to master
2013-10-25 14:15:05 +02:00
3fc232370e
make sure the shared ldap connection is rebound to the configured user after being used for password checking.
2013-10-25 11:12:18 +02:00
d78a80a689
merge master with resolved conflicts
2013-10-23 12:01:45 +02:00
e61d961efb
LDAP: Fix base-comparison with multibyte characters, fixes #5081 . Thanks to @sfyang
2013-10-19 00:51:37 +02:00
652caa1c88
LDAP: move Configuration out of Connection into class of its own. The new wizard requires it.
2013-10-17 19:13:14 +02:00
0c837cefb6
LDAP: allow different UUID attributes for groups and users
2013-10-04 11:47:40 +02:00
81cf4a22ef
LDAP: coding style
2013-09-27 13:34:15 +02:00
d4f92494a2
LDAP: make Access be a dependency to the user and group backend instead of inheriting it.
2013-09-27 13:34:15 +02:00
6e850e0bee
LDAP: establish wrapper interface to allow proper mocking
2013-09-27 13:34:15 +02:00
52454e39b7
LDAP: move is_resource check to ldap wrapper to make it mockable
2013-09-27 13:34:15 +02:00
d34fbf3a86
LDAP: move PHP LDAP functions calls to an LDAP Wrapper for better isolation and mock testing
2013-09-27 13:34:15 +02:00
321c514782
LDAP: case insensitive replace for more robustness
2013-08-27 22:23:48 +02:00
88fc410c19
fix numRows usage in user_ldap
2013-06-24 16:29:58 +02:00
bd7771867b
LDAP: fix generation of alternate internal name on conflicts. Use also smaller number for better user experience on e.g. *DAV links
2013-05-30 16:55:21 +02:00
beaa10b823
Merge branch 'master' into ldap_configurable_username_n_uuid
2013-05-13 12:41:22 +02:00
3f1717d3d5
LDAP: implement UUID and internal username override
2013-05-08 14:56:52 +02:00
175633d380
Merge pull request #3050 from owncloud/===_and_!==_in_user_ldap-app
...
Use === and !== in user_ldap app
2013-05-07 12:45:43 -07:00
1e2b872160
LDAP: cachekey in set method needs to match with that one from get
2013-05-03 15:13:37 +02:00
22a8e7ad55
LDAP: remove restriction from group names to be in line with core behaviour again
2013-05-03 14:11:06 +02:00
d6b13ccd12
Use !== and === in user_ldap app – Part 2
2013-04-20 22:46:37 +02:00
0f4e02b6fc
LDAP: avoid irritating log output
2013-03-19 14:40:30 +01:00
1e07801c95
LDAP: compatibility with Novell eDirectory UUID
2013-03-11 13:30:06 +01:00
055fadd10d
LDAP: escape some more chars for proper search filter, fixes #1673
2013-03-05 14:33:20 +01:00
b08894ba77
LDAP: error codes can be negative, too
2013-03-05 13:47:03 +01:00
64551ee06f
LDAP: sort users on server-side
2013-02-26 22:27:09 +01:00
92a36ca8b8
Join short comment lines
2013-02-15 15:45:34 +01:00
1ef2ecd6e8
Style cleanup user_ldap
2013-02-14 22:16:48 +01:00
1e45453da2
LDAP: format dn before using it, not other way round. fixes #1605
2013-02-13 14:49:18 +01:00
afc9fe419a
adjust copyright
2013-02-10 21:53:27 +01:00
dbb4be903c
LDAP: change generation of internal names. Use UUID for users. Change to sequential numbers for groups as they are still used as display names
2013-02-10 21:52:57 +01:00
b3b0544e17
LDAP: make it possible to define attributes that should be considered on searches
2013-01-31 01:46:34 +01:00
ad1113c2cb
LDAP: fix parameter passed not as expected
2013-01-16 14:56:57 +01:00
4a8c25eef5
dechex not necessary, do not waste time with it
2013-01-08 19:25:19 +01:00
19fa78d1ee
Code style
2013-01-08 19:00:49 +01:00
ec1caa7d35
support LDAP search using multiple base DNs also with paged results, implements #395
2013-01-04 23:57:55 +01:00
81489ad860
support multiple base DNs
2013-01-03 21:38:53 +01:00
df7d6cb26c
More style fixes
2012-12-15 00:43:46 +01:00
68562dafb4
More whitespace fixes
2012-12-15 00:43:46 +01:00
f39454ed12
Fix "Line indented incorrectly"
2012-12-15 00:43:46 +01:00
8256650da8
Fix "No space found after comma in function call"
2012-12-15 00:43:46 +01:00
680ff3a51b
Merge pull request #584 from wardragon/ldap_access_userExists_fix
...
Really fix OCP\Share::shareItem with LDAP users
2012-12-12 16:59:43 -08:00
de34f771c2
Exclude LDAP backend from global user searches
...
triggered by itself.
2012-12-07 17:19:30 +01:00
4cb760a924
LDAP: ldap_explode_dn escaped too much, fix it by manual replacement. Fixes different problems, esp. with non-ascii characters in the dn ( #631 )
2012-12-03 12:55:42 +01:00
495a8da354
port 95cee0e from stable45
2012-11-21 19:29:56 +01:00
aebd4fd32d
port dd694b5 from stable45
2012-11-21 19:28:29 +01:00
24e13419a3
LDAP: escape values in the DN, fixes #419
2012-11-21 19:25:10 +01:00
d79e9a2da7
LDAP: cherrypick objectGUID handling from stable45, was part of PR 344
2012-11-12 17:00:23 +01:00
ca24f4767b
Return an empty array on succesful existence check
2012-11-05 17:35:09 +01:00
510191db68
Return true or false from readAttribute if $attr is empty
...
This way, readAttribute can act as an existence checker.
2012-11-05 15:38:49 +01:00
3f85432df9
LDAP: make filter in readAttribute configurable
2012-10-27 19:43:07 +02:00
5b3c9518dc
LDAP: improve slicing
2012-10-27 17:46:01 +02:00
33aa630af3
LDAP: add error handling for failed searches
2012-10-27 17:46:01 +02:00
b942c1253e
remove TODO comment, it's done
2012-10-27 17:46:01 +02:00
605281da9b
LDAP: let result processing in Access::search slice the array for not-paginated search. getUsers e.g. does not need to take care of it anymore. adjustments in group_ldap to follow.
2012-10-27 12:19:08 +02:00
ee6fc22d4b
LDAP: sourced out paged search init into initPagedSearch method, making search slicker again
2012-10-27 12:19:08 +02:00
84130b885f
LDAP: add support for paged searches.
2012-10-26 21:54:34 +02:00
e73b817a38
Checkstyle: NoSpaceAfterComma
2012-10-23 22:53:54 +02:00
800fd5fd79
LDAP: check if index is set, fix Notices
2012-10-15 17:17:37 +02:00
33e9399ba3
LDAP: fix sharing doesn't work with ldap groups, oc-1819
2012-10-01 18:27:58 +02:00
2a7a928ae9
LDAP: replace expensive recursiveArraySearch with direct SQL search, leading to a performance boost. Imorives UX especially on directories with tons of users, solves complains on ML and probably fixes oc.1080
2012-09-21 13:03:28 +02:00
6444c27e6a
LDAP: fix MySQL-query with DUAL table by removing wrong backticks. Got broke when they were added to SQL queries.
2012-09-17 22:50:08 +02:00
741a21292e
LDAP: fix potential infinite loop introduced with 4c4aa92eef, as side effect optimize groupExists-method.
2012-08-29 19:37:18 +02:00
8be8f6fff2
LDAP: Remove unnecessary debug output, fixes a Notice
2012-08-29 19:37:18 +02:00
4c4aa92eef
LDAP: check for existing username from other backends when creating one for an LDAP user or group. Led also to some code cleanup. Fixes oc-1551 in master.
2012-08-29 01:23:51 +02:00
5985d00c6f
LDAP: transliterate other latin characters to ASCII when creating owncloud names. Already created usernames are not being affected.
2012-08-27 21:32:56 +02:00
fa3497f6ed
add backticks to SQL, use limit parameter instead of LIMIT SQL
2012-08-25 01:52:27 +02:00
d5c111a984
LDAP: identify (map) users with their directory UUID. Fixes the issue, that usernames for owncloud will change, when the DN changes (which happens rarely, but it happens).
2012-08-23 18:29:43 +02:00
6fd48675e6
remove accidentally added blank lines
2012-08-05 22:03:47 +02:00
c3cbb463e3
add missing \
2012-08-05 21:35:37 +02:00
d546718179
LDAP: sanitize user and group base trees for strripos comparison. fixes oc-1302
2012-08-05 21:28:59 +02:00
b465fc84ae
LDAP: don't die on unexpected collisions, handle empty display-name attributes properly
2012-07-30 17:42:33 +02:00
b94631de0c
LDAP: check if php-ldap is installed. If not, give an error output. FIX: blank Users page when the module is not installed.
2012-07-25 18:40:48 +02:00
6285cc2604
LDAP: remove debug output
2012-07-25 13:19:07 +02:00
ab1d9507a9
code style
2012-07-25 13:18:31 +02:00
b10f7aafb7
LDAP: silence warning, but handle the error
2012-07-25 12:56:09 +02:00
Lukas Reschke
blizzz
Bart Visscher
Robin McCorkell
Alexander Bergolth
Scrutinizer Auto-Fixer
Thomas Müller
Jörn Friedrich Dreyer
Donald Buczek
kondou
Lorenzo M. Catucci
Felix Moeller