615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore
...
Pimp ActionProviderStore
2021-03-08 09:20:45 +01:00
c51c3c771f
Remove unneeded steps to add already existing user
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:34:10 +01:00
0e6401933b
Fix acceptance test for searching just added users in contacts menu
...
User "user1" is added when installing and configuring the server, so it
is already added in all tests. As the test verifies that just added
users can be searched in the contacts menu a new user should be actually
added.
The test did not fail because it assumed that "user1" did not exist and
just checked that it existed after "adding" it, but not whether adding
it failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-07 18:27:45 +01:00
ee1f8104a0
Find directly the label instead of falling back to it
...
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
7b6946d2d2
Assert also element visibility instead of just finding it
...
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
78faf0105d
Add explicit locator for "Enable all" bundle button
...
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
f87473e410
Find elements through the actor rather than the driver
...
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:43 +01:00
6d145ea54a
Add locator for apps list
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +01:00
4c23d24277
Fix identation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:34:42 +01:00
bc084070c8
Fix delete user acceptance test
...
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.
The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-06 01:29:54 +01:00
d5586ec437
Verify WaitFor::element... results with an assertion
...
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +01:00
caa2246568
Add missing waits when finding elements in the acceptance tests
...
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-05 22:06:05 +01:00
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +01:00
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +01:00
7b9ca4f7c2
Add some typing to SharedStorage
...
Makes psalm a bit more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +01:00
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
...
Remove deprecated \OCP\API
2021-03-03 21:57:34 +01:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
68ec18323d
Fix types in the Group Manager
...
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
ee06780029
Include additional scripts in Noto fonts
...
Generated avatars as well as text file previews are rendered using the
"core/fonts/NotoSans-Regular.ttf" font. The file was the standard hinted
"NotoSans-Regular.ttf" file from https://www.google.com/get/noto/ .
However that file does not cover some non LGC (Latin, Greek, Cyrillic)
scripts, like Arabic, Devanagari or Hebrew, to name a few.
Markdown file previews also use "core/fonts/NotoSans-Bold.ttf", which is
in the same situation as the regular one.
Due to limitations in the TTF format it is not possible to provide a
single file for each style that includes all Noto fonts. However, it is
possible to add more scripts to the standard "NotoSans-Regular.ttf" and
"NotoSans-Bold.ttf" files (although no CJK (Chinese, Japanese, Korean)
glyph can be included due to the aforementioned limitations).
This commit replaces the standard files with an extended version created
using the Noto Tools. The build script (as well as a patch for the Noto
Tools) is also included for reference and to be able to update the font
files in the future if needed.
Due to the additional scripts added the font files are now much larger,
although this does not seem to increase the time spent rendering LGC
scripts.
Note that the file for the bold style still contains less scripts than
the regular one, as not all scripts supported by Noto have a bold
weight.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 19:15:01 +01:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +01:00
5026d2cca1
Merge pull request #25086 from nextcloud/dependabot/composer/nextcloud/coding-standard-0.5.0
...
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
2021-02-18 14:05:54 +01:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
6ed4aaeeea
Send emails on password reset to the displayname
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-18 12:38:43 +01:00
644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
...
Cache the user backend info for 5mins
2021-02-17 08:56:55 +01:00
b794fadbce
Merge pull request #25575 from k00ni/pr/add-tests-for-LoginFlowV2Service
...
Add tests for \OC\Core\Service\LoginFlowV2Service
2021-02-15 12:22:39 +01:00
645f83121e
Cache the user backend info for 300s
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +01:00
24d4c3eeab
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop
...
Make the app code checker a NOOP
2021-02-13 15:51:41 +01:00
330315f03e
refined name of getOpenSSLEncryptedAndPrivateKey
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 13:01:37 +01:00
0bc49d67cd
added unit tests for LoginFlowV2Service::createTokens
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 12:57:24 +01:00
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +01:00
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +01:00
c755165dd4
added unit tests for LoginFlowV2Service::flowDone
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 10:45:47 +01:00
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +01:00
d60dd8a208
added unit tests for LoginFlowV2Service::startLoginFlow
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:56:09 +01:00
f29748a5e1
added unit tests for LoginFlowV2Service::getByLoginToken
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:49:39 +01:00
b0a2278a7e
added unit tests for LoginFlowV2Service::poll
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:38:29 +01:00
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +01:00
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
...
Added tests for OC\Core\Data\LoginFlowV2Credentials
2021-02-09 21:37:37 +01:00
a50c615d37
simplified tests
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:48:37 +01:00
a28705064b
fixed coding style issue
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:40:19 +01:00
b38a619212
added tests for OC\Core\Data\LoginFlowV2Credentials
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:25:37 +01:00
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
86109f77e0
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
f6ddda8dad
Test the symfony adapter
...
To prevent regression in the future.
And make sure we always return an object …
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +01:00
b68c3a5836
Add test for dbal exception wrapping
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-02-03 19:43:52 +01:00
d4a45b4cac
test: adjust expectation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 19:32:12 +01:00
558f062ca6
add repair job for unencoded calendars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:29:10 +01:00
7d9dceb1af
Add negative version comparison test for version suffixes
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-27 16:01:26 +01:00
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
...
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +01:00
e511a539b7
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:55:38 +01:00
5ae0be08b4
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +01:00
27f9df2e87
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:50 +01:00
a44aab11f7
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:46 +01:00
99d525eb36
Convert 2FA token type to string
...
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +01:00
d84e1f1951
Re-use fetched dependencies in lib/base.php
...
Reduces calls to DI container by reusing already fetched dependencies.
For status.php it went from 355 to 344.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +01:00
0893bba369
Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ
...
Force signature verification of apps on occ
2021-01-19 09:35:52 +01:00
90c3013d40
Cleanup the constructor
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
d6a1d8d3a1
Add "composer.lock" for acceptance tests to git
...
As "composer.lock" was not versioned the dependencies had to be resolved
everytime that the acceptance tests run, which took some precious time.
Besides that the dependency versions were also tightened for better
control.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-17 16:44:32 +01:00
f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
...
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +01:00
9b58a027e3
Allow installing/updating of apps again
...
The Guzzle API changed. We shall now use sink
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-12 10:51:41 +01:00
7cdc7adf59
Merge pull request #25038 from nextcloud/bugfix/noid/install-mysql8-with-php8
...
Don't try a transaction for the migrator on MySQL
2021-01-11 18:07:11 +01:00
2d34ca4143
Only rollback when not MySQL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-11 16:11:02 +01:00
f9484d15cb
DB: warn on parameter number constraints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-11 13:43:34 +01:00
c3cb288268
Bump scssphp/scssphp from 1.0.3 to 1.4.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-11 12:41:25 +01:00
f0c6cfde3a
Rollback failed transactions in TestCase.php to not break followup tests
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
261966ace5
Update EncryptionTest.php
2021-01-05 21:45:50 +01:00
664e74a82e
2nd attempt to fix tests
2021-01-05 20:41:02 +01:00
87c640193b
attemtp to fix test
2021-01-05 19:09:16 +01:00
98560c80ea
Properly handle result when copying with failure and throw in tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 09:20:35 +01:00
ee842f1c43
Fix writeStream mocking
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 09:20:35 +01:00
1bb81f8f11
jsunit: Remove warnings during test runs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:34 +01:00
c7a320d880
jsunit: Run jsunit with chromium/puppeteer on github actions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-29 08:42:27 +01:00
b981cb0718
Merge pull request #19942 from ACTom/add-mindmap-icon
...
Add mindmap type file icon
2020-12-28 10:13:38 +01:00
d9db6ae84e
Readd test getOnlyDefaultAliases()
...
Signed-off-by: ACTom <i@actom.me>
2020-12-28 13:59:10 +08:00
e0bafb7475
deleteChildren only returns array
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2020-12-23 11:00:47 +01:00
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
...
Add well known handlers API
2020-12-18 13:34:04 +01:00
6995223b1e
Add well known handlers API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +01:00
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +01:00
131fcac91e
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-14 11:14:59 +01:00
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5
...
Handle owncloud migration to latest release
2020-12-10 14:32:13 +01:00
3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck
...
Add deck share provider support
2020-12-10 14:30:08 +01:00
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string
2020-12-09 17:25:59 +01:00
85e6cbc87a
Extend dummy factory in tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:25 +01:00
9fe94f282f
Readd repair steps that are relevant when migrating from ownCloud
...
This reverts commit d9b1492e03
2020-12-09 12:13:35 +01:00
d04b7cf03d
Skip the test if Imagick is misconfigured
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-09 09:07:20 +01:00
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
...
Phone number validation and search
2020-12-08 17:05:38 +01:00
4f927721b2
Add temporary test for migrating int to string
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:06:13 +01:00
6a7e849090
php cs fix
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
c02e6fcae2
fix appconfig tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
b668850aa1
Fix filesystem tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
a25b46f494
Make sure we can also run with escapedshell args
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
48679ae39f
Make sure we just check for the keys
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
d690f90928
Do not run image tests on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
1670eabdb3
Do not run on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
6b7731a852
Move to new phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
988ce1374c
Don't check on php8
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
c084008df2
Avatar fixes
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
9317e0f0f0
Fix test traits for phpunit 9
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
f0ca76aefb
Add and fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
3d315ec64f
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:25:11 +01:00
c0a05c0412
Add notification for user limit
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +01:00
d87705a894
Allow subscription to indicate that a userlimit is reached
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 15:20:03 +01:00
83a75c670b
Replace static call to Share::unshare with ShareManager->deleteShare in tests
...
And then cleanup all the code that is dead then...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-30 09:51:18 +01:00
2172432420
Merge pull request #23912 from nextcloud/objectstore-copy
...
use in objectstore copy
2020-11-25 16:09:26 +01:00
9d4848e863
use in objectstore copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 15:16:58 +01:00
16a78f535a
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-24 11:30:11 +01:00
efe644137d
[encryption] Remove dependency fetching inside the constructor and move them to method call parameters
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-22 22:35:02 +01:00
1b613c84e9
Merge pull request #24007 from nextcloud/select-distinct-multiple
...
allow selecting multiple columns with SELECT DISTINCT
2020-11-19 22:39:01 +01:00
d602aa1825
Merge pull request #24135 from medical-cloud/fix/23357-nextcloud-logo-in-email-notifications-is-misaligned-in-version-20
...
Fix nextcloud logo in email notifications misalignment
2020-11-19 10:48:18 +01:00
87ec4a0da3
Fix #23357
...
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
2020-11-18 22:29:02 +01:00
66013f906d
Merge pull request #24189 from nextcloud/enh/csp/frame-ancestors
...
Set frame-ancestors to none if none are filled
2020-11-18 11:29:28 +01:00
9163790b7c
Set frame-ancestors to none if none are filled
...
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-18 10:13:36 +01:00
72a9c35be3
Remove some IRouter methods
...
This is not the end. IRouter needs to burn.
But it is a start.
🎵 we didn't start the fire 🎵
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-17 14:08:20 +01:00
a61a757b85
allow selecting multiple columns with SELECT DISTINCT
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-16 15:45:17 +01:00
4d3cb1533e
Add unit tests for "validateExpirationDateInternal"
...
They were copied and adjusted as needed from the tests for
"validateExpirationDate".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 08:54:19 +01:00
baaaacd650
Add explicit time to test date for clarity
...
This shows in a clearer way that the expected expiration date is the
original one, but without time.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:34 +01:00
578b57837a
Add unit test for expiration date with date and with default
...
This adds back what was being actually tested in the unit test fixed in
the previous commit.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:34 +01:00
70018ddabf
Fix unit test for expiration date without date but with default
...
The expiration date was explicitly given, so it was not testing what it
should. Moreover, "link_defaultExpDays" needs to be mapped when testing
the default value (even if it will just fallback to the value of
"shareapi_expire_after_n_days").
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:32 +01:00
3a53c2b6e5
Fix unit test method name
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:31 +01:00
e997f0fa46
Fix unit test for verifying enforced valid expiration date.
...
The enforced expiration date was not actually enabled, as for that
"shareapi_default_expire_date" needs to be explicitly set to "yes".
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:31 +01:00
8f1fff40e8
Fix unit test for verifying enforced expire date too far in the future
...
The test should fail if no exception was thrown, and no exception was
thrown due to a missing configuration parameter. However, the use of
"addToAssertionCount(1)" made the test pass even if no exception was
thrown and, therefore, to silently fail.
Now the missing configuration parameter was added and the test will fail
if the expected exception is not thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:29 +01:00
ec92e82571
Add unit tests to enforce a relaxed default share expiration date
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:28 +01:00
4dbeab5cff
Remove wrong and misleading comment
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:26 +01:00
72f51422ec
Remove extra spaces
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:25 +01:00
7cfa2701b9
Fix typo in variable name
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:23 +01:00
c8dc51f0ba
Fix typos in method names
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-12 11:57:22 +01:00
42a033bbc4
Change to full class names for the encryption app DI in preparation of auto-wiring
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-11 21:30:45 +01:00
e39d657e24
Merge pull request #23882 from nextcloud/tests/oracle
...
Run unit tests against oracle
2020-11-11 10:05:24 +01:00
b6dec0be99
Add acceptance tests for reshares by link when resharing is disabled
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 01:35:27 +01:00
22d949d9d9
Add acceptance tests for reshares when resharing is disabled
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-11 01:35:27 +01:00
0c695d97ec
Fix unique key in test table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 21:39:19 +01:00
61c767128c
Skip the insertIfNotExists() tests on Oracle because it doesn't work with clob
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:34:35 +01:00
74c0143001
Easier debugging and spell fix
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:34:35 +01:00
e313777cd6
Use a different column for the primary key as we can not insert it on oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:34:35 +01:00
2050517d44
Add github action for oci8
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-10 15:34:35 +01:00
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
c07720de77
Use query builder instead of OC_DB in OC\Files\*
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 09:05:15 +01:00
d25e5366b8
Merge pull request #23934 from nextcloud/enh/avoid_scss_compile
2020-11-07 10:11:50 +01:00
3e6e9186d8
Fix tests to return config default values
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-07 10:11:20 +01:00
659ea6ad79
Merge pull request #23851 from nextcloud/enh/read_env_only_once
...
Read the env variables only once
2020-11-06 22:35:00 +01:00
da1c2bdfe6
Fix repair mimetype step to not leave stray cursors
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 10:33:59 +01:00
f7a2b71627
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:37:45 +01:00
ede7510854
Add a function to get the unread count for multiple objects in one go
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-04 11:01:21 +01:00
8d02ee9ac7
Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system
...
Improve CertificateManager to not be user context dependent
2020-11-03 21:48:37 +01:00
f03bb4716b
Remove OCSResponse type hint - see #23827
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:43:32 +01:00
Roeland Jago Douma
Daniel Calviño Sánchez
Roeland Jago Douma
Johannes Leuker
Christoph Wurst
dependabot-preview[bot]
Joas Schilling
Konrad Abicht
Christoph Wurst
Daniel Kesselberg
Arthur Schiwon
Robin Appelman
Morris Jobke
Jasper Knockaert
Julius Härtl
ACTom
Maxence Lange
Joas Schilling
medcloud
John Molakvoæ