c5d0c8ce12
Simplify the function looking for output
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-27 09:11:19 +01:00
dd3d5829e7
This is not javascript
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-26 17:06:32 +01:00
46e3ea4e41
Fix undefined variable
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-26 16:37:54 +01:00
d08dca4ee5
Update baseline
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-22 14:44:38 +02:00
3ecfaca85f
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-21 04:30:21 +00:00
8f813c691d
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-20 04:29:45 +00:00
8005fd6f19
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-16 04:28:48 +00:00
2c40d2cf45
Bump vimeo/psalm from 3.15 to 3.17.1
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 11:47:54 +02:00
081e9ac47f
Use own psalm instead of a global one
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-13 17:55:37 +02:00
035346a5d3
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-13 04:28:02 +00:00
953c6eda28
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-11 04:27:09 +00:00
7896b20100
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-09 04:27:56 +00:00
ab6f6f7149
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-07 04:26:43 +00:00
c2a6893033
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-10-06 04:27:00 +00:00
482b42c4a7
Merge pull request #22891 from nextcloud/techdebt/18680/improve-ProvisioningApiMiddleware-service-logic
...
Improve registerService logic for ProvisioningApiMiddleware for static code analysis
2020-10-05 21:50:50 +02:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
8c2fe6df0a
Bump jsdoc from 3.6.5 to 3.6.6 in /build
...
Bumps [jsdoc](https://github.com/jsdoc/jsdoc ) from 3.6.5 to 3.6.6.
- [Release notes](https://github.com/jsdoc/jsdoc/releases )
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.6/CHANGES.md )
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.5...3.6.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-26 01:16:20 +00:00
f7e5ba6116
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-09-25 04:24:37 +00:00
7b9a40b407
Add integration tests to check that only the given path is transferred
...
Until recently (it was fixed in ac2999a26a
2020-09-18 18:35:06 +02:00
c4c602ee80
Add integration tests for transferring files of a user with a risky name
...
The files:transfer-ownership performs a sanitization of users with
"risky" display names (including characters like "\" or "/").
In order to allow (escaped) double quotes in the display name the
regular expression used in the "user XXX with displayname YYY exists"
step had to be adjusted.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:34:30 +02:00
5e143845cb
Add integration test for transferring the path of a single file
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:32:23 +02:00
281f0d6793
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-09-18 04:23:58 +00:00
a65b431f51
Update baseline
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 17:02:44 +02:00
c6948c2517
Update baseline
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:54:10 +02:00
04a3580d19
Remove phan config - was replaced by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
1c9a898875
Merge pull request #22761 from nextcloud/extend-integration-tests-for-files-transfer-ownership-command
...
Extend integration tests for "files:transfer-ownership" command
2020-09-14 17:50:53 +02:00
04c174ab89
Merge pull request #22665 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.7.0
...
Update behat/behat requirement from ~3.6.1 to ~3.7.0 in /build/integration
2020-09-10 12:52:31 +02:00
58d57b35ea
Add integration tests for transferring ownership of reshares
...
Currently only transferring ownership of a reshare with a group to a
user in the group is possible.
When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).
When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).
The added integration tests reflect the above behaviours.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:34:33 +02:00
0ce8096839
Check share ownership after transferring file ownership
...
The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:24:16 +02:00
d3d01d6355
Check whether file exists or not after transferring ownership
...
The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:18:53 +02:00
c104c192ae
Merge pull request #22663 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.7
...
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
2020-09-09 21:24:28 +02:00
fe5f8c5010
Merge pull request #22600 from nextcloud/dependabot/npm_and_yarn/build/http-proxy-1.18.1
...
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
2020-09-09 20:55:08 +02:00
9c57fff01f
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-09-09 04:23:34 +00:00
94b228dca1
Update behat/behat requirement in /build/integration
...
Updates the requirements on [behat/behat](https://github.com/Behat/Behat ) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases )
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Behat/Behat/compare/v3.6.1...v3.7.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:56 +00:00
20e6d04a69
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
...
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport ) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases )
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG )
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.6...1.0.7 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:47 +00:00
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
54438c9d26
Merge pull request #21945 from nextcloud/fix-contact-download-picture
...
Changed Content-Disposition header to download Contact Photo with correct extension
2020-09-07 08:40:23 +02:00
14baa52a1a
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-09-06 04:22:33 +00:00
e8a4feb1c6
Change Content-Disposition Header
...
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes
Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 -07:00
3e9359f930
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
...
Bumps [http-proxy](https://github.com/http-party/node-http-proxy ) from 1.17.0 to 1.18.1. **This update includes a security fix.**
- [Release notes](https://github.com/http-party/node-http-proxy/releases )
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.17.0...1.18.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-04 18:10:40 +00:00
7511885c15
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-09-03 04:22:57 +00:00
9dc23867c6
Use proper branch name in phpdoc builds
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 08:47:16 +02:00
b5e9f7e846
Merge pull request #22432 from nextcloud/enh/phpdoc
...
Add php docs build script
2020-08-26 21:18:11 +02:00
8c33bfe86b
Add php docs build script
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-26 08:32:42 +02:00
bc7abbdb85
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-08-26 04:21:23 +00:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
067945ff10
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2020-08-21 04:21:23 +00:00
d58e71f0e6
Fix psalm warnings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 21:12:15 +02:00
bb8be58386
Fix psalm warnings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 18:30:48 +02:00
8381af626f
Accept psalm warning for now
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:46:00 +02:00
69bbbc32a1
Extend psalm baseline to ignore errors for now
...
One is a false positive - see https://github.com/vimeo/psalm/pull/4032
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 14:20:56 +02:00
70d1d1997a
new weather status used in dashboard
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-08-20 00:21:08 +02:00
d8bdb439a4
Merge pull request #22289 from nextcloud/techdebt/noid/fix-encryption-stream-invalid-scalar-arguments
...
Cast float to int to avoid invalid scalar argument warning
2020-08-19 22:08:15 +02:00
c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names
...
Use matching parameter names form interfaces and implementations
2020-08-19 19:34:02 +02:00
4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
...
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +02:00
fedf9c69d9
Use matching parameter names form interfaces and implementations
...
Found by Psalm 3.14.1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
60be722ee8
Merge pull request #22288 from nextcloud/techdebt/noid/fix-oc_image-invalid-scalar-arguments
...
Cast float/char to int to avoid invalid scalar argument warning
2020-08-19 17:55:56 +02:00
e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +02:00
5ced155032
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
...
Use dispatchTyped instead of dispatch on the new event dispatcher
2020-08-18 21:29:48 +02:00
a5853d7ecc
Use dispatchTyped instead of dispatch on the new event dispatcher
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 20:27:46 +02:00
560ccf5d83
Cast float to int to avoid invalid scalar argument warning
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:56:36 +02:00
27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +02:00
4c4f4685dc
Update psalm baseline due to fixes in #22236
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:49:36 +02:00
42bb6cd7d7
Check only the baseline.xml and exclude the psalm.xml from the file check
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
c6b251ca0c
Add patches for stubs
...
* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
b70792aa6a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
4efca69f8d
Add psalm baseline
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 12:59:17 +02:00
8b3b5ae5be
Add stubs for phpseclib
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
7257793fc4
Hello psalm
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
79fc7e78b7
Merge pull request #21138 from nextcloud/fix/noid/search-in-group-displayname-email
...
Search also the email and displayname in user mangement for groups
2020-08-05 16:09:00 +02:00
907d3542dc
Add integration tests for search in groups
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:14:06 +02:00
8d5f5e8f8c
Fix integration test fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 13:43:15 +02:00
8e1d334258
Bump jsdoc from 3.6.4 to 3.6.5 in /build
...
Bumps [jsdoc](https://github.com/jsdoc/jsdoc ) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/jsdoc/jsdoc/releases )
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.5/CHANGES.md )
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.4...3.6.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-25 01:15:12 +00:00
94ae095051
Bump lodash from 4.17.14 to 4.17.19 in /build
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-16 07:23:29 +00:00
aed5eb55af
Merge pull request #21843 from nextcloud/debt/noid/less-verbose-translation-checker
...
Make translation-checker.php less verbose
2020-07-15 19:37:51 +02:00
8dd48f3dc8
Fix integration test due to new dashboard app
...
See #21346
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 14:07:59 +02:00
5ffe9fc7db
Make translation-checker.php less verbose.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 11:29:12 +02:00
e0fbf4d033
Add more integration tests for resharing permissions
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-09 11:14:44 +02:00
3333c885c0
Merge pull request #21264 from stweil/master
...
build: Fix some typos (most of them found by codespell)
2020-07-05 22:52:28 +02:00
dc175d4ecc
Fix typo in variable name and make check more accurate
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:48:38 +02:00
e2100856ad
Add another test for exact matching of a user in group restriction
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:06:50 +02:00
cdcd61d4c8
Use empty for the OCP @since checker
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-09 08:49:24 +02:00
72f853424b
build: Fix two typos in function names
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 15:57:08 +02:00
e8af52001e
build: Fix some typos (most of them found by codespell)
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 13:03:00 +02:00
b192c04dc2
Add integration tests for video verification
...
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.
When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +02:00
a2f80d4f4c
Add integration tests for creating and updating a mail share
...
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.
To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.
In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.
For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +02:00
7817f8578b
Generalize integration test steps to download last share
...
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
6e49d3bb94
Remove unused variables
...
The step names were adjusted accordingly.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
bd0a1b6e7d
Merge pull request #20586 from nextcloud/techdebt/noid/make-image-optimization.sh-better-readable
...
Improve build/image-optimization.sh
2020-05-21 09:48:55 +02:00
108faf25c0
Update public link share permission code
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +02:00
c84a82bc0c
Bump node-sass from 4.14.0 to 4.14.1 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.14.0...v4.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 01:16:27 +00:00
d9e5925201
Merge pull request #20655 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.14.0
...
Bump node-sass from 4.13.0 to 4.14.0 in /build
2020-04-29 16:15:04 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
b836bcf040
Bump node-sass from 4.13.0 to 4.14.0 in /build
...
Bumps [node-sass](https://github.com/sass/node-sass ) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases )
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/node-sass/compare/v4.13.0...v4.14.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-29 08:27:58 +00:00
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
...
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
7a9469f282
Adjust integration tests to new permissions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 16:22:48 +02:00
3fc66a65f8
Revert "Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.3 in /build/integration"
2020-04-22 16:40:11 +02:00
e9f0a388d9
Allow to specify a directory and skip node_modules and tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:50:26 +02:00
e49b6c576d
Don't error when the directory is broken
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:33:11 +02:00
f354a4f17f
FIx glob usage to avoid problems with directories that contain spaces
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:32:11 +02:00
Joas Schilling
Daniel Kesselberg
Nextcloud-PR-Bot
Christoph Wurst
Morris Jobke
dependabot-preview[bot]
Daniel Calviño Sánchez
Roeland Jago Douma
dependabot[bot]
John Molakvoæ
Jacob Neplokh
Julius Härtl
Julien Veyssier
Stefan Weil
Roeland Jago Douma