Commit Graph

58514 Commits

Author SHA1 Message Date
Joas Schilling 167efa19d7
Fix psalm errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling df47445c01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling 56ae87c281
Less ILogger
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Joas Schilling 13b37a5255
Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:35 +02:00
Joas Schilling 174f4dd043
Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:34 +02:00
Joas Schilling bf1c875425
Merge pull request #26764 from nextcloud/feature/noid/add-geo-location-as-ROS-type
Add geo location as ROS type
2021-04-27 13:54:28 +02:00
Arthur Schiwon 2a5473e146
do not try to search after the last page
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 12:52:26 +02:00
Valdnet 505863c55e
l10n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-27 12:38:28 +02:00
Julius Härtl 9de6efd14e
Merge pull request #26774 from nextcloud/techdebt/noid/ldap-remove-pre73-paged-results 2021-04-27 07:00:28 -01:00
Joas Schilling 1029abc8f6
More cleaning after auto-add removal
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 08:13:47 +02:00
Joas Schilling 3f0b7fd289
Merge pull request #26765 from nextcloud/td/no_more_add_auto_trusted
No longer add trusted servers on federated share creation
2021-04-27 08:06:59 +02:00
John Molakvoæ b8cde2c8b6
Merge pull request #26775 from robottod/patch-1
Remove some deprecated calls from ShareByMailProvider.php
2021-04-27 07:59:27 +02:00
Nextcloud-PR-Bot 65d9ba620f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-27 04:12:15 +00:00
Nextcloud bot 2aad4bbed6
[tx-robot] updated from transifex 2021-04-27 02:25:33 +00:00
Arthur Schiwon 5e8f43a55e
removes PagedResults adapter for PHP < 7.3
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-26 22:57:42 +02:00
robottod 0451927994
Remove some deprecated calls from ShareByMailProvider.php
This moves the execute calls to the executeQuery and executeUpdate calls
Resulting in less calls to deprecated functions

Signed-off-by: rtod <robottod@protonmail.com>
2021-04-26 21:53:56 +02:00
Roeland Jago Douma 71e05b1fd3 No longer add trusted servers on federated share creation
It was disabled by default for ages. And often resulted in unwanted
behavior. If admins want trusted servers they just have to do it
manually.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 19:47:55 +02:00
Roeland Jago Douma 10df6b93c1
Merge pull request #26763 from nextcloud/enh/federation/improve_permissions
Improve federated permission handling
2021-04-26 17:23:12 +02:00
Joas Schilling 303d689001
Merge pull request #26762 from nextcloud/bugfix/noid/respect-the-error-level-on-logging
Respect the error level when logging
2021-04-26 17:10:52 +02:00
Joas Schilling 7d3c135146
Add geo location as ROS type
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:47:01 +02:00
Joas Schilling 21ed3419f3
Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:19:03 +02:00
Roeland Jago Douma 70f12e7332 Improve federated permission handling
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 16:10:44 +02:00
Joas Schilling 8d9e5e0b91
Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 14:18:18 +02:00
Joas Schilling aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
J0WI 8323cbb9e5 Use strict
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:45:12 +02:00
Lukas Reschke e1a3000cbe
Merge pull request #26747 from nextcloud/php8-libxml
Fix installer deprecation warnings for PHP 8
2021-04-26 12:44:38 +02:00
J0WI d1f23b0428 core: add more strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:44:37 +02:00
J0WI a369933084 Fix ini_set() type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:44:05 +02:00
J0WI efc5c57a79 Some more strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:33:45 +02:00
Christoph Wurst 8f3a0705d4
Merge pull request #26755 from yan12125/bugfix/yan12125/caldav-truncation
Correctly truncate multibyte strings to fit into the database
2021-04-26 11:56:26 +02:00
Chih-Hsuan Yen fea5b4a8b9
Correctly truncate multibyte strings to fit into the database
Closes: #26174

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
2021-04-26 16:54:50 +08:00
Roeland Jago Douma bf9ed2d3cd
Merge pull request #26721 from nextcloud/fix/noid/final-private
private cannot be final
2021-04-26 09:04:18 +02:00
Roeland Jago Douma 8238abd34a
Merge pull request #26750 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-04-26 08:43:58 +02:00
Nextcloud-PR-Bot d6f3a6feb9 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-04-26 04:13:05 +00:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +00:00
dependabot-preview[bot] 835643b19d
Merge pull request #26749 from nextcloud/dependabot/composer/vimeo/psalm-4.7.1 2021-04-26 01:47:41 +00:00
dependabot-preview[bot] 5a876f5a9d
Bump vimeo/psalm from 4.7.0 to 4.7.1
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.7.0...4.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-04-26 01:17:16 +00:00
acsfer 3d900b1e58
PHP 8+ deprecates openssl_free_key 2021-04-25 13:50:23 +02:00
acsfer 5882648cac
Only use libxml_disable_entity_loader on PHP<8 2021-04-25 13:45:14 +02:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +00:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +00:00
Daniel Calviño Sánchez 8fc8451004
Merge pull request #25417 from nextcloud/fix-account-data-visibility-after-disabling-public-addressbook-upload
Fix account data visibility after disabling public addressbook upload
2021-04-23 16:48:36 +02:00
Joas Schilling 04c15e7835
Merge pull request #26719 from nextcloud/chore/dav-cleanup-query-usage
Clean up DB code in the CalDAV backend
2021-04-23 15:38:09 +02:00
Christoph Wurst 323f95693c
Close open cursors
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 14:35:02 +02:00
Maxence Lange bb32880ec4 private cannot be final
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-23 11:00:10 -01:00
Christoph Wurst 72a4f21efe
Use the new executeQuery and executeUpdate methods
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Christoph Wurst 94bf14a8dc
Drop default fetch mode parameter
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Christoph Wurst 1a1ea4e3ea
Merge pull request #26717 from nextcloud/fix/copy-etag-node-not-found
Only set copy etag if the destination source can be found
2021-04-23 13:20:08 +02:00
Daniel Calviño Sánchez da84ed7d4c Fix active scope not visible in the menu if excluded
Depending on some settings (for example, if lookup server upload is
disabled) some items can be hidden in the scope menu. However, if the
user selected an scope in the past once the settings were changed the
scope was no longer visible in the menu. Now the active scope will be
always visible in the menu, although if it is an excluded scope it will
be disabled. Selecting any other scope will then hide the excluded and
no longer active one.

When upload to the lookup server is disabled the scope menu was hidden
for display name and email in the personal information settings; now the
menu will be always shown to enable the above described behaviour.

Note that the menu will be shown even if there is a single available
scope so the user can read its description.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00
Daniel Calviño Sánchez 7159a70894 Guard against null phone number value
"parsePhoneNumber()" expects a string, so a TypeError would be thrown if
the phone number value is null.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00