bc66bdc072
Add a wrapper to fall back to the share owner on public shares
...
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
f662d3663b
Temporary fix contacts search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
...
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
deb2ea9cea
Provide links to calendar in event creation/update activities
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
...
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00
d7161b4eee
Only catch anonymous OPTIONS for Office
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 14:46:07 +02:00
6709833dc7
Use paginated search for contacts
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag
...
Make sure that OC-ETag is set again
2020-04-22 22:21:22 +02:00
8730cc6764
Use a proper upload file so propfinds return 404
...
Fixes #20235
By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:33:28 +02:00
effcd58e14
Fix usages of afterMethod -> afterMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-21 10:19:06 +02:00
4ee56689a8
Make sure that OC-ETag is set again
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:14:31 +02:00
ed56619a20
Merge pull request #19901 from nextcloud/bugfix/noid/vcard-photo-handling
...
Improved vcard photo handling
2020-04-17 11:43:20 +02:00
29541322c1
Update list of multiple properties
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-17 09:38:47 +02:00
fe4527a8e2
Update Contact Size after removing photo
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-15 15:49:49 +02:00
648c8df516
Don't populate the PHOTO property when it's not an image
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:39 +02:00
bb754cb363
Always transform the etag and read the data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:36 +02:00
2e9f105786
Use table variable everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:12 +02:00
73271aa086
DAV's exception logger should deal with any Throwable
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-15 15:28:37 +02:00
5c0637bc90
Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic
...
Make remote checking more generic
2020-04-15 12:48:49 +02:00
d63abebc93
Merge pull request #19351 from nextcloud/dav-upload-hash
...
Return hashes of uploaded content for dav uploads
2020-04-15 10:23:22 +02:00
5e402f8aae
Check all remotes for local access
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
91ab811824
Verify that destination is not a directory.
...
Otherwise file_put_contents will fail later.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 12:52:12 +02:00
0408c37b3d
Only delete the default calendar setting when the default calendar
...
itself is deleted
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:43 +02:00
ebdf66b706
Provide dav setting for user's default calendar
...
And add tests to handle schedule-default-calendar-URL
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:42 +02:00
57403c7020
dont set headers for cli
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:29 +02:00
c2677682c4
Return hashes of uploaded content for dav uploads
...
hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers.
these headers are set for file uploads and the MOVE request at the end of a multipart upload.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:27 +02:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
3a415e4139
Remove space between switch case and colon
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
42625a46be
Remove spaces after method or function call
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
e266666380
Merge pull request #20188 from nextcloud/bug/19662/add-default-title-for-event-in-invitatios
...
Add default titles for titleless events in invitations
2020-04-07 11:22:17 +02:00
9a4193f557
Merge pull request #19761 from nextcloud/bugfix/19658/add_missing_index_to_original_migration
...
Add missing index to original migration
2020-04-06 09:44:34 +02:00
4a292126e5
Merge pull request #20139 from nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings
...
Unify default value for restricting user enumeration with settings
2020-04-04 10:33:04 +02:00
fba7bcfcc4
Catch NoUserException when running the upload cleanup as cronjob
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-03 23:06:26 +02:00
058ffa37ff
Add default titles for titleless events in invitations
...
Closes #19662
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-03 13:49:25 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
2200cc8562
Merge pull request #19325 from nextcloud/dependachristoph/composer/sabre-4.0
...
Update Sabre (and friends) to 4.0
2020-03-30 09:34:25 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
5e2c802bb7
Set custom ProdId in Birthday service, do not depend on Sabre Versio number for unit tests
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
52ba75f644
Sabre/DAV 4.0: beforeMethod is now beforeMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-27 12:53:44 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
23eb0462e5
Use lowercase true, false and null constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
5a33cb0b78
Register an address book with recent contacts
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 16:16:45 +01:00
ba14c41a1c
Merge pull request #20145 from nextcloud/bugfix/noid/generated-avatars-and-nophoto-cache
...
Fix generated avatars and nophoto cache files
2020-03-25 11:14:13 +01:00
3427653676
Merge pull request #19986 from nextcloud/bugfix/19980/fix_uid_as_uri
...
RefreshWebcalService: randomly generate calendar-object uri
2020-03-25 08:11:49 +01:00
f3a5bd6753
Fix generated avatars and nophoto cache files
...
Since nextcloud/server#19493 newFile() by default does not write the file anymore.
Setting an empty string as content will make it write the file immediate,
without having to call putContent() afterwards.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-24 18:23:38 +01:00
3e338c9075
Merge pull request #18788 from nextcloud/fix/18782/translate-busy-in-caldav
...
Translate 'Busy' in CalDAV
2020-03-24 15:12:21 +01:00
d4f25b01b8
Unify default value for restricting user enumeration with settings
...
If the value was never enabled or disabled, the settings show "Restrict
username enumeration to groups" as disabled. However, in some components
it was enabled by default, which caused an inconsistency in the
behaviour with respect to the settings, for example in the contacts
menu.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-24 14:30:59 +01:00
42dde6d623
Add check that DateTime parameters are of correct type
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-03-22 14:24:13 +01:00
65c591093e
fix OCA\DAV\CalDAV\CalDavBackend search $options
...
Signed-off-by: dartcafe <github@dartcafe.de>
2020-03-22 14:24:13 +01:00
019ba27943
Merge pull request #20042 from nextcloud/fix/noid/styled-dav-browser-error
...
fix dav browser error page not styled
2020-03-22 14:23:17 +01:00
82f8a167a6
use core templates for displaying dav errors in the browser
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-03-20 22:39:22 +01:00
ae4dc3467c
Return empty system addressbook since we cannot easily limit it to groups
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
0fa897fcfc
Limit enumeration in principal search
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:56 +01:00
b285e19dc8
fix dav browser error page not styled
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-03-19 23:44:14 +01:00
15a21ee19a
remove the detour trough node and work with path directly
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
451c8761a7
use INode instead of Node for custom properties
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
7819a904d7
handle long property paths to hasing paths >250 chars
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
95cd44c41e
remove unused code
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
ce398cf7bd
merge the two almost identical custom property backends
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-18 13:41:04 +01:00
bd1f98cba3
RefreshWebcalService: randomly generate calendar-object uri
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-16 15:36:13 +01:00
0d613cd2f0
Merge pull request #19704 from Nils160988/master
...
Fix hostname in Apple configuration profile
2020-03-09 21:02:53 +01:00
b6245be302
Merge pull request #19746 from nextcloud/locked-exception-forward-existing
...
pass the existing locks info when making locked exception with absolu…
2020-03-09 19:31:45 +01:00
827c0980d8
Prevent creation of reserved address book name
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-09 13:36:39 +01:00
ec245d5fec
Add address book plugins
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-09 13:12:18 +01:00
79dcd34a07
Create Mount IDs as BigInt by default
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-03 14:17:22 +01:00
7961a0b446
Add indices to original DAV migration
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-03-03 13:10:41 +01:00
fab22ac14c
pass the existing locks info when making locked exception with absolute paths
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-02 19:29:44 +01:00
4725fb9c1a
Fix hostname given in Apple config file
...
Signed-off-by: Nils Wittenbrink <nilswittenbrink@web.de>
2020-02-28 20:17:04 +01:00
4b593cbd25
Catch NotFoundException when getting the user folder
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-26 11:20:20 +01:00
e6206731c7
Merge pull request #19252 from nextcloud/bug/fix-notification-object-id
...
Hash event UID to make sure it's not too long for PushProvider notifications
2020-02-25 17:04:25 +01:00
d224ee667e
Correctly trim long cyrillic note
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-25 11:17:02 +01:00
713d3d49ad
Merge pull request #19196 from nextcloud/feature/17126/allow_apps_to_register_their_own_calendars
...
Allow apps to provide Calendars in user's calendarHome
2020-02-23 17:00:03 +01:00
709e7447ed
Translate 'Busy' in CalDAV
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-02-23 22:38:24 +08:00
354e8c1f2b
Introduce a default refresh rate app setting for calendar subscriptions
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-21 12:49:37 +01:00
b46e5cb270
Allow apps to provide Calendars in user's calendarHome
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-02-18 14:35:14 +01:00
8b22b9f046
Move RefreshWebcalJob logic to a proper service so that it may be called
...
independently
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-10 16:04:38 +01:00
bfb1273a2e
Merge pull request #19219 from nextcloud/bugfix/19135/wrong_dtend_invitation_mail
...
Fix display of DTEND for multi-day all-day event
2020-02-05 20:54:02 +01:00
8fba05db96
Check for empty authorization headers for office requests and allow anonymous option on the whole tree
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-04 15:35:23 +01:00
41fa057285
Hash event UID to make sure it's not too long for PushProvider
...
notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-02-01 18:13:51 +01:00
165fc172b1
Fix display of DTEND for multi-day all-day event
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-30 15:02:16 +01:00
98edf44c66
RefreshWebcalJob: Fix reading subscription from database leading to ignored refreshRate
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-30 13:04:42 +01:00
4d299d1c66
Changes the Birthday calendar color to slightly brighter one
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-01-14 16:48:48 +01:00
b7f93cc56b
Merge pull request #18115 from nextcloud/bugfix/17951/reminderservice_resource_error
...
Properly handle resources in ReminderService
2019-12-27 14:42:10 +01:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
8d7baaff74
Merge pull request #18061 from nextcloud/bugfix/noid/dav-plugin-old
...
Load apps dav plugins on the old webdav route
2019-12-16 13:38:38 +01:00
27a31cdaf1
Support more IPv6 addresses in the RefreshWebcalJob
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-12 10:05:36 +01:00
97deaf85b9
Merge pull request #17935 from nextcloud/feature/noid/public-auth-for-circles
...
adding share type circles
2019-12-11 12:37:54 +01:00
Roeland Jago Douma
Joas Schilling
Christoph Wurst
Morris Jobke
Thomas Citharel
Julius Härtl
Roeland Jago Douma
Georg Ehrke
John Molakvoæ (skjnldsv)
Arthur Schiwon
Joas Schilling
Daniel Kesselberg
Robin Appelman
Christoph Wurst
Daniel Calviño Sánchez
dartcafe
Nils Wittenbrink
Gary Kim