Robin Appelman
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +01:00
Joas Schilling
9c1983b714
Fix hover background for dark mode
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-12 13:18:39 +01:00
Konrad Abicht
330315f03e
refined name of getOpenSSLEncryptedAndPrivateKey
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 13:01:37 +01:00
Konrad Abicht
0bc49d67cd
added unit tests for LoginFlowV2Service::createTokens
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-12 12:57:24 +01:00
Dan VerWeire
1f47ae7c1b
Use ownerDisplayName for SharingEntry Tooltip
...
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com ) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.
This commit changes the value showed for the owner to the full display name.
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-12 07:32:26 +00:00
Nextcloud bot
361f160d0d
[tx-robot] updated from transifex
2021-02-12 02:20:18 +00:00
Roeland Jago Douma
f124cb0ef1
Merge pull request #25582 from nextcloud/fix/no-imip-for-invalid-recpient
...
Do not send imip email to invalid recipients
2021-02-11 19:57:58 +01:00
Roeland Jago Douma
37199c1da0
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation
...
Micro-optimize validation of empty email addresses
2021-02-11 19:51:06 +01:00
Christoph Wurst
5babad4f6f
Merge pull request #25576 from nextcloud/fix/webp_check
...
Fix WebP availability check
2021-02-11 15:58:14 +01:00
Christoph Wurst
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +01:00
Christoph Wurst
9430de181e
Do not send imip email to invalid recipients
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:13:05 +01:00
Jan C. Borchardt
e207b94554
Merge pull request #25299 from elsiehupp/favicon-touch-corners
...
favicon-touch image corners
2021-02-11 12:28:02 +01:00
Roeland Jago Douma
bf4210aa8d
Always use the cache
...
If there is no cache available we will use the null cache. Which (you
guessed it) just doesn't do anything. This makes the code flow a bit
nicer and psalm a bit happier.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-11 11:48:52 +01:00
Christoph Wurst
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +01:00
Roeland Jago Douma
cc554890c1
Fix WebP availability check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-11 11:31:38 +01:00
Konrad Abicht
c755165dd4
added unit tests for LoginFlowV2Service::flowDone
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 10:45:47 +01:00
Roeland Jago Douma
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +01:00
Konrad Abicht
d60dd8a208
added unit tests for LoginFlowV2Service::startLoginFlow
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:56:09 +01:00
Konrad Abicht
f29748a5e1
added unit tests for LoginFlowV2Service::getByLoginToken
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:49:39 +01:00
Konrad Abicht
b0a2278a7e
added unit tests for LoginFlowV2Service::poll
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-11 09:38:29 +01:00
Nextcloud bot
02885358a9
[tx-robot] updated from transifex
2021-02-11 02:20:37 +00:00
Christoph Wurst
8a474305fa
Merge pull request #25570 from nextcloud/enh/dashboard/psalm_fixes
...
Some psalm fixes for the DashboardController
2021-02-10 21:37:18 +01:00
Roeland Jago Douma
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
Roeland Jago Douma
a6cd238517
Some psalm fixes for the DashboardController
...
* Use the AppFramework IInitialState
* Set return type
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 20:00:04 +01:00
Roeland Jago Douma
d0cf4e2f58
Merge pull request #24904 from nextcloud/enh/github-psalm
...
Have psalm analysis directly on github
2021-02-10 19:03:55 +01:00
Roeland Jago Douma
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
Roeland Jago Douma
1cc23c6e6e
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
...
Deprecate the GenericEvent wrapper
2021-02-10 18:57:07 +01:00
Roeland Jago Douma
847ee4041a
Merge pull request #25566 from nextcloud/fix/25359/followup
...
Fix remaining #25359
2021-02-10 18:02:24 +01:00
Christoph Wurst
039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
...
Make our event base class independent of Symfony and follow PSR
2021-02-10 16:13:06 +01:00
Roeland Jago Douma
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
Christoph Wurst
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +01:00
Roeland Jago Douma
8677870a09
Merge pull request #25435 from nextcloud/fix/favorite-icon
...
Fix favorite dark icon
2021-02-10 15:19:04 +01:00
Christoph Wurst
0a28440bf6
Make our event base class independent of Symfony and follow PSR
...
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 15:15:29 +01:00
Roeland Jago Douma
f9a4871bd4
Merge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-02-10 15:15:04 +01:00
Roeland Jago Douma
cc18213c98
Have psalm analysis directly on github
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 14:57:36 +01:00
Lukas Reschke
d42f9e65a2
Merge pull request #25554 from nextcloud/fix/pslam/tainted_cookie
...
tain-escape the cookie input
2021-02-10 12:20:49 +01:00
Christoph Wurst
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
Christoph Wurst
f76ec25e58
Deprecate the GenericEvent wrapper
...
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 08:54:08 +01:00
Nextcloud-PR-Bot
130ce14892
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-02-10 04:31:13 +00:00
Nextcloud bot
decb70b9ac
[tx-robot] updated from transifex
2021-02-10 02:20:59 +00:00
Roeland Jago Douma
784a752c0f
tain-escape the cookie input
...
we only set the cookie if it is a proper <=32 char alphanum string.
Otherwise we just ignore the input.
Makes psalm also happier so that we can focus on other errors.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-09 22:35:18 +01:00
Christoph Wurst
e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
...
Added tests for OC\Core\Data\LoginFlowV2Credentials
2021-02-09 21:37:37 +01:00
Lukas Reschke
1fb03b3b2f
Merge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu
...
Corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
2021-02-09 21:26:30 +01:00
Christoph Wurst
3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
...
Deprecate all remaining event constants
2021-02-09 20:19:04 +01:00
Christoph Wurst
f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
...
Deprecate the internal IDBConnection event name constants
2021-02-09 18:50:55 +01:00
Christoph Wurst
4201fb25d3
Merge pull request #25549 from nextcloud/remove-reconnect-wrapper
...
remove ReconnectWrapper
2021-02-09 18:15:56 +01:00
Robin Appelman
111fa47f10
remove ReconnectWrapper
...
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
Konrad Abicht
a50c615d37
simplified tests
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:48:37 +01:00
Konrad Abicht
a28705064b
fixed coding style issue
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:40:19 +01:00
Konrad Abicht
b38a619212
added tests for OC\Core\Data\LoginFlowV2Credentials
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:25:37 +01:00