Commit Graph

55570 Commits

Author SHA1 Message Date
Julius Härtl 2004ae4603
Set delimiter so that the CommonPrefixes response can properly be determined
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 08:11:55 +02:00
Robin Appelman fc96fa0cc7
fix s3 doesDirectoryExist check for empty directories
if a directory is empty, only the 'marker' object `/` exists.

since not all s3 implementations return just the prefix when listing objects by prefix,
when listing objects by the folder prefix, nothing will be returned if the directory is empty.
by not including the trailing slash in the prefix, the folder marked will always be returned if it exists

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-10 08:11:55 +02:00
Daniel Calviño Sánchez 58d57b35ea Add integration tests for transferring ownership of reshares
Currently only transferring ownership of a reshare with a group to a
user in the group is possible.

When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).

When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).

The added integration tests reflect the above behaviours.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:34:33 +02:00
Daniel Calviño Sánchez 0ce8096839 Check share ownership after transferring file ownership
The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:24:16 +02:00
Daniel Calviño Sánchez d3d01d6355 Check whether file exists or not after transferring ownership
The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:18:53 +02:00
Morris Jobke 9780c4f755
Merge pull request #22700 from nextcloud/dependabot/npm_and_yarn/blueimp-md5-2.18.0
Bump blueimp-md5 from 2.17.0 to 2.18.0
2020-09-09 22:09:31 +02:00
Roeland Jago Douma 6895d97cf0
Merge pull request #22520 from nextcloud/normalize-path-invalid-utf8
dont use `false` as cache key for non utf8 path in normalizePath
2020-09-09 21:52:36 +02:00
Roeland Jago Douma e7f03486ad
Merge pull request #22651 from nextcloud/fix/s3/empty_files
Fix reading empty files from objectstorage
2020-09-09 21:43:59 +02:00
Roeland Jago Douma c104c192ae
Merge pull request #22663 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.7
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
2020-09-09 21:24:28 +02:00
Roeland Jago Douma 94eff7d797
Merge pull request #22587 from timm2k/patch-1
Check if var debugMode exists
2020-09-09 21:21:27 +02:00
Roeland Jago Douma fe5f8c5010
Merge pull request #22600 from nextcloud/dependabot/npm_and_yarn/build/http-proxy-1.18.1
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
2020-09-09 20:55:08 +02:00
Roeland Jago Douma 918d1f68b5
Merge pull request #22634 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2020-09-09 20:53:26 +02:00
Roeland Jago Douma bb06b6cce4
Fix reading empty files from objectstorage
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-09 20:45:13 +02:00
dependabot[bot] cb76d6a872
Bump blueimp-md5 from 2.17.0 to 2.18.0
Bumps [blueimp-md5](https://github.com/blueimp/JavaScript-MD5) from 2.17.0 to 2.18.0.
- [Release notes](https://github.com/blueimp/JavaScript-MD5/releases)
- [Commits](https://github.com/blueimp/JavaScript-MD5/compare/v2.17.0...v2.18.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-09 18:37:49 +00:00
Morris Jobke cd563023db
Merge pull request #22657 from nextcloud/bugfix/noid/quota-trash-creation
Check if quota should be applied to path when creating directories
2020-09-09 17:37:28 +02:00
Morris Jobke e6fca0a519
Fix code style
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-09 17:36:58 +02:00
Morris Jobke 22ff60e088
Merge pull request #22564 from nextcloud/bugfix/noid/show-avatars-again
The privacy setting is only about syncing to other servers
2020-09-09 17:35:13 +02:00
Morris Jobke 49415eea2c
Merge pull request #22660 from nextcloud/dependabot/composer/psalm/phar-3.15
Bump psalm/phar from 3.12.2 to 3.15
2020-09-09 17:10:06 +02:00
Robin Appelman 928cee2ae7
only get the permissions from the share source if it's not already cached
this prevents having to setup the share source when doing metadata stuff on the share root

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-09 13:48:48 +02:00
Joas Schilling f0b46ea605
Merge pull request #22648 from nextcloud/bugfix/noid/transfer-all-shares
Transfer shares if no path provided
2020-09-09 13:32:43 +02:00
Joas Schilling e280c05053
Merge pull request #22636 from nextcloud/bugfix/noid/initial-stte-cspv3
Make sure that getConfig is still called for browsers that do not support CSPv3
2020-09-09 13:11:59 +02:00
Morris Jobke d8dea5070b
Merge pull request #22729 from nextcloud/fix/object_storage_permissions_shortcut
Run stat less often for objectstorages
2020-09-09 10:43:37 +02:00
Nextcloud-PR-Bot 9c57fff01f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-09 04:23:34 +00:00
blizzz 0485e68ecf
Merge pull request #22649 from nextcloud/fix/noid/user-settings-event
emit typed event for user management
2020-09-08 23:50:01 +02:00
Arthur Schiwon f959828616
emit typed event for user management
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +02:00
Roeland Jago Douma 9fdeed8cc0
Run stat less often for objectstorages
When we want to get the permissions we now do stat at least 5 times for
each entry. Which is a bit much. Especially since the permssions are all
just in the database already.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-08 14:38:36 +02:00
Julius Härtl 74747163d6
Make sure tests cover the new mkdir behaviour on 0 quota
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-08 11:35:32 +02:00
Joas Schilling c2bef528ef
Remove unused members and imports
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-08 10:45:35 +02:00
Roeland Jago Douma 919a8d473b
Merge pull request #22646 from nextcloud/bugfix/mimetype-mapping
Fix detecting text/x-php mimetype and secure mimetype mapping
2020-09-08 10:41:09 +02:00
Roeland Jago Douma b4729ce142
Merge pull request #22647 from nextcloud/fix/noid/depcreated-methods-settings
fix use of removed escapeHTML in settings.js
2020-09-08 10:35:24 +02:00
Roeland Jago Douma ac5f2914c7
Merge pull request #22641 from nextcloud/fix/credentials-store-upgrade-property-undefined
Fix undefined class property access after upgrade from 19 to 20
2020-09-08 10:26:23 +02:00
Roeland Jago Douma 292c86fc29
Merge pull request #22638 from nextcloud/bugfix/noid/dashboard-category-icon
Add icon for dashboard app store category
2020-09-08 09:58:19 +02:00
Joas Schilling 6540c397aa
Merge pull request #22469 from nextcloud/bugfix/noid/oracle-casting-select-distinct
Don't use SELECT DISTINCT when to_char() is used in a WHERE statement
2020-09-08 09:40:11 +02:00
dependabot[bot] d46252e0e8 Bump query-string from 5.1.1 to 6.13.1
Bumps [query-string](https://github.com/sindresorhus/query-string) from 5.1.1 to 6.13.1.
- [Release notes](https://github.com/sindresorhus/query-string/releases)
- [Commits](https://github.com/sindresorhus/query-string/compare/v5.1.1...v6.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-08 07:11:57 +00:00
John Molakvoæ c436e5db16
Merge pull request #22712 from nextcloud/fix/dependabot-config
Delete dependabot.yml
2020-09-08 09:11:23 +02:00
John Molakvoæ 28df9239bb
Delete dependabot.yml 2020-09-08 08:56:33 +02:00
dependabot[bot] 94b228dca1
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.6.1...v3.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:56 +00:00
dependabot[bot] 20e6d04a69
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.6...1.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:47 +00:00
dependabot[bot] 49941335d4
Bump psalm/phar from 3.12.2 to 3.15
Bumps [psalm/phar](https://github.com/psalm/phar) from 3.12.2 to 3.15.
- [Release notes](https://github.com/psalm/phar/releases)
- [Commits](https://github.com/psalm/phar/compare/3.12.2...3.15)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:34 +00:00
John Molakvoæ 90b1244d10
Merge pull request #22642 from nextcloud/dependabot/config
Move to automated dependabot merging
2020-09-08 08:36:26 +02:00
John Molakvoæ (skjnldsv) d939f2fa5a
Split target-branch between stablexx branches until it supports Arrays
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-09-08 08:32:14 +02:00
Raimund Schlüßler 6989200147 Change status popover container
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
2020-09-08 08:05:15 +02:00
Julius Härtl 87e5fd0d2c
Check if quota should be applied to path when creating directories
This fixes an issue where the files_trashbin hierarchy of a user could
not been created as the mkdir operations were blocked by the quota
storage wrapper. Even with 0 quota, users should be able to have a
trashbin for external storages.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-08 07:33:57 +02:00
Arthur Schiwon 43ea48c079
fixes use of removed escapeHTML in settings.js
- solves non-working "additional settings" sections (at least)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-07 22:57:45 +02:00
Morris Jobke 34d2ae25f7
Merge pull request #22643 from nextcloud/bugfix/noid/fix-installing-on-oracle
Fix installing on Oracle
2020-09-07 20:55:50 +02:00
Morris Jobke 0e6344f543
Merge pull request #22650 from nextcloud/fix/noid/fix-psalm-warning
Only load viewer in settings if the viewer app is enabled
2020-09-07 20:41:49 +02:00
Morris Jobke 6f4ea73e0c
Merge pull request #22644 from nextcloud/fix/license-headers-20-2
Update license headers for Nextcloud 20 (again)
2020-09-07 20:34:36 +02:00
Morris Jobke ce1e873a0a
Only load viewer in settings if the viewer app is enabled
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-07 20:25:57 +02:00
Julius Härtl aa04a26c68
Transfer shares if no path provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-07 17:35:29 +02:00
Julius Härtl 16b9817358
Add text/x-php as an alternative for application/x-php
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-07 16:43:00 +02:00