Commit Graph

58019 Commits

Author SHA1 Message Date
Morris Jobke b34035f845
Merge pull request #26193 from nextcloud/techdebt/noid/remove-sharing-duplicate-unit-integration-tests
Permission tests for the sharing are fully covered in sharing v1 integration tests
2021-03-18 11:34:15 +01:00
Morris Jobke d650de13a4
Remove duplicate unit test in sharing that checks for group permission updates
* it was skipped before anyways
* it is covered for example in build/integration/sharing_features/sharing-v1-part3.feature#L517-L548 (see 54f8f75f6f/build/integration/sharing_features/sharing-v1-part3.feature (L517-L548))
* more permission updates are tested in the webdav section, where an OCS API is called and the WebDAV response is checked for the properly changed permission

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:31:56 +01:00
Morris Jobke e6bd23acf9
Permission tests for the sharing are fully covered in sharing v1 integration tests
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:15:42 +01:00
kesselb dd39f5e871
Merge pull request #25112 from nextcloud/repair-exception
dont error the entire repair process when a repair step errors
2021-03-18 10:14:47 +01:00
Morris Jobke 6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +01:00
Robin Appelman 9e3775618b
log full expection during repair step
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:17 +01:00
Robin Appelman 9135a42781
make repair errors more visible
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
Robin Appelman c75b82adbb
dont error the entire repair process when a repair step errors
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
Morris Jobke 5cdc3e9c9d
Merge pull request #26188 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-03-18 08:30:44 +01:00
Nextcloud-PR-Bot 3959313b2c Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-03-18 04:34:21 +00:00
Nextcloud bot a186d08471
[tx-robot] updated from transifex 2021-03-18 02:25:02 +00:00
Morris Jobke 37feee4e87
Merge pull request #24384 from nextcloud/cleanup/remove-old-migration-check
Remove dead code from checking core/apps before upgrades
2021-03-17 21:29:19 +01:00
Julius Härtl a2f3077ee8
Skip db migration simulation for core schema changes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-17 21:08:22 +01:00
Morris Jobke 459e0b311b
Merge pull request #25924 from nextcloud/bugfix/noid/only-mark-migrations-as-installed-after-executing-them-in-case-the-developer-broke-them
Only mark migrations as installed after execution
2021-03-17 20:29:28 +01:00
Morris Jobke f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
Drop \OCP\Util::isIe
2021-03-17 20:18:11 +01:00
John Molakvoæ f1fefd91df
Merge pull request #26160 from nextcloud/enh/eslint 2021-03-17 18:14:31 +01:00
Morris Jobke 6867ba8e33
Merge pull request #24580 from nextcloud/enh/noid/db-convert
DB conversion: improve console output
2021-03-17 17:52:42 +01:00
Joas Schilling 0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
Improve search results when only phonebook-matches can we autocompleted
2021-03-17 15:22:03 +01:00
John Molakvoæ (skjnldsv) 87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 14:45:29 +01:00
Morris Jobke d011df6aa7
Merge pull request #26076 from nextcloud/enh/noid/ldap-occ-user-reset
adds ldap user:reset command
2021-03-17 14:36:18 +01:00
Simon Spannagel 244e13cd43
DB conversion: improve console output
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2021-03-17 14:35:40 +01:00
Morris Jobke 2445b9491e
Merge pull request #26172 from nextcloud/techdebt/noid/code-checker-is-noop
occ app:check-code is noop
2021-03-17 13:45:09 +01:00
John Molakvoæ (skjnldsv) 043b5a9de4
Fix TerserPlugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:39 +01:00
John Molakvoæ (skjnldsv) 5d9bb5e247
Lint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +01:00
John Molakvoæ (skjnldsv) fb183b457c
Add eslint testing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +01:00
dependabot-preview[bot] 1b5db252c5
Merge pull request #26165 from nextcloud/dependabot/composer/vimeo/psalm-4.6.4 2021-03-17 10:47:44 +00:00
Joas Schilling 68a402d889
occ app:check-code is noop
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 11:29:53 +01:00
Arthur Schiwon 1b0355f2c6
adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
  guarded
- ensures that the user is not being deleted on LDAP through a plugin

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-17 11:23:48 +01:00
Joas Schilling cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 11:20:30 +01:00
Vincent Petry ab5c19bb08
Merge pull request #26131 from nextcloud/fix/initialstate-templates
Fix default missing initial state for templates
2021-03-17 10:18:03 +01:00
dependabot-preview[bot] 958d6e2f34
Bump vimeo/psalm from 4.6.2 to 4.6.4
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.6.2 to 4.6.4.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.6.2...4.6.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-17 09:05:25 +00:00
Joas Schilling 3379e69ecc
Fix parameter types in docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
Joas Schilling 47e14c9a79
Add missing index on the user column
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
Joas Schilling 9a189bc710
Improve search results when only phonebook-matches can we autocompleted
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-17 09:51:31 +01:00
Vincent Petry 98fb265e9f
Merge pull request #26153 from nextcloud/psalm/26111/fix-undefined-exception-class
Use correct exception type hint in catch statement
2021-03-17 09:41:47 +01:00
Nextcloud bot 096806087c
[tx-robot] updated from transifex 2021-03-17 02:24:19 +00:00
Morris Jobke 0f2c4ff64c
Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-16 22:06:07 +01:00
Robin Appelman 5938da8d20
Merge pull request #26137 from nextcloud/block-__groupfolders-uid
dont allow creating users with __groupfolders as uid
2021-03-16 18:47:40 +00:00
Robin Appelman dd477d30f9
dont allow creating users with __groupfolders as uid
Fixes https://github.com/nextcloud/groupfolders/issues/338

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 19:03:10 +01:00
Robin Appelman f1e2fb426e
Merge pull request #26013 from nextcloud/object-store-copy-cache-id
Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-16 16:11:17 +00:00
Robin Appelman 5ffaa94fbc
add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:35:35 +01:00
Joas Schilling 7a09b7d60e
Merge pull request #26143 from nextcloud/techdebt/noid/fix-cs
Fix CS in CacheTest
2021-03-16 12:50:07 +01:00
Joas Schilling ccaa131e96
Merge pull request #26144 from nextcloud/funding
Add funding info
2021-03-16 12:49:06 +01:00
tobiasKaminsky bfb535b2b2
Add funding info
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-03-16 11:44:59 +01:00
Vincent Petry c6d2d8746c
Fix CS in CacheTest
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-16 11:43:53 +01:00
Nextcloud bot 72e6201869
[tx-robot] updated from transifex 2021-03-16 02:24:42 +00:00
Vincent Petry e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
John Molakvoæ (skjnldsv) 223fe2aae6
Fix default missing initial state for templates
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-15 17:23:30 +01:00
Robin Appelman a550649708
expand 'path is already shared' error message
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +01:00
Morris Jobke f512705f8f
Merge pull request #26003 from nextcloud/enh/simplefile/getid
Add getID function to the simplefile implementation
2021-03-15 14:41:15 +01:00