ceed64154f
Merge pull request #26148 from nextcloud/backport/26013/stable19
...
[stable19] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-19 15:29:14 +01:00
ecaa02678a
Update user share must use correct expiration validation
...
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-19 11:07:04 +01:00
df77c7d37c
limit constructing of result objects in file search
...
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:23:16 +01:00
f302616544
Merge pull request #26092 from nextcloud/backport/25722/stable19
...
[stable19] apply object store copy optimization when 'cross storage' copy is wit…
2021-03-17 20:09:11 +01:00
68fb72b028
remove explicit fclose from S3->writeStream
...
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:15 +00:00
300c4dd6b8
verify that cache entry is valid
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:13 +00:00
53dcc7b1ca
also implement for FailedCache and NullCache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:11 +00:00
cc1a5d5ced
use returned file id for object store copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:09 +00:00
603ec9be0c
add ICopyFromCache trait to expose existing implementation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:06 +00:00
b2903064c9
only use share cacheentry when available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
1d1d4de991
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
b9b2c6d2fa
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
75a48fbc2a
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
564390e303
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:26:59 +01:00
b39f9fb2c9
apply object store copy optimization when 'cross storage' copy is within the same object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:38 +00:00
23e3730a10
Merge pull request #25449 from nextcloud/backport/25393/stable19
...
[stable19] add repair job for unencoded group share uris
2021-02-17 21:05:16 +01:00
8315de942c
adjust applicable version
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 20:07:56 +01:00
1bb5314491
compatibility to Nc 19
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:26:18 +01:00
8f499b9c8a
add missing changes from backport source
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:25:41 +01:00
68fa9a4f54
Merge pull request #25389 from nextcloud/backport/25302/stable19
...
[stable19] Use RFC-compliant URL encoding for cookies
2021-02-09 22:07:45 +01:00
09f16281a2
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:18 +00:00
d494c6650c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:16 +00:00
038def2328
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:14 +00:00
ec12ac058b
show suggestion to clean up possible invalid shares later
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:43 +00:00
fcf358e0df
add repair job for unencoded calendars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:39 +00:00
c5d2ea84e6
Use RFC-compliant URL encoding for cookies
...
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.
Fixes #24438
Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-29 12:42:14 +00:00
6fa08f38b3
The objectid is a string
...
This allows the query to use the index. Else it has to resort on
scanning all the rows.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-29 07:17:41 +00:00
a4c7a62394
Merge pull request #25121 from nextcloud/backport/25036/stable19
...
[stable19] respect DB restrictions on number of arguments in statements and queries
2021-01-28 12:27:52 +01:00
1de3cfd049
Don't log keys on checkSignature
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 21:28:32 +00:00
b78ed6ea3f
CI satisfaction
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:48 +01:00
83b0b84c1f
DB: warn on parameter number constraints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:37 +01:00
16850b940f
Make sure to do priority app upgrades first
...
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 13:49:12 +00:00
57e165c244
Merge pull request #24593 from nextcloud/backport/23912/stable19
...
[stable19] use in objectstore copy
2021-01-07 13:28:38 +01:00
3f8024932a
Merge pull request #24962 from nextcloud/backport/24683/stable19
...
[stable19] [Fix #24682 ]: ensure federation cloud id is retruned if FN property not found
2021-01-07 09:41:40 +01:00
d77b3345b2
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:06:32 +01:00
db048845ef
[ Fix #24682 ]: ensure federation cloud id is retruned if FN property not found
...
Signed-off-by: Guillaume Virlet <github@virlet.org>
2021-01-05 08:27:31 +00:00
7d282a4e88
Avoid huge exception argument logging
...
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.
Now it will just print the first 5. And add a line that there are N
more.
If you are on debug level we will still print them all.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-29 10:46:54 +00:00
ae49423991
Actually set the TTL on redis set
...
Else well the keys remain for ever and ever.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-21 13:53:42 +00:00
dedff0facb
use in objectstore copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:25 +00:00
ec270ce35e
Fix typo
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-04 15:56:38 +00:00
a5951d0d79
Remember me is not an app_password
...
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 15:56:32 +00:00
ca917c59e1
Generate a new session id if the decrypting the session data fails
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 11:58:13 +00:00
bf9888870c
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:20:06 +00:00
349f754833
Fix file size computation on 32bit platforms
...
Signed-off-by: aler9 <46489434+aler9@users.noreply.github.com>
2020-12-02 15:27:22 +00:00
21defabc41
Merge pull request #24327 from nextcloud/backport/24103/stable19
...
[stable19] Only check path for being accessible when the storage is a object home
2020-12-01 11:04:09 +01:00
6d6382a55d
Merge pull request #24354 from nextcloud/backport/24162/stable19
...
[stable19] set the display name of federated sharees from addressbook
2020-11-25 16:18:12 +01:00
29a452c693
send expected format of cloud id
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-25 14:32:30 +01:00
10a252c905
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-25 14:32:06 +01:00
aecf4eff27
Extra white space to follow other ifs
...
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-11-25 11:55:16 +00:00
43e401e3a2
Avoid substr() error when strpos returns false
...
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-11-25 11:55:15 +00:00
Morris Jobke
Vincent Petry
Robin Appelman
Roeland Jago Douma
Arthur Schiwon
Samuel
Marco Ziech
Roeland Jago Douma
Joas Schilling
Julius Härtl
Guillaume Virlet
aler9
lui87kw
bladewing