c423a50938
Fix the Talk verification
...
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).
When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.
We'll have to backport to 18.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 13:51:42 +00:00
48c0ac2f12
normalize sftp path in read and write stream
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-06-03 10:19:35 +00:00
25dd585251
Do not only catch Exceptions but any Throwable during rmt share delete
...
When a remote share is deleted, we notify the remove instance. This may
trigger various error conditions, which we want to catch in order to
avoid undeletable shares. The try-catch, however, did only capture
exceptions, so things like TypeErrors were not caught and caused the
process to fail hard.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 09:13:47 +00:00
9a5b51d43c
Fix creating a mail share with a password
...
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
5de6eb07c0
Extend mail shares unit tests to check the password and mail template
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:42 +00:00
e9ccb802e8
Fix reference to wrong class name
...
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 06:48:00 +00:00
d12e379c96
Merge pull request #21128 from nextcloud/backport/21123/stable19
...
[stable19] simplify getGroups, fixing wrong chunking logic
2020-05-28 14:59:50 +02:00
1e5295138a
simplify getGroups, fixing wrong chunking logic
...
pagination is taken care of properly in the search logic in Access class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 17:38:45 +00:00
14b618bcaf
Fix devices & sessions sanitization
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 15:57:18 +02:00
557a3754c1
use the loginname to verify the old password in user password changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 19:20:42 +00:00
d0559a4871
fixes infinitely repeating LDPA search results with PHP <= 7.2
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 09:56:10 +00:00
138eddc0f1
Merge pull request #21028 from nextcloud/backport/20629/stable19
...
[stable19] Don't load text file preview when text app is available (Fixes : #20615 )
2020-05-20 13:54:17 +02:00
dd15780edd
Fix share update test
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-18 13:47:39 +00:00
aac0dd1f20
Have share permissions on link shares if it is enabled
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 13:47:38 +00:00
be37ca1776
Don't load text file preview when text app is available ( Fixes : #20615 )
...
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.
So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-05-18 08:59:53 +00:00
ffc3b48a40
update icewind/smb to 3.2.4
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-15 12:35:22 +00:00
4bde23d239
Merge pull request #20878 from nextcloud/backport/20719/stable19
2020-05-11 14:55:16 +02:00
e048bf8550
Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
d1909526fc
Implement ctag and etag in ContactsInteraction
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:55 +00:00
adbdecb1d6
Fix languages empty array
...
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
90a65f83e0
Do not process the same FileInfo twice
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
614acc9419
add locking to resolve concurent move to trashbin conflicts
...
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-06 20:36:55 +02:00
06732cf2af
Merge pull request #20832 from nextcloud/fix/sharing-filter-user-shares-only-fix-group-display
...
Do not filter id matching userId on non-user-share shares
2020-05-06 17:46:21 +02:00
3bf4e7d673
[tx-robot] updated from transifex
2020-05-06 02:16:28 +00:00
a26ca1e638
Do not filter id matching userId on non-user-share shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
edecd0931e
Fix filtering our owner & current user from shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
09d7854d0e
[tx-robot] updated from transifex
2020-05-05 02:16:14 +00:00
ff20da637e
Fix federated link sharing permissions
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
6aceb39714
Merge pull request #19124 from nextcloud/bug/13647/ignore-delete-groups
...
Exclude groups from sharing: Skip delete groups
2020-05-04 10:02:32 +02:00
43fefee847
[tx-robot] updated from transifex
2020-05-04 02:16:18 +00:00
d2f165e448
[tx-robot] updated from transifex
2020-05-03 02:16:16 +00:00
8dd23f9854
Fix expiry datepicker allowing all dates
...
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.
This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
e77e0b0e2f
[tx-robot] updated from transifex
2020-05-02 02:16:32 +00:00
31172a0cd9
Process shares only once, better debug and expiration date code
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
b7b7b2872c
Fix owner on publicownerwrapper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 10:50:26 +02:00
c724eb24d5
Merge pull request #20380 from nextcloud/design/notification-mails
...
Fix design and layout of notification mails
2020-05-01 08:53:39 +02:00
da9ad9ec78
Merge pull request #20291 from nextcloud/fix/user_menu_not_focused
...
Fix focus for user actionmenu
2020-05-01 08:42:06 +02:00
9f448d864b
[tx-robot] updated from transifex
2020-05-01 02:16:47 +00:00
e981669e89
Fix notification mail tests
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +02:00
9b1f98f6fd
Fix the keyboard tab for actionmenu
...
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-30 19:03:56 +00:00
b2b8be83f8
Merge pull request #20538 from nextcloud/fix/20520/share-expire
...
Fix share expiration date not shown
2020-04-30 20:55:05 +02:00
ae665e2175
Merge pull request #20744 from nextcloud/fix/public-design
...
Fix public layout header title & description
2020-04-30 19:02:32 +02:00
02b5ded840
Fix share expiration date not shown
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
0f9b88c5a9
Merge pull request #20718 from nextcloud/fix/public_share_owner_activity_mess
...
Add a wrapper to fall back to the share owner on public shares
2020-04-30 13:46:13 +02:00
6e79fb60d8
Fix public layout header title & description
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
5b5550dbba
Merge pull request #20677 from nextcloud/followup/17718/scaling-user-provisioning
...
Scaling user provisioning for subadmins with many groups
2020-04-30 12:49:57 +02:00
b8b53a2d9a
Merge pull request #19436 from nextcloud/bugfix/noid/dav-quota-calculation
...
Do not include mountpoints when calculating quota usage on WebDAV
2020-04-30 09:13:19 +02:00
a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
...
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
bc66bdc072
Add a wrapper to fall back to the share owner on public shares
...
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
2df57b270c
Merge pull request #20720 from nextcloud/bugfix/noid/temporary-fix-contacts-search
...
Temporary fix contacts search
2020-04-30 08:52:50 +02:00
523a8ba5c3
[tx-robot] updated from transifex
2020-04-30 02:17:11 +00:00
d466a7b808
Allow to navigate to others with access from the sidebar
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
f662d3663b
Temporary fix contacts search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
b219eadb8f
Merge pull request #20714 from nextcloud/fix/license-headers-19
...
Update license headers for 19
2020-04-29 14:24:27 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
08296c04c0
Bump webpack from 4.42.1 to 4.43.0
...
Bumps [webpack](https://github.com/webpack/webpack ) from 4.42.1 to 4.43.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v4.42.1...v4.43.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 09:23:51 +00:00
297276baba
[tx-robot] updated from transifex
2020-04-29 02:16:55 +00:00
192cf12440
Merge pull request #20636 from nextcloud/tests/noid/tests-for-update-notifications-controller
...
Add tests for update notification controller for non-default updater …
2020-04-28 16:18:18 +02:00
773e9d0554
Add tests for update notification controller for non-default updater server URL
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-04-28 15:28:47 +02:00
0c701cec56
Merge pull request #20676 from clementhk/ldap-group
...
Don't remove last user in ldap group when limit is -1
2020-04-28 12:58:02 +02:00
c69686a29d
Merge pull request #20673 from nextcloud/enh/tweaks-app-data-scan
...
Set exit code if something went wrong.
2020-04-28 12:04:25 +02:00
ef566a1f40
[tx-robot] updated from transifex
2020-04-28 02:16:22 +00:00
31ebc827f7
Merge pull request #20558 from nextcloud/dependabot/npm_and_yarn/vue-click-outside-1.1.0
...
Bump vue-click-outside from 1.0.7 to 1.1.0
2020-04-27 11:08:21 +02:00
1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
...
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
...
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
e56ffe5992
[tx-robot] updated from transifex
2020-04-27 02:16:13 +00:00
9f5f505acf
Don't remove last user in ldap group when limit is -1
...
Signed-off-by: Clement Wong <git@clement.hk>
2020-04-27 02:33:00 +02:00
3294f53942
Set exit code if something went wrong.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-26 20:37:21 +02:00
deb2ea9cea
Provide links to calendar in event creation/update activities
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
0eeb660679
[tx-robot] updated from transifex
2020-04-26 02:16:12 +00:00
6ffde74928
Patch to optimize for large installations (>5000 users >20000 groups) where subadmins have access to many of groups (>250)
...
- UsersController:editUser() calls isUserAccessible() even if the user is admin
This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.
Signed-off-by: Mikael Hammarin <mikael@try2.se>
2020-04-25 14:37:46 +02:00
39f6f1ba34
[tx-robot] updated from transifex
2020-04-25 02:16:01 +00:00
902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
16f29d81bf
Ignore delete groups
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-24 18:10:02 +02:00
dc46743ef5
Bump vue-click-outside from 1.0.7 to 1.1.0
...
Bumps [vue-click-outside](https://github.com/vue-bulma/click-outside ) from 1.0.7 to 1.1.0.
- [Release notes](https://github.com/vue-bulma/click-outside/releases )
- [Commits](https://github.com/vue-bulma/click-outside/commits/v1.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-24 14:58:19 +00:00
768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
...
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00
4114bce1e5
Merge pull request #17623 from j3l11234/master
...
Add support for download share on old android browser
2020-04-24 16:01:45 +02:00
d7161b4eee
Only catch anonymous OPTIONS for Office
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 14:46:07 +02:00
8c07b6e07a
Merge pull request #20626 from nextcloud/enh/scan-appdata-folder-arg
...
Add folder argument to files:scan-app-data
2020-04-24 13:07:17 +02:00
212138daa1
Merge pull request #19919 from nextcloud/enh/noid/ldpa_group_perf
...
LDAP Group Backend optimizations
2020-04-24 12:27:27 +02:00
84a3536159
[tx-robot] updated from transifex
2020-04-24 02:27:55 +00:00
038045d55e
Merge pull request #18816 from nextcloud/bugfix/noid/paginate-contacts-search
...
Use paginated search for contacts
2020-04-23 22:20:58 +02:00
4babdc082b
formatting
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-23 21:34:05 +02:00
6709833dc7
Use paginated search for contacts
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
24e58947d6
Merge pull request #20618 from nextcloud/bugfix/noid/fix-workflow-ui
...
Fix workflow UI
2020-04-23 17:16:33 +02:00
335b1f15f3
Fix workflow UI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-23 13:52:04 +02:00
7a4ea4a6b6
make php-cs happy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-23 13:35:30 +02:00
79e3823d72
[tx-robot] updated from transifex
2020-04-23 02:16:54 +00:00
4a8871f5f2
Merge pull request #19399 from nextcloud/smb-read-acl
...
Add option to check share ACL's when listing directories
2020-04-22 23:16:12 +02:00
8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag
...
Make sure that OC-ETag is set again
2020-04-22 22:21:22 +02:00
d0a57a33a9
Merge pull request #20595 from nextcloud/fix/ie11-fallback-upload
...
Fix IE11 upload fallback methods
2020-04-22 22:06:56 +02:00
f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions
...
Fix Sharing recommendation user display
2020-04-22 14:56:01 +02:00
acdc68e1e2
Merge pull request #20591 from nextcloud/fix/settings
...
Fix settings routing
2020-04-22 14:45:25 +02:00
7f32fe6d50
add tooltip to option
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-22 14:25:33 +02:00
754fd40e40
Fix IE11 upload fallback methods
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-22 13:40:23 +02:00
8ffa762486
Merge pull request #20536 from nextcloud/fix/noid/ldap-73api-read-wo-pagedresults
...
do not run paged results against ldap_read ops on PHP7.3+
2020-04-22 13:37:43 +02:00
e983ae3b06
Add folder argument to files:scan-app-data
...
If you need to rescan something but don't feel like rescanning your
whole preview stash.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:27:33 +02:00
c870b6ab2e
Fix new routing in settings etc
...
Also prefix resources
Unify the prefix handling
Handle urls with and without slash
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:09:25 +02:00
ac57bbcf99
[tx-robot] updated from transifex
2020-04-22 02:17:06 +00:00
23e2baeb95
Add option to check share ACL's when listing directories
...
If a file or folder in a directory doesn't have read permissions they
will not be shown
Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.
Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
...
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
75c686d825
do not run paged results against ldap_read ops on PHP7.3+
...
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-21 15:47:49 +02:00
5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +02:00
45c3ee7f36
Set proper share type when converting link shares to federated shares
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:28 +02:00
0e925285b7
Add test that shares and tags are ignored for chunk files.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-21 14:00:52 +02:00
aa79f9ada2
Merge pull request #20577 from nextcloud/bugfix/noid/sabre4_aftermethod
...
Fix usages of afterMethod -> afterMethod:*
2020-04-21 13:26:13 +02:00
89bd8ea449
Merge pull request #20564 from go2sh/fix_fileinfo
...
Set fileInfo correctly for LegacyTabs
2020-04-21 12:24:54 +02:00
8730cc6764
Use a proper upload file so propfinds return 404
...
Fixes #20235
By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:33:28 +02:00
effcd58e14
Fix usages of afterMethod -> afterMethod:*
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-21 10:19:06 +02:00
4ee56689a8
Make sure that OC-ETag is set again
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-21 10:14:31 +02:00
7eceba7dae
Fix Sharing recommendation user display
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-21 07:48:10 +00:00
f0c1041d2e
[tx-robot] updated from transifex
2020-04-21 02:16:40 +00:00
9735b5d61f
Add method to storage backends to get directory content with metadata
...
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.
While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)
With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
b1a90da347
[tx-robot] updated from transifex
2020-04-20 02:16:12 +00:00
c9e0ea525b
Set fileInfo correctly for LegacyTabs
...
Watch for changes of the fileInfo prop and propagate it to,
the underlying component.
Fixes #20106 .
Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
2020-04-19 22:56:30 +02:00
e9930aebc7
[tx-robot] updated from transifex
2020-04-19 02:16:10 +00:00
1b93d5f1db
PHP CS fixes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
685d7b0637
Directly use the class to get the service
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
031b6656d1
Reduce noise in test output
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
9654a924ab
Fix route definitions of cloud_federation_api
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
e45c87cd2e
Fix creating the share controller
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
708b4991d9
Fix legacy routes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
f93d55eebd
PHP CS fixes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
3f8168b6e5
Allow some apps to have root URLs in their own routing file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
64196ddd19
Merge pull request #20449 from liamjack/fix/19066/empty_file_versions
...
Array offset error due to empty file versions array
2020-04-18 10:54:19 +02:00
ad603fd13a
Merge pull request #20540 from nextcloud/fix/mail-test
...
Fix mailer test
2020-04-18 10:34:04 +02:00
2fc35d10e4
Added trailing space
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-18 10:26:35 +02:00
148bdabd58
[tx-robot] updated from transifex
2020-04-18 02:16:28 +00:00
ab550d682f
do not rerun expensive sanitizer against already processed DNs
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:49:47 +02:00
32000dd1af
read records from DB for lists at once, not one by one.
...
Keep a runtime cache of dn-id-mapping
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:39:54 +02:00
cc31c38277
don't circulate with only one backend
...
- saves some overhead costs
- in some occasions saves LDAP requests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:52 +02:00
e8ddb4718c
consolidate groupsMatchFilter in groupsExist
...
- less duplication
- profiting of the same cache entry
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:07 +02:00
ed56619a20
Merge pull request #19901 from nextcloud/bugfix/noid/vcard-photo-handling
...
Improved vcard photo handling
2020-04-17 11:43:20 +02:00
7c4b7e9329
Merge pull request #20529 from nextcloud/fix/Card-multiple
...
Update list of multiple properties
2020-04-17 10:39:19 +02:00
36f9ad32f2
Merge pull request #20447 from liamjack/fix/13287/welcome_email
...
Increase max-height on button in welcome email template
2020-04-17 09:42:49 +02:00
29541322c1
Update list of multiple properties
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-17 09:38:47 +02:00
9bd9c2bf32
Merge pull request #20381 from nextcloud/fix/allow_edit_admin_user
...
Allow to edit admin user
2020-04-17 09:06:58 +02:00
a8809f079b
[tx-robot] updated from transifex
2020-04-17 02:16:31 +00:00
d17c58eeec
Allow to edit admin user
...
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-16 11:59:01 +02:00
8971403ada
Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap
...
PHP-CS-Fixer green
2020-04-16 10:37:49 +02:00
d9990b09b8
PHP-CS-Fixer green
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:25:17 +02:00
bb4dedb015
Provide the proper language to the mailer
...
Else we can't properly translate the footer in the recipients e-mail
language.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:04:13 +02:00
078ac97939
[tx-robot] updated from transifex
2020-04-16 02:17:30 +00:00
fe4527a8e2
Update Contact Size after removing photo
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-04-15 15:49:49 +02:00
648c8df516
Don't populate the PHOTO property when it's not an image
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:39 +02:00
bb754cb363
Always transform the etag and read the data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:36 +02:00
2e9f105786
Use table variable everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 15:49:12 +02:00
73271aa086
DAV's exception logger should deal with any Throwable
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-15 15:28:37 +02:00
8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1
...
do not use deprecated API for LDAP paged results
2020-04-15 15:02:51 +02:00
d8557d0d8a
Merge pull request #19540 from jlutran/fixKeystoneV3Auth
...
Fix issues with Keystone auth v3 in files_external app
2020-04-15 14:05:32 +02:00
5c0637bc90
Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic
...
Make remote checking more generic
2020-04-15 12:48:49 +02:00
19171d77e2
Merge pull request #19191 from laurisb/patch-1
...
Improve Opcache detection
2020-04-15 11:03:05 +02:00
3e849daf11
Fix issues with Keystone auth v3 in files_external app
...
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
2020-04-15 10:33:08 +02:00
d63abebc93
Merge pull request #19351 from nextcloud/dav-upload-hash
...
Return hashes of uploaded content for dav uploads
2020-04-15 10:23:22 +02:00
b212151af1
Merge pull request #20476 from nextcloud/techdebt/php-cs-check-action
...
Add php-cs check action
2020-04-15 08:30:29 +02:00
fd0c1a3bb2
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:06:51 +02:00
bccd13ffae
[tx-robot] updated from transifex
2020-04-15 02:17:12 +00:00
609b8aff12
Also disallow ; in remote urls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
5e402f8aae
Check all remotes for local access
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-14 18:56:06 +02:00
833d1d2c3b
Fix php-cs formatting
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-14 17:53:44 +02:00
d7a74d0e35
Merge pull request #20472 from nextcloud/fix/19848/make-sure-destination-is-not-a-directory
...
Verify that destination is not a directory.
2020-04-14 15:20:46 +02:00
84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
...
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +02:00
91ab811824
Verify that destination is not a directory.
...
Otherwise file_put_contents will fail later.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 12:52:12 +02:00
47146a1992
Properly display share error messages
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-14 08:39:40 +00:00
09bb8ac6e2
[tx-robot] updated from transifex
2020-04-14 02:16:50 +00:00
3ea9dd8487
Merge pull request #19852 from nextcloud/dav/provide-dav-setting-for-default-calendar
...
Provide dav setting for user's default calendar
2020-04-13 17:00:04 +02:00
d5ce231c4b
Bump marked from 0.8.1 to 0.8.2
...
Bumps [marked](https://github.com/markedjs/marked ) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/markedjs/marked/releases )
- [Commits](https://github.com/markedjs/marked/compare/v0.8.1...v0.8.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-13 14:10:24 +00:00
0408c37b3d
Only delete the default calendar setting when the default calendar
...
itself is deleted
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:43 +02:00
ebdf66b706
Provide dav setting for user's default calendar
...
And add tests to handle schedule-default-calendar-URL
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-13 15:07:42 +02:00
ae6e5fb76d
Bump @nextcloud/paths from 1.1.1 to 1.1.2
...
Bumps @nextcloud/paths from 1.1.1 to 1.1.2.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-13 12:24:37 +00:00
21d8a2bfc1
Merge pull request #20446 from nextcloud/dependabot/npm_and_yarn/css-loader-3.5.2
...
Bump css-loader from 3.4.1 to 3.5.2
2020-04-13 14:11:00 +02:00
a307d82e1d
Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity
...
Fix password reset saying Admin changed my password when reset from login page
2020-04-13 13:15:49 +02:00
372d6bf23e
Bump css-loader from 3.4.1 to 3.5.2
...
Bumps [css-loader](https://github.com/webpack-contrib/css-loader ) from 3.4.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases )
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.1...v3.5.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-13 11:13:09 +00:00
57403c7020
dont set headers for cli
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:29 +02:00
c2677682c4
Return hashes of uploaded content for dav uploads
...
hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers.
these headers are set for file uploads and the MOVE request at the end of a multipart upload.
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-13 12:57:27 +02:00
6187cea304
[tx-robot] updated from transifex
2020-04-13 02:19:45 +00:00
1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods
...
Show setup check for recommended php modules
2020-04-12 15:56:10 +02:00
b6c76f43a1
Fix #19066 - Array offset error due to empty file versions array
...
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
2020-04-12 15:35:17 +02:00
301335e9e1
Fix #13287 - Increase max-height on button in welcome email template
...
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
2020-04-12 13:07:16 +02:00
8924214299
Merge pull request #20439 from nextcloud/Valdnet-patch-3
...
Changing the translation catalog for "Share"
2020-04-12 09:08:52 +02:00
d32ea71c30
[tx-robot] updated from transifex
2020-04-12 03:09:11 +00:00
a50698b3c3
Changing the translation catalog for "Share"
...
Change "files" to "files_sharing".
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-12 02:20:14 +00:00
c20321e7e0
Add tests for encoded group id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-11 06:36:20 +00:00
5252836f44
Make sure the group id parameter gets properly encoded when used in URLs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-11 08:28:15 +02:00
e7249de145
Make the groupId url encoded
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-11 08:28:15 +02:00
e5ac5c7f34
Merge pull request #20185 from azul/open-new_tab
...
Modify do_action so default ctrl-click opens tab
2020-04-11 08:23:11 +02:00
b5a30d5cd6
Merge pull request #20426 from nextcloud/techdebt/psr2
...
It is done
2020-04-11 08:21:35 +02:00
97de425a17
Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various
...
Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …
2020-04-11 08:18:14 +02:00
de52e1cda7
[tx-robot] updated from transifex
2020-04-11 02:18:37 +00:00
18e8af4bb8
Fix password reset saying Admin changed my password when reset from
...
login page
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-10 18:05:43 +02:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
e24818f6bb
Bump core-js from 1.4.1 to 1.5.0
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-10 12:37:20 +00:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
75836f004d
Show setup check for recommended php modules
...
Fixes #20393
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-10 13:25:12 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag
...
Do not use closing tags
2020-04-10 08:34:18 +02:00
078b12a9b0
[tx-robot] updated from transifex
2020-04-10 02:18:23 +00:00
Christoph Wurst
Robin Appelman
Daniel Calviño Sánchez
Roeland Jago Douma
Arthur Schiwon
Morris Jobke
Julius Härtl
Roeland Jago Douma
Jonas Meurer
John Molakvoæ
Georg Ehrke
GretaD
John Molakvoæ (skjnldsv)
Nextcloud bot
Gary Kim
Jan-Christoph Borchardt
Joas Schilling
Joas Schilling
Christoph Wurst
dependabot-preview[bot]
Clement Wong
Daniel Kesselberg
Thomas Citharel
Mikael Hammarin
Christoph Seitz
Julien Lutran
Liam JACK
Valdnet