Commit Graph

56223 Commits

Author SHA1 Message Date
dependabot-preview[bot] c27223f747
Merge pull request #23919 from nextcloud/dependabot/npm_and_yarn/css-loader-5.0.1 2020-11-06 20:55:42 +00:00
Morris Jobke 3f88ab8252
Merge pull request #23929 from nextcloud/techdebt/noid/deprecate-prepare-and-execute-audited-as-they-leak-cursors
Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors
2020-11-06 16:24:29 +01:00
Joas Schilling cb8bef1f37
Fix iLike() falsely turning escaped % and _ into wildcards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 16:22:13 +01:00
Morris Jobke 9e2ced609e
Merge pull request #23932 from nextcloud/enh/s3/do_not_check_bucket_exists_on_every_request
Allow config to specify the bucket exists
2020-11-06 16:13:20 +01:00
Christoph Wurst 7e2c3a820e
Remove the cookie paths for php<7.3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-06 15:57:17 +01:00
Roeland Jago Douma 0dece78617
Skip already loaded apps in loadApps
Otherwise you might end up calling a lot of functions unneeded.
And while the individual calls are cheap if you multiply them by 20k
they still get somewhat expensive.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 14:56:06 +01:00
Arthur Schiwon c96a9a9001
fix insert values
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:30:19 +01:00
Joas Schilling ad8b848444
Replace some usages of OC_DB in OC\Share\* with query builder
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 13:02:14 +01:00
Arthur Schiwon 4104416e81
only delete specified config
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-06 13:01:37 +01:00
Joas Schilling 3aaf2fabb1
Make sure Oracle always casts everything in the best way
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 12:13:22 +01:00
Joas Schilling 4b125d4402
Use Query builder function
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 12:13:22 +01:00
Joas Schilling 3c027bd0cf
Fix order of GREATEST for Oracle
As per https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions060.htm
Oracle uses the first value to cast the rest or the values.
So when the first value is a plain int, instead of doing the math,
it will cast the expression to int and continue with a potential 0.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 12:13:22 +01:00
Joas Schilling 8547934e20
Correctly place the array type 2020-11-06 12:09:58 +01:00
Julius Härtl 3f4fb9dc89
Merge pull request #23921 from nextcloud/techdebt/oci/fix-casting-to-integer
Fix casting to integer on Oracle
2020-11-06 11:39:48 +01:00
Roeland Jago Douma cd849db8be
Avoid SCSS compilation if not needed
Now we do on each template load a compile with the SCSS variables to see
if they changed or not. However there is no real reason for this if the
variables didn't change.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 11:31:36 +01:00
Joas Schilling c5b6e4bc09
Use query builder to interact with member management
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:28:53 +01:00
Joas Schilling 5fba0e562f
Use query builder instead of OC_DB in user_ldap
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 11:25:28 +01:00
Roeland Jago Douma 65141d4864
Allow config to specify the bucket exists
In the 99% case the bucket is just always there. And if it is not the
read/write will fail hard anyways. Esp on big instances the Objectstore
is not always fast and this can save a few hundered ms of each request
that acess the objectstore.

In short it is adding

'verify_bucket_exists' => false

To the S3 config part

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 11:08:38 +01:00
Joas Schilling a847aea19c
Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 10:37:37 +01:00
Joas Schilling da1c2bdfe6
Fix repair mimetype step to not leave stray cursors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 10:33:59 +01:00
Roeland Jago Douma f7a2b71627
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:37:45 +01:00
Morris Jobke 2c6bbe783a
Merge pull request #23920 from nextcloud/fix/match_bearer_front
Bearer must be in the start of the auth header
2020-11-06 09:19:05 +01:00
Morris Jobke 9feaceebcf
Merge pull request #23918 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2020-11-06 09:11:33 +01:00
Roeland Jago Douma 448044d831
Fix getstorage call
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:03:32 +01:00
Roeland Jago Douma 48d843858d
Do not setup the default FS on normal routes
This should help with load times hopefully. Only initialize the FS if we
actually ned it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 09:03:32 +01:00
dependabot-preview[bot] bc5b58cb29
Bump css-loader from 3.6.0 to 5.0.1
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.0.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.6.0...v5.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-06 09:00:20 +01:00
Joas Schilling 3d2f71cfa9
Improve query type detection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 08:38:56 +01:00
Joas Schilling cfc35fa49a
Fix casting to integer on Oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 08:38:08 +01:00
Roeland Jago Douma e93823cba0
Bearer must be in the start of the auth header
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 08:32:50 +01:00
John Molakvoæ 404785dd2b
Merge pull request #23347 from st3iny/enhancement/19526/new-share-pending-confirm-button 2020-11-06 08:04:07 +01:00
dependabot-preview[bot] 08c9b0e58a
Merge pull request #23916 from nextcloud/dependabot/npm_and_yarn/mocha-8.2.1 2020-11-06 06:54:29 +00:00
Nextcloud-PR-Bot 4c61d52879 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-11-06 04:25:56 +00:00
Nextcloud bot c8d3f03bde
[tx-robot] updated from transifex 2020-11-06 02:19:11 +00:00
Morris Jobke bbc4f7bf3b
Merge pull request #23857 from nextcloud/dependabot/composer/vimeo/psalm-4.1.1
Bump vimeo/psalm from 4.0.1 to 4.1.1
2020-11-05 23:56:56 +01:00
dependabot-preview[bot] 8751aad023
Bump vimeo/psalm from 4.0.1 to 4.1.1
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.0.1 to 4.1.1.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/4.0.1...4.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-11-05 22:41:22 +00:00
Morris Jobke f657f0c455
Merge pull request #23906 from nextcloud/techdebt/noid/simplify-can-change-user-pasword
Simplify the check if admin can change password based on encryption status
2020-11-05 23:39:13 +01:00
Morris Jobke 0247f22c83
Merge pull request #23887 from ecsecta/fix_23797
Do not emit UserCreatedEvent twice
2020-11-05 22:58:30 +01:00
Morris Jobke a223f603f9
Simplify the check if admin can change password based on encryption status
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 22:20:34 +01:00
Julius Härtl 88eebf9ed6
Merge pull request #23004 from nextcloud/files-scan-background
only run the background scanner for users that have unscanned files
2020-11-05 22:15:01 +01:00
dependabot-preview[bot] 90f883b78f
Bump mocha from 7.2.0 to 8.2.1
Bumps [mocha](https://github.com/mochajs/mocha) from 7.2.0 to 8.2.1.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mochajs/mocha/compare/v7.2.0...v8.2.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-11-05 21:06:45 +00:00
Julius Härtl 2702876b81
Merge pull request #23910 from nextcloud/bugfix/23908/fix-share-link-avatar
Fix link share avatar icon
2020-11-05 22:00:11 +01:00
Vincent Petry 5474c299d9
Make link share avatar icon blue again
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-05 17:14:29 +01:00
Vincent Petry 88d019e696
Fix link share avatar icon
Use "icon-class" instead of "class" as this is how to tell the component
that we don't want initials displayed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-05 16:43:48 +01:00
kesselb a7c6869ad5
Merge pull request #23907 from nextcloud/fix/noid/update-baseline-due-to-phpdoc
Check in InvalidArgument psalm error into baseline
2020-11-05 16:34:01 +01:00
Richard Steinmetz a46c329734
Add confirm button in new link share pending expire/password menu
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-05 15:55:39 +01:00
Morris Jobke 0a1f4549e7
Check InvalidArgument psalm error into baseline - PHPDoc needs to be improved
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 13:49:25 +01:00
John Molakvoæ ecbe8cb4c9
Merge pull request #23904 from nextcloud/fix/php-lint
Fix php lint action
2020-11-05 10:51:13 +01:00
John Molakvoæ 188051b6c6
Merge pull request #23868 from nextcloud/techdebt/webpack-hide-modules
Remove old hide modules option for webpack
2020-11-05 10:20:16 +01:00
Christoph Wurst d31ff68f17
Remove old hide modules option for webpack
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-11-05 09:58:37 +01:00
Roeland Jago Douma 12e2b74872
Merge pull request #23901 from nextcloud/techdebt/noid/deprecate-old-usermanager-events
Deprecate old user manager events for user creation
2020-11-05 09:37:07 +01:00