Commit Graph

22993 Commits

Author SHA1 Message Date
Roeland Jago Douma 9b23da22c0
Merge pull request #26216 from nextcloud/backport/26145/stable19
[stable19] add (hidden) option to always show smb root as writable
2021-03-20 10:53:45 +01:00
Nextcloud bot a4d6201d7e
[tx-robot] updated from transifex 2021-03-20 02:24:08 +00:00
Robin Appelman ec0ca19deb add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.

This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.

This can be enabled using

```bash
occ files_external:config <mount id> root_force_writable true
```

where you can find your mount id using

```bash
occ files_external:list
```

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:09 +00:00
Nextcloud bot 8670ef707f
[tx-robot] updated from transifex 2021-03-19 02:25:21 +00:00
Daniel Calviño Sánchez 05cbdddb0d Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:28 +00:00
Nextcloud bot 0e30c82f30
[tx-robot] updated from transifex 2021-03-18 02:25:29 +00:00
Morris Jobke 10b024642f Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:49:42 +00:00
Nextcloud bot 709788e08f
[tx-robot] updated from transifex 2021-03-17 02:24:47 +00:00
Robin Appelman b9b2c6d2fa
fix search in nested jails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
Christoph Wurst f9c9e27e46
Merge pull request #26129 from nextcloud/backport/26115/stable19
[stable19] Log exceptions when creating share
2021-03-16 11:09:15 +01:00
Nextcloud bot 95b55423e8
[tx-robot] updated from transifex 2021-03-16 02:25:09 +00:00
Vincent Petry e43c93881e Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:34 +00:00
Christoph Wurst 3ac0601e26
Merge pull request #26060 from nextcloud/backport/25911/stable19
[stable19] Only clear share password model when actually saved
2021-03-15 09:48:23 +01:00
Nextcloud bot 901472a899
[tx-robot] updated from transifex 2021-03-15 02:24:26 +00:00
Nextcloud bot bbb616a604
[tx-robot] updated from transifex 2021-03-14 02:24:05 +00:00
Nextcloud bot 2a955bf864
[tx-robot] updated from transifex 2021-03-13 02:23:21 +00:00
Vincent Petry 20c16e21c2
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-12 12:23:36 +01:00
Nextcloud bot 54affce466
[tx-robot] updated from transifex 2021-03-12 02:23:09 +00:00
Roeland Jago Douma 586cbde4ba
Merge pull request #26041 from nextcloud/backport/25916/stable19
[stable19] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:44 +01:00
Nextcloud bot c750417f19
[tx-robot] updated from transifex 2021-03-11 02:23:35 +00:00
Roeland Jago Douma 0a7a401f95
Merge pull request #26028 from nextcloud/backport/25933/stable19
[stable19] Hide expiration date field for remote shares
2021-03-10 15:46:47 +01:00
Vincent Petry 6e394ac9d6 Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 08:45:54 +00:00
Julius Härtl 37b161b526 Remove trash items from other trash backends when deleting all
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:05:03 +00:00
Nextcloud bot efcc3dd99f
[tx-robot] updated from transifex 2021-03-10 02:23:25 +00:00
Nextcloud bot 6db532444f
[tx-robot] updated from transifex 2021-03-09 02:24:20 +00:00
Nextcloud bot ad8a1bcc12
[tx-robot] updated from transifex 2021-03-08 02:23:37 +00:00
Nextcloud bot 82244f1466
[tx-robot] updated from transifex 2021-03-07 02:22:31 +00:00
Roeland Jago Douma e73ea889ab
Merge pull request #25957 from nextcloud/backport/25932/stable19
[stable19] Skip empty obsolete owner when adding to own NC
2021-03-06 10:54:10 +01:00
Nextcloud bot 3bf923ec55
[tx-robot] updated from transifex 2021-03-06 02:22:48 +00:00
Vincent Petry f21e25182b Skip empty obsolete owner when adding to own NC
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.

Fixes an issue where "Add to your Nextcloud" doesn't add anything.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:40:41 +00:00
Roeland Jago Douma bcb840ce04
Merge pull request #25845 from nextcloud/backport/25757/stable19
[stable19] fix detecting cyclic group memberships
2021-03-05 08:43:35 +01:00
Nextcloud bot 8d9d540257
[tx-robot] updated from transifex 2021-03-05 02:22:23 +00:00
Nextcloud bot 18ba1854db
[tx-robot] updated from transifex 2021-03-04 02:22:39 +00:00
Arthur Schiwon 7afb588059
fix detecting cyclic group memberships
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-03 10:53:24 +01:00
Roeland Jago Douma 4a111afc8d
Merge pull request #25901 from nextcloud/backport/25860/stable19
[stable19] do not die after LDAP auth failed with expired acc
2021-03-03 08:35:21 +01:00
Nextcloud bot 7d5f7cef93
[tx-robot] updated from transifex 2021-03-03 02:21:51 +00:00
Arthur Schiwon 4b3961c412 do not die after LDAP auth failed with expired acc
- some servers return error code 53

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:11 +00:00
kesselb 3177ab8ba9
Merge pull request #25859 from nextcloud/backport/25856/stable19
[stable19] Card::getOwner should return the actual value
2021-03-02 09:20:34 +01:00
Nextcloud bot 47bb51cfeb
[tx-robot] updated from transifex 2021-03-02 02:22:49 +00:00
Roeland Jago Douma 6baad31815 Card::getOwner should return the actual value
I guess we never call this at runtime or it would already ahve done boom
very loudly.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 17:33:17 +00:00
Roeland Jago Douma a00eff8372
Merge pull request #25741 from nextcloud/backport/25602/stable19
[stable19] Avoid creating two share links when password is enforced
2021-03-01 12:49:12 +01:00
Julius Härtl 832374d4fe
Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 10:00:57 +01:00
Nextcloud bot b9d417f812
[tx-robot] updated from transifex 2021-03-01 02:20:45 +00:00
Nextcloud bot be671e390e
[tx-robot] updated from transifex 2021-02-28 02:20:20 +00:00
Nextcloud bot bd3c0eb0d2
[tx-robot] updated from transifex 2021-02-27 02:22:47 +00:00
Nextcloud bot ae438cd079
[tx-robot] updated from transifex 2021-02-26 02:22:14 +00:00
Nextcloud bot 495cc2aa2c
[tx-robot] updated from transifex 2021-02-25 02:21:48 +00:00
Nextcloud bot f505f01b99
[tx-robot] updated from transifex 2021-02-24 02:22:31 +00:00
Nextcloud bot 33cebe106a
[tx-robot] updated from transifex 2021-02-23 02:39:52 +00:00
Nextcloud bot 044c535a7a
[tx-robot] updated from transifex 2021-02-21 02:40:24 +00:00
Nextcloud bot 6df72b6c53
[tx-robot] updated from transifex 2021-02-20 02:37:48 +00:00
Nextcloud bot d6fd0d2286
[tx-robot] updated from transifex 2021-02-18 02:22:21 +00:00
Roeland Jago Douma 23e3730a10
Merge pull request #25449 from nextcloud/backport/25393/stable19
[stable19] add repair job for unencoded group share uris
2021-02-17 21:05:16 +01:00
blizzz d9a67236c0
Merge pull request #25380 from nextcloud/backport/25101/stable19
[stable19] LDAP: make actually use of batch read known groups
2021-02-17 15:15:15 +01:00
Arthur Schiwon 654a41e313
really use known groups
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 14:05:13 +01:00
Roeland Jago Douma 733311d76e
Merge pull request #25652 from nextcloud/backport/25594/stable19
[stable19] Use ownerDisplayName for SharingEntry Tooltip
2021-02-17 10:38:33 +01:00
Roeland Jago Douma 8be6692521
Merge pull request #25593 from nextcloud/backport/25582/stable19
[stable19] Do not send imip email to invalid recipients
2021-02-17 10:38:13 +01:00
Christoph Wurst 59805dbe2c
Do not send imip email to invalid recipients
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-17 09:29:36 +01:00
Dan VerWeire 371353bc61 Use ownerDisplayName for SharingEntry Tooltip
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-17 07:51:26 +00:00
Roeland Jago Douma fb2b19221f
Merge pull request #25385 from nextcloud/backport/25218/stable19
[stable19] do not remove valid group shares
2021-02-17 08:48:25 +01:00
Nextcloud bot fab7d9ca5f
[tx-robot] updated from transifex 2021-02-17 02:21:34 +00:00
Nextcloud bot f5a5afc592
[tx-robot] updated from transifex 2021-02-16 02:22:00 +00:00
Nextcloud bot b7acd16fd0
[tx-robot] updated from transifex 2021-02-15 02:20:33 +00:00
Nextcloud bot a916b4a091
[tx-robot] updated from transifex 2021-02-14 02:20:26 +00:00
Nextcloud bot 1d64813825
[tx-robot] updated from transifex 2021-02-13 02:20:54 +00:00
Nextcloud bot 5807a0ff40
[tx-robot] updated from transifex 2021-02-12 02:20:44 +00:00
Nextcloud bot 3c8bea717e
[tx-robot] updated from transifex 2021-02-11 02:21:03 +00:00
Nextcloud bot 2018bcba9b
[tx-robot] updated from transifex 2021-02-10 02:21:25 +00:00
Nextcloud bot 02e2cde84d
[tx-robot] updated from transifex 2021-02-09 02:21:10 +00:00
Nextcloud bot aacc60472f
[tx-robot] updated from transifex 2021-02-08 02:20:30 +00:00
Nextcloud bot afe109ae21
[tx-robot] updated from transifex 2021-02-07 02:21:16 +00:00
Nextcloud bot 5c3c78b58d
[tx-robot] updated from transifex 2021-02-06 02:21:16 +00:00
Nextcloud bot 43601086dd
[tx-robot] updated from transifex 2021-02-05 02:21:58 +00:00
Nextcloud bot f23fc11b5a
[tx-robot] updated from transifex 2021-02-04 02:20:29 +00:00
Nextcloud bot 6db77c1c22
[tx-robot] updated from transifex 2021-02-03 02:20:09 +00:00
Arthur Schiwon b570b22601 take into account that UNIQUE index might not work as expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:41 +00:00
Julius Härtl 5b898fa60e
Merge pull request #25422 from nextcloud/backport/25383/stable19
[stable19] Properly handle SMB ACL blocking scanning a directory
2021-02-02 11:58:43 +01:00
Nextcloud bot 5c8be9ac66
[tx-robot] updated from transifex 2021-02-02 02:20:16 +00:00
Julius Härtl 6f6f45b77b Properly handle SMB ACL blocking scanning a directory
This makes sure that a possible ForbiddenException is properly passed
through the storage as a ForbiddenException and can be catched when
trying to fetch the quota info of a parent folder

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-01 11:13:52 +00:00
Nextcloud bot 59b43e0699
[tx-robot] updated from transifex 2021-02-01 02:19:56 +00:00
Nextcloud bot 0cc117e3ce
[tx-robot] updated from transifex 2021-01-31 02:19:22 +00:00
Nextcloud bot 8bd5641fc3
[tx-robot] updated from transifex 2021-01-30 02:20:53 +00:00
Arthur Schiwon ae8903e946 do not remove valid group shares
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 10:44:35 +00:00
Roeland Jago Douma aff475b51d
Merge pull request #25367 from nextcloud/backport/25361/stable19
[stable19] fix parameter provided as string not array
2021-01-29 08:33:15 +01:00
Nextcloud bot af54ab7af6
[tx-robot] updated from transifex 2021-01-29 02:21:35 +00:00
Arthur Schiwon 9fc88bd217 fix parameter provided as string not array
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-28 19:42:41 +00:00
blizzz a4c7a62394
Merge pull request #25121 from nextcloud/backport/25036/stable19
[stable19] respect DB restrictions on number of arguments in statements and queries
2021-01-28 12:27:52 +01:00
Nextcloud bot 947ba76d00
[tx-robot] updated from transifex 2021-01-28 02:24:30 +00:00
Roeland Jago Douma 0fe59bc25a
Merge pull request #25323 from nextcloud/backport/25310/stable19
[stable19] [CalDAV] Validate notified emails
2021-01-27 14:49:10 +01:00
Nextcloud bot 370e4c05dd
[tx-robot] updated from transifex 2021-01-27 02:21:06 +00:00
Thomas Citharel a720bdb83d
[CalDAV] Validate notified emails
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-01-26 11:09:43 +01:00
Nextcloud bot 2fe66cb2e3
[tx-robot] updated from transifex 2021-01-26 02:21:51 +00:00
Nextcloud bot ef771f54f3
[tx-robot] updated from transifex 2021-01-25 02:20:51 +00:00
Nextcloud bot c90882c958
[tx-robot] updated from transifex 2021-01-24 02:20:04 +00:00
Nextcloud bot 1eea17d2f3
[tx-robot] updated from transifex 2021-01-23 02:20:24 +00:00
Morris Jobke e95f6a85b2
Merge pull request #25277 from nextcloud/backport/25274/stable19
[stable19] Do not obtain userFolder of a federated user
2021-01-22 16:16:35 +01:00
Roeland Jago Douma 2f0948ed15 Do not obtain userFolder of a federated user
Federated shares are somewhat special. So we can't move the files from
the main user and we should try to get it from the intialized root
already.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-22 13:40:10 +00:00
Roeland Jago Douma 7f3faa7165
Merge pull request #25262 from nextcloud/backport/25255/stable19
[stable19] also use storage copy when dav copying directories
2021-01-22 14:37:04 +01:00
Morris Jobke 7365caae24
Merge pull request #25264 from nextcloud/backport/25253/stable19
[stable19] silence log message
2021-01-22 10:25:19 +01:00
Nextcloud bot 3d794c39b9
[tx-robot] updated from transifex 2021-01-22 02:20:15 +00:00