Commit Graph

19186 Commits

Author SHA1 Message Date
Roeland Jago Douma 41fbda00ed
Merge pull request #11928 from stweil/fix
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
Roeland Jago Douma 530e39b061
Merge pull request #11778 from nextcloud/versions-webui-dav
move versions webui over to the dav api
2018-10-23 20:21:05 +02:00
John Molakvoæ (skjnldsv) ede6472e52
Fix FF performance and recals issues
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
Morris Jobke 4ad27260a9
Merge pull request #11439 from nextcloud/trash-modular-api
Modular trashbin api
2018-10-23 17:11:16 +02:00
John Molakvoæ (skjnldsv) 8013dab044
Allow focus on input with keyboard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
Nextcloud bot a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv) cf57df6e73
Restore table head
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
John Molakvoæ (skjnldsv) b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
Morris Jobke ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00
Morris Jobke 869df2ee7a
Merge pull request #11980 from nextcloud/assemblly-stream-lazy
lazy open first source stream in assemblystream
2018-10-23 16:17:49 +02:00
Morris Jobke 9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app
Fix opening a section again in the Files app
2018-10-23 15:29:55 +02:00
Jan-Christoph Borchardt b04ebd8553
Round off buttons 'pill style' like on the website
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 15:18:37 +02:00
Morris Jobke 171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
Roeland Jago Douma d11609a152
Merge pull request #11974 from nextcloud/bugfix/noid/lax-csp-on-talk-shares
Use lax CSP when the share is a talk share
2018-10-23 14:29:52 +02:00
Jan-Christoph Borchardt ade50d3b71
Remove font-specifics from high contrast theme because we are now on regular+bold anyway
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:13:07 +02:00
Jan-Christoph Borchardt 0158703590
Fix font-face in dyslexia-friendly theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:32 +02:00
Jan-Christoph Borchardt d9aa484641
Fix font-face on LDAP tooltip
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
John Molakvoæ (skjnldsv) 26ca7a0e2f
Add filepicker toggle
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
Roeland Jago Douma 31d1179c41
Merge pull request #11973 from nextcloud/bug/accessibility/get_js_without_uid
If there is no UID do not explode accessibility javascript
2018-10-23 10:18:45 +02:00
John Molakvoæ (skjnldsv) bf6a1650ce
Use preview-x & preview-y on public pages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:59:34 +02:00
John Molakvoæ (skjnldsv) ec05e5d048
Fix public background override
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:54:09 +02:00
John Molakvoæ (skjnldsv) e0dde083d0
Public fixes, request & default to grid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:43:02 +02:00
John Molakvoæ (skjnldsv) 8652ada561
Tooltip on hover only
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:27:27 +02:00
John Molakvoæ (skjnldsv) efdb535a5d
Fix grey background over thumbnail
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:23:22 +02:00
John Molakvoæ (skjnldsv) b662977862
Fix table hidden on empty folder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:18:14 +02:00
dependabot[bot] 0ee610f012
Bump webpack from 4.20.2 to 4.22.0 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-22 20:43:17 +00:00
Stefan Weil a887c6e77b Fix use of undeclared variable
This fixes a warning from LGTM:

    Variable 'data' is used before its declaration.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-22 21:07:52 +02:00
Robin Appelman 2f518b6ac8
lazy open first source stream in assemblystream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-22 16:11:13 +02:00
Georg Ehrke 5cfb5ec176
allow group principal search for dav displayname property
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 218253db76
allow user principal search for dav displayname property
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 10f0296ad6
overwrite Sabre/DAV's handler for calendar-user-type to report correct user type
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:18 +02:00
Georg Ehrke 325e366b58
add correct calendar-user-type to resource and room backend
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-22 15:48:13 +02:00
Roeland Jago Douma f737ae719d
Merge pull request #11960 from nextcloud/dependabot/npm_and_yarn/apps/oauth2/webpack-4.22.0
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
2018-10-22 15:31:09 +02:00
Roeland Jago Douma 3ac15a45ea
If there is no UID do not explode accessibility javascript
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-22 11:26:21 +02:00
Joas Schilling 3febeb6ca7
Use lax CSP when the share is a talk share
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-22 10:57:55 +02:00
Daniel Calviño Sánchez 0426ba6de5 Remove event handler no longer needed
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.

The file list for tags uses the handler for a different purpose, though,
so that one was kept.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:59 +02:00
Daniel Calviño Sánchez 449349e901 Fix opening a section again in the Files app
When a section is open in the Files app a "show" event is triggered.
File list objects handle that event by reloading themselves, but only
if the file list was shown at least once. However, the file list objects
of plugins are created when the "show" event is triggered for the first
time for their section; as the file list objects register their handler
for the "show" event when they are created they never handle the first
triggered "show" event, as the handler is set while that event is being
already handled. Therefore, from the point of view of the handler, the
second time that a "show" event was triggered it was seen as if the file
list was shown for the first time, and thus it was not reloaded. Now the
"shown" property is explicitly set for those file lists that are created
while handling a "show" event, which causes them to be reloaded as
expected when opening their section again.

Note that it is not possible to just reload the file list whenever it is
shown; the file list is reloaded also when the directory changes, and
this can happen when the web page is initially loaded and the URL is
parsed. In that case, if file lists were reloaded when shown for the
first time then it could be reloaded twice, one with the default
parameters due to the "show" event and another one with the proper
parameters once the URL was parsed, and the files that appeard in the
list would depend on which response from the server was received the
last.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:19 +02:00
dependabot[bot] f4353a9acd
Bump webpack from 4.20.2 to 4.22.0 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:36:20 +00:00
dependabot[bot] 3ea326f811
Bump webpack from 4.20.2 to 4.22.0 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.20.2 to 4.22.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.20.2...v4.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-21 11:35:11 +00:00
Roeland Jago Douma f544c9fec9
Merge pull request #11927 from stweil/clean
Remove duplicate condition
2018-10-19 21:15:04 +02:00
Stefan Weil 81c0f2a9a7
Remove duplicate condition
This fixes a warning from LGTM:

    Operands additionnalShares and additionnalShares are identical.

Fix also the typo in the parameter name.
2018-10-19 20:19:08 +02:00
Stefan Weil c5d3febf37
Add missing variable declarations
This fixes errors from LGTM like the following one:

    Variable i is used like a local variable,
    but is missing a declaration.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 20:17:55 +02:00
Roeland Jago Douma 543c863434
Merge pull request #11931 from nextcloud/bug/do_not_emit_pre_hooks_twice_objectstore
Do not emit preHooks twice on non-part-storage
2018-10-19 19:56:42 +02:00
Roeland Jago Douma 97717ae3a7
Merge pull request #11905 from nextcloud/design/noid/tab-icons
Add icon to file sidebar tabs
2018-10-19 16:53:56 +02:00
Morris Jobke 851f525889
Merge pull request #11668 from nextcloud/bugfix/7726/convert_caldav_subscription_source_to_long_text
convert source column in calendarsubscription table to (long) text
2018-10-19 15:49:17 +02:00
Morris Jobke 6a979a0ba0
Merge pull request #11823 from lex111/fix-illegible-text-color-in-size-and-modified-columns
Fix illegible text color in columns Size and Modified on dark theme
2018-10-19 15:31:51 +02:00
Roeland Jago Douma b51e503aea
Do not emit preHooks twice on non-part-storage
The old code would emit the hooks twice. Thus having the version written
twice. Which is not very performant as it is first read twice as well.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 12:19:53 +02:00
Morris Jobke d35b6513cd
Merge pull request #11922 from stweil/semicolons
Add missing semicolons
2018-10-19 12:07:59 +02:00
Morris Jobke 08476297c3
Merge pull request #11917 from nextcloud/csp/files_external
Move files_external to compiled handlebars
2018-10-19 12:06:42 +02:00
Stefan Weil 2ad38200fb Add missing semicolons
This fixes some recommendations from LGTM:

    Avoid automated semicolon insertion (90% of all statements
    in the enclosing function have an explicit semicolon).

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
Morris Jobke 1226c13201
Add .l10nignore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:41:37 +02:00
Morris Jobke 1b44bdfb58
Add .l10nignore files for compiled assets
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:29:36 +02:00
Roeland Jago Douma c43e0d6e28
Move files_external to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-19 08:41:01 +02:00
Alexey Pyltsyn 30cbd137e8 Fix illegible text color in columns Size and Modified on dark theme: rework after review
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-18 20:49:46 +03:00
blizzz 5daa4f27e1
Merge pull request #11882 from nextcloud/feature/noid/consider-net-connection
Do not try to contact lookup server without internet connection or URL
2018-10-18 18:24:41 +02:00
Arthur Schiwon 8e4ae23c48
Do not try to contact lookup server without internet connection or URL
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-18 17:49:28 +02:00
Julius Härtl 45804b5bef
Add icon to file sidebar tabs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-18 15:54:17 +02:00
Jan-Christoph Borchardt 0f299d1077
Revert "Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show"
This reverts commit fb7fb1cebae5af129c4474a380e0f5e55f79569f.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:11 +02:00
Jan-Christoph Borchardt 8614693e9a
Reduce bottom whitespace on share link page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt 25ae3ea296
More space for filename on public share page since there is no share icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt d979da3755
In "Deleted files", do not show "Restore" text next to icon as there is no space
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
Jan-Christoph Borchardt bdfece12b2
Fix tabbability to view-toggle, action on Enter to be fixed
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 35ef2b2737
Adjustments for public share page, actions menu, view toggle
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt c0648efe3a
Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 1d486673f6
If there is a comment, show it instead of the share icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
Jan-Christoph Borchardt 64607f5491
If an avatar is present, show that instead of the icon
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) b532c95162
Border radius
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 1f1dddcc5e
Fix spacing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 184c1b03e3
Default to grid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) 07224da3d4
Fix focus background
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
John Molakvoæ (skjnldsv) cd1cfe002d
Improve default visual and selection + default to file link
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) 872b866a69
Tooltip
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) c4cce14134
Remember toggle and events handler
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:07 +02:00
John Molakvoæ (skjnldsv) 49fda8ba56
Hidden footer
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) 4911f06c3e
Loading hidden fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) bb56d75f2b
Set grid variable and overall size adjustement
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:06 +02:00
John Molakvoæ (skjnldsv) 5b8dd4d4d6
Fixed multiselect and header
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 39ff82f707
Use grid view in other file views too
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt e704899e22
Show view toggle in controls bar
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 2a42a8da3e
Center align the footer file number & size summary
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:05 +02:00
Jan-Christoph Borchardt 32d6090c8b
Fetch high resolution thumbnails for grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 5b293a96f2
Also add border-radius to thumbnail
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 1983f91e29
Fix grey background behind selection checkbox
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 34038136b0
Fix popovermenu position
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:04 +02:00
Jan-Christoph Borchardt 10c96656a2
Adjust design of grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:03 +02:00
John Molakvoæ (skjnldsv) f717bed085
Grid init
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:03 +02:00
Morris Jobke 729b853a30
Merge pull request #11853 from nextcloud/csp/comments
Move more comments to compiled handlebars
2018-10-18 11:40:00 +02:00
Morris Jobke 4e53ea6dbd
Merge pull request #11822 from nextcloud/bugfix/noid/forbid_freebusy_but_allow_local_delivery
allow local delivery of schedule message while prohibiting FreeBusy requests
2018-10-18 11:35:51 +02:00
blizzz 0c05ed1d3d
Merge pull request #11878 from nextcloud/no-require-same-site-cookie-on-assets
Don't require Same Site Cookies on assets
2018-10-18 10:24:56 +02:00
Robin Appelman 9e0ebf1830
store user for trashitem in the trashitem
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 15:21:09 +02:00
Robin Appelman 136113a22b
remove user parameter from `ITrashItem::getOriginalLocation`
since the target user is known at the time of creating the trashitem
the original location can already be adjusted on a per user level

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:58:02 +02:00
Robin Appelman a369adb4cd
fix trash storage wrapper tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:43 +02:00
Robin Appelman b94fbcebeb
fix preview controller tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:40 +02:00
Robin Appelman f5a41e2e15
fix error message for folder preview request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:57:37 +02:00
Robin Appelman d38163e895
fix trashbin previews for modular api
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:56:48 +02:00
Robin Appelman 4adac445dc
fix select statement
fix select statement
Make trashbin api modules

Apps can register trashbin backends for specific storages,
allowing them to modify trashbin behavior for storages

The old trashbin implementation has been wrapped in a "legacy" backend,
for future work this can be replaced with a new backend that better handles
shares while still keeping the legacy backend around to keep existing trash
from being accessible

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-17 14:56:45 +02:00
blizzz 2634ceb35b
Merge pull request #11862 from nextcloud/bugfix/ensure_cache_it_init
Double check for failed cache with a shared storage
2018-10-17 13:12:57 +02:00
Thomas Citharel d63de5471b Don't require Same Site Cookies on assets
Which can be used for public iframe embeeding

See https://github.com/nextcloud/calendar/issues/169

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2018-10-17 09:24:21 +02:00
Georg Ehrke f5dc7b7f07
move disableFreeBusy check from User principal backend to Scheduling Outbox collection. This allows to keep local delivery of scheduling messages while prohibiting FreeBusy requests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-16 20:27:33 +02:00
Alexey Pyltsyn 5911367a18 Fix illegible text color in columns Size and Modified on dark theme
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-16 21:06:01 +03:00
Morris Jobke b88ab75c3a
Merge pull request #11870 from nextcloud/fix/noid/proper-column-name-escaping
Properly quote column name in "createFunction" call
2018-10-16 17:02:26 +02:00
Morris Jobke b458ed9c82
Properly escape column name in "createFunction" call
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-16 15:24:02 +02:00
Roeland Jago Douma 2849f24154
Merge pull request #11839 from nextcloud/csp/files_drop
Move files_drop to compiled handlebars
2018-10-16 12:16:31 +02:00
Roeland Jago Douma 1bc388e507
Double check for failed cache with a shared storage
When obtaining the SourceRootInfo we can call init. If this fails the
cache is set to a failed cache and the storage to a failed storage.
However we did not check for this. Which means that if the storage was
invalid it would fail later on.

Now we will properly error out.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 10:57:37 +02:00
Morris Jobke afaee648dd
Merge pull request #11358 from Zulan/fix-welcome-l10n
Fix welcome l10n
2018-10-16 09:01:59 +02:00
Roeland Jago Douma bee5bbbf0e
Move files_drop to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-16 08:27:06 +02:00
Roeland Jago Douma 353fddfbb9
Merge pull request #11849 from nextcloud/csp/fileactionsmenu
Move fileactionsmenu to compiled handlebars
2018-10-15 21:22:07 +02:00
Roeland Jago Douma e7443ee892
Move more comments to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 19:52:22 +02:00
Julius Härtl c316eb6b97
Tests: Properly compare the file action label
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-15 19:18:20 +02:00
zulan cf266ee004 Get l10n within NewUserMailHelper to ensure it always uses the new user's language.
Some related tests had to be changed because they relied on internals, see also from the PHPUnit documentation:
"Exercise caution when using [the at] matcher as it can lead to brittle tests which are too closely tied to specific implementation details."

Signed-off-by: Zulan <git@zulan.net>
2018-10-15 19:01:46 +02:00
Roeland Jago Douma a1b7449202
Move fileactionsmenu to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 15:51:40 +02:00
Roeland Jago Douma 8c4c4b700f
Move workflowengine to compiled handlebars
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-15 14:55:25 +02:00
Georg Ehrke b83918ed6d
convert source column in calendarsubscription table to (long) text
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-15 13:16:31 +02:00
Morris Jobke 24a2107e03
Fix a case where "password_by_talk" was not a boolean (e.g. null or "0") and actively cast it to a boolean
This was the error message that we have seen:

```
Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-12 17:01:54 +02:00
Joas Schilling 16817f3743
Make activity events strict
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-12 12:12:12 +02:00
Morris Jobke b5753d0efa
Merge pull request #11759 from nextcloud/feature/11504/sharing-favicon
Use default favicon on sharing pages
2018-10-12 10:30:21 +02:00
Robin Appelman ee84d83519
move versions webui over to the dav api
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-11 20:42:41 +02:00
Roeland Jago Douma dd8350b3b3
Merge pull request #10778 from suntorytimed/patch-1
check for empty string
2018-10-11 19:05:38 +02:00
Julius Härtl 2538079876
Use default favicon on sharing pages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-11 16:29:24 +02:00
Morris Jobke 0acae1d4aa
Merge pull request #11719 from nextcloud/techdebt/noid/allow-to-mock-new-datetime
Allow to inject/mock `new \DateTime()` similar to time()
2018-10-10 14:54:15 +02:00
Felix Nüsse 8dc449990d fix for favorites-quickaccess: newly added folders dont show up when added to favorites
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2018-10-10 13:33:44 +02:00
Joas Schilling 78cc4171ee
Fix mock of ITimeFactory
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-10 12:42:20 +02:00
Nextcloud bot 7c26bbbd82
[tx-robot] updated from transifex 2018-10-10 00:13:11 +00:00
Morris Jobke ab3599155f
Merge pull request #11716 from nextcloud/bugfix/noid/use-numeric-placeholders-for-rtl-translations
Use numeric placeholders if there are multiple, so that RTL languages…
2018-10-09 16:31:52 +02:00
Morris Jobke ddfc362779
Revert "in 14 the click action gets lost in the Backbone view." 2018-10-09 15:33:01 +02:00
Morris Jobke 877823eb9d
Merge pull request #11709 from nextcloud/refactor/jquery-beforeunload
Fix depracted jQuery.bind call
2018-10-09 14:48:42 +02:00
Joas Schilling ea21aa3f7a
Use numeric placeholders if there are multiple, so that RTL languages can operate better
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-09 14:32:14 +02:00
Christoph Wurst 9af69ca2a5
Fix usage of deprecated OC.webroot
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 13:53:59 +02:00
Christoph Wurst 912729c427
Fix depracted jQuery.bind call
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-09 12:00:48 +02:00
Nextcloud bot d07c5db947
[tx-robot] updated from transifex 2018-10-09 00:12:27 +00:00
Roeland Jago Douma 1178e85206
Merge pull request #11664 from nextcloud/feature/noid/has-been-interrupted-throw-exception
Syntactic sugar for hasBeenInterrupted
2018-10-08 21:31:29 +02:00
Morris Jobke 6994a2a87d
Merge pull request #11679 from nextcloud/refactor/remove-ie8-apis
Remove IE8 APIs
2018-10-08 18:36:07 +02:00
Morris Jobke 2a9e006355
Merge pull request #11518 from nextcloud/feature/noid/save-s3-requests
S3 reuse information from listObject and skip headObject
2018-10-08 18:28:38 +02:00
Morris Jobke 3330600dc5
Merge pull request #11682 from nextcloud/refactor/remove-deprecated-unused-fileDownloadPath
Remove deprecated and unused fileDownloadPath
2018-10-08 18:04:08 +02:00
Morris Jobke 5d83645a00
Merge pull request #11680 from nextcloud/refactor/remove-deprecated-svg-apis
Remove deprecated SVG helpers for old IEs
2018-10-08 17:30:14 +02:00
Morris Jobke c4ac9bcea2
Merge pull request #10782 from nextcloud/fix/10774/deadtagaction
in 14 the click action gets lost in the Backbone view.
2018-10-08 17:14:00 +02:00
Morris Jobke fe2a600823
Merge pull request #10839 from nextcloud/bugfix/10212/use_class_implementation
adjust Calendar resource / room interfaces to use class implementation
2018-10-08 17:00:50 +02:00
Christoph Wurst 576e44f890
Remove deprecated and unused fileDownloadPath
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:46:36 +02:00
Daniel Kesselberg 4cbea5f7e1
Remove value from cache on delete/clear
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 16:40:39 +02:00
Christoph Wurst dccb3ab5b2
Remove deprecated SVG helpers for old IEs
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:33:41 +02:00
Christoph Wurst dd459bbb7a
Remove OC.scaleFixForIE8
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2018-10-08 16:17:16 +02:00
Morris Jobke 8110a3be69
Merge pull request #11599 from nextcloud/feature/7136/workflow-engine-filename
Add FileName to Workflow engine
2018-10-08 13:57:57 +02:00
Daniel Kesselberg 311de17730
Rename method to abortIfInterrupted
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 13:05:00 +02:00
Daniel Kesselberg be5e992021
Fix typo
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-08 13:02:12 +02:00
Morris Jobke 7971ba5cc6
Merge pull request #10898 from nextcloud/feature/10684/default-logo-color-theme-colors
Switches the default logo color depending on the primary color
2018-10-08 10:33:22 +02:00
Nextcloud bot 80f7add485
[tx-robot] updated from transifex 2018-10-08 00:12:54 +00:00
Georg Ehrke 1c6f666bbf
adjust Calendar resource / room interfaces to use class implementation
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-08 01:25:20 +02:00
Daniel Kesselberg 752f637207
Adjust code for changed method signature
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-07 18:17:29 +02:00
Nextcloud bot 4c47ec005f
[tx-robot] updated from transifex 2018-10-07 00:12:21 +00:00
Nextcloud bot 7dd2212b2c
[tx-robot] updated from transifex 2018-10-06 00:12:15 +00:00