Commit Graph

19211 Commits

Author SHA1 Message Date
Roeland Jago Douma 3a6b525a34
Merge pull request #12095 from MasterOfDeath/OCA-ShareByMail-Capabilities-test-unit
OCA\ShareByMail\Capabilities add unit test
2018-10-31 10:15:03 +01:00
Roeland Jago Douma 2574394625
Merge pull request #12147 from MasterOfDeath/OCA-SystemTags-Activity-Setting-add-unit-test
OCA\SystemTags\Activity\Setting unit test
2018-10-31 10:13:50 +01:00
Bjoern Schiessle d0411b2369
allow to create multiple link shares via share api
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-31 06:55:52 +01:00
Jan-Christoph Borchardt 9c68db5ffb
slightly round off thumbnails in list view too
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 00:01:58 +01:00
Arthur Schiwon 0c5d9127e8
remove app specific IUserTools and consolidate test
Just some house keeping. IUserTools with used in even older days for
easier creation of Access instances…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 22:44:50 +01:00
Bjoern Schiessle 0efd29f41f
first check if the user is already logged in and then try to authenticate via apache, this way we suppress wrong audit log messages about failed login attempts
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-30 22:14:52 +01:00
blizzz 1293affc84
Merge pull request #12020 from nextcloud/bugfix/11795/calendar_invitation_fallback_lang
Calendar invitation: use system default instead of sender's language as fallback
2018-10-30 22:05:20 +01:00
Rinat Gumirov 6760c3e699 OCA\SystemTags\Activity\Setting unit test
Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
2018-10-31 01:26:59 +05:00
MasterOfDeath f465839e34 OCA\ShareByMail\Capabilities unit test
OCA\ShareByMail\Capabilities unit test

Signed-off-by: Rinat Gumirov <rinat.gumirov@mail.ru>
2018-10-31 00:07:44 +05:00
Roeland Jago Douma 674930da7f
Move ExpiredTokenException to the correct namespace
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 19:30:45 +01:00
Roeland Jago Douma 41ff001b77
Merge pull request #11899 from nextcloud/enhancement/noid/sharing-consolidation
Sharing user consolidation
2018-10-30 19:27:05 +01:00
Daniel Calviño Sánchez bfb2a914d2 Honour "hide download" in the public share page
When the "hide download" property of a share is set the public share
page will not show the download button nor the menu with the download,
direct link and "Add to your Nextcloud" actions; the "downloadURL"
hidden field will not be included either in the generated HTML.

Despite that, note that the "downloadURL" parameter is still set and
passed to the template, as this could be needed anyway to generate
previews (for example, of audio files).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-30 15:18:55 +01:00
Roeland Jago Douma c237a3f003 Expose hide download to public page
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 15:18:55 +01:00
Roeland Jago Douma abbb946bbb Propegate hide download state in share provider
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 15:18:55 +01:00
Morris Jobke b28a0c10bf
Merge pull request #11946 from nextcloud/bugfix/11945/fix-js-namespace-of-files-external
Fix JS namespace of files_external app
2018-10-30 14:57:57 +01:00
Julius Härtl ffc32222f1
Styling papercuts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:34 +01:00
Julius Härtl b9c5e569d3
Update AddressBookImpl documentation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 14:43:08 +01:00
Roeland Jago Douma c1698948b8
Merge pull request #12130 from nextcloud/fix/reset_bruteforce_oauth
Reset bruteforce on token refresh OAuth
2018-10-30 14:26:50 +01:00
Roeland Jago Douma 8b2b238d86
Merge pull request #12054 from nextcloud/fix/5212/interact-with-userobject
LDAP: announce display name changes so that addressbook picks it up
2018-10-30 13:38:16 +01:00
Joas Schilling d295ff5367
Populate the mention-notification with the actual message
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 13:29:58 +01:00
Arthur Schiwon 49456e42f9
do not run into UniqueConstraintViolationException
… when an unmapped user logs in for the first time when background job
mode is ajax and no memcache was configured.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-30 12:12:03 +01:00
Roeland Jago Douma 75456b057d
Reset bruteforce on token refresh OAuth
When using atoken obtained via OAuth the token expires. Resulting in
brute force attempts hitting the requesting IP.

This resets the brute force attempts for that UID on a valid refresh of
the token.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-30 11:21:27 +01:00
Julius Härtl 61af607525
Make enhancing entries with type property optional
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
Julius Härtl 192324e4de
Make dropdown height 6 1/2 entries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:35 +01:00
Julius Härtl 5059605c99
Increase max-width of the share autocompletion suggestions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 3e11515b9c
Merge contacts and add type of result to the UI
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 8b92a6c9cb
Add type of properties to address book results
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:34 +01:00
Julius Härtl 45d8aeb9f2
Remove federated sharing address books which are the same as local ones
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:33 +01:00
Julius Härtl 6dde7e1183
Improve share select list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-30 10:19:32 +01:00
Morris Jobke 31ccf8580a
Merge pull request #12070 from nextcloud/fix/noid/announce-chosen-uid
announce the chosen uid (fixes wrong variable usage)
2018-10-30 10:12:04 +01:00
Joas Schilling 9645e545b3 Fix JS namespace of files_external app
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-30 09:43:26 +01:00
Nextcloud bot 9f99232865
[tx-robot] updated from transifex 2018-10-30 01:12:54 +00:00
Roeland Jago Douma 90dc8fb42e
A folder should get a folder mimetype
If doing achunked upload the mimetype of the folder would otherwise be
guessed from the path. Which always returned application/octet-stream.

If an access control rule to block that is in place this means that all
chunked uploads fail hard in directories as the isCreatable on the
directory always fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-29 21:35:08 +01:00
Morris Jobke 963d968f06
Merge pull request #12113 from nextcloud/fileinfo-getextension
Add getExtension() to FileInfo
2018-10-29 17:23:27 +01:00
Morris Jobke 76c31857cb
Merge pull request #12107 from nextcloud/fix/12086/no-unintentional-empty-attributes
remove unneeded empty LDAP search attribute values
2018-10-29 17:00:14 +01:00
Roeland Jago Douma 3aae3c82a4
Merge pull request #12041 from nextcloud/gridfixes
Properly hide files when searching
2018-10-29 16:12:44 +01:00
John Molakvoæ c05e8acdb1
Merge pull request #12019 from nextcloud/icons-svg-api-fixes
Move svg api endpoint
2018-10-29 15:45:45 +01:00
Robin Appelman e5c3e4b76f
Add getExtension() to FileInfo
this is a fairly common operation so it makes sense to prevent having
to repeatedly implement it.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-10-29 15:24:02 +01:00
Roeland Jago Douma 4a642fc004
Merge pull request #12106 from nextcloud/bugfix/noid/federated-settings-logo
Fix logo path in personal federated sharing settings
2018-10-29 14:54:20 +01:00
John Molakvoæ (skjnldsv) c0477afb5d
Properly hide files when searching
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
Arthur Schiwon d47e1513bc
remove unneeded empty search attribute values, fixes #12086
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-29 13:21:02 +01:00
Julius Härtl 4dda244ce2
Fix logo path in personal federated sharing settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 13:18:39 +01:00
Julius Härtl 4b7ef668a4
Adjust accessibility app color replacement
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-29 12:09:44 +01:00
dependabot[bot] 8c202f3af1
Bump webpack from 4.22.0 to 4.23.1 in /apps/oauth2
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 10:43:49 +00:00
dependabot[bot] 55f94695d0
Bump webpack from 4.22.0 to 4.23.1 in /apps/updatenotification
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-29 08:22:25 +00:00
Roeland Jago Douma 972f4191f4
Merge pull request #12096 from nextcloud/dependabot/npm_and_yarn/apps/accessibility/webpack-4.23.1
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
2018-10-29 09:19:35 +01:00
Nextcloud bot 18fef12721
[tx-robot] updated from transifex 2018-10-29 01:13:07 +00:00
dependabot[bot] 0e750aa3c9
Bump webpack from 4.22.0 to 4.23.1 in /apps/accessibility
Bumps [webpack](https://github.com/webpack/webpack) from 4.22.0 to 4.23.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.22.0...v4.23.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-28 18:28:05 +00:00
Nextcloud bot 13abee2836
[tx-robot] updated from transifex 2018-10-28 00:12:49 +00:00
Nextcloud bot 0092e3adec
[tx-robot] updated from transifex 2018-10-27 00:12:35 +00:00
Arthur Schiwon 05f909dcf3
fixes wrong variable usage
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-26 18:03:41 +02:00
Stefan Weil a226f65aa2 Fix off-by-one bugs
This fixes warnings from LGTM:

    Off-by-one index comparison against length may lead
    to out-of-bounds read.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-26 17:31:42 +02:00
Morris Jobke 31c3814b0a
Merge pull request #12038 from nextcloud/assemblystream_size
Implement the size of an assembly stream
2018-10-26 17:02:16 +02:00
Roeland Jago Douma 70e4884e02
Implement the size of an assembly stream
This will make it possible to act propely on moves of future files if we
need to know the size (like for max size virus scanning).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-10-26 10:43:11 +02:00
Morris Jobke 7aa76a82bc
Merge pull request #12053 from nextcloud/enhancement/10923/remove-unncessary-check
remove LDAP::hasPagedResultSupport() from PHP < 5.4 days
2018-10-26 10:28:47 +02:00
Nextcloud bot aff53d6e34
[tx-robot] updated from transifex 2018-10-26 00:12:48 +00:00
Arthur Schiwon bbe44108b5
only write when the displayname differs, but then announce it
refs #5212 and fixes #9112

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 23:41:12 +02:00
Arthur Schiwon 2048872f9e
functions that were checked for are present since PHP 5.4, supported is >=/
* so the check from older days is really not necessary anymore
* resolves #10923

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-10-25 22:50:42 +02:00
Morris Jobke 6ad7f32938
Merge pull request #12016 from nextcloud/wip/noid/icon-base64
Directly embed icons into the icon-vars css file
2018-10-25 16:04:23 +02:00
Morris Jobke 0a2476fcb3
Merge pull request #11988 from nextcloud/docs/jsdoc-build
JSdoc build fixes and move build script out of the root folder
2018-10-25 15:49:27 +02:00
Daniel Calviño Sánchez 661756b02a Set error expected by the DAV client for a failed move
A revert triggers a move in the DAV client, and the DAV client expects a
DAV error message to be provided by the server in case of failure; if
no error message is given the client ends trying to get an attribute
from an undefined object and "crashes".

Besides that, if the revert fails the "done" callback of the promise
(the first parameter of "then") is never called, so a "fail" callback
should be used instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 13:07:06 +02:00
Daniel Calviño Sánchez 24abfd8869 Wait for the promise to be fulfilled before running the next test
In Jasmine 2.5 the "it" function takes an optional parameter that should
be called when the async work is completed (returning a promise was
introduced in Jasmine 2.7, so it is not supported yet in the tests). If
the parameter is not declared then the next test is executed without
waiting for the asynchronous work in the previous one to finish, which
could cause that asynchronous work to finish while a different test is
being run.

Note that if that happens the test could still work as expected if it
relied only in local variables. However, in the case of the successful
revert tests, the stubs being checked are not the ones created when that
test was initialized, but the ones created when the next test, the
failed revert test, was initialized and the previous variables were
replaced (although the model itself calls the proper stubs, as they are
set through parameters in function calls).

Besides all that, the checks in the failed revert test were never
executed due to a different problem which will be fixed in the next
commit.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-25 12:25:41 +02:00
Julius Härtl d21ded67a7
Keep list of icons in a separate file for use in the accessibility app
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-25 12:16:10 +02:00
Nextcloud bot 58fde16226
[tx-robot] updated from transifex 2018-10-25 00:13:01 +00:00
Morris Jobke 88904200e0
Merge pull request #11889 from stweil/lgtm
Remove replace call which does not replace anything
2018-10-24 23:55:55 +02:00
Georg Ehrke 5c51d84a67
Calendar invitation: use system default instead of sender's language as fallback
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-10-24 18:39:30 +02:00
Bjoern Schiessle 87657fffd8
skip already encrypted files on encrypt all command
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2018-10-24 16:53:39 +02:00
Julius Härtl d14434fa2e
Adjust some jsdocs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 16:24:16 +02:00
Julius Härtl 5d888984a0
Fix jsdocs build on server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
Morris Jobke 37782b1084
Merge pull request #11573 from nextcloud/gridview-table
Files grid view
2018-10-24 15:31:23 +02:00
Morris Jobke 2ec5d2a6de
Merge pull request #11533 from nextcloud/accessibility-cache-fixes
Added cache override to ensure an always up-to-date accessibility css
2018-10-24 15:04:29 +02:00
Stefan Weil a13c80062d Remove replace call which does not replace anything
The original code replaced / by /.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-24 14:53:52 +02:00
Roeland Jago Douma b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
Nextcloud bot ded746f821
[tx-robot] updated from transifex 2018-10-24 00:12:31 +00:00
Roeland Jago Douma b853102a8f
Merge pull request #11886 from nextcloud/feature/noid/principal_search_displayname
Principal property search for users and groups with {DAV:}display name
2018-10-23 21:26:31 +02:00
Roeland Jago Douma 41fbda00ed
Merge pull request #11928 from stweil/fix
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
Roeland Jago Douma 530e39b061
Merge pull request #11778 from nextcloud/versions-webui-dav
move versions webui over to the dav api
2018-10-23 20:21:05 +02:00
John Molakvoæ (skjnldsv) ede6472e52
Fix FF performance and recals issues
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
Morris Jobke 4ad27260a9
Merge pull request #11439 from nextcloud/trash-modular-api
Modular trashbin api
2018-10-23 17:11:16 +02:00
John Molakvoæ (skjnldsv) 8013dab044
Allow focus on input with keyboard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
Nextcloud bot a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv) cf57df6e73
Restore table head
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
John Molakvoæ (skjnldsv) b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
Morris Jobke ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00
Morris Jobke 869df2ee7a
Merge pull request #11980 from nextcloud/assemblly-stream-lazy
lazy open first source stream in assemblystream
2018-10-23 16:17:49 +02:00
Morris Jobke 9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app
Fix opening a section again in the Files app
2018-10-23 15:29:55 +02:00
Jan-Christoph Borchardt b04ebd8553
Round off buttons 'pill style' like on the website
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 15:18:37 +02:00
Morris Jobke 171fe69db7
Merge pull request #11932 from nextcloud/font-nunito
Change typeface to Nunito
2018-10-23 15:14:10 +02:00
Roeland Jago Douma d11609a152
Merge pull request #11974 from nextcloud/bugfix/noid/lax-csp-on-talk-shares
Use lax CSP when the share is a talk share
2018-10-23 14:29:52 +02:00
Jan-Christoph Borchardt ade50d3b71
Remove font-specifics from high contrast theme because we are now on regular+bold anyway
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:13:07 +02:00
Jan-Christoph Borchardt 0158703590
Fix font-face in dyslexia-friendly theme
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:32 +02:00
Jan-Christoph Borchardt d9aa484641
Fix font-face on LDAP tooltip
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 13:12:08 +02:00
John Molakvoæ (skjnldsv) 26ca7a0e2f
Add filepicker toggle
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
Roeland Jago Douma 31d1179c41
Merge pull request #11973 from nextcloud/bug/accessibility/get_js_without_uid
If there is no UID do not explode accessibility javascript
2018-10-23 10:18:45 +02:00
John Molakvoæ (skjnldsv) bf6a1650ce
Use preview-x & preview-y on public pages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:59:34 +02:00
John Molakvoæ (skjnldsv) ec05e5d048
Fix public background override
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:54:09 +02:00
John Molakvoæ (skjnldsv) e0dde083d0
Public fixes, request & default to grid
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:43:02 +02:00
John Molakvoæ (skjnldsv) 8652ada561
Tooltip on hover only
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:27:27 +02:00
John Molakvoæ (skjnldsv) efdb535a5d
Fix grey background over thumbnail
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:23:22 +02:00
John Molakvoæ (skjnldsv) b662977862
Fix table hidden on empty folder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:18:14 +02:00