8185c46bd8
Find directly the label instead of falling back to it
...
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:45 +00:00
3a470c2ebe
Assert also element visibility instead of just finding it
...
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:44 +00:00
b086a0f007
Add explicit locator for "Enable all" bundle button
...
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:44 +00:00
1058abc97c
Find elements through the actor rather than the driver
...
"Actor::find" is a more robust way to look for elements, as it handles
some exceptions that may be thrown. Therefore, even if the elements are
not actually used and it is only checked whether they exist or not using
the actor is the preferred way when possible (and it also makes it
consistent with the rest of the acceptance tests).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:43 +00:00
270db2f523
Add locator for apps list
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:43 +00:00
4c98d2949f
Fix identation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:42 +00:00
34814adb36
Fix delete user acceptance test
...
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.
The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:42 +00:00
d03bc3e535
Verify WaitFor::element... results with an assertion
...
WaitFor::element... calls only perform the waiting and return whether
the condition succeeded or not, but that result needs to be explicitly
checked to prevent further steps from being executed if the wait failed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:41 +00:00
f3a4ec723a
Add missing waits when finding elements in the acceptance tests
...
As no timeout was specified the elements were tried to be found just
once. This caused the steps to fail if the elements did not appear yet
in the page when they were tried to be found.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:55:40 +00:00
6842530d7f
Merge pull request #25962 from nextcloud/backport/25712/stable21
...
[stable21] Fix admin password strengthify tooltip
2021-03-08 08:53:47 +01:00
48df1bef17
[tx-robot] updated from transifex
2021-03-08 02:23:21 +00:00
0dc05f51ef
[tx-robot] updated from transifex
2021-03-07 02:22:17 +00:00
e645482089
Merge pull request #25955 from nextcloud/backport/25932/stable21
...
[stable21] Skip empty obsolete owner when adding to own NC
2021-03-06 10:54:22 +01:00
5e6a891fce
[tx-robot] updated from transifex
2021-03-06 02:22:32 +00:00
4c2159a622
Fix admin password strengthify tooltip
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-03-05 18:15:30 +01:00
9f7973a70e
Skip empty obsolete owner when adding to own NC
...
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.
Fixes an issue where "Add to your Nextcloud" doesn't add anything.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:35:36 +00:00
d81954f913
Merge pull request #25935 from nextcloud/backport/25926/stable21
...
[stable21] Activity: show if files are hidden or not
2021-03-05 14:29:22 +01:00
3aba094d86
Merge pull request #25573 from nextcloud/backport/25378/stable21
...
[stable21] Improve mention matches
2021-03-05 09:55:44 +01:00
b4b55616c2
Merge pull request #25918 from nextcloud/backport/25805/stable21
...
[stable21] Clear multiselect after selection in share panel
2021-03-05 09:44:07 +01:00
01b9988a2d
Merge pull request #25571 from nextcloud/backport/25460/stable21
...
[stable21] Always renew apppasswords on login
2021-03-05 09:07:42 +01:00
67d62a820c
catch notfound and forbidden exception in smb::getmetadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-05 07:51:47 +00:00
163bf97c3e
[tx-robot] updated from transifex
2021-03-05 02:22:09 +00:00
8ab601cf66
Sharebymail: set expiration on creation
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 18:52:30 +00:00
5e2a9de3f0
Activity: show if files are hidden or not
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 16:04:30 +00:00
1575b09d0d
Clear multiselect after selection in share panel
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-04 15:02:13 +00:00
4df7cf1f54
Merge pull request #25875 from nextcloud/backport/25797/stable21
...
[stable21] Do not trigger a full filelist reload after creating a new file from a template
2021-03-04 15:48:23 +01:00
27e2f066a1
Merge pull request #25922 from nextcloud/backport/25882/stable21
...
[stable21] Filter out tables that does not belong to Nextcloud
2021-03-04 08:28:41 +01:00
5a39900c24
[tx-robot] updated from transifex
2021-03-04 02:22:22 +00:00
549cefed15
Filter tables with other table prefix
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-03-03 21:13:25 +00:00
3922966f3c
Merge pull request #25843 from nextcloud/backport/25757/stable21
...
[stable21] fix detecting cyclic group memberships
2021-03-03 11:34:25 +01:00
f1363bcfde
Bump bundles
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-03 10:01:45 +00:00
7c8c8902fa
Merge pull request #25899 from nextcloud/backport/25860/stable21
...
[stable21] do not die after LDAP auth failed with expired acc
2021-03-03 08:34:50 +01:00
2a66d4e5d1
[tx-robot] updated from transifex
2021-03-03 02:21:34 +00:00
9d937489db
do not die after LDAP auth failed with expired acc
...
- some servers return error code 53
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:02 +00:00
8aafd0d765
Merge pull request #25871 from nextcloud/backport/25758/stable21
...
[stable21] Include RichObject for forms
2021-03-02 21:10:34 +01:00
db5229bd70
Merge pull request #25846 from nextcloud/backport/25799/stable21
...
[stable21] fix typo in template directory config
2021-03-02 19:19:58 +01:00
36749161d7
disable trasbin during the moveFromStorage fallback
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-02 13:27:56 +00:00
472f6faf3f
At least try to give the full context for the file action
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 13:17:46 +00:00
060a0101ae
Do not trigger a full filelist reload after creating a new file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-02 13:17:46 +00:00
65db84d0fc
Merge pull request #25872 from nextcloud/backport/25869/stable21
...
[stable21] Fix namespacing
2021-03-02 14:00:54 +01:00
b5de59e4d7
Fix namespacing
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-03-02 10:07:48 +00:00
41930265e9
Include RichObject for forms
...
Ref. https://github.com/nextcloud/forms/pull/789
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
2021-03-02 09:59:10 +00:00
097bdf973e
Merge pull request #25857 from nextcloud/backport/25856/stable21
...
[stable21] Card::getOwner should return the actual value
2021-03-02 09:18:28 +01:00
3aca170a3e
[tx-robot] updated from transifex
2021-03-02 02:22:30 +00:00
b96a0cd77d
Card::getOwner should return the actual value
...
I guess we never call this at runtime or it would already ahve done boom
very loudly.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 17:27:49 +00:00
d0f4bac711
Merge pull request #25847 from nextcloud/backport/25715/stable21
...
[stable21] Bump the ca location
2021-03-01 18:26:45 +01:00
9c23684dcd
Bump the ca location
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 12:35:28 +00:00
7897414f1a
fix typo in template directory config
...
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2021-03-01 12:23:28 +00:00
256927d8d4
Merge pull request #25739 from nextcloud/backport/25602/stable21
...
[stable21] Avoid creating two share links when password is enforced
2021-03-01 12:50:01 +01:00
81fcc0a618
fix detecting cyclic group memberships
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-01 11:10:31 +00:00
Daniel Calviño Sánchez
Roeland Jago Douma
Nextcloud bot
Richard Steinmetz
Vincent Petry
Robin Appelman
Roeland Jago Douma
Daniel Kesselberg
Julius Härtl
Arthur Schiwon
Anna Larch
Jonas Rittershofer
Sascha Wiswedel