Commit Graph

4889 Commits

Author SHA1 Message Date
Joas Schilling 5e5c5a16dc
Add correct method for hardcoded `/f/{fileid}`
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-14 15:13:56 +01:00
Evilham de648f6a3e [app:files] Use current directory for hashing.
This fixes collisions that were causing uploads to break in a very
terrible way.

Kudos to @kesselb for finding the problematic place and to
@hottwister for the proposed solution.

Fixes #10527.
2019-03-13 22:21:32 +01:00
Jan-Christoph Borchardt 9306caec3e
Add border around previews in grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-03-12 10:44:51 +01:00
Joas Schilling c6a69ba925
Remove the upload and memory setting
* Remove unneeded private method phpFileSize()
* Bump autoloader
* Remove setUploadLimit tests
* Remove integrity check hacks for upload limit

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-03-04 12:14:22 +01:00
Julius Härtl f0e50bcb74
Fetch node and filename also if access cache was used
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:57:01 +01:00
Joas Schilling 55cd9eab03
Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:57:00 +01:00
Joas Schilling fdfe984adb
Register providers via class names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:57:00 +01:00
Joas Schilling 01b4db62fb
Add dispatcher events to User and Group objects
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:56:59 +01:00
Joas Schilling 55ae7fa2a4
Invalidate the cache when a share is updated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:56:59 +01:00
Joas Schilling 1a73cab3db
Fix doc block
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:56:59 +01:00
Joas Schilling 59c92a7513
Further work on the access cache
Searching for all is still a problem

Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:56:19 +01:00
Julius Härtl 31340b8be9
Add icon for resource type and icons for folder/file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:56:18 +01:00
Julius Härtl 3777df64ae
Add link to resource provider
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:56:18 +01:00
Julius Härtl 506eb885bc
Only call resource provider if type matches
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:56:17 +01:00
Julius Härtl d85e3e3a6d
Allow apps to register resource providers
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:56:17 +01:00
Julius Härtl 88aa3de784
Add iconClass to resources
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-01 20:56:17 +01:00
Joas Schilling 702dcfb728
Make names mandatory
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-03-01 20:56:16 +01:00
Nextcloud bot 374f89aba1
[tx-robot] updated from transifex 2019-03-01 01:12:36 +00:00
Nextcloud bot 057e81a1e2
[tx-robot] updated from transifex 2019-02-28 01:12:39 +00:00
Morris Jobke 0051bb7e4c
Merge pull request #14342 from nextcloud/bugfix/13911-occ-files-scan-elapsedtime-not-good-after-1day
Fix occ files:scan elapsed time
2019-02-26 15:46:22 +01:00
Roeland Jago Douma 0b7b32e808
Merge pull request #14251 from tomasz-grobelny/upload_reliability_improvements
Limit number of simultaneous MKCOL requests to server to increase upload reliability
2019-02-26 11:33:44 +01:00
Joel S 27aafa77db Fix occ files:scan-app-data elapsed time
Signed-off-by: Joel S <joel.devbox@protonmail.com>
2019-02-22 20:55:24 +05:30
Joel S f29b092a76 Fix-13911-occ-files-scan-elapsed-time
Signed-off-by: Joel S <joel.devbox@protonmail.com>
2019-02-22 19:59:03 +05:30
Jan-Christoph Borchardt de53a08632
Fix alignment of filelist header
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-02-21 13:55:46 +01:00
Nextcloud bot 10388eab34
[tx-robot] updated from transifex 2019-02-21 01:12:02 +00:00
Tomasz Grobelny 701f7902d2 Fix unit tests
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-02-20 23:07:38 +01:00
Julius Härtl c8ce7ebae2
Use proper scroll container when dragging files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-02-20 10:22:07 +01:00
Nextcloud bot ad0b67cbce
[tx-robot] updated from transifex 2019-02-19 01:12:10 +00:00
Tomasz Grobelny 7c4c5fe6ae Limit number of simultaneous MKCOL requests to server to increase upload reliability
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-02-16 23:27:50 +01:00
Nextcloud bot 1edfffd091
[tx-robot] updated from transifex 2019-02-16 01:12:24 +00:00
Nextcloud bot 49a0ea01e5
[tx-robot] updated from transifex 2019-02-15 01:12:49 +00:00
John Molakvoæ 6a3f4e4957
Merge pull request #12652 from tomasz-grobelny/operation_progress_improvements3
Operation progress improvements
2019-02-14 14:24:20 +01:00
Nextcloud bot 4d8c42a4fb
[tx-robot] updated from transifex 2019-02-14 01:12:26 +00:00
Nextcloud bot 6c6642e8ee
[tx-robot] updated from transifex 2019-02-13 01:12:15 +00:00
Nextcloud bot 44f6303dc3
[tx-robot] updated from transifex 2019-02-12 01:12:25 +00:00
Nextcloud bot de52f4d633
[tx-robot] updated from transifex 2019-02-11 01:12:23 +00:00
Nextcloud bot d4cf0bdb6a
[tx-robot] updated from transifex 2019-02-10 01:13:28 +00:00
Morris Jobke fda3f4fc41
Merge pull request #14060 from nextcloud/bugfix/noid/use-new-method
Use the new method instead of the deprecated wrapper
2019-02-08 10:57:16 +01:00
Nextcloud bot 45777abce0
[tx-robot] updated from transifex 2019-02-08 01:12:39 +00:00
Nextcloud bot 8db2f3ec3a
[tx-robot] updated from transifex 2019-02-06 22:18:24 +00:00
Joas Schilling 3580a1a240
Use the new method instead of the deprecated wrapper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-02-06 13:34:12 +01:00
Nextcloud bot 0df5110127
[tx-robot] updated from transifex 2019-02-06 11:27:29 +00:00
Christian Aigner ce37930910 HBOX-297 trim in webfrontend for new files to stay compatible with windows 2019-02-01 09:47:07 +00:00
fnuesse f13b3ab4ae Add drop zone for favorites quick access in navigation
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 01:45:03 +01:00
fnuesse 4b32e1c6ab Extract variable for yellow color in icons
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 00:59:05 +01:00
fnuesse ad407f64bd Fix drop zone shadow
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 00:59:05 +01:00
Daniel Calviño Sánchez 8680ced1ae Unify handling of dropping one file or several files on the trash bin
When a single file was dropped on the trash bin the file information was
gotten from the original element in the file list. When several files
were dropped on the trash bin the file information was gotten from the
helper elements being dragged around. The helper element also contain
the needed file information when a single file is being dragged, so the
handling was unified to always get the file information from the helper
elements.

As the handling of several files is the same as before there is still
the issue of only deleting those files shown in the drag helper instead
of all the selected files.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-02-01 00:56:50 +01:00
Daniel Calviño Sánchez e46a67ef4c Use full names instead of abbreviations in variable names
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:51 +01:00
Daniel Calviño Sánchez 3baa078f70 Make code format more consistent with the rest of the file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:51 +01:00
Daniel Calviño Sánchez 75edcad549 Replace double quotes with single quotes
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:51 +01:00
Daniel Calviño Sánchez 96bc1397b1 Add missing trailing ";"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:33 +01:00
Daniel Calviño Sánchez 72a424d4c8 Remove unneeded triggering of event
The "droppedOnTrash" event was being triggered when the file list was
initialized, but it should be triggered only when the user actually
drops a file on the trash bin.

Besides that, the event had no effect; only the file list handles it,
but as it was not triggered on any element it ended being triggered on
the document, and thus not handled. Moreover, even if it had been
triggered on the file list it would have been done before the handler
was set, so it would not have been handled anyway. And even if it had
been handled no data was provided, so the handler would have failed.

In conclusion, triggering the event there was not needed, and thus it
was removed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:14:58 +01:00
Daniel Calviño Sánchez dd91c4e500 Remove duplicated variable declaration
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 17:59:50 +01:00
Daniel Calviño Sánchez 47937a5062 Remove leftover from a WIP
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 17:49:25 +01:00
Daniel Calviño Sánchez 2aee19a4ba Remove hack to prefetch the starred trash icon
Since 6ad7f32938 SVG icons are directly embedded in "icons-vars.css", so
the starred trash icon is now loaded along with the regular trash icon
all at once. Therefore it is not needed to explicitly prefetch it using
a hidden div.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 17:40:14 +01:00
John Molakvoæ 53fd4997cc
Merge pull request #12364 from tomasz-grobelny/file_range_select
Ability to select file ranges with mouse or touchscreen
2019-01-30 10:21:23 +01:00
Tomasz Grobelny 08919eb193 Merge branch 'master' into operation_progress_improvements3
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-29 21:26:44 +01:00
Daniel Calviño Sánchez 038e665db9 Fix dropping a folder on a folder row
When the uploaded files have a relative path (that is, when a folder is
uploaded) it is first ensured that all the parent folders exist, which
is done by trying to create them. When a folder is created in the
currently opened folder the file list is updated and a row for the new
folder is added. However, this was done too when the folder already
existed, which caused the previous row to be removed and a new one added
to replace it.

For security reasons, some special headers need to be set in requests;
this is done automatically for jQuery by handling the "ajaxSend" event
in the document. In the case of DAV requests, if the headers are not set
the server rejects the request with "CSRF check not passed".

When a file or folder is dropped on a folder row the jQuery upload
events are chained from the initial drop event, which has the row as its
target. In order to upload the file jQuery performs a request, which
triggers the "ajaxSend" event in the row; this event then bubbles up to
the document, which is then handled by adding the special headers to the
request.

However, when a folder was dropped on a folder row that folder row was
removed when ensuring that the folder exists. The jQuery upload events
were still triggered on the row, but as it had been removed it had no
parent nodes, and thus the events did not bubble up. Due to this the
"ajaxSend" event never reached the document when triggered on the
removed row, the headers were not set, and the upload failed.

All this is simply fixed by not removing the folder row when trying to
create it if it existed already.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-29 13:04:19 +01:00
Christoph Wurst 8fcb9fcfdc
Merge pull request #13855 from tomasz-grobelny/faster_file_upload
Throttle getstoragestats.php calls and allow simultaneous uploads
2019-01-29 08:51:38 +01:00
Tomasz Grobelny f99ce0d546 Throttle getstoragestats.php calls and allow simultaneous uploads
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-27 22:59:14 +01:00
imsolost 5742ec79ab changed case on variable to match initial case
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
imsolost 3e37620cc2 fixed replacement functions to catch all instances of parenthesis
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
Tomasz Grobelny 907deab278 Add more accessible method of selecting file ranges
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-24 22:04:52 +01:00
Joas Schilling 0ba9e3b8bd
Make the yellow favorite icon non-monochrome
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-22 16:13:29 +01:00
Joas Schilling 55cd351324
Add icon to restore activity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-22 15:37:07 +01:00
Roeland Jago Douma 03290df8d4
Merge pull request #13723 from kofemann/patch-1
apps: file-upload: fix typo in comments
2019-01-22 09:26:40 +01:00
Nextcloud bot af36746d7c
[tx-robot] updated from transifex 2019-01-22 01:12:25 +00:00
Tigran Mkrtchyan 0573413134 apps: file-upload: fix typo in comments
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
2019-01-21 19:11:13 +01:00
Morris Jobke 990bca8696
Merge pull request #13567 from nextcloud/fix/deuglify-upload-progress
Improve the upload progress bar layout
2019-01-21 13:54:04 +01:00
Nextcloud bot f12b589d40
[tx-robot] updated from transifex 2019-01-19 01:12:22 +00:00
Morris Jobke 743323ee48
Merge pull request #12381 from rummatee/master
Move/copy file picker: Remeber last destination and start in current folder
2019-01-18 17:20:54 +01:00
Nextcloud bot ac6ee0b8b7
[tx-robot] updated from transifex 2019-01-17 01:12:15 +00:00
Florian Schunk 332b4aee9d fix testing for undefined
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk ecb936495f also remember folder for multiselect actions
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk 37270fc525 remember last copied to directory
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk 528964e0b7 copy Dialog starts in current directory
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Nextcloud bot e35a5ef387
[tx-robot] updated from transifex 2019-01-16 01:12:34 +00:00
Morris Jobke 6ac66ea0a3
Merge pull request #12173 from nextcloud/filename-center
Ensure filename is possibly centered below file icons in grid view
2019-01-15 08:47:46 +01:00
Nextcloud bot 56ad07b85e
[tx-robot] updated from transifex 2019-01-15 01:12:14 +00:00
Julius Härtl e5c1049d04
Properly center text inside of the grid container
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-14 22:03:40 +01:00
Michael Weimann 5ed63b05c7
Deuglify the file upload progress bar
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
2019-01-14 21:20:57 +01:00
Jan-Christoph Borchardt 4d103f8b97
Ensure filename is possibly centered below file icons in grid view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-14 20:19:10 +01:00
Nextcloud bot 8edd9b0e33
[tx-robot] updated from transifex 2019-01-14 01:12:00 +00:00
Nextcloud bot 363c0c31f4
[tx-robot] updated from transifex 2019-01-13 01:12:53 +00:00
Nextcloud bot ce89fe7f39
[tx-robot] updated from transifex 2019-01-12 01:11:54 +00:00
Nextcloud bot 75b8e98f8e
[tx-robot] updated from transifex 2019-01-11 01:12:31 +00:00
Nextcloud bot e8040d896a
[tx-robot] updated from transifex 2019-01-08 01:12:02 +00:00
Nextcloud bot 29dc12c885
[tx-robot] updated from transifex 2019-01-06 01:13:07 +00:00
Nextcloud bot a1b6333712
[tx-robot] updated from transifex 2019-01-05 01:11:57 +00:00
Nextcloud bot a1f9ed1d7d
[tx-robot] updated from transifex 2019-01-04 01:12:28 +00:00
Felix Nüsse d3171a80e0
Implemented short quota-design v2
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
2019-01-03 18:47:30 +01:00
Nextcloud bot cb4371c4f3
[tx-robot] updated from transifex 2019-01-01 01:11:35 +00:00
Nextcloud bot 8d5b74b6b6
[tx-robot] updated from transifex 2018-12-31 01:11:41 +00:00
Nextcloud bot eeceb684e8
[tx-robot] updated from transifex 2018-12-30 01:12:41 +00:00
Nextcloud bot 760c502f3c
[tx-robot] updated from transifex 2018-12-28 01:11:49 +00:00
Nextcloud bot 1c3f468d56
[tx-robot] updated from transifex 2018-12-27 01:11:41 +00:00
Nextcloud bot 3c83925f97
[tx-robot] updated from transifex 2018-12-26 01:11:56 +00:00
Nextcloud bot 9d5f7c7f62
[tx-robot] updated from transifex 2018-12-24 01:11:46 +00:00
Roeland Jago Douma bcea6c3697
Merge pull request #13212 from nextcloud/bugfix/noid/ie11-files-loading
Files list not rendering if user has favorites navigation unfolded
2018-12-21 14:20:41 +01:00
Julius Härtl 6bcc77a7c6
Replace ChildNode.before with custom before helper
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-21 12:03:34 +01:00
Roeland Jago Douma 8f16768a8b
Merge pull request #13183 from nextcloud/enhancement/whats_new_one_per_hour
Only check whatsnew once per hour
2018-12-21 09:21:16 +01:00
Nextcloud bot c0a6ad0a72
[tx-robot] updated from transifex 2018-12-21 01:11:48 +00:00
Roeland Jago Douma 00446ffb9e
Only check whatsnew once per hour
Store the last check in the session storage. (Which gets cleared on
logout). And only check once an hour.
Saves a request to the server on most requests when browsing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-20 20:09:05 +01:00
Nextcloud bot 4be6aa5270
[tx-robot] updated from transifex 2018-12-20 01:11:44 +00:00
Nextcloud bot 3d53398d07
[tx-robot] updated from transifex 2018-12-19 01:11:46 +00:00
Nextcloud bot ffd2410a7e
[tx-robot] updated from transifex 2018-12-17 01:11:33 +00:00
Nextcloud bot 3068f07ad9
[tx-robot] updated from transifex 2018-12-16 01:12:32 +00:00
Nextcloud bot 5a2a78c692
[tx-robot] updated from transifex 2018-12-15 01:11:38 +00:00
Nextcloud bot f1af773e11
[tx-robot] updated from transifex 2018-12-12 01:11:38 +00:00
Morris Jobke a938f0ea9d
Add abort stub in JSUnit
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-06 12:00:09 +01:00
Roeland Jago Douma 9204ce7d3d
Do not show general warning on free space error
Fixes #12588
Probably needs more fixing for the other cases. But this is the quick
fix I could come up with for now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-05 22:40:07 +01:00
Nextcloud bot 953332ae35
[tx-robot] updated from transifex 2018-12-05 01:11:55 +00:00
Nextcloud bot 95d33cd889
[tx-robot] updated from transifex 2018-12-04 01:12:05 +00:00
Nextcloud bot 9563f03ee6
[tx-robot] updated from transifex 2018-12-03 01:11:33 +00:00
Nextcloud bot a529f6ff26
[tx-robot] updated from transifex 2018-11-30 01:11:57 +00:00
Morris Jobke 6aefd8389b
Merge pull request #12732 from nextcloud/polishing-fixes
Polishing fixes
2018-11-29 18:21:31 +01:00
John Molakvoæ (skjnldsv) d526ab55fb
Fix default filepicker style and gridview
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-29 14:05:10 +01:00
Nextcloud bot 68f04686a0
[tx-robot] updated from transifex 2018-11-29 01:11:34 +00:00
Nextcloud bot 802a978bb5
[tx-robot] updated from transifex 2018-11-28 01:11:55 +00:00
Nextcloud bot e8886fb63a
[tx-robot] updated from transifex 2018-11-27 01:11:34 +00:00
Nextcloud bot e673c7dc49
[tx-robot] updated from transifex 2018-11-26 01:11:21 +00:00
Nextcloud bot 5b42972648
[tx-robot] updated from transifex 2018-11-25 01:12:16 +00:00
Tomasz Grobelny 04d326f95f Fix unit tests
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:57:13 +01:00
Tomasz Grobelny c83c26877b Use reportOperationProgress for removing files
Fix copying files

Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:56:56 +01:00
Tomasz Grobelny 8e240d1197 Properly handle errors (including 500)
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:42 +01:00
Tomasz Grobelny 1f6f276fa0 Add progress reporting to move and copy operations
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:33 +01:00
Tomasz Grobelny 7bafa54ae1 Fix progress bar label
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:25 +01:00
Tomasz Grobelny e99340dc4d Move progress bar to separate component
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:17 +01:00
Tomasz Grobelny 296e69fe04 Restructuring code in file-upload.js
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:55:01 +01:00
Nextcloud bot ea17e962bf
[tx-robot] updated from transifex 2018-11-24 01:11:17 +00:00
Joas Schilling 1751c28c28
Bump versions of server and the requirements of apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-23 10:28:40 +01:00
Nextcloud bot d664a9b37b
[tx-robot] updated from transifex 2018-11-23 01:12:51 +00:00
Morris Jobke 68ad2ae118
Merge pull request #10825 from greenido/fixing-issue-9931
Copy a file to the same directory
2018-11-22 17:37:04 +01:00
Julius Härtl a90b4bcc32
Do not switch to root folder if filelist is already shown
Navigating to the root folder is already handled by
OCA.Files.Navigation.setActiveItem in case the view doesn't change.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-22 14:03:23 +01:00
Daniel Calviño Sánchez e39db808fb Fix rendering of the sidebar in Files app
When a view is rendered it should not be concerned with where it is
going to be placed in the document; in general this should be a
responsibility of the object using the view.

Moreover, when the details view is rendered it should simply prepare a
skeleton that includes the root elements provided by the plugins; those
elements will be updated by the plugins as needed when a file or a tab
is selected.

Finally, the details view should not be explicitly rendered. The
rendering removes the previous elements, but that is needed only when
the details view is in a dirty state, that is, when new plugins were
added since the last time that it was rendered. However, that dirty
state is internally handled, and the view is automatically rendered
again if needed when a file info is set.

Due to all that the details view is no longer explicitly rendered when
updating it with a different file. Also, as each file list has its own
details view, and each details view has its own element, but there can
be only one details view/sidebar element in the document, when the file
list updates the details view it also replaces the current one in the
document with its own details view if needed (that is, if it is not the
current one already).

Besides that, when the element of a details view is replaced with the
element of a different details view the old one should be detached from
the document, but never removed. Otherwise the event handlers would not
work when that element is attached again later (when changing to a
different section in the Files app and then going back to the previous
one).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:58:25 +01:00
Julius Härtl 78056a3bef
Fix whitespace and file action cleanup
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:49 +01:00
Julius Härtl fb8aa31dbf
Allow to hide download option for folders shared by link
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:35 +01:00
Morris Jobke 802e4a79d1
JSUnit tests are not compatible with let/const yet
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 15:22:10 +01:00
Morris Jobke 85a491a6fb
Translate name for "(copy)"
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 13:57:27 +01:00
Ido Green 313aee91ca
Per the last comment on having only (copy) for the first one
Signed-off-by: Ido Green <greenido@gmail.com>
2018-11-19 13:57:23 +01:00
Ido Green 48d74482c1
Use the new naming per the comments on #9931
More details here: https://github.com/nextcloud/server/issues/9931#issuecomment-402318120

Signed-off-by: Ido Green <greenido@gmail.com>
2018-11-19 13:57:17 +01:00
Ido Green c794452689
fixing issue 9931 - copy a file to the same directory
Signed-off-by: Ido Green <greenido@gmail.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 13:56:40 +01:00
Julius Härtl eb039608f9
Make number of file list entries depending on the width for grid view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-18 10:44:53 +01:00
Nextcloud bot 8bf7ec26e0
[tx-robot] updated from transifex 2018-11-18 01:12:58 +00:00
Morris Jobke 9a6d60e95f
Merge pull request #12474 from nextcloud/default-to-files-list
Rollback to default list view
2018-11-16 13:48:16 +01:00
Nextcloud bot def8af3e7e
[tx-robot] updated from transifex 2018-11-16 01:12:14 +00:00
John Molakvoæ (skjnldsv) 1deda8fd65
Rollback to default list view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-15 20:29:10 +01:00
Morris Jobke 790ee0c8a3
Merge pull request #12467 from nextcloud/bugfix/11901/show-thumbnail-on-rename
Show thumbnail on rename
2018-11-15 14:09:55 +01:00
Morris Jobke c09560627f
Enhance jsunit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 13:40:05 +01:00
Morris Jobke 61f7eecc0b
Show thumbnail on rename
* does not hide thumbnail when rename is shown
* fixes layout for grid and list view
* fixes #11901

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 12:14:15 +01:00
Morris Jobke d70b010432
Merge pull request #12447 from nextcloud/bugfix/12446/fix-oracle-install-again
Shorten index name of calendar changes table
2018-11-15 10:47:51 +01:00
Nextcloud bot 10c9b37461
[tx-robot] updated from transifex 2018-11-15 01:12:14 +00:00
Morris Jobke c126c3f56a
Update PHPDoc to fix typos
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-14 21:21:41 +01:00
Joas Schilling aa88254f64
Shorten index name of calendar changes table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
Nextcloud bot fef51895c2
[tx-robot] updated from transifex 2018-11-14 01:12:12 +00:00
Nextcloud bot 5e84824839
[tx-robot] updated from transifex 2018-11-13 01:12:40 +00:00
Nextcloud bot 48395baa7e
[tx-robot] updated from transifex 2018-11-12 01:12:49 +00:00
Nextcloud bot 55f0c2ac3b
[tx-robot] updated from transifex 2018-11-08 01:12:18 +00:00
Julius Härtl c48722c201
Fix file move tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 11:14:19 +01:00
Nextcloud bot c26d847d19
[tx-robot] updated from transifex 2018-11-07 01:12:29 +00:00
John Molakvoæ e03bc6e4c9
Merge pull request #12303 from nextcloud/grid-for-all-file-templates
Add grid toggle for every files view
2018-11-06 17:29:31 +01:00
John Molakvoæ (skjnldsv) cac2f7f4d6
Fix tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 16:05:34 +01:00
Daniel Kesselberg ccd89f366d
Merge pull request #11968 from nextcloud/feature/noid/drop-verbose-appscan
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
2018-11-06 14:41:39 +01:00
John Molakvoæ (skjnldsv) 98edf3612c
Fix min trhumbnail size
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:45:19 +01:00
John Molakvoæ (skjnldsv) 5682d302c7
Add grid toggle for every files view
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:42:18 +01:00
Morris Jobke a88e7d30f3
Merge pull request #11831 from nextcloud/feature/noid/drop-verbose-scan
Replace $verbose with VERBOSITY_VERBOSE
2018-11-06 10:21:51 +01:00
Nextcloud bot 54a30a4b81
[tx-robot] updated from transifex 2018-11-06 01:12:39 +00:00
Morris Jobke f350f2e3ec
Merge pull request #12128 from tomasz-grobelny/fix_file_move
Fix file move operation for large number of files
2018-11-06 00:24:27 +01:00
Roeland Jago Douma cd31bea2b7
Merge pull request #12289 from nextcloud/ie11-grid-disable
Disable grid for ie
2018-11-05 22:48:24 +01:00
John Molakvoæ (skjnldsv) e0de0a122f
Disable grid for ie
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 17:27:09 +01:00
John Molakvoæ (skjnldsv) a793b1027c
Ask before cancelling an ongoing upload
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 10:11:50 +01:00
Roeland Jago Douma 4be625b128
Merge pull request #12231 from nextcloud/bugfix/10934/setmodel_before_render
Set the filemodel before rending the detailsview
2018-11-05 08:07:49 +01:00
Nextcloud bot c28ea52155
[tx-robot] updated from transifex 2018-11-05 01:12:32 +00:00
Tomasz Grobelny 1fa6e0be23 Merge remote-tracking branch 'upstream/master' into fix_file_move
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-04 09:39:19 +00:00
Nextcloud bot 9d7f02ec47
[tx-robot] updated from transifex 2018-11-04 01:14:02 +00:00
Tomasz Grobelny 41687ef00f Fix move related tests
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-03 23:01:32 +00:00
Roeland Jago Douma b1fd72c1cf
Set the filemodel before rending the detailsview
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 22:45:25 +01:00
Morris Jobke bfab6ccf1b
Merge pull request #12180 from nextcloud/sidebar-fixes
Sidebar fixes, mostly fixing design of tabs
2018-11-01 12:42:03 +01:00
Morris Jobke 0247a0d6db
Merge pull request #12162 from nextcloud/file-menu-align
Align file menu below '+' button, fix #5595
2018-11-01 12:01:05 +01:00
Jan-Christoph Borchardt 4e12132e43
Fix issues with clipboard button for local link in sidebar
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 04:11:20 +01:00
Nextcloud bot 9d5982ba4b
[tx-robot] updated from transifex 2018-11-01 01:12:59 +00:00
Julius Härtl 838105877c
Merge pull request #11647 from nextcloud/make-possible-for-tab-views-to-add-css-classes-to-their-container
Make possible for tab views to add CSS classes to their container
2018-10-31 15:37:48 +01:00
Jan-Christoph Borchardt 1cc05af7a6
Align file menu below '+' button, fix #5595
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 11:20:02 +01:00
Jan-Christoph Borchardt 9c68db5ffb
slightly round off thumbnails in list view too
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 00:01:58 +01:00
Tomasz Grobelny 68a27debd1 Fix file move operation for large number of files
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-10-30 15:37:21 +01:00
John Molakvoæ (skjnldsv) c0477afb5d
Properly hide files when searching
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
Nextcloud bot 18fef12721
[tx-robot] updated from transifex 2018-10-29 01:13:07 +00:00
Nextcloud bot 13abee2836
[tx-robot] updated from transifex 2018-10-28 00:12:49 +00:00
Nextcloud bot 0092e3adec
[tx-robot] updated from transifex 2018-10-27 00:12:35 +00:00
Nextcloud bot aff53d6e34
[tx-robot] updated from transifex 2018-10-26 00:12:48 +00:00
Julius Härtl 5d888984a0
Fix jsdocs build on server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
Morris Jobke 37782b1084
Merge pull request #11573 from nextcloud/gridview-table
Files grid view
2018-10-24 15:31:23 +02:00
Roeland Jago Douma b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
Roeland Jago Douma 41fbda00ed
Merge pull request #11928 from stweil/fix
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
John Molakvoæ (skjnldsv) ede6472e52
Fix FF performance and recals issues
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
John Molakvoæ (skjnldsv) 8013dab044
Allow focus on input with keyboard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
Nextcloud bot a9fb21f9fc
[tx-robot] updated from transifex 2018-10-23 14:54:28 +00:00
John Molakvoæ (skjnldsv) cf57df6e73
Restore table head
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
John Molakvoæ (skjnldsv) b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
Morris Jobke ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00