e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
...
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
223fe2aae6
Fix default missing initial state for templates
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-15 17:23:30 +01:00
a550649708
expand 'path is already shared' error message
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 15:55:08 +01:00
f512705f8f
Merge pull request #26003 from nextcloud/enh/simplefile/getid
...
Add getID function to the simplefile implementation
2021-03-15 14:41:15 +01:00
d7748e2b4d
verify that cache entry is valid
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:23:02 +01:00
c2fc3195dd
also implement for FailedCache and NullCache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:43 +01:00
ad636ae12d
use returned file id for object store copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:40 +01:00
d2bcb57a54
add ICopyFromCache trait to expose existing implementation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 17:22:36 +01:00
32551b9ff7
Merge pull request #25722 from nextcloud/objectstore-copy-cross
...
apply object store copy optimization when 'cross storage' copy is wit…
2021-03-12 16:10:18 +00:00
bf39adb49b
Merge pull request #26049 from nextcloud/search-file-limit-results
...
limit constructing of result objects in file search
2021-03-12 12:58:49 +01:00
7ac6eee129
Merge pull request #26079 from nextcloud/bugfix/noid/chunk-phone-search
...
Chunk the array of phone numbers
2021-03-12 11:20:35 +01:00
2e08c8b5a1
Chunk the array of phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 08:49:23 +01:00
98d2f3bc5c
Merge pull request #26072 from nextcloud/s3-no-explicit-close
...
remove explicit fclose from S3->writeStream
2021-03-12 08:21:54 +01:00
cd3ef614be
[tx-robot] updated from transifex
2021-03-12 02:22:44 +00:00
3eb764e65d
remove explicit fclose from S3->writeStream
...
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 18:05:04 +01:00
b62ee577d7
implement PagedProvider for file search
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 17:18:38 +01:00
424db15dea
limit constructing of result objects in file search
...
even thought we currently have no proper way of limiting the search itself, we can at least limit the construction of the result objects.
this saves about 40% of the time spend in the search request in my local testing
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-11 14:49:57 +01:00
dd1248d672
Merge pull request #26047 from nextcloud/JakubOnderka-patch-2
...
Fix warning in AppFetcher.php when appstore is disabled
2021-03-11 10:51:35 +01:00
b78dc6a6bf
Merge pull request #26050 from nextcloud/view-search-reuse-usermanager
...
reuse usermanager instance when processing search results
2021-03-11 10:27:30 +01:00
6db7731742
Merge pull request #26015 from nextcloud/dependabot/composer/psr/container-1.1.1
...
Bump psr/container from 1.0.0 to 1.1.1
2021-03-11 08:50:32 +01:00
56b08c04c7
Merge pull request #26031 from nextcloud/feature/noid/allow-autocomplete-based-on-phone-sync
...
Allow autocomplete based on phone sync
2021-03-11 08:29:21 +01:00
b4f6aca624
Clean up the logic of the contacts store a bit
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:48:17 +01:00
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
7287a15acb
Bump psr/container from 1.0.0 to 1.1.1
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-10 19:44:09 +01:00
f98fed3f8a
reuse usermanager instance when processing search results
...
saves some time when processing large search results
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 19:35:13 +01:00
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +01:00
c048f0100f
cache baseurl in url generator
...
Servers don't tend to change their url in the middle of a request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 17:22:31 +01:00
236aa194e2
Restrict autocompletion also based on the phonebook known users
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
c7be18c0d6
Add a service to find out if a user knows another user
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
1992d11d7d
Fix warning in AppFetcher.php when appstore is disabled
...
Signed-off-by: Jakub Onderka <ahoj@jakubonderka.cz>
2021-03-10 16:30:02 +01:00
f1bb4e5699
Add a KnownUsers database with model
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
c87b1a50d9
apply object store copy optimization when 'cross storage' copy is within the same object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 20:31:27 +01:00
7f3051e5bf
Drop \OCP\Util::isIe
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-09 20:29:42 +01:00
fad86afd26
Merge pull request #25533 from nextcloud/resend-share-notifications-on-recreate
...
send share notification instead of erroring on duplicate share
2021-03-09 19:44:22 +01:00
61f13583a2
Merge pull request #25677 from nextcloud/drop/cache-factory-create
...
Drop \OC\Memcache\Factory::create
2021-03-09 19:37:34 +01:00
3da33ce3fc
send share notification instead of erroring on duplicate share
...
when creating a share that already exists, instead of erroring, resend the notifications
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-09 19:20:37 +01:00
95af966f60
Merge pull request #26017 from nextcloud/enh/boostrap/initialstate
...
Move initialstate bootstrap to proper types classes
2021-03-09 16:28:59 +01:00
45cfeefd1b
Merge pull request #25930 from nextcloud/techdept/psalm/25839/RedundantPropertyInitializationCheck
...
Fix RedundantPropertyInitializationCheck
2021-03-09 13:06:55 +01:00
618805b14f
Fix RedundantPropertyInitializationCheck
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:49:45 +01:00
2e6cab4d82
Move initialstate bootstrap to proper types classes
...
For more type safety
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:19:23 +01:00
30e096f3f5
Allow overwriting isAuthenticated
...
* Some implementations might check for different things
* IT will not change how the current ones work
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-09 09:17:30 +01:00
cc2beee872
Add getID function to the simplefile implementation
...
Sometimes it is useful to get the actual fileid
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 14:59:36 +01:00
43b333331d
Merge pull request #25997 from nextcloud/techdept/psalm/redundantcast
...
Fix some redundant casts
2021-03-08 14:28:11 +01:00
615721df82
Merge pull request #25925 from nextcloud/techdept/psalm/ActionProviderStore
...
Pimp ActionProviderStore
2021-03-08 09:20:45 +01:00
43c8298dec
Merge pull request #25948 from nextcloud/techdebt/noid/depreate-getHTMLName
...
Deprecate getHTMLName on \OCP\Defaults
2021-03-08 08:54:42 +01:00
69b26c73f3
Fix some redundant casts
...
Happier psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +01:00
e8f087d7d1
[tx-robot] updated from transifex
2021-03-08 02:23:08 +00:00
c28542ef7f
[tx-robot] updated from transifex
2021-03-07 02:22:07 +00:00
41f9fdab1c
[tx-robot] updated from transifex
2021-03-06 02:22:22 +00:00
e47bd8324d
Merge pull request #25928 from nextcloud/enh/contactsmenu/entry
...
Type Entry and IEntry
2021-03-05 09:46:40 +01:00
11e2286a82
Merge pull request #25588 from nextcloud/techdept/custom-psr-logger
...
Migrate custom loggers to PSR
2021-03-05 09:46:07 +01:00
9dc5b8274e
Deprecate getHTMLName on \OCP\Defaults
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-05 09:34:24 +01:00
54cffefed4
Merge pull request #25660 from hosting-de/feature/add-backend-list-groups
...
Show group backends in occ group:list --info and group:info
2021-03-05 08:49:43 +01:00
e6ef096e52
Merge pull request #25659 from nextcloud/smb-getmetadata-catch
...
catch notfound and forbidden exception in smb::getmetadata
2021-03-05 08:49:23 +01:00
3c9a62721f
Merge pull request #25725 from lmamane/master
...
token login: emit preLogin event with LoginName
2021-03-05 08:46:46 +01:00
85e48d796c
Merge pull request #25929 from nextcloud/techdept/psalm/25839/redundantcasts
...
Remove Redundantcasts
2021-03-05 08:42:54 +01:00
a6c9688fd6
[tx-robot] updated from transifex
2021-03-05 02:22:00 +00:00
d7f7d3bc51
Type CompositeExpression and ICompositeExpression
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 21:47:44 +01:00
b844293536
catch notfound and forbidden exception in smb::getmetadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
c3f1eb4f7f
Remove Redundantcasts
...
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:44:04 +01:00
b14be34689
Type Entry and IEntry
...
* Fixed a docblock
* Typed the entries
Psalm happier, Roeland happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:30:21 +01:00
76a6328d10
Add executeQuery and executeUpdate
...
Names shamelessly copied from Doctrine itself.
Internally it is still using the same flow. But I added some checks
around it.
This should make static analysis a bit more happy. Which in turn makes
me more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 14:03:31 +01:00
f04a2ce19f
Pimp ActionProviderStore
...
* Fix paradoxale condition
* Add types
* Move away from ILogger
Makes psalm happy, and thus me happy
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 12:29:49 +01:00
1e5fea0460
Only mark migrations as installed after execution
...
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-04 08:49:42 +01:00
365d31743f
[tx-robot] updated from transifex
2021-03-04 02:22:10 +00:00
5325c3002c
Merge pull request #25917 from nextcloud/techdept/kill_deprecated/ocp_api
...
Remove deprecated \OCP\API
2021-03-03 21:57:34 +01:00
a58b4ceaab
Merge pull request #25889 from nextcloud/techdept/psalm/fix_group_manager_function_return_type
...
Fix types in the Group Manager
2021-03-03 20:55:52 +01:00
cc744740b7
Remove deprecated \OCP\API
...
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
68ec18323d
Fix types in the Group Manager
...
Psalm found an issue. However the issue found was because of lying
docblocks. Fixed those and did some typing to make it all better.
For #25839
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 14:52:47 +01:00
a6246be34c
Merge pull request #25656 from nextcloud/enh/type/expressionbuilder
...
Type the experssionbuilders
2021-03-03 11:37:16 +01:00
11858a3d66
Merge pull request #25816 from nextcloud/iquerybuilder-join-conditions
...
allow non string join conditions in query builder
2021-03-03 11:34:56 +01:00
74f36173bc
Merge pull request #25882 from nextcloud/bug/25748/filter-other-tables
...
Filter out tables that does not belong to Nextcloud
2021-03-03 11:24:47 +01:00
4bdf9f5849
Type the experssionbuilders
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 10:44:09 +01:00
47dd8e54b5
allow non string join conditions in query builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-03 10:43:15 +01:00
e11be3b693
[tx-robot] updated from transifex
2021-03-03 02:21:24 +00:00
bc91eb7c64
Filter tables with other table prefix
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-03-02 21:09:33 +01:00
1531414e8d
Fix docblock return type for IShareProvider
...
All the implementations already returned an array of array of shares. So
better to make sure the docblock also doesn't lie.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:12:46 +01:00
19e2136963
Update autoloader files
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
3d62233cab
Merge pull request #25869 from nextcloud/fix/imanager-namespacing
...
Fix namespacing
2021-03-02 11:05:14 +01:00
1a724cb57f
Merge pull request #25758 from nextcloud/enh/include_RichObject_forms
...
Include RichObject for forms
2021-03-02 10:56:40 +01:00
f9083ef7bf
Fix namespacing
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-03-02 09:37:34 +01:00
7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
...
Move app_password_created to a typed event
2021-03-02 08:18:59 +01:00
63f68e0412
[tx-robot] updated from transifex
2021-03-02 02:22:18 +00:00
9f96a47125
Add OCC command to reset rendered texts
...
The command is meant to be used when the fonts used to render texts
("core/fonts/NotoSans-Regular.ttf" and "core/fonts/NotoSans-Bold.ttf")
are changed (for example, to add support for other scripts). The avatar
and text file previews will be removed, so they will be generated again
with the updated font when needed.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-01 20:54:43 +01:00
2796ef80ff
Show group backends in occ group:list --info and group:info
...
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-01 16:02:08 +01:00
f02362e029
Include RichObject for forms
...
Ref. https://github.com/nextcloud/forms/pull/789
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
2021-03-01 14:00:33 +01:00
91f260fe29
Merge pull request #25804 from nextcloud/bugfix/noid/fread-0
...
Do not attempt to read 0 bytes when manually iterating over a non-seekable file
2021-03-01 09:54:33 +01:00
24d5afb1b1
[tx-robot] updated from transifex
2021-02-28 02:19:54 +00:00
19eb48b8a3
Properly end iterating over the file once the target has been reached
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-26 11:29:01 +01:00
b4ccadea2b
[tx-robot] updated from transifex
2021-02-26 02:21:45 +00:00
ce082dd49b
Merge pull request #25786 from nextcloud/fix/register-aliases-params-once
...
Register service aliases und parameters just once
2021-02-25 09:47:27 +01:00
c8f7a808fd
[tx-robot] updated from transifex
2021-02-25 02:21:21 +00:00
6a9b693540
Register service aliases und parameters just once
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-24 17:30:10 +01:00
b89fbaf52d
[tx-robot] updated from transifex
2021-02-24 02:22:06 +00:00
ff54a0481b
[tx-robot] updated from transifex
2021-02-23 02:39:25 +00:00
e5a0219133
Merge pull request #25680 from nextcloud/taint-expressionbuilder
...
Add expression taint source and sanitizer
2021-02-22 12:26:48 +01:00
3ff92423e2
[tx-robot] updated from transifex
2021-02-21 02:39:59 +00:00
f99f463834
token login: emit preLogin event with LoginName
...
to bring it in line with normal (non-token) login.
Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
2021-02-19 22:27:46 +01:00
c222bac9ed
[tx-robot] updated from transifex
2021-02-19 02:20:56 +00:00
16652ac6c6
Explicitly check hex2bin input
...
For #23197
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-18 20:12:20 +01:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
d79cc8ea6d
Merge pull request #25706 from nextcloud/bugfix/noid/when-it-kicks-in
...
When coding style kicks in
2021-02-18 11:30:06 +01:00
1de3b8b0ec
When it kicks in
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-18 10:14:12 +01:00
5f194dad24
[tx-robot] updated from transifex
2021-02-18 02:21:54 +00:00
82f4bb0eba
Merge pull request #25700 from nextcloud/fix/zipresponse-initialize-array
...
Initialize \OCP\AppFramework\Http\ZipResponse::$resources
2021-02-17 22:26:06 +01:00
d7590a6190
Add expression taint source and sanitizer
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-17 21:38:15 +01:00
08d4458542
Initialize \OCP\AppFramework\Http\ZipResponse::$resources
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-17 19:59:27 +01:00
9d96b0b7fb
bump applicable version due to an intermediate release
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 17:37:45 +01:00
644e6df02e
Merge pull request #25440 from nextcloud/bugfix/noid/cache-the-user-backend-info-for-30s
...
Cache the user backend info for 5mins
2021-02-17 08:56:55 +01:00
f0c8f7421f
Merge pull request #25678 from nextcloud/drop/defaults-logo-claim
...
Drop \OCP\Defaults::getLogoClaim
2021-02-16 16:14:04 +01:00
2dac72ddea
Merge remote-tracking branch 'upstream/master' into feat-federatedfilesharing-logging
2021-02-16 14:33:22 +01:00
24e035dfc8
Drop \OCP\Defaults::getLogoClaim
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-16 11:46:06 +01:00
0c5adaddf8
Drop \OC\Memcache\Factory::create
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-16 11:43:05 +01:00
2ea3cb7c93
Drop redundant indes
...
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
0363af3790
move AbstractCacheEvent into OCP
...
otherwise we have concrete cache events in OCP extending non OCP classes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-15 19:12:30 +01:00
19f1cc6dde
Merge pull request #25646 from nextcloud/fix/psalm/markdown
...
Markdown: remove redundant int cast
2021-02-15 12:04:21 +01:00
645f83121e
Cache the user backend info for 300s
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-15 10:36:08 +01:00
4d7c4b3d2f
Markdown: remove redundant int cast
...
For #25641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:29:54 +01:00
11a9bd3e19
Some OCS result psalm fixes
...
For #25641
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:03:48 +01:00
24d4c3eeab
Merge pull request #25577 from nextcloud/enhancement/app-code-checker-noop
...
Make the app code checker a NOOP
2021-02-13 15:51:41 +01:00
69f0d7d5d4
[tx-robot] updated from transifex
2021-02-13 02:20:27 +00:00
361f160d0d
[tx-robot] updated from transifex
2021-02-12 02:20:18 +00:00
37199c1da0
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation
...
Micro-optimize validation of empty email addresses
2021-02-11 19:51:06 +01:00
059bcf65a5
Merge remote-tracking branch 'upstream/master' into feat-federatedfilesharing-logging
2021-02-11 19:28:34 +01:00
d45692ee96
Migrate custom loggers to PSR
...
This will help phase out the deprecated ILogger interface.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 16:16:34 +01:00
883848b58a
Micro-optimize validation of empty email addresses
...
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 15:15:38 +01:00
957e287b79
Merge remote-tracking branch 'upstream/master' into feat-federatedfilesharing-logging
2021-02-11 12:06:16 +01:00
e618ea83b5
Make the app code checker a NOOP
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 11:46:02 +01:00
cc554890c1
Fix WebP availability check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-11 11:31:38 +01:00
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
...
Improve mention matches
2021-02-11 10:33:15 +01:00
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
...
Always renew apppasswords on login
2021-02-10 21:09:20 +01:00
cd457cc68b
Always renew apppasswords on login
...
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 19:02:37 +01:00
1cc23c6e6e
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
...
Deprecate the GenericEvent wrapper
2021-02-10 18:57:07 +01:00
847ee4041a
Merge pull request #25566 from nextcloud/fix/25359/followup
...
Fix remaining #25359
2021-02-10 18:02:24 +01:00
039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
...
Make our event base class independent of Symfony and follow PSR
2021-02-10 16:13:06 +01:00
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +01:00
0a28440bf6
Make our event base class independent of Symfony and follow PSR
...
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 15:15:29 +01:00
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
f76ec25e58
Deprecate the GenericEvent wrapper
...
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 08:54:08 +01:00
decb70b9ac
[tx-robot] updated from transifex
2021-02-10 02:20:59 +00:00
3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
...
Deprecate all remaining event constants
2021-02-09 20:19:04 +01:00
f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
...
Deprecate the internal IDBConnection event name constants
2021-02-09 18:50:55 +01:00
f8808e260d
Move app_password_created to a typed event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +01:00
111fa47f10
remove ReconnectWrapper
...
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
...
Fix the legacy dispatcher argument order
2021-02-09 14:39:12 +01:00
4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
...
Improve exception when auto-wiring fails
2021-02-09 14:27:43 +01:00
4fc0b2c639
Deprecate all remaining event constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 13:53:41 +01:00
ec875227ec
forward query exception when fallback construction fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
3d075c370a
Deprecate the internal IDBConnection event name constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 11:27:59 +01:00
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
75fbc66f9b
fix(sahre20): missing ILogger param instantiating Notifications
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 09:55:39 +01:00
9eea1e56dc
[tx-robot] updated from transifex
2021-02-09 02:20:45 +00:00
3401be216d
forward original query exception when querying by name fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
26a20ed13f
[tx-robot] updated from transifex
2021-02-08 02:20:05 +00:00
f19287ae57
[tx-robot] updated from transifex
2021-02-07 02:20:51 +00:00
98032425b4
Fix linter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
ef7ed47f14
Make Psalm happy
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
1344c61145
Improve mention matches
...
The previous regex didn't correctly match users with . ' or -
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:05 +01:00
cd77b1f238
Merge pull request #25499 from nextcloud/test/symfony-adapter
...
Test the symfony adapter / fix missing return object
2021-02-06 13:01:23 +01:00
8bb6bb53ad
[tx-robot] updated from transifex
2021-02-06 02:20:50 +00:00
6e461248e0
Merge pull request #25500 from Worteks/fix-sharemanager-genericshareexception
...
fix(translation): replace static error message
2021-02-05 16:17:34 +01:00
3a077a3903
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 13:27:37 +01:00
5f8dfa8e4c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:52:59 +01:00
f6ddda8dad
Test the symfony adapter
...
To prevent regression in the future.
And make sure we always return an object …
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +01:00
59e43b4828
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:06:35 +01:00
91e1707498
Log deprecation notice of GenericEventWrapper just once
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 08:45:58 +01:00
c935f6a776
[tx-robot] updated from transifex
2021-02-05 02:21:31 +00:00
df9ce19a6b
[tx-robot] updated from transifex
2021-02-04 02:20:03 +00:00
137636b651
Merge pull request #24700 from Imajie/s3-creds
...
Resolves #24699 , Support ES2 and ECS instance providers for S3 buckets
2021-02-02 21:48:22 +01:00
5c6d245661
Merge pull request #25393 from nextcloud/fix/25165/repair-dav-shares
...
add repair job for unencoded group share uris
2021-02-02 21:43:42 +01:00
18e2e86b95
Avoid template creators being registered multiple times
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-02 19:36:31 +01:00
ad2033ef1d
Merge pull request #25444 from nextcloud/bug/25415/move-generic-errors-to-end
...
Check for generic errors at last.
2021-02-02 18:59:43 +01:00
fe378200fa
Check for generic errors at last.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-02-02 18:28:49 +01:00
e18c608cb4
[tx-robot] updated from transifex
2021-02-02 02:19:50 +00:00
86678ba5df
[tx-robot] updated from transifex
2021-02-01 02:19:36 +00:00
d1bdd1ceba
[tx-robot] updated from transifex
2021-01-31 02:19:02 +00:00
fcbe4c5be5
[tx-robot] updated from transifex
2021-01-30 02:20:34 +00:00
3ecc6d0a8a
show suggestion to clean up possible invalid shares later
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:43:58 +01:00
558f062ca6
add repair job for unencoded calendars
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:29:10 +01:00
8fcc0e8d8c
Merge pull request #25302 from mziech/patch-2
...
Use RFC-compliant URL encoding for cookies
2021-01-29 13:38:02 +01:00
222d8e6c1a
Use proper path for scanner
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 09:40:46 +01:00
0d384dedaa
Obtain the user language from the passed in user id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:56:32 +01:00
39a4b1c401
Normalize compared path to avoid renaming to the same directory
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:43:17 +01:00
7e727a1a31
The objectid is a string
...
This allows the query to use the index. Else it has to resort on
scanning all the rows.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-28 22:09:55 +01:00
e29f903dc4
Merge pull request #25360 from nextcloud/fix/update-autoloaders
...
Update all composer autoloader files
2021-01-28 20:38:22 +01:00
299f37c5d9
Update all composer autoloader files
...
The format changed between 2.0.8 and 2.0.9.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-28 14:24:34 +01:00
a71bb8a485
Make whole Template class final
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
6c1b357973
Move TemplateProvider registration to boot context and make template type registration lazy
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
0111381529
Only create template directory if it is present in the default skeleton
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
4f90766ba3
Skip template picker if none available
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:20 +01:00
7e6d69d166
Add templatedirectory config value to let admins have their custom templates by default
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
66fa3fca83
Add ratio to template creators
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
78e114ed72
Add template picker
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:18 +01:00
4974404774
files: Create files from template API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 11:59:46 +01:00
3a9c7f99f6
Merge pull request #25335 from nextcloud/fix/app-fetcher-php-compat-comparison
...
Fix/app fetcher php compat comparison
2021-01-27 15:14:52 +01:00
e0f0e6e41a
Merge pull request #25268 from nextcloud/enh/previews/sgi-tga
...
Add SGI and TGA preview support
2021-01-27 14:54:27 +01:00
baba83e185
[tx-robot] updated from transifex
2021-01-27 02:20:46 +00:00
b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
...
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +01:00
6ecf33bfe7
only use share cacheentry when available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 16:22:00 +01:00
e511a539b7
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:55:38 +01:00
5ae0be08b4
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:54 +01:00
27f9df2e87
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:50 +01:00
a44aab11f7
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-26 15:30:46 +01:00
652bf9d363
Revert "Fix comparison of PHP versions"
...
This reverts commit bedd9acf78
2021-01-26 13:48:06 +01:00
b98860eeb3
[tx-robot] updated from transifex
2021-01-25 02:20:31 +00:00
4923c6be25
Use RFC-compliant URL encoding for cookies
...
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.
Fixes #24438
Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-24 14:18:28 +01:00
1d2707ad78
Merge pull request #25273 from nextcloud/enhancement/hide-two-factor-settings-if-no-providers
...
Do not show 2FA settings if the user has no providers available
2021-01-22 16:26:17 +01:00
47b10c3775
Merge pull request #25275 from nextcloud/fix/two-factor-token-type
...
Convert 2FA token type to string
2021-01-22 16:14:45 +01:00
ac591e2fc2
Fully deprecate the old initial state interface, not just the methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:53:26 +01:00
939433363e
Merge pull request #25128 from nextcloud/ldapprovider-get-property
...
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 14:31:19 +01:00
f15148f695
adjust since
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
2021-01-22 14:29:39 +01:00
99d525eb36
Convert 2FA token type to string
...
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +01:00
378f116a63
Do not show 2FA settings if the user has no providers available
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +01:00
0bc9e3ca15
Change license mail alias
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 13:06:35 +01:00
d47b84be67
Add SGI and TGA preview support
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 10:42:51 +01:00
7989247574
[tx-robot] updated from transifex
2021-01-22 02:19:54 +00:00
10214fbee0
Merge pull request #25214 from nextcloud/dependabot/composer/phpseclib/phpseclib-2.0.30
...
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
2021-01-21 10:25:02 +01:00
d4d33e3095
Merge pull request #25238 from nextcloud/enh/noid/apps-defacto-in-root
...
Apps folder is defacto in root folder and not above
2021-01-21 09:08:54 +01:00
15b0e4d922
Merge pull request #25240 from nextcloud/enh/noid/re-use-fetched-dependencies
...
Re-use fetched dependencies in lib/base.php
2021-01-21 08:54:05 +01:00
349b65eff3
Merge pull request #25236 from nextcloud/mkdir-explicit-chmod
...
explicitly set permissions on newly created folders
2021-01-21 07:56:10 +01:00
054783e385
[tx-robot] updated from transifex
2021-01-21 02:20:36 +00:00
d84e1f1951
Re-use fetched dependencies in lib/base.php
...
Reduces calls to DI container by reusing already fetched dependencies.
For status.php it went from 355 to 344.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +01:00
5b0e69828f
Apps folder is defacto in root folder and not above
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:22:39 +01:00
d182043e83
explicitly set permissions on newly created folders
...
this works around any `umask` that might be set and limiting the folder permissions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-20 17:15:57 +01:00
4c81f5c4ad
Merge pull request #25212 from nextcloud/enh/preview-markdown
...
Enhance markdown file preview rendering
2021-01-20 15:02:41 +01:00
01f013661a
Fix typo in comment
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 15:02:32 +01:00
6129a85187
Merge pull request #25224 from nextcloud/bugfix/24600/fix-saving-user-credentials
...
Update handling of user credentials
2021-01-20 14:59:30 +01:00
aed1fde6fd
Enhance markdown file preview rendering
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-20 11:07:55 +01:00
fcbbcacab4
Also load CA properly in integrity check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
d751fedffb
phpsec lib can't parse multiple certs in one go
...
So we have to split it manually and do it ourselves
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
3d61adc908
Drop authtoken_version_index
...
The index was used when deleting old tokens. On top of that the index is
of course not that great since the version is either 1 or 2.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 09:34:41 +01:00
6c1e294edd
Compare and store the login name via the event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:50:17 +01:00
6d4afca7ac
Add support for webp
...
Including handling in OC_Image
But also a preview provider
Of course only works if your php actually supports webp
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 20:17:10 +01:00
fdc8635afb
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-19 16:33:58 +01:00
0893bba369
Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ
...
Force signature verification of apps on occ
2021-01-19 09:35:52 +01:00
91864aeb40
[tx-robot] updated from transifex
2021-01-19 02:20:43 +00:00
847aa08ebd
Don't log keys on checkSignature
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 16:09:06 +01:00
76c7356af9
Only use alphanumeric chars for mysql password
...
/ and + can cause problems with other tools that you might want to run on your Nextcloud database.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 12:03:52 +01:00
90c3013d40
Cleanup the constructor
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
f319660f60
Force run the verification of the signature on occ
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
6d291c3c19
[tx-robot] updated from transifex
2021-01-18 02:19:28 +00:00
1907cc197d
[tx-robot] updated from transifex
2021-01-17 02:19:53 +00:00
40fde94b4d
fix even more brackets
...
Signed-off-by: Jasper Knockaert jasper@knockaert.nl
2021-01-16 14:49:53 +01:00
252d1ae512
fix brakcets
2021-01-16 14:38:19 +01:00
f9a0380eb1
consolidation of boolean expression
2021-01-16 14:33:44 +01:00
eafd281800
Merge pull request #25138 from gouttegd/fix25137
...
Fix comparison of PHP versions
2021-01-15 15:18:25 +01:00
bcb52d64f0
Merge pull request #25141 from nextcloud/bugfix/noid/add-a-hint-about-priority
...
Add a hint about the direction of priority
2021-01-15 09:46:37 +01:00
b8acf2fe69
Add a hint about the direction of priority
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-15 08:34:24 +01:00
bedd9acf78
Fix comparison of PHP versions
...
Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.
Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
2021-01-14 23:03:20 +00:00
Vincent Petry
John Molakvoæ (skjnldsv)
Robin Appelman
Morris Jobke
Roeland Jago Douma
Joas Schilling
Nextcloud bot
Christoph Wurst
Joas Schilling
Christoph Wurst
Jakub Onderka
Julius Härtl
Roeland Jago Douma
Lukas Reschke
Daniel Kesselberg
Anna Larch
Daniel Calviño Sánchez
Johannes Leuker
Jonas Rittershofer
Lionel Elie Mamane
dependabot-preview[bot]
Arthur Schiwon
Samuel
Marco Ziech
Jasper Knockaert
Damien Goutte-Gattat