Commit Graph

4301 Commits

Author SHA1 Message Date
Nextcloud bot b8c728de6d
[tx-robot] updated from transifex 2018-06-19 00:12:55 +00:00
Abijeet 419d72e0ee
Adds a test case for the loading symbol in deleted files.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 470310b3bf
Fixes issue with action being displayed incorrectly.
Also fixes the issue with the loading icon on copy & move.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Morris Jobke 57b649d665
Fix alignment of more icon
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-06-18 07:39:44 +02:00
Abijeet 5d95911537
Fixes UI issues with the design,
1. Removes an unnecessary width
2. Content of the table header moving down on selection. Happening due to increase in height of header.
3. Invalid font-size for the actions menu.
4. Vertical position of the action menu

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 0c77b93b86
Fixes issues found during running of test cases.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet e89f6590e2
Fixed failing test cases for the new actions menu.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:44 +02:00
Abijeet 45db89f3e6
Added a new action menu in files and trash list.
Uses the new file-multi-select-menu component.

Towards #7647

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:43 +02:00
Abijeet 174ba1f012
Adds an action dropdown that is shown on file selection.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-06-18 07:39:43 +02:00
Nextcloud bot 5e5671983c
[tx-robot] updated from transifex 2018-06-17 00:12:48 +00:00
Nextcloud bot db9ad32d75
[tx-robot] updated from transifex 2018-06-16 00:13:15 +00:00
Nextcloud bot 84a1c915e6
[tx-robot] updated from transifex 2018-06-15 00:12:49 +00:00
Nextcloud bot 479e31997f
[tx-robot] updated from transifex 2018-06-14 00:13:06 +00:00
Nextcloud bot 5ecfd80f07
[tx-robot] updated from transifex 2018-06-13 00:12:59 +00:00
Nextcloud bot d91bed9490
[tx-robot] updated from transifex 2018-06-12 00:12:46 +00:00
John Molakvoæ a1496d7cc1
Merge pull request #9807 from nextcloud/fix-highlighting-of-the-upload-drop-zone
Fix highlighting of the upload drop zone
2018-06-11 09:17:48 +02:00
Nextcloud bot ae3bdb4fb9
[tx-robot] updated from transifex 2018-06-09 00:13:06 +00:00
Daniel Calviño Sánchez 4eafae4178 Do not show an error message when draging and dropping text
When the browser reports a drag of items other than files (for example,
text) and then triggers a drop event with no files no error message
should be shown to the user, as in that case there would be no highlight
of the drop zone and no indication that the drop would be valid (except
for the mouse cursor); the error message should be shown only when
the drop event with no files follows a file drag.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 20:37:43 +02:00
Daniel Calviño Sánchez 463d92c339 Remove no longer needed special handling for Firefox
The highlighting was removed in Firefox when the cursor was no longer
moving to handle the behaviour of reporting a file drag and then
providing no files in the drop event. That behaviour (which was only
present in Firefox 48 and 49) is already handled with the "dropnofiles"
callback, so that special handling is no longer needed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 20:01:41 +02:00
Daniel Calviño Sánchez d8251344c1 Use "dropnofiles" callback to disable the drop state in the UI
When a file is dragged from the desktop to the file list the file list
is highlighted, and when the file is finally dropped or the drag
operation is cancelled the highlighting is removed. In some cases, due
to a wrong implementation, a browser may end a file drag with a drop
with no files (for example, when a folder or text is dragged), which
would cause the highlight to not be removed. Now those cases are handled
with the "dropnofiles" callback, which restores the UI and also shows a
message to the user.

The error message is just a generic one, as in some cases it is not even
possible to know whether the problem came from a text drag or a folder
drag, and whether the problem appears or not depends on the browser,
version and even operating system.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 19:15:28 +02:00
Daniel Calviño Sánchez bb64b6f87c Add callback to clean up after misbehaved drag and drop events
The jQuery Plugin triggers the "dragover" callback when the browser
triggers the "dragover" event and the types in their DataTransfer
include a "Files" item. It also triggers the "drop" callback when the
browser triggers the "drop" event and the list of files in its
DataTransfer is not empty.

Unfortunately some browsers may trigger "dragover" events with a
DataTransfer that includes a "Files" item and then trigger a "drop"
event with an empty list of files. When that happens the actions
performed in the "dragXXX" callbacks could be left hanging if they were
expected to be finished in the "drop" callback (for example, if the drop
zone was highlighted during the drag to be then restored when the file
was finally dropped). This commit adds the "dropnofiles" callback to be
able to handle those situations.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 19:15:27 +02:00
Daniel Calviño Sánchez 74ab68872f Remove duplicated code
"disableDropState" was set as the event handler in 8d4e5747f3, but
the duplicated code was accidentally added back in 786e858d23.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-06-08 11:10:46 +02:00
Nextcloud bot b34111bfc9
[tx-robot] updated from transifex 2018-06-08 00:12:51 +00:00
Nextcloud bot cc61c6ea15
[tx-robot] updated from transifex 2018-06-07 00:12:44 +00:00
Nextcloud bot bba1663350
[tx-robot] updated from transifex 2018-06-06 00:12:36 +00:00
Nextcloud bot a00cb2c5d7
[tx-robot] updated from transifex 2018-06-04 00:12:26 +00:00
Nextcloud bot 9ac36dc30b
[tx-robot] updated from transifex 2018-05-31 00:12:36 +00:00
Nextcloud bot 7df563ee39
[tx-robot] updated from transifex 2018-05-30 00:12:08 +00:00
Nextcloud bot 645eaaa434
[tx-robot] updated from transifex 2018-05-29 00:12:21 +00:00
Nextcloud bot f0fdac8078
[tx-robot] updated from transifex 2018-05-26 00:13:01 +00:00
Nextcloud bot 60734cd79d
[tx-robot] updated from transifex 2018-05-25 00:14:54 +00:00
Nextcloud bot 4bbad8f88a
[tx-robot] updated from transifex 2018-05-23 00:15:44 +00:00
Nextcloud bot 0d90c5ebc4
[tx-robot] updated from transifex 2018-05-22 00:13:31 +00:00
Nextcloud bot ca089b9412
[tx-robot] updated from transifex 2018-05-20 00:13:24 +00:00
Nextcloud bot 514b374923
[tx-robot] updated from transifex 2018-05-18 00:13:45 +00:00
Nextcloud bot ef665fde42
[tx-robot] updated from transifex 2018-05-17 00:13:46 +00:00
Nextcloud bot 5fcb3dd1dc
[tx-robot] updated from transifex 2018-05-12 00:13:00 +00:00
Nextcloud bot 01c21601e8
[tx-robot] updated from transifex 2018-05-10 00:13:09 +00:00
Morris Jobke d161d4473e
Merge pull request #9029 from nextcloud/settings-restructure
Restructure server settings
2018-05-07 12:29:53 +02:00
Julius Härtl 951ac518e1
Fix jsunit tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-07 11:19:50 +02:00
Julius Härtl 94528ad2be
Move quota icon to core
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 10:32:16 +02:00
Julius Härtl 35cb529df3
Fix settings tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:25 +02:00
Julius Härtl cea4c9d000
Move files settings to main server settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-05-03 08:58:23 +02:00
Roeland Jago Douma 0dc019370d
Merge pull request #9248 from nextcloud/fix-files-ellipsis
Fix ellipsis in filename column
2018-04-24 20:36:41 +02:00
Julius Härtl cbdaa8b7ce
Add min-width to trick the table width calculation in safari
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-22 23:09:15 +02:00
Daniel Calviño Sánchez 375a55b0ad
Fix race condition when preparing upload folder
Before any upload is submitted the upload is registered in a list of
known uploads; this is needed to retrieve the upload object at several
points of the upload process. When a chunked upload is submitted first a
directory to upload all the chunks is created and, once that is done,
the chunks are sent; in order to send a chunk the upload object needs to
be retrieved from the list of known uploads.

When all the active uploads were finished the list of known uploads was
cleared. However, an upload is not active until it actually starts
sending the data, so while waiting for the upload directory to be
created the upload is already in the list of known uploads yet not
active. Due to all this, if the active uploads finished while another
pending upload was waiting for the upload directory to be created that
pending upload would be removed from the list of known uploads too, and
once the directory was created and thus the chunks were sent a field of
a null upload object would be accessed thus causing a failure.

Instead of removing all the known uploads at once when the active
uploads finish now each upload is explicitly removed when it finishes.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-22 20:38:11 +02:00
Nextcloud bot 74b5ab8d39
[tx-robot] updated from transifex 2018-04-22 00:11:51 +00:00
Nextcloud bot 6b5132502e
[tx-robot] updated from transifex 2018-04-21 00:11:39 +00:00
Julius Härtl fb7d73708b
Use flex based layout inside the filename table cell
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-19 20:13:26 +02:00
Jan-Christoph Borchardt 0d675eca56
Ensure proper color contrast according to WCAG AA
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-04-18 15:38:30 +02:00