Thomas Müller
35b97ed672
Adding renameKeys to IStorage
2015-04-07 13:30:29 +02:00
Thomas Müller
4db75e3407
Setting up the encryption wrapper in a setup hook - temporarily fixes the wrapping order
2015-04-07 13:30:29 +02:00
Thomas Müller
bf809ac85a
Removing left overs from old encryption app
2015-04-07 13:30:29 +02:00
Thomas Müller
6ccd3ffa23
adding function getSecureRandom(); to IServerContainer
2015-04-07 13:30:29 +02:00
Bjoern Schiessle
0f28d538a0
add session class to handle all session operations
2015-04-07 13:30:28 +02:00
Thomas Müller
1b42b492dc
kill OC_FileProxy 💥
2015-04-07 13:30:28 +02:00
Thomas Müller
dbdd754c3f
Further cleanup of files_encryption
2015-04-07 13:30:28 +02:00
Thomas Müller
00338f9dca
Removing files_encryption left overs
2015-04-07 13:30:28 +02:00
Thomas Müller
99255ff3a9
Fix - public sharing: in case on user is available - get it from the path
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
0eee3a2618
remove unencrypted_size from the cache, size will contain the unencrypted size
2015-04-07 13:30:28 +02:00
Thomas Müller
d185761d31
initializing some variables + update size after writing the headers
2015-04-07 13:30:28 +02:00
Thomas Müller
4441835d18
https://github.com/owncloud/core/pull/15305#discussion_r27382305
...
Conflicts:
lib/private/files/stream/encryption.php
2015-04-07 13:30:28 +02:00
Thomas Müller
90487384f7
initializing some variables
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
0c48b069ba
call end() before closing the file
2015-04-07 13:30:28 +02:00
Thomas Müller
498625ea3a
adding unit tests for stream wrapper
2015-04-07 13:30:28 +02:00
Thomas Müller
a905f641b3
various fixes & start to unit test the encryption storage wrapper
2015-04-07 13:30:28 +02:00
jknockaert
3e6eb28ee3
Applying diff as of https://github.com/owncloud/core/pull/15303
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
a85e2e0bfd
make recovery settings work
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
937efe856d
fix lib/private/encryption/util.php call
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
c266b3b5b7
remove debug code from core
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
c64e0af4fb
check if recovery key exists and encrypt the file with the recovery key if needed
2015-04-07 13:30:28 +02:00
Bjoern Schiessle
2244ea998d
core: documentation fixes
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
cb9980823d
core: small fixes
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
810ca9105c
implement rename and delete of encryption keys
2015-04-07 13:30:27 +02:00
Clark Tomlinson
0c2f9ca849
Updating keystorage movement and fixing hooks
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
506222567e
add deleteKey methods to key storage
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
e2f714263f
fix encryption manager to handle more than one encryption module
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
5bc9ababeb
fix keystorage and add unit tests
2015-04-07 13:30:27 +02:00
Clark Tomlinson
39733c8da1
Initial commit
2015-04-07 13:30:27 +02:00
Bjoern Schiessle
63e7fe608a
create basic interfaces and wrapper to make encryption more modular
2015-04-07 13:30:27 +02:00
Joas Schilling
3bde7c2f67
When guessing the timezone, the offset might only be valid on a given timestamp
2015-04-07 10:13:06 +02:00
Jenkins for ownCloud
95e55aa4ad
[tx-robot] updated from transifex
2015-04-07 01:54:47 -04:00
Jenkins for ownCloud
2bff92ade5
[tx-robot] updated from transifex
2015-04-05 01:54:51 -04:00
Thomas Müller
4996706078
Merge pull request #15338 from owncloud/encryption-mount-option
...
Add mount point to disable the encryption wrapper
2015-04-04 12:51:41 +02:00
Jenkins for ownCloud
9b250baf9e
[tx-robot] updated from transifex
2015-04-04 01:54:43 -04:00
Robin McCorkell
fbb84a518f
Fix UrlGenerator::imagePath() for app paths
2015-04-03 23:42:18 +01:00
Thomas Müller
3bf269e565
Merge pull request #15229 from owncloud/response-setContentLengthHeader
...
Add OC_Response::setContentLengthHeader() for Apache PHP SAPI workaround...
2015-04-03 22:51:36 +02:00
Thomas Müller
b2b3e1ac94
Merge pull request #15391 from owncloud/fix-language-caching
...
fix caching of preferred language
2015-04-03 22:51:13 +02:00
Thomas Müller
3d2116dfe7
Merge pull request #15386 from oparoz/yaml-cnf-mediatype
...
Introducing media types for yml, yaml, cnf, conf
2015-04-03 22:49:41 +02:00
Robin Appelman
712e478cb2
fix caching of preferred language
2015-04-03 15:36:24 +02:00
Lukas Reschke
25531bad88
Make user names clickable
2015-04-03 13:36:03 +02:00
Lukas Reschke
0816cf9142
Add experimental applications switch
...
Allows administrators to disable or enabled experimental applications as well as show the trust level.
2015-04-03 13:21:24 +02:00
Morris Jobke
a2087f30d1
Merge pull request #15383 from owncloud/fix-exception-message
...
Update exception messages to better reflect and describe the problem
2015-04-03 10:15:23 +02:00
Jenkins for ownCloud
23f1702f24
[tx-robot] updated from transifex
2015-04-03 01:54:53 -04:00
Olivier Paroz
70ec74e88b
Introducing media types for yml, yaml, cnf, conf
2015-04-02 21:37:57 +02:00
Lukas Reschke
fa079a5959
Merge pull request #12314 from oparoz/patch-3
...
Make findBinaryPath compatible with open_basedir
2015-04-02 18:54:03 +02:00
Joas Schilling
a8d1ede347
Fix the exception messages
2015-04-02 18:40:06 +02:00
Thomas Müller
9f58097e4d
Merge pull request #14113 from owncloud/chunking-chunkpartfiles
...
Added part files for when writing chunks
2015-04-02 18:15:27 +02:00
Thomas Müller
4082436419
Merge pull request #15367 from owncloud/pre-setup-hook
...
setup storage wrappers before setting up the filesystem
2015-04-02 17:40:23 +02:00
Morris Jobke
1720fdf5f4
Merge pull request #15346 from oparoz/split-image-provider
...
Split image provider in one sub-class per media type
2015-04-02 13:40:09 +02:00
Robin Appelman
f585994c4b
setup mount manager before wrappers
2015-04-02 13:28:36 +02:00
Olivier Paroz
8ec6dfdbf8
Split image provider in one sub-class per media type
2015-04-02 10:31:24 +02:00
Morris Jobke
82f91c50c7
Merge pull request #15349 from oparoz/limit-bitmap-previews-2
...
The bitmap preview class now takes maxX and maxY into consideration
2015-04-02 10:23:55 +02:00
Thomas Müller
9e5b319ed4
Merge pull request #15362 from owncloud/issue/15359-purge-memcache-console-app-disable
...
Correctly purge the cache when an app is disabled via cli
2015-04-02 09:26:15 +02:00
Joas Schilling
696c750cfe
Fix docs and line breaks
2015-04-02 08:28:42 +02:00
Jenkins for ownCloud
cc96105ebe
[tx-robot] updated from transifex
2015-04-02 01:54:47 -04:00
Robin Appelman
3cb53b7756
setup storage wrappers before setting up the filesystem
2015-04-01 17:12:06 +02:00
Olivier Paroz
1525ecd3dd
The bitmap preview class now takes maxX and maxY into consideration
...
This is a fix for owncloud#13607 and is part of the global programme: owncloud#13609
The image aspect ratio is kept intact.
2015-04-01 15:54:22 +02:00
Joas Schilling
d01cfde982
Correctly purge the cache when an app is disabled via cli
2015-04-01 15:43:38 +02:00
Roeland Jago Douma
288da619b1
Deprecate functions that only call the urlgenerator anyway
2015-04-01 14:32:49 +02:00
Joas Schilling
730efe25a4
Make scrutinizer happy
2015-04-01 12:13:49 +02:00
Pierre Jochem
a1828ff034
More secure proposal
2015-04-01 11:28:53 +02:00
Jenkins for ownCloud
f5c7ba6b81
[tx-robot] updated from transifex
2015-04-01 01:55:33 -04:00
Olivier Paroz
0f01de9f7e
Use getenv to get the paths for `find`
2015-03-31 23:49:21 +02:00
Olivier Paroz
7c41c0c13f
use ExecutableFinder and find in findBinaryPath
...
When using open_basedir, commands such as `which`or `command`can fail
because they might try to look outside of the restricted perimeter.
Symfony's ExecutableFinder can be used instead to look in standard
locations and we can use `find` as a last resort
A better solution would be to adopt a mechanism similar to what has
been done for office documents where a configuration parameter is used
to indicate the path where the executable is to be found.
2015-03-31 23:49:16 +02:00
Robin Appelman
bac9b54bef
Add mount point to disable the encryption wrapper
2015-03-31 16:25:33 +02:00
Robin Appelman
068c624b0d
fix copying folder across devices
2015-03-31 13:50:11 +02:00
Jenkins for ownCloud
1d06d93d27
[tx-robot] updated from transifex
2015-03-31 01:55:55 -04:00
Roeland Jago Douma
0bf06d6691
No injections
2015-03-30 20:07:12 +02:00
Morris Jobke
bf17ac929d
Merge pull request #15169 from rullzer/fix_displayNamesInGroup
...
Groupmanagers displayNamesInGroup should actually search in displaynames
2015-03-30 17:04:09 +02:00
Joas Schilling
b95d12700c
Add logic for getting the user from the rss token to the Manager
2015-03-30 15:23:09 +02:00
Roeland Jago Douma
b0aa17b13f
OCS Fixes to allow setting of password without removing additional settings
...
- Added setPassword to share.php
- Fixed OCS API call
- Added unit tests
2015-03-30 14:00:50 +02:00
Robin McCorkell
4f0abd910c
Merge pull request #15269 from owncloud/migrate-checksetup-and-add-memcache
...
Add check for activated local memcache
2015-03-30 11:24:44 +01:00
Jenkins for ownCloud
da55ff630c
[tx-robot] updated from transifex
2015-03-30 01:54:41 -04:00
Lukas Reschke
65202d2a18
Add check for activated local memcache
...
Also used the opportunity to refactor it into an AppFramework controller so that we can unit test it.
Fixes https://github.com/owncloud/core/issues/14956
2015-03-28 13:59:22 +01:00
Vincent Petry
d3752ca1e9
Merge pull request #15289 from owncloud/min-upload-limit
...
Require minimum 1 MiB upload limit
2015-03-28 11:34:11 +01:00
Robin McCorkell
ab991458ad
Require minimum 1 MiB upload limit
2015-03-27 23:43:35 +00:00
Robin McCorkell
1511a42da7
Check for relative datadirectory path
2015-03-27 23:29:46 +00:00
Vincent Petry
a32c71d25e
Revert "Deprecated \OCP\IAppConfig - add missing methods to IConfig"
...
This reverts commit 012016d331
.
2015-03-27 18:50:11 +01:00
Morris Jobke
f4dc9e6bf3
Merge pull request #15155 from owncloud/share-donotreturntrashedfiles
...
Do not return shares for files outside "files"
2015-03-27 17:05:14 +01:00
Thomas Müller
4d12c4a38b
Merge pull request #13938 from owncloud/deprecate-iappconfig
...
Deprecated \OCP\IAppConfig - add missing methods to IConfig
2015-03-27 16:07:41 +01:00
Thomas Müller
722e50a112
Merge pull request #15240 from owncloud/storage-wrapper-priority
...
add priority to storage wrappers
2015-03-27 15:18:44 +01:00
Thomas Müller
98bc1ad70a
Merge pull request #15265 from owncloud/enc2_fixes
...
core improvements for Encryption 2.0
2015-03-27 14:58:33 +01:00
Morris Jobke
e918bcf212
Merge pull request #15247 from owncloud/fix_group_share_master_backport
...
also call generateTarget for group shares
2015-03-27 14:40:52 +01:00
Vincent Petry
80f83ab5e0
Do not return shares for files outside "files"
2015-03-27 13:25:23 +01:00
Vincent Petry
7ad4dfa201
Merge pull request #15227 from owncloud/ocetag-header
...
Copy Etag header to OC-Etag for sabre calls
2015-03-27 13:10:27 +01:00
Bjoern Schiessle
b5fad75e57
add deleteAllFileKeys to public interface and add "uid" as parameter for the
...
update call
2015-03-27 11:51:53 +01:00
Bjoern Schiessle
c6be1ba8d3
fix check if a file is excluded from encryption or not
2015-03-27 11:51:50 +01:00
Morris Jobke
a62f38a18b
Merge pull request #15225 from owncloud/make-setups-for-users-that-tend-to-use-owncloud-on-not-proper-machines-a-little-bit-more-secure
...
Add some generic default headers as well via PHP
2015-03-27 09:54:40 +01:00
Jenkins for ownCloud
880b31c513
[tx-robot] updated from transifex
2015-03-27 01:56:21 -04:00
Lukas Reschke
9622fbdf29
Filter potential dangerous characters in path name
...
We should not allow / or \ in the postfix here.
2015-03-26 23:17:18 +01:00
Vincent Petry
670ca68453
Added stat cache for DAV storage
...
The stat cache stored known states of files/folders to avoid requerying
the DAV server multiple times.
2015-03-26 23:15:53 +01:00
Vincent Petry
746be98e03
Merge pull request #13654 from oparoz/tmpfile-with-extension
...
Keep the extension in temp files
2015-03-26 23:08:08 +01:00
Robin McCorkell
c2909355bf
Merge pull request #14925 from owncloud/ext-mountoptions-ui
...
Mount options GUI for external storage
2015-03-26 21:36:34 +00:00
Lukas Reschke
9d1ce53cb1
Add some generic default headers as well via PHP
2015-03-26 22:32:57 +01:00
Bjoern Schiessle
223cca2a07
also call generateTarget for group share to add the correct prefix if share_folder is defined in config.php
2015-03-26 22:31:45 +01:00
Morris Jobke
e8109f0bc3
Merge pull request #13802 from owncloud/share-partfilepermissions
...
Fix share permission checks
2015-03-26 22:01:05 +01:00
Morris Jobke
4c00be4961
Merge pull request #14488 from owncloud/enhancement/security/inline-disposition
...
Serve all files with a Content-Disposition of 'attachment' via WebDAV
2015-03-26 21:45:30 +01:00
Robin Appelman
cb9ead7dde
add priority to storage wrappers
2015-03-26 21:26:38 +01:00
Thomas Müller
232518ac54
Merge pull request #15234 from owncloud/encryption2_core
...
core part of encryption 2.0
2015-03-26 21:14:59 +01:00
Bjoern Schiessle
ff9c85ce60
implement basic encryption functionallity in core to enable multiple encryption modules
2015-03-26 20:56:51 +01:00
Lukas Reschke
8ebe667202
Remove unneeded argument
2015-03-26 20:45:39 +01:00
Lukas Reschke
74a9fc29b4
Merge pull request #14399 from owncloud/ignore-empty-plurals
...
Ignore empty plurals just like with singulars
2015-03-26 20:15:33 +01:00
Lukas Reschke
55fd0082aa
Serve all files with a Content-Disposition of 'attachment' via WebDAV
...
As an additional security hardening it's sensible to serve these files with a Content-Disposition of 'attachment'. Currently they are served 'inline' and get a "secure mimetype" assigned in case of potential dangerous files.
To test this change ensure that:
- [ ] Syncing with the Desktop client still works
- [ ] Syncing with the Android client still works
- [ ] Syncing with the iOS client still works
I verified that the 1.8 OS X and iOS client still work with this change.
2015-03-26 20:01:05 +01:00
Lukas Reschke
c8c722bc6d
Merge pull request #15129 from owncloud/version-command-bus
...
expire versions in a background command
2015-03-26 19:55:13 +01:00
Lukas Reschke
3e57e9d3e5
Merge pull request #15232 from owncloud/remove-arg-separator-magic
...
Remove custom `arg_separator.output`
2015-03-26 19:41:22 +01:00
Morris Jobke
70e64822b9
Merge pull request #14665 from owncloud/fileid-increment
...
SQLite autoincrement test
2015-03-26 19:36:18 +01:00
Vincent Petry
58b4c2c0e5
Make sure mountOptions keep their data type
...
str_replace for $user substitution was converting the data type of
mountOptions to string. This fix prevents this to happen by making sure
only strings are processed by substitution.
Also added a int conversion when reading the watcher policy
2015-03-26 19:24:37 +01:00
Thomas Müller
a8b756154a
Merge pull request #14495 from owncloud/update-mailmap-01
...
Updating .mailmap
2015-03-26 17:17:18 +01:00
Lukas Reschke
73af302d39
Remove custom `arg_separator.output`
...
This seems unrequired nowadays and like a legacy fragment. It should be safe to remove.
Fixes https://github.com/owncloud/core/issues/14782
2015-03-26 17:07:26 +01:00
Robin Appelman
8c903c100f
check limit of serialized command in unit tests
2015-03-26 17:07:02 +01:00
Robin Appelman
268f249e8d
ensure commands can be serialized in unit tests
2015-03-26 17:07:02 +01:00
Robin Appelman
ddd6a67d2a
Handle exceptions thrown during hooks when running unit tests
2015-03-26 17:07:02 +01:00
Robin Appelman
3ed6ed3c36
Force test cases using background commands to handle setting up the filesystem
2015-03-26 17:07:02 +01:00
Andreas Fischer
0f58315543
Add OC_Response::setContentLengthHeader() for Apache PHP SAPI workaround.
...
Do not send Content-Length headers with a value larger than PHP_INT_MAX
(2147483647) on Apache PHP SAPI 32-bit. PHP will eat them and send 2147483647
instead.
When X-Sendfile is enabled, Apache will send a correct Content-Length header,
even for files larger than 2147483647 bytes. When X-Sendfile is not enabled,
ownCloud will not send a Content-Length header. This prevents progress bars
from working, but allows the actual transfer to work properly.
2015-03-26 16:37:38 +01:00
Joas Schilling
39dbf9509b
Merge pull request #15224 from owncloud/issue/15191-app-code-checker-error-list
...
Correctly only send the errors of the current file to the event
2015-03-26 16:35:46 +01:00
Vincent Petry
70acd58336
Copy Etag header to OC-Etag for sabre calls
2015-03-26 16:06:43 +01:00
Joas Schilling
db763027bb
Correctly only send the errors of the current file to the event
2015-03-26 15:33:31 +01:00
Vincent Petry
a84ade5f32
Revert "adding OC-ETag header"
...
This reverts commit 30ee8b6f99
.
2015-03-26 15:04:41 +01:00
Vincent Petry
daceb1a9ac
Revert "adding unit tests"
...
This reverts commit 8d327c94a8
.
2015-03-26 15:04:36 +01:00
Vincent Petry
cda7f7fd61
Merge pull request #15168 from owncloud/oc-etag-master
...
adding OC-ETag header
2015-03-26 13:52:43 +01:00
Lukas Reschke
468456e168
Merge pull request #14125 from dratini0/master
...
[nginx] Extending X-Accel-Redirect support
2015-03-26 13:35:00 +01:00
Jenkins for ownCloud
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
Morris Jobke
20f5290462
Merge pull request #15195 from owncloud/reanimate-add-guzzle
...
Add wrapper for Guzzle
2015-03-26 11:06:48 +01:00
Thomas Müller
c8f0cbab5a
Merge pull request #15194 from owncloud/fix-15146
...
Do not use APCu when apc.enabled is Off.
2015-03-26 11:03:36 +01:00
Vincent Petry
f056558b72
Add repair step to fix SQLite autoincrement
...
Force Doctrine to generate alter table SQL statements for SQLite to make
sure the code from OCSqlitePlatform is triggered.
2015-03-26 11:00:22 +01:00
Thomas Müller
8d327c94a8
adding unit tests
2015-03-26 10:49:26 +01:00
Jenkins for ownCloud
40b77eb97a
[tx-robot] updated from transifex
2015-03-26 01:55:29 -04:00
Morris Jobke
24d0dfc727
Revert "FIX for webdav.mediencenter.t-online.de"
2015-03-26 00:56:06 +01:00
Oliver Kohl D.Sc.
9323285987
FIX for webdav.mediencenter.t-online.de
...
https://webdav.mediencenter.t-online.de returns invalid response code.
e.g.
{"reqId":"f9a1c394b98108e4e5ca62bf47829c64","remoteAddr":"81.189.45.224","app":"PHP","message":"Undefined offset: 2 at \/var\/www\/owncloud\/3rdparty\/sabre\/dav\/lib\/Sabre\/DAV\/Client.php#569","level":3,"time":"2015-03-25T18:25:48+00:00","method":"GET","url":"\/index.php\/apps\/files\/ajax\/getstoragestats.php?dir=External%2FT-Cloud%2FTests"}
e.g.
{"reqId":"3407d66672b3cef206b0af883e49bff4","remoteAddr":"46.74.125.245","app":"PHP","message":"Undefined index: {DAV:}getlastmodified at \/var\/www\/owncloud\/lib\/private\/files\/storage\/dav.php#563","level":3,"time":"2015-03-25T16:33:21+00:00"}
2015-03-25 21:29:29 +01:00
Robin Appelman
ac8254de6a
Rename platform
2015-03-25 18:33:21 +01:00
Robin Appelman
24a30c10d7
Add custom sqlite platform to set auto increment
2015-03-25 18:33:21 +01:00
Lukas Reschke
5f044ebf1b
Add wrapper for Guzzle
2015-03-25 16:04:41 +01:00
Andreas Fischer
630b7edc54
Do not use APCu when apc.enabled is Off.
2015-03-25 14:52:01 +01:00
Jenkins for ownCloud
fb61889490
[tx-robot] updated from transifex
2015-03-25 01:55:46 -04:00
Thomas Müller
43beaba0dc
Merge pull request #15171 from owncloud/sabre-logforbiddenasdebug
...
Log forbidden in debug level
2015-03-24 23:31:35 +01:00
Lukas Reschke
ec12f5e019
Merge pull request #14949 from owncloud/sabre-2.1.3
...
Update sabre-2.1.3 thirdparty submodule
2015-03-24 23:16:57 +01:00
Vincent Petry
72c1c89bcd
Log forbidden in debug level
2015-03-24 22:08:11 +01:00
Thomas Müller
30ee8b6f99
adding OC-ETag header
2015-03-24 21:36:46 +01:00
Roeland Jago Douma
abfb524b29
When searching for displayname then search for displayname
2015-03-24 21:35:44 +01:00
Lukas Reschke
5a9c9b86f8
Merge pull request #15153 from owncloud/uniquename-node
...
Add `getNonExistingName()` to the node api
2015-03-24 15:51:12 +01:00
Robin Appelman
d11f01fa0f
Add `getNonExistingName()` to the node api
2015-03-24 15:00:36 +01:00
Vincent Petry
331f0196e0
Merge pull request #15150 from owncloud/sabre-removerangeexceptionforencryption
...
Remove range header exception for encryption
2015-03-24 14:29:01 +01:00
Morris Jobke
92791bb8ba
Merge pull request #15126 from owncloud/sabre-storagenotavailable
...
Soft fail in CustomPropertiesBackend whenever storage not available
2015-03-24 14:01:47 +01:00
Joas Schilling
5e71d1558a
Merge pull request #15149 from owncloud/fix-enable-for-group
...
Correctly get array of groups and send OCP\IGroup objects to enable meth...
2015-03-24 13:50:56 +01:00
Vincent Petry
302c19067a
Merge pull request #15145 from owncloud/fix-15097-master
...
Properly catch whether a share is `null`
2015-03-24 13:37:47 +01:00
Vincent Petry
46475bf580
Merge pull request #15003 from owncloud/issue/14859-speed-up-favorite-list
...
Do not walk over the users directory, but over the list of tagged objects
2015-03-24 13:26:59 +01:00
jknockaert
a1b68b5a48
Remove range header exception for encryption
...
revert #10422
2015-03-24 13:19:49 +01:00
Joas Schilling
b262c30fa9
Correctly get array of groups and send OCP\IGroup objects to enable method
2015-03-24 12:56:42 +01:00
Lukas Reschke
e2453d78c0
Properly catch whether a share is `null`
...
Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory.
To test this perform the following steps:
* Share file in owncloud 7 (7.0.4.2)
* Delete the parent folder of the shared file
* The share stays is in the DB and the share via the sharelink is inaccessible. (which is good)
* Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones)
* Optional Step: Logout, Reset Browser Session, etc.
* Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL.
* Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file)
* No exception is thrown and no error is logged.
This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8.
Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so.
Fixes https://github.com/owncloud/core/issues/15097
2015-03-24 11:21:58 +01:00
Jenkins for ownCloud
9cb07f126d
[tx-robot] updated from transifex
2015-03-24 01:55:24 -04:00
dratini0
d4e5ef4f38
Removed simplified X-accel-redirect even further
2015-03-23 17:51:12 +01:00
Vincent Petry
eb894e6625
Soft fail in CustomPropertiesBackend whenever storage not available
...
When a storage is not available, it will not fail the whole call any
more but still return a usable file list.
2015-03-23 17:41:32 +01:00
Morris Jobke
0adcb99110
Merge pull request #14862 from owncloud/introduce-shipped.json-master
...
shipped apps are now defined in core/shipped.json - the shipped tag in i...
2015-03-23 17:17:33 +01:00
dratini0
c432b52c74
Changed the disputed while loop to a single if.
2015-03-23 16:12:03 +01:00
Joas Schilling
1a26263123
Do not walk over the users directory, but over the list of tagged objects
...
Way quicker
2015-03-23 15:10:58 +01:00
Jenkins for ownCloud
a9b4f0d842
[tx-robot] updated from transifex
2015-03-23 01:54:48 -04:00
Morris Jobke
21bc8e0c81
Merge pull request #15088 from oparoz/3d-support
...
Introducing 3D images support (media type)
2015-03-22 23:14:02 +01:00
Jenkins for ownCloud
a79d973005
[tx-robot] updated from transifex
2015-03-22 01:55:21 -04:00
Jenkins for ownCloud
e36a33c89a
[tx-robot] updated from transifex
2015-03-21 01:56:09 -04:00
Olivier Paroz
f3fe46685b
Introducing 3D images support (media type)
...
So that people with 3D images can at least see a 2D picture
Full 3D support is possible via an app
2015-03-20 22:11:42 +01:00
Thomas Müller
afa8872955
Merge pull request #14857 from owncloud/preview-provider-registration-in-manager
...
Preview provider registration in manager
2015-03-20 16:34:22 +01:00
Morris Jobke
a45e45df1e
Merge pull request #14941 from AdamWill/pipeline-apps
...
fall back to absolute path for pipelined assets (#14940 )
2015-03-20 14:56:02 +01:00
Thomas Müller
0b1c4bfc3b
Merge pull request #15062 from owncloud/fix-15053-master
...
Handle session initialization errors and display error page
2015-03-20 14:07:15 +01:00
Vincent Petry
67160e0861
Do not automatically add "update" permission to shared mounts
...
In the past it seems the update permission was needed to be able to
rename shared mounts, but it doesn't seem to be the case any more.
Removing the "update" permission that used to be added automatically
fixes the read-only permission check when trying to overwrite a
read-only file over WebDAV.
2015-03-20 12:33:59 +01:00
Thomas Müller
843fef0490
Handle session initialization errors and display error page - fixes #15053
2015-03-20 12:21:03 +01:00
Thomas Müller
a87cc90d1e
Merge pull request #14993 from owncloud/stop-on-missing-deps
...
Stop executing, when 3rdparty is missing or apps directory is invalid
2015-03-20 11:36:02 +01:00
Thomas Müller
cce303ff5c
Merge pull request #15047 from owncloud/connect-failed-exception-message
...
be a little more verbose in the exception message when we cant connect to...
2015-03-20 10:06:06 +01:00
Robin McCorkell
b6676c32d6
Merge pull request #15046 from owncloud/exception-show-type
...
show exception type in debug mode
2015-03-20 08:48:22 +00:00
Morris Jobke
1de6fa19de
Merge pull request #15035 from owncloud/assocmapper
...
If the execute method on the mapper receives an assoc array, it binds by...
2015-03-20 08:53:14 +01:00
Robin Appelman
faa4918355
be a little more verbose in the exception message when we cant connect to the db
2015-03-20 03:56:38 +01:00
Robin Appelman
2df20aaffb
show exception type in debug mode
2015-03-20 03:51:21 +01:00
Vincent Petry
5ba508b346
Fix permission checks in Sabre connector
...
This fixes moving files in and out of shared folders with some exotic
permission combinations.
2015-03-19 21:18:48 +01:00
Morris Jobke
2a8c3798a8
Merge pull request #14947 from oparoz/repairmimetypes-sql
...
Make repairmimetypes compatible with case sensitive SQL backends
2015-03-19 17:22:25 +01:00
Bernhard Posselt
df24a014b8
If the execute method on the mapper receives an assoc array, it binds by value instead of index
2015-03-19 17:08:46 +01:00
Thomas Müller
857b22c61b
Merge pull request #15025 from rullzer/ocs_respect_enforced_date
...
Ocs respect enforced date
2015-03-19 17:06:04 +01:00
Thomas Müller
3765af4edf
Merge pull request #14986 from owncloud/fixmapperbackw
...
Fix backwards compatibility for mapper execute method
2015-03-19 17:04:01 +01:00
Robin Appelman
73874ca27f
Merge pull request #14704 from owncloud/storage-wrapper-mount
...
pass mountpoint to storage wrapper callback
2015-03-19 16:20:38 +01:00
Olivier Paroz
f890c3ffb1
Make the method compatible with all types of extensions
...
Fix existing tests
2015-03-19 16:09:16 +01:00
Olivier Paroz
60b1643f02
Fix the office class
...
The office converter already replaces the original extension with '.pdf', so we need to switch the extensions of the tmp file instead of appending '.pdf' to it
2015-03-19 16:09:09 +01:00
Olivier Paroz
8d6b2b8867
Keep the extension in temp files
...
The file extension helps some applications like ImageMagick to properly
process files
2015-03-19 16:09:02 +01:00
Thomas Müller
0868e49663
Merge pull request #14980 from owncloud/fix-fileglobalgc
...
Fix fileglobalgc unlink parameter warnings
2015-03-19 14:17:20 +01:00
Roeland Jago Douma
3c39658a1c
When the expiration date is enforced respect this
...
Make sure that we do not allow removing of the expiration date when this
is enforced in the settings.
2015-03-19 10:07:17 +01:00
Jenkins for ownCloud
e40b0701d7
[tx-robot] updated from transifex
2015-03-19 01:55:06 -04:00
Bernhard Posselt
f77ae37f23
also use backwards compatible method for mapper
2015-03-18 22:20:23 +01:00
Vincent Petry
fe8002a7db
Merge pull request #14995 from owncloud/remove-unrequired-backtick-removal
...
Remove unrequired backtick removal
2015-03-18 19:34:49 +01:00
Robin McCorkell
693ca9a92f
Add unit tests for gc() for \OC\Cache\FileGlobalGC
2015-03-18 16:19:04 +00:00
Robin Appelman
e2e16249a1
Merge pull request #14999 from owncloud/kill-fileoperations-proxy
...
kill fileoperations proxy
2015-03-18 15:42:00 +01:00
Lukas Reschke
7310575f07
Merge pull request #14994 from owncloud/sabre-customprops-softfail
...
Soft fail in custom properties backend
2015-03-18 15:39:35 +01:00
Robin Appelman
8f9ddef435
kill fileoperations proxy
...
check is now handled by storage backends
2015-03-18 15:04:28 +01:00
Morris Jobke
378eef7eb4
migrate share helper method to IConfig
2015-03-18 13:07:39 +01:00
Lukas Reschke
bb5c5a3691
Remove unreqired backtick removal
...
Without this files with a ` (backtick) in the beginning of the filenames where simply not correctly referenced as the ` got removed. This can lead to all possible havoc situations.
Should get backported to stable8 and in future we might consider if it is really worth to backport such changes when it is just for SQLite 🙈
Regression of https://github.com/owncloud/core/pull/14734
2015-03-18 12:38:19 +01:00
Vincent Petry
50194c31b4
Soft fail in custom properties backend
...
This makes it possible for clients to still receive a file list (minus
the broken files) instead of getting no list at all
2015-03-18 12:36:37 +01:00
Joas Schilling
0bed187613
Stop executing, when 3rdparty is missing or apps directory is invalid
2015-03-18 11:58:18 +01:00
Lukas Reschke
917cb66a5b
Use ArrayCache if ownCloud is not installed
...
If ownCloud has not been installed yet the prefix might otherwise change at this point quite some time and thus the cache runs havoc.
This made installing ownCloud impossible on systems where APCu or so was available. However, I was not able to reproduce the same problem for application upgrades so this patch seems to work fine for this situation as well.
Fixes itself.
2015-03-18 11:47:16 +01:00
Bernhard Posselt
c52bd10361
fix backwards compatibility for mapper execute method
2015-03-18 09:25:22 +01:00
Jenkins for ownCloud
8a95bf18b7
[tx-robot] updated from transifex
2015-03-18 01:55:22 -04:00
Robin McCorkell
42fcd0e8b7
Fix fileglobalgc unlink parameter warnings
2015-03-18 00:07:18 +00:00
Thomas Müller
c69cd28a73
Merge pull request #14968 from owncloud/files-reallowsinglequote
...
Reallow single quote in file names
2015-03-17 23:50:16 +01:00
Thomas Müller
a4d2c7810e
Merge pull request #14975 from owncloud/add-smtp-debug-mode
...
Add debug mode back to mailer
2015-03-17 23:49:19 +01:00