mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
53,605 Commits 349 Branches 696 Tags 1.6 GiB
Commit Graph

22369 Commits

Author SHA1 Message Date
Arthur Schiwon 4babdc082b
formatting 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-23 21:34:05 +02:00
Julius Härtl 6709833dc7
Use paginated search for contacts 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-23 19:08:16 +02:00
blizzz 24e58947d6
Merge pull request #20618 from nextcloud/bugfix/noid/fix-workflow-ui 
Fix workflow UI
 2020-04-23 17:16:33 +02:00
Joas Schilling 335b1f15f3
Fix workflow UI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-23 13:52:04 +02:00
Robin Appelman 7a4ea4a6b6
make php-cs happy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-23 13:35:30 +02:00
Nextcloud bot 79e3823d72
[tx-robot] updated from transifex 2020-04-23 02:16:54 +00:00
blizzz 4a8871f5f2
Merge pull request #19399 from nextcloud/smb-read-acl 
Add option to check share ACL's when listing directories
 2020-04-22 23:16:12 +02:00
Roeland Jago Douma 8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag 
Make sure that OC-ETag is set again
 2020-04-22 22:21:22 +02:00
John Molakvoæ d0a57a33a9
Merge pull request #20595 from nextcloud/fix/ie11-fallback-upload 
Fix IE11 upload fallback methods
 2020-04-22 22:06:56 +02:00
Morris Jobke f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions 
Fix Sharing recommendation user display
 2020-04-22 14:56:01 +02:00
Roeland Jago Douma acdc68e1e2
Merge pull request #20591 from nextcloud/fix/settings 
Fix settings routing
 2020-04-22 14:45:25 +02:00
Robin Appelman 7f32fe6d50
add tooltip to option 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-22 14:25:33 +02:00
John Molakvoæ (skjnldsv) 754fd40e40
Fix IE11 upload fallback methods 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-04-22 13:40:23 +02:00
Morris Jobke 8ffa762486
Merge pull request #20536 from nextcloud/fix/noid/ldap-73api-read-wo-pagedresults 
do not run paged results against ldap_read ops on PHP7.3+
 2020-04-22 13:37:43 +02:00
Roeland Jago Douma e983ae3b06
Add folder argument to files:scan-app-data 
If you need to rescan something but don't feel like rescanning your
whole preview stash.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-22 13:27:33 +02:00
Roeland Jago Douma c870b6ab2e
Fix new routing in settings etc 
Also prefix resources
Unify the prefix handling
Handle urls with and without slash

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-22 13:09:25 +02:00
Nextcloud bot ac57bbcf99
[tx-robot] updated from transifex 2020-04-22 02:17:06 +00:00
Robin Appelman 23e2baeb95
Add option to check share ACL's when listing directories 
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-21 16:26:12 +02:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls 
Allow some apps to have root URLs in their own routing file
 2020-04-21 16:00:34 +02:00
Arthur Schiwon 75c686d825
do not run paged results against ldap_read ops on PHP7.3+ 
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-21 15:47:49 +02:00
Julius Härtl 5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-21 14:35:29 +02:00
Julius Härtl 45c3ee7f36
Set proper share type when converting link shares to federated shares 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-21 14:35:28 +02:00
Daniel Kesselberg 0e925285b7
Add test that shares and tags are ignored for chunk files. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-04-21 14:00:52 +02:00
Roeland Jago Douma aa79f9ada2
Merge pull request #20577 from nextcloud/bugfix/noid/sabre4_aftermethod 
Fix usages of afterMethod -> afterMethod:*
 2020-04-21 13:26:13 +02:00
Morris Jobke 89bd8ea449
Merge pull request #20564 from go2sh/fix_fileinfo 
Set fileInfo correctly for LegacyTabs
 2020-04-21 12:24:54 +02:00
Roeland Jago Douma 8730cc6764
Use a proper upload file so propfinds return 404 
Fixes #20235

By using an UploadFile we make sure that we don't need to have another
check everywhere for the path. But we just have ot check (which we have
to anyway) if it is a proper Connector/File (or directory).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-21 10:33:28 +02:00
Georg Ehrke effcd58e14
Fix usages of afterMethod -> afterMethod:* 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-04-21 10:19:06 +02:00
Roeland Jago Douma 4ee56689a8
Make sure that OC-ETag is set again 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-21 10:14:31 +02:00
John Molakvoæ (skjnldsv) 7eceba7dae Fix Sharing recommendation user display 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-21 07:48:10 +00:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata 
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-20 15:45:04 +02:00
Nextcloud bot b1a90da347
[tx-robot] updated from transifex 2020-04-20 02:16:12 +00:00
Christoph Seitz c9e0ea525b Set fileInfo correctly for LegacyTabs 
Watch for changes of the fileInfo prop and propagate it to,
the underlying component.

Fixes #20106.

Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de>
 2020-04-19 22:56:30 +02:00
Nextcloud bot e9930aebc7
[tx-robot] updated from transifex 2020-04-19 02:16:10 +00:00
Joas Schilling 1b93d5f1db
PHP CS fixes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling 685d7b0637
Directly use the class to get the service 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling 031b6656d1
Reduce noise in test output 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling 9654a924ab
Fix route definitions of cloud_federation_api 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling e45c87cd2e
Fix creating the share controller 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling 708b4991d9
Fix legacy routes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling f93d55eebd
PHP CS fixes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Joas Schilling 3f8168b6e5
Allow some apps to have root URLs in their own routing file 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-18 11:21:28 +02:00
Roeland Jago Douma 64196ddd19
Merge pull request #20449 from liamjack/fix/19066/empty_file_versions 
Array offset error due to empty file versions array
 2020-04-18 10:54:19 +02:00
Roeland Jago Douma ad603fd13a
Merge pull request #20540 from nextcloud/fix/mail-test 
Fix mailer test
 2020-04-18 10:34:04 +02:00
Roeland Jago Douma 2fc35d10e4
Added trailing space 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-18 10:26:35 +02:00
Nextcloud bot 148bdabd58
[tx-robot] updated from transifex 2020-04-18 02:16:28 +00:00
Arthur Schiwon ab550d682f
do not rerun expensive sanitizer against already processed DNs 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:49:47 +02:00
Arthur Schiwon 32000dd1af
read records from DB for lists at once, not one by one. 
Keep a runtime cache of dn-id-mapping

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:39:54 +02:00
Arthur Schiwon cc31c38277
don't circulate with only one backend 
- saves some overhead costs
- in some occasions saves LDAP requests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:38:52 +02:00
Arthur Schiwon e8ddb4718c
consolidate groupsMatchFilter in groupsExist 
- less duplication
- profiting of the same cache entry

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-17 12:38:07 +02:00
Roeland Jago Douma ed56619a20
Merge pull request #19901 from nextcloud/bugfix/noid/vcard-photo-handling 
Improved vcard photo handling
 2020-04-17 11:43:20 +02:00
John Molakvoæ 7c4b7e9329
Merge pull request #20529 from nextcloud/fix/Card-multiple 
Update list of multiple properties
 2020-04-17 10:39:19 +02:00
John Molakvoæ 36f9ad32f2
Merge pull request #20447 from liamjack/fix/13287/welcome_email 
Increase max-height on button in welcome email template
 2020-04-17 09:42:49 +02:00
John Molakvoæ (skjnldsv) 29541322c1
Update list of multiple properties 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2020-04-17 09:38:47 +02:00
Morris Jobke 9bd9c2bf32
Merge pull request #20381 from nextcloud/fix/allow_edit_admin_user 
Allow to edit admin user
 2020-04-17 09:06:58 +02:00
Nextcloud bot a8809f079b
[tx-robot] updated from transifex 2020-04-17 02:16:31 +00:00
GretaD d17c58eeec
Allow to edit admin user 
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-04-16 11:59:01 +02:00
Roeland Jago Douma 8971403ada
Merge pull request #20511 from nextcloud/fix/cs-fixer-ldap 
PHP-CS-Fixer green
 2020-04-16 10:37:49 +02:00
Roeland Jago Douma d9990b09b8
PHP-CS-Fixer green 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:25:17 +02:00
Roeland Jago Douma bb4dedb015
Provide the proper language to the mailer 
Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-16 09:04:13 +02:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Georg Ehrke fe4527a8e2
Update Contact Size after removing photo 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-04-15 15:49:49 +02:00
Joas Schilling 648c8df516
Don't populate the PHOTO property when it's not an image 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-15 15:49:39 +02:00
Joas Schilling bb754cb363
Always transform the etag and read the data 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-15 15:49:36 +02:00
Joas Schilling 2e9f105786
Use table variable everywhere 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-15 15:49:12 +02:00
Arthur Schiwon 73271aa086
DAV's exception logger should deal with any Throwable 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-15 15:28:37 +02:00
blizzz 8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1 
do not use deprecated API for LDAP paged results
 2020-04-15 15:02:51 +02:00
Morris Jobke d8557d0d8a
Merge pull request #19540 from jlutran/fixKeystoneV3Auth 
Fix issues with Keystone auth v3 in files_external app
 2020-04-15 14:05:32 +02:00
Joas Schilling 5c0637bc90
Merge pull request #20138 from nextcloud/bugfix/noid/make-remote-checking-more-generic 
Make remote checking more generic
 2020-04-15 12:48:49 +02:00
Roeland Jago Douma 19171d77e2
Merge pull request #19191 from laurisb/patch-1 
Improve Opcache detection
 2020-04-15 11:03:05 +02:00
Julien Lutran 3e849daf11
Fix issues with Keystone auth v3 in files_external app 
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
 2020-04-15 10:33:08 +02:00
Roeland Jago Douma d63abebc93
Merge pull request #19351 from nextcloud/dav-upload-hash 
Return hashes of uploaded content for dav uploads
 2020-04-15 10:23:22 +02:00
Roeland Jago Douma b212151af1
Merge pull request #20476 from nextcloud/techdebt/php-cs-check-action 
Add php-cs check action
 2020-04-15 08:30:29 +02:00
Joas Schilling fd0c1a3bb2
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-15 08:06:51 +02:00
Nextcloud bot bccd13ffae
[tx-robot] updated from transifex 2020-04-15 02:17:12 +00:00
Joas Schilling 609b8aff12
Also disallow ; in remote urls 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-14 18:56:06 +02:00
Joas Schilling 5e402f8aae
Check all remotes for local access 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-14 18:56:06 +02:00
Christoph Wurst 833d1d2c3b
Fix php-cs formatting 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-14 17:53:44 +02:00
Roeland Jago Douma d7a74d0e35
Merge pull request #20472 from nextcloud/fix/19848/make-sure-destination-is-not-a-directory 
Verify that destination is not a directory.
 2020-04-14 15:20:46 +02:00
Arthur Schiwon 84619a5b9c
use serverControls directly with LDAP calls, fixes 19127 
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-04-14 12:58:28 +02:00
Daniel Kesselberg 91ab811824
Verify that destination is not a directory. 
Otherwise file_put_contents will fail later.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-04-14 12:52:12 +02:00
John Molakvoæ (skjnldsv) 47146a1992 Properly display share error messages 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-14 08:39:40 +00:00
Nextcloud bot 09bb8ac6e2
[tx-robot] updated from transifex 2020-04-14 02:16:50 +00:00
John Molakvoæ 3ea9dd8487
Merge pull request #19852 from nextcloud/dav/provide-dav-setting-for-default-calendar 
Provide dav setting for user's default calendar
 2020-04-13 17:00:04 +02:00
dependabot-preview[bot] d5ce231c4b Bump marked from 0.8.1 to 0.8.2 
Bumps [marked](https://github.com/markedjs/marked) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Commits](https://github.com/markedjs/marked/compare/v0.8.1...v0.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-13 14:10:24 +00:00
Thomas Citharel 0408c37b3d
Only delete the default calendar setting when the default calendar 
itself is deleted

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2020-04-13 15:07:43 +02:00
Thomas Citharel ebdf66b706
Provide dav setting for user's default calendar 
And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2020-04-13 15:07:42 +02:00
dependabot-preview[bot] ae6e5fb76d Bump @nextcloud/paths from 1.1.1 to 1.1.2 
Bumps @nextcloud/paths from 1.1.1 to 1.1.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-13 12:24:37 +00:00
Roeland Jago Douma 21d8a2bfc1
Merge pull request #20446 from nextcloud/dependabot/npm_and_yarn/css-loader-3.5.2 
Bump css-loader from 3.4.1 to 3.5.2
 2020-04-13 14:11:00 +02:00
Roeland Jago Douma a307d82e1d
Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity 
Fix password reset saying Admin changed my password when reset from login page
 2020-04-13 13:15:49 +02:00
dependabot-preview[bot] 372d6bf23e Bump css-loader from 3.4.1 to 3.5.2 
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.4.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.1...v3.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-13 11:13:09 +00:00
Robin Appelman 57403c7020
dont set headers for cli 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-13 12:57:29 +02:00
Robin Appelman c2677682c4
Return hashes of uploaded content for dav uploads 
hashes are set in "X-Hash-MD5", "X-Hash-SHA1" and "X-Hash-SHA256" headers.

these headers are set for file uploads and the MOVE request at the end of a multipart upload.

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-13 12:57:27 +02:00
Nextcloud bot 6187cea304
[tx-robot] updated from transifex 2020-04-13 02:19:45 +00:00
Roeland Jago Douma 1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods 
Show setup check for recommended php modules
 2020-04-12 15:56:10 +02:00
Liam JACK b6c76f43a1
Fix #19066 - Array offset error due to empty file versions array 
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
 2020-04-12 15:35:17 +02:00
Liam JACK 301335e9e1
Fix #13287 - Increase max-height on button in welcome email template 
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
 2020-04-12 13:07:16 +02:00
John Molakvoæ 8924214299
Merge pull request #20439 from nextcloud/Valdnet-patch-3 
Changing the translation catalog for "Share"
 2020-04-12 09:08:52 +02:00
Nextcloud bot d32ea71c30
[tx-robot] updated from transifex 2020-04-12 03:09:11 +00:00
Valdnet a50698b3c3 Changing the translation catalog for "Share" 
Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-12 02:20:14 +00:00
Julius Härtl c20321e7e0 Add tests for encoded group id 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-11 06:36:20 +00:00
Julius Härtl 5252836f44
Make sure the group id parameter gets properly encoded when used in URLs 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-11 08:28:15 +02:00
Julius Härtl e7249de145
Make the groupId url encoded 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-04-11 08:28:15 +02:00
John Molakvoæ e5ac5c7f34
Merge pull request #20185 from azul/open-new_tab 
Modify do_action so default ctrl-click opens tab
 2020-04-11 08:23:11 +02:00
John Molakvoæ b5a30d5cd6
Merge pull request #20426 from nextcloud/techdebt/psr2 
It is done
 2020-04-11 08:21:35 +02:00
John Molakvoæ 97de425a17
Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various 
Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …
 2020-04-11 08:18:14 +02:00
Nextcloud bot de52e1cda7
[tx-robot] updated from transifex 2020-04-11 02:18:37 +00:00
Thomas Citharel 18e8af4bb8
Fix password reset saying Admin changed my password when reset from 
login page

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2020-04-10 18:05:43 +02:00
Christoph Wurst 734c62bee0
Format code according to PSR2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:56:50 +02:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst a7c8d26d31
Add visibility to all properties and move static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:48:31 +02:00
John Molakvoæ (skjnldsv) e24818f6bb Bump core-js from 1.4.1 to 1.5.0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-10 12:37:20 +00:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Roeland Jago Douma 75836f004d
Show setup check for recommended php modules 
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-04-10 13:25:12 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Roeland Jago Douma 7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag 
Do not use closing tags
 2020-04-10 08:34:18 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup 
Remove all extra whitespace PSR2 does not like
 2020-04-09 20:39:37 +02:00
Azul 43f0d2a3b5 Allow opening files for editing in new tabs 
In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>
 2020-04-09 16:41:09 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords 
Use php keywords in lowercase
 2020-04-09 16:25:14 +02:00
Christoph Wurst 3a415e4139
Remove space between switch case and colon 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:17:53 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:07:47 +02:00
Christoph Wurst 42625a46be
Remove spaces after method or function call 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:05:56 +02:00
Christoph Wurst 709584b853
Do not use closing tags 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:01:17 +02:00
Christoph Wurst c56a273b39
Merge pull request #20383 from nextcloud/techdebt/function-spacing 
Unify function spacing to PSR2 recommendation
 2020-04-09 15:53:09 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
John Molakvoæ 66b743385e
Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585 
Clear comment on successful post
 2020-04-09 13:46:20 +02:00
Christoph Wurst 2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
John Molakvoæ 732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3 
update icewind/smb to 3.2.3
 2020-04-09 08:16:43 +02:00
Nextcloud bot b537e9fbc7
[tx-robot] updated from transifex 2020-04-09 02:18:26 +00:00
Christoph Wurst 85e369cddb
Fix multiline comments 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-08 22:24:54 +02:00
Azul d2728cbdc1 refactor: fileActions.getCurrentDefaultFileAction() 
fileActions.getCurrentDefaultFileAction() returns the default file action
for the currently selected file.

There were a number of places querying for the mime, type and permissions
of that file first to then query for the default action.

Signed-off-by: Azul <azul@riseup.net>
 2020-04-08 18:19:58 +02:00
Robin Appelman 2340f4f2d5
update icewind/smb to 3.2.3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-04-08 17:30:47 +02:00
Joas Schilling 3ea37d0d10
Show the displayname instead of the user id 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-08 16:09:03 +02:00
Joas Schilling f8a5812f98
Try to use the display name of file transfers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-04-08 15:41:20 +02:00
Roeland Jago Douma 981278a666
Merge pull request #20315 from nextcloud/dependabot/npm_and_yarn/handlebars-4.7.6 
Bump handlebars from 4.7.4 to 4.7.6
 2020-04-08 15:37:58 +02:00
dependabot-preview[bot] 32209c0d92 Bump handlebars from 4.7.4 to 4.7.6 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.4 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-08 12:59:43 +00:00
John Molakvoæ (skjnldsv) 05821ab243 Clear comment on successful post 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-04-08 06:29:38 +00:00
Nextcloud bot 8146e1988c
[tx-robot] updated from transifex 2020-04-08 02:18:45 +00:00
Roeland Jago Douma e266666380
Merge pull request #20188 from nextcloud/bug/19662/add-default-title-for-event-in-invitatios 
Add default titles for titleless events in invitations
 2020-04-07 11:22:17 +02:00
Nextcloud bot 9895aff4d9
[tx-robot] updated from transifex 2020-04-07 02:18:10 +00:00
Christoph Wurst 8119e0b18e
Inline usages of OCP.Toast in bundled files 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-06 17:19:57 +02:00
Christoph Wurst 01a70e5d0f
Use external Toast implementation and deprecate the OCP API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-06 17:00:58 +02:00