Commit Graph

106 Commits

Author SHA1 Message Date
John Molakvoæ (skjnldsv) 4de6e80771
Upgrade lifecycle and vue parent context
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-07 09:40:59 +02:00
John Molakvoæ (skjnldsv) 843d799a2e
Move Files Sidebar to proper javascript standard
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-07 09:40:58 +02:00
Joas Schilling 40af51cc9b
Never copy the share link when the password is forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-18 14:06:01 +02:00
Joas Schilling 1da890150d Only copy the link when updating a share or no password was forced
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-20 13:12:06 +00:00
Georg Ehrke 4485cb30a1
Display user-status in sharing list
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-17 21:55:29 +02:00
John Molakvoæ (skjnldsv) 3a31397ac2
Use `babel-loader-exclude-node-modules-except`
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-31 11:00:33 +02:00
John Molakvoæ (skjnldsv) a384b4a97a
Bump @nextcloud/eslint-config and peers
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-31 09:35:55 +02:00
John Molakvoæ (skjnldsv) 0f8aca9d87
Bump compiled files
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-31 09:26:43 +02:00
Roeland Jago Douma df1fa52ee5
Respect default share permissions
Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-23 09:30:42 +02:00
John Molakvoæ (skjnldsv) 6fcd075730
Use DOMContentLoaded and fix sharebymail loading issue
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-20 12:42:08 +02:00
Gary Kim a2cedcefee
Add user input for link share labels
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-07-14 10:02:17 +08:00
Joas Schilling d9f12977d3
Improve error reporting on sharing errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-08 11:24:29 +02:00
Roeland Jago Douma 0bcc643d6e
Cleanup share by mail a bit
* Moved to ned IBootstrap
* Register everything via the capabilities api (So clients can use it as
  well)
  - This applies to the enforcing passwords
* Updated the sharing js code to use it
* removed app.php
* removed unused settings now
* typehints
* strict typing

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-06 09:45:08 +02:00
Daniel Calviño Sánchez 3ffb482b4e Fix share permission checkboxes enabled when permissions can not be set
A sharee can reshare a file and set the edit, create, delete and share
permissions of the reshare only if the received share has edit, create,
delete and share permissions, or if they were revoked in the received
share after being set in the reshare. Therefore, the permission
checkboxes in the share menu should be enabled only if the user can set
them (otherwise trying to check them will lead to an error).

Note that "sharePermissions" has all the permissions if the file is not
a reshare but a file owned by the user.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-12 00:05:36 +02:00
Roeland Jago Douma d0525df63c
Pass the proper share permissions to the create share call
Fixes #21188

This way we do not run into the share permission issue

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-09 20:59:41 +02:00
Daniel Calviño Sánchez fdac2ffe24 Restore previous state when failing to change video verification state
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-06-01 18:50:13 +02:00
Christoph Wurst 5d92a6a7c9 Fix the Talk verification
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).

When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.

We'll have to backport to 18.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-01 17:21:42 +02:00
Roeland Jago Douma b9e7fd2418 Remove the escape-html global
Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-29 08:34:10 +00:00
John Molakvoæ (skjnldsv) d37c5c3038 Do not process the same FileInfo twice
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-06 19:41:31 +00:00
John Molakvoæ (skjnldsv) a26ca1e638
Do not filter id matching userId on non-user-share shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv) edecd0931e Fix filtering our owner & current user from shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
John Molakvoæ (skjnldsv) ff20da637e Fix federated link sharing permissions
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Gary Kim 8dd23f9854
Fix expiry datepicker allowing all dates
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.

This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.

Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
John Molakvoæ (skjnldsv) 31172a0cd9 Process shares only once, better debug and expiration date code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
Gary Kim 02b5ded840
Fix share expiration date not shown
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
Roeland Jago Douma d466a7b808 Allow to navigate to others with access from the sidebar
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
John Molakvoæ (skjnldsv) 7eceba7dae Fix Sharing recommendation user display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-21 07:48:10 +00:00
John Molakvoæ (skjnldsv) 47146a1992 Properly display share error messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-14 08:39:40 +00:00
Valdnet a50698b3c3 Changing the translation catalog for "Share"
Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-12 02:20:14 +00:00
Joas Schilling e57f619e1e
Merge pull request #19763 from nextcloud/bugfix/noid/received-share-sidebar-broken
Fix "Error loading the shares list TypeError: "this is undefined"" fo…
2020-03-06 16:43:20 +01:00
Joas Schilling 275df5d233
Fix "Error loading the shares list TypeError: "this is undefined"" for conversation shares
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-03 20:22:39 +01:00
Julius Härtl d612aeec2d
Fix regex to not take email uids as federated ids
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-03 18:19:46 +01:00
Christoph Wurst 699cbeb2fc Show the link password when it's set
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-02-23 12:38:28 +00:00
Christoph Wurst c47a0a0153
Add more tests for the new js modules
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-02-10 12:05:43 +01:00
Julius Härtl 60f49efe8a
Give the sharing tab a unique id so it also opens properly on other languages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-29 16:44:52 +01:00
John Molakvoæ (skjnldsv) 05742c083c
Migrate to @nextcloud/vue 1.x.x
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-22 17:33:49 +01:00
Julius Härtl eb4c42d3d1
Make auto accepting the default and provide setting to enforce the share acceptance process
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-16 22:07:51 +01:00
John Molakvoæ (skjnldsv) 9a0fa63a5c
Do not save on update, use submit
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-01-16 00:00:19 +01:00
Roeland Jago Douma aa9878e867
Only allow navigation to a folder if you have access
Fixes #18716

If you can delete the share then you have access yourself to that shares
location.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-15 07:40:41 +01:00
Daniel Calviño Sánchez 897111404a Add "Password protected by Talk" option to shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-01-14 17:15:02 +01:00
John Molakvoæ 3e43ae7bd6 Add placeholder
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-01-10 14:50:24 +00:00
John Molakvoæ (skjnldsv) 8eded83d50 Fix sharing note placeholder
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-10 14:50:23 +00:00
Roeland Jago Douma d99bcf1f8b
Only show others with access if you have reshare permissions
Fixes #18711

If you do not have reshare permissions the others with access will throw
an error anyways. So better to just not show it ;)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-07 16:15:40 +01:00
Roeland Jago Douma 1fc39196bf
Show message if no other users with access are found
Fixes #18632
Show a small subtitle if no other users with access are found.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 21:45:38 +01:00
Roeland Jago Douma d4ce8c9427
Don't show link shares in sidebar if disabled
Fixes #17799

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 12:23:06 +01:00
Roeland Jago Douma 9a8b361911
Do not show e-mail suggestions if link shares are disabled
For #17774

This removes the e-mail suggestions from the share input if link shares
are disabled. As e-mail shares use just link shares.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-06 10:22:22 +01:00
Julius Härtl 272aa9231c
Fix style of the sharing setting checkbox
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-02 09:44:32 +01:00
Alexandre Guiot--Valentin ab50fee1e5
Change icon-delete to icon-close in others locations
Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr>
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-12-26 21:17:50 +08:00
Alexandre GV d8ba5e5d57 Clarify "Delete share" action in sharing sidebar
- change "Delete share" to "Unshare"
- change icon-delete to icon-close

Signed-off-by: Alexandre Guiot--Valentin <contact@alexandregv.fr>
2019-12-25 08:51:19 +00:00
GretaD 455013c309
fix the folder share
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-19 16:14:47 +01:00