Commit Graph

3045 Commits

Author SHA1 Message Date
Roeland Jago Douma 2ec160aec8
Merge pull request #23264 from nextcloud/bug/23177/escape-html
Add local version of escapeHTML
2020-10-09 09:25:05 +02:00
Robin Appelman 9bdf0eed65
Merge pull request #23020 from nextcloud/disable-notify-self-check
add option to disable notify self check
2020-10-08 11:27:08 +00:00
Daniel Kesselberg d0f18f4d9a Add local version of escapeHTML
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-07 23:06:42 +02:00
Robin Appelman ea80d1d68f
also give storage backend it's change to manipulate the config
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-07 15:43:44 +02:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Nextcloud bot 0d05c600d6
[tx-robot] updated from transifex 2020-10-02 11:06:18 +00:00
Nextcloud bot 190f0be5fb
[tx-robot] updated from transifex 2020-09-27 02:17:24 +00:00
Robin Appelman 6fed17a342
allow using saved login credentials for notify
when only the user is provided, we use to provided user to try and get saved login credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:49:27 +02:00
Robin Appelman a79f9605b4
add option to disable notify self check
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-23 15:16:16 +02:00
Nextcloud bot 7d06027922
[tx-robot] updated from transifex 2020-09-23 02:17:50 +00:00
Joas Schilling 48761481eb
Bump versions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-18 09:16:45 +02:00
J0WI 68ce17e59b Unify links to php.net
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +02:00
Robin Appelman 43b3049a4f
improve handling of out of space errors for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-17 17:23:33 +02:00
Morris Jobke 99c9423766
Remove @suppress SqlInjectionChecker
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +02:00
Julius Härtl 2004ae4603
Set delimiter so that the CommonPrefixes response can properly be determined
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 08:11:55 +02:00
Robin Appelman fc96fa0cc7
fix s3 doesDirectoryExist check for empty directories
if a directory is empty, only the 'marker' object `/` exists.

since not all s3 implementations return just the prefix when listing objects by prefix,
when listing objects by the folder prefix, nothing will be returned if the directory is empty.
by not including the trailing slash in the prefix, the folder marked will always be returned if it exists

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-09-10 08:11:55 +02:00
Roeland Jago Douma bb06b6cce4
Fix reading empty files from objectstorage
Since we try to do range requests this will fail hard.
However since empty files are not that interesting to read anyways we
just read from an emptry memory stream.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-09 20:45:13 +02:00
Roeland Jago Douma 89ce8d50e0
Upgrade icewind/smb to 3.2.7
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-04 08:57:27 +02:00
Nextcloud bot b287760694
[tx-robot] updated from transifex 2020-08-25 02:17:40 +00:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Nextcloud bot 9e8b6b9995
[tx-robot] updated from transifex 2020-08-24 02:16:45 +00:00
Morris Jobke d028423107
Merge pull request #22335 from nextcloud/fix/16017/remove_nc_encryption
Remove encryption option for nextcloud external storage
2020-08-20 18:27:11 +02:00
Roeland Jago Douma 85406bcaa5
Remove encryption option for nextcloud external storage
Fixes #16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-20 16:28:03 +02:00
Morris Jobke ac73982395
Merge pull request #21734 from nextcloud/external-s3-no-touch
disable touch to update mtime for external s3 storage
2020-08-20 16:07:59 +02:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
Nextcloud bot c96044085b
[tx-robot] updated from transifex 2020-08-18 02:17:28 +00:00
Morris Jobke d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
Ref #21787

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +02:00
Daniel Kesselberg 6f8147b18f
Fix some MissingDocblockType or InvalidDocblock warnings.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-14 15:10:48 +02:00
Morris Jobke afd52c6b12
Remove setCustomJs of the files_external FrontendDefinitionTrait
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 21:49:50 +02:00
Daniel Kesselberg ba3a855ad8
Remove unused method uploadFile
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-13 08:02:28 +02:00
Morris Jobke 234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +02:00
blizzz a2c262b68a
Merge pull request #21037 from nextcloud/login-credentails-save
Only save login credentials in database once there is an external storage that needs it
2020-08-07 10:49:42 +00:00
Nextcloud bot 0eed71870d
[tx-robot] updated from transifex 2020-08-04 02:16:30 +00:00
Morris Jobke 0b0cc48c88
Move event listener to dedicated class
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-30 12:04:56 +02:00
Robin Appelman d1bd3ba594
update saved credentials on password change
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
Robin Appelman c864e5dfc2
remove saved credentails if the user no longer has any storage configured using them
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
Robin Appelman 7ad0f66fc4
Only save login credentials in database once there is an external storage that needs it
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-30 11:43:15 +02:00
Robin Appelman 7f7d361da2
update icewind/smb to 3.2.6
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-22 14:25:33 +02:00
John Molakvoæ (skjnldsv) 6fcd075730
Use DOMContentLoaded and fix sharebymail loading issue
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-20 12:42:08 +02:00
Nextcloud bot 2c79083f27
[tx-robot] updated from transifex 2020-07-17 02:17:12 +00:00
Morris Jobke 638e9438a9
Merge pull request #21728 from nextcloud/bugfix/noid/s3-external-mtime-cache
Reuse cache for directory mtime/size if filesystem changes can be ignored
2020-07-15 18:26:48 +02:00
Morris Jobke cbbbbee8b1
Merge pull request #21785 from nextcloud/techdebt/noid/remove-classmap-in-files_external
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH us…
2020-07-13 16:47:12 +02:00
Robin Appelman e357d46863
filter files containing a hash in the path for ftp storages
the php ftp streamwrapper doesn't handle hashes correctly and will break when it tries to enter a path containing a hash.

By filtering out paths containing a hash we can at least stop the external storage from breaking completely

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-10 14:18:40 +02:00
Morris Jobke 065ef14cb0
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-10 00:02:59 +02:00
Robin Appelman 0d6910ac13
disable touch to update mtime for external s3 storage
since updating the mtime requires doing a copy this can have a significant overhead and it messes with versioning

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-07 15:55:38 +02:00
Julius Härtl f5cc34c9c2
Reuse cache for directory mtime/size if filesystem changes can be ignored
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 10:22:22 +02:00
Joas Schilling 347ab5241c
Move files_external to migrations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-06 16:42:14 +02:00
Joas Schilling d7c0b9cced
Also always return in app commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 15:12:11 +02:00
Julius Härtl 69f4c50032
Remove rescanDelay from directory mtime
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-22 14:15:57 +02:00
Nextcloud bot e324c90a8d
[tx-robot] updated from transifex 2020-06-18 02:16:35 +00:00
Nextcloud bot e1e7de43c1
[tx-robot] updated from transifex 2020-06-11 02:15:48 +00:00
Robin Appelman 892589746d
Merge pull request #21252 from nextcloud/smb-3.2.5
update icewind/smb to 3.2.5
2020-06-09 12:27:46 +00:00
Nextcloud bot 99e14b5ada
[tx-robot] updated from transifex 2020-06-09 02:15:56 +00:00
Joas Schilling 33f6a26a7d
Merge pull request #21091 from nextcloud/sftp-normalize-path
normalize sftp path in read and write stream
2020-06-03 12:17:38 +02:00
Nextcloud bot f62f23ed1d
[tx-robot] updated from transifex 2020-06-03 02:16:18 +00:00
Nextcloud bot 0f4de3d353
[tx-robot] updated from transifex 2020-06-01 02:16:00 +00:00
Nextcloud bot 64c15a15d4
[tx-robot] updated from transifex 2020-05-30 02:16:04 +00:00
Robin Appelman 41fdfc9966
update icewind/smb to 3.2.5
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-27 17:44:54 +02:00
Nextcloud bot b9d17cfdec
[tx-robot] updated from transifex 2020-05-27 02:16:10 +00:00
Robin Appelman 6f2e920a5b
normalize sftp path in read and write stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-25 15:26:04 +02:00
Nextcloud bot 23080fcd9c
[tx-robot] updated from transifex 2020-05-23 02:16:22 +00:00
Nextcloud bot 3b519f776a
[tx-robot] updated from transifex 2020-05-22 02:17:20 +00:00
Nextcloud bot 74e577876c
[tx-robot] updated from transifex 2020-05-20 02:16:28 +00:00
Nextcloud bot 1b55119c85
[tx-robot] updated from transifex 2020-05-19 02:17:09 +00:00
Morris Jobke 385b060893
Merge pull request #20941 from nextcloud/smb-3.2.4
update icewind/smb to 3.2.4
2020-05-15 14:32:56 +02:00
Nextcloud bot 75d50a55b8
[tx-robot] updated from transifex 2020-05-14 02:16:36 +00:00
Robin Appelman 42019c0f4f
update icewind/smb to 3.2.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-12 14:39:08 +02:00
Nextcloud bot 901110f068
[tx-robot] updated from transifex 2020-05-12 02:16:11 +00:00
Joas Schilling af1dd9f152
Bump app versions and requirements
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-07 10:29:04 +02:00
Nextcloud bot 97f36e62f2
[tx-robot] updated from transifex 2020-05-07 02:16:14 +00:00
Nextcloud bot d2f165e448
[tx-robot] updated from transifex 2020-05-03 02:16:16 +00:00
Nextcloud bot e77e0b0e2f
[tx-robot] updated from transifex 2020-05-02 02:16:32 +00:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Nextcloud bot ef566a1f40
[tx-robot] updated from transifex 2020-04-28 02:16:22 +00:00
Nextcloud bot 0eeb660679
[tx-robot] updated from transifex 2020-04-26 02:16:12 +00:00
Nextcloud bot 39f6f1ba34
[tx-robot] updated from transifex 2020-04-25 02:16:01 +00:00
Nextcloud bot 84a3536159
[tx-robot] updated from transifex 2020-04-24 02:27:55 +00:00
Robin Appelman 7f32fe6d50
add tooltip to option
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-22 14:25:33 +02:00
Robin Appelman 23e2baeb95
Add option to check share ACL's when listing directories
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
Joas Schilling 708b4991d9
Fix legacy routes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Julien Lutran 3e849daf11
Fix issues with Keystone auth v3 in files_external app
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
2020-04-15 10:33:08 +02:00
Nextcloud bot bccd13ffae
[tx-robot] updated from transifex 2020-04-15 02:17:12 +00:00
Nextcloud bot 6187cea304
[tx-robot] updated from transifex 2020-04-13 02:19:45 +00:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00