14ddf9d923
rename IAdmin to ISettings, the interface is not bound to a specific settings scope
2016-08-11 14:48:21 +02:00
1eb8b951c2
more admin page splitup improvements
...
* bump version to ensure tables are created
* make updatenotification app use settings api
* change IAdmin::render() to getForm() and change return type from Template to TemplateResponse
* adjust User_LDAP accordingly, as well as built-in forms
* add IDateTimeFormatter to AppFramework/DependencyInjection/DIContainer.php. This is important so that \OC::$server->query() is able to resolve the
constructor parameters. We should ensure that all OCP/* stuff that is available from \OC::$server is available here. Kudos to @LukasReschke
* make sure apps that have settings info in their info.xml are loaded before triggering adding the settings setup method
2016-08-10 15:21:25 +02:00
ceeb44bd04
Initial work on Apps page split:
...
* interfaces for the Admin settings (IAdmin) and section (ISection)
* SettingsManager service
* example setup with LDAP app
2016-08-09 18:05:09 +02:00
83c64f3485
Merge pull request #590 from nextcloud/fixing-undefined-OfflineUser-composeAndStoreDisplayName
...
Fix undefined OfflineUser::composeAndStoreDisplayName()
2016-07-28 17:41:02 +02:00
bf7afcdace
Merge pull request #592 from nextcloud/ldap-avoidneedlesssetemailonlogin
...
Prevent setting email and triggering events at login time (#25553 )
2016-07-28 17:09:59 +02:00
bd65a17203
Nextcloud license header for new files
2016-07-28 15:13:00 +08:00
77df09d58a
Prevent setting email and triggering events at login time ( #25553 )
...
Whenever an LDAP user also has an email address defined in LDAP, the
LDAP code will try and update the email address of the locally known
user. This happens at login time or every time the user's LDAP
attributes are processed.
There is code listening to the email setting hook which updates the
system address book, which also will trigger FS setup due to avatars
and other things.
This fix only sets the email address when really necessary.
2016-07-27 11:28:33 +02:00
1177c70b9d
[stable9.1] Fix undefined OfflineUser::composeAndStoreDisplayName() - fixes #23248
2016-07-27 11:17:53 +02:00
2719dcabed
Merge branch 'master' of https://github.com/nextcloud/server
2016-07-27 15:17:29 +08:00
1c64ee67af
comments amended
2016-07-27 15:16:57 +08:00
32fb6beac3
final changes
2016-07-27 15:10:35 +08:00
f88109be75
Merge pull request #349 from nextcloud/ldab-groupOfUniqueNames
...
add groupOfUniqueNames as valid group object class
2016-07-26 23:32:47 +02:00
02ec8b1726
New LDAPProvider for user_ldap
2016-07-22 16:46:29 +08:00
0215b004da
Update with robin
2016-07-21 18:13:58 +02:00
813f0a0f40
Fix apps/
2016-07-21 18:13:57 +02:00
7c0de08cc4
Escape special characters ( #25429 )
...
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Escape LIKE parameter
* Use correct method in the AbstractMapping class
* Change the getNamesBySearch method so that input can be properly escaped while still supporting matches
* Don't escape hardcoded wildcard
2016-07-20 14:46:47 +02:00
81d4d85803
add groupOfUniqueNames as valid group object class
2016-07-08 18:13:22 +02:00
b77fcc19d4
Merge pull request #25344 from owncloud/fix-ldap-check-user
...
check if renamed user is still valid by reapplying the ldap filter
2016-07-05 11:29:55 +02:00
e901ec4941
check if renamed user is still valid by reapplying the ldap filter ( #25338 )
2016-07-04 14:20:08 +02:00
d2d2a75529
Cap LDAP user cache ( #25323 )
2016-07-04 13:57:15 +02:00
704a993e37
Fix null pointer exception in user_ldap ( #25062 )
2016-06-21 16:30:48 +02:00
990ac34aaa
Use proper namespaces - fixes #25078 ( #25079 )
2016-06-13 19:32:54 +02:00
c5a6c8b70b
Use array_merge when reading cached groups members
2016-06-08 11:22:01 +02:00
dc4fd43f39
Use a capped memory cache for the user/group cache
...
For #24403
When upgrading huge installations this can lead to memory problems as
the cache will only grow and grow.
Capping this memory will make sure we don't run out while during normal
operation still basically cache everything.
2016-05-30 10:57:14 +02:00
aba539703c
Update license headers
2016-05-26 19:57:24 +02:00
a4980a3de4
Last instances of lowercase user_ldap
2016-05-25 16:06:09 +02:00
b616318327
Fix several minor issues
2016-05-25 16:06:08 +02:00
db2e9df5f0
Move Job to a better class name
2016-05-25 16:06:06 +02:00
c807a26bd8
Move Access to PSR-4
2016-05-25 16:04:59 +02:00
02d5b75fb4
Move BackendUtility to PSR-4
2016-05-25 16:04:59 +02:00
aa7b600383
Move Configuration to PSR-4
2016-05-25 16:04:59 +02:00
af0a6961b1
Move Connection to PSR-4
2016-05-25 16:04:59 +02:00
387019a212
Move FilesystemHelper to PSR-4
2016-05-25 16:04:58 +02:00
7db6b487f5
Move Helper to PSR-4
2016-05-25 16:04:58 +02:00
391531851c
Move interface to PSR-4
2016-05-25 16:04:58 +02:00
3690ce1b36
Move LDAP to PSR-4
2016-05-25 16:04:58 +02:00
5b3087d375
Move LDAP Utility to PSR-4
2016-05-25 16:04:57 +02:00
6feccccbd5
Move LogWrapper to PSR-4
2016-05-25 16:04:57 +02:00
e73d811425
Move Proxy to PSR-4
2016-05-25 16:04:57 +02:00
d16a97a273
lib/user
2016-05-25 16:04:57 +02:00
d4e828f39e
Move wizard
2016-05-25 16:04:57 +02:00
3f5e76162d
Move lib\user to PSR-4
2016-05-25 16:04:56 +02:00
b7fa527791
Move User_LDAP and User_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
cbba55a26c
Move Group_LDAP and Group_Proxy to PSR-4
2016-05-25 16:04:56 +02:00
4ac283ecd3
Move Command namespace to PSR-4
2016-05-25 16:04:56 +02:00
9d61acb27d
Move User_LDAP to PSR-4
2016-05-25 16:04:55 +02:00
6321596134
Merge pull request #24052 from owncloud/fix-ldap-cache-race-conditions
...
Fix LDAP race conditions
2016-04-25 14:55:20 +02:00
203b0e9cba
on clone Connection, do not take over the existing LDAP resource
...
For one, it solves potential conflicts when using the resource. For the
other, one on the login check (the only place where a clone happens
currently) we do not need to rebind after confirming the user's login
was successful.
2016-04-22 21:43:41 +02:00
62a59854f0
Fix LDAP race conditions
...
* getFromCache is wrapped in isCached
* inbetween the two calls the cache entry hits it's TTL
* getFromCache returns null
* this fix only checkes if the returned value is null and
return only non-null values
2016-04-20 21:50:28 +02:00
5911ce530b
Merge pull request #23527 from owncloud/fix-21136
...
disable Paged Search when chunksize is set to 0, fixes #21136
2016-04-14 11:14:19 -04:00
16df1c5188
apps: Fix typos (found by codespell) ( #23862 )
...
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-12 12:52:51 +02:00
f6b846584b
Handle case where the user is not known - fixes #23759
2016-04-04 16:56:59 +02:00
c9587cea76
disable Paged Search when chunksize is set to 0, fixes #21136
2016-03-23 19:47:31 +01:00
8442516e10
Merge pull request #23329 from owncloud/fix-21555
...
Avatar must be saved after login is done and external storages set up…
2016-03-21 09:47:50 +01:00
d8621c78ed
Avatar must be saved after login is done and external storages set up properly, fixes #21555
2016-03-16 20:51:03 +01:00
8e0bd5630c
fix writing to cache when fallback server should be used immediately
2016-03-16 14:44:18 +01:00
fe2a506e56
remove deprecated ldap_sort
2016-03-10 13:13:38 +01:00
5d3183afcd
improve log output when no LDAP user was found on login attempt
2016-03-05 00:18:34 +01:00
82b55c4db9
untangle different user manager instances, fixes #22770
2016-03-02 13:02:43 +01:00
c353d51810
Remove Scrutinizer Auto Fixer
2016-03-01 17:48:23 +01:00
933f60e314
Update author information
...
Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)
2016-03-01 17:25:15 +01:00
b9b85e32be
take the first result of that array, if present. Fixes 2nd display name to be 'Array', if cache is configured and enabled.
2016-02-24 21:32:03 +01:00
3a796d1e15
Consolidate getQuota and setQuota methods in User instance
2016-02-09 17:16:43 +01:00
69a4cd2898
Merge pull request #22102 from owncloud/ldap_2nddispname-master
...
[LDAP] add second field for additional/optional display name attribute
2016-02-06 13:27:01 +01:00
0d797637f3
code changes for user_ldap Dynamic Group Membership
...
Added new setting of “Dynamic Group Member URL”
(ldapDynamicGroupMemberURL) - see LDAP settings advanced tab.
Added public function getDynamicGroupMembers.
Updated function _groupMembers.
Updated function getUserGroups.
2016-02-03 21:50:27 +01:00
c1871f5787
Port of test_ldap_2nddispname to master
2016-02-03 13:55:39 +01:00
e4ad4c7e98
[user_ldap] properly decode cached objects
...
* fixes #21896
2016-01-29 07:51:16 +01:00
77069f5582
Use IUser::setEMailAddress in ldap as well
2016-01-20 15:21:33 +01:00
aeb89947a2
Introduce IUser::setEMailAddress and add hook mechanism
2016-01-20 14:57:20 +01:00
dd733d8925
Merge pull request #20804 from owncloud/fix-ldap-process-user-wo-displayname
...
LDAP: do not attempt to process user records without display name, fi…
2016-01-20 11:33:26 +01:00
83a8e75614
Scrutinizer Auto-Fixes
...
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2016-01-15 12:54:26 +00:00
682821c71e
Happy new year!
2016-01-12 15:02:18 +01:00
1ed6132899
LDAP: do not attempt to process user records without display name, fixes fatal error
2016-01-11 11:21:02 +01:00
26d0f42dac
Respect user enumeration
...
Respect shareapi_allow_share_dialog_user_enumeration in user_ldap filter
generation function to increase search performance in sharing dialog.
2016-01-08 15:32:31 +01:00
70b58cf367
Merge pull request #17924 from owncloud/ldap-fix-appending-port
...
ensure an LDAP URL is used, append the port to the host URL when necessary, and just in one place
2016-01-08 12:34:15 +01:00
553a981980
Make LDAP more robust to exceptions and log them properly
2016-01-06 13:46:55 +01:00
e39415c946
fix find DN by UUID for AD
2015-12-14 22:42:27 +01:00
4020d5b77a
look for DN changes before marking a user as deleted
2015-12-11 01:56:53 +01:00
000523a7fe
Merge pull request #18212 from ryno83/treat_LDAP_users_not_available_by_user_filter_as_deleted
...
treat LDAP users not available by user filter as deleted
2015-12-07 17:47:10 +01:00
86fcb08745
wizard should also detect protocol errors, as side effect enforces LDAPv3
2015-12-05 00:43:38 +01:00
a32b002cff
always use an LDAP URL when connecting to LDAP
2015-12-05 00:09:15 +01:00
c60c793cf2
More cleanups of OC_Config usage
2015-12-03 16:41:23 +01:00
4978a785fa
Merge pull request #18294 from esakol/issue17173
...
Fix RHDS ldap paged search, Issue #17173
2015-11-24 16:04:23 +01:00
46a8eab772
Fix RHDS ldap paged search, Issue #17173
...
Change-Id: Ic804ea95401a9b49cb2b0866af722aa0d3ee58c5
2015-11-09 10:27:45 -02:00
133e3fe89d
remove uselessly used parameter, read all user attributes also when looking up users in groups
2015-11-06 15:21:56 +01:00
bf941032a3
Merge pull request #20271 from owncloud/fix-18701
...
LDAP: attempt to connect to backup server again, if main server is no…
2015-11-06 10:01:06 +01:00
8eeaf11d41
add port to host only, if an URL is used instead of a plain hostname
2015-11-04 12:34:30 +01:00
6b866fa917
LDAP: attempt to connect to backup server again, if main server is not available. Fixes #18701
2015-11-03 17:17:00 +01:00
83d3c94590
Merge branch 'master' into fix-20151
2015-11-02 13:32:24 +01:00
a2f2ffb8db
if a user that is flag as deleted shows up again, remove that flag. Fixes #20090
2015-10-30 19:20:42 +01:00
16aa339475
add method to count users by loginname and use it for diagnose test, fixes #20151
2015-10-30 18:20:50 +01:00
f96e552164
fix attribute casing to ensure array keys work
2015-10-27 19:10:38 +01:00
e1d61284f8
fix update quota with known value
2015-10-27 18:07:40 +01:00
8f09d5b67c
Update license headers
2015-10-26 14:04:01 +01:00
f50f78dd9b
Merge pull request #19795 from owncloud/fix-language-level-compat
...
Remove arbitrary expression in empty
2015-10-15 16:42:32 +02:00
24420e9eb1
Fix doc blocks of LDAP classes
2015-10-15 08:29:35 +02:00
4e5eb3b828
Remove arbitrary expression in empty
...
Those are only allowed in PHP 5.5, thus making our code incompatible with PHP 5.4
Fixes https://github.com/owncloud/core/issues/19793
2015-10-14 22:35:46 +02:00
3f083353c1
Merge pull request #19635 from owncloud/fix-ldap-value-limitation
...
allow an attribute to return more than one value
2015-10-13 14:09:52 +02:00
e3a148584a
adjust fetchList with a single requested attribute accordingly
2015-10-09 20:07:35 +02:00
a876efda50
treat dn as any other attribute when building the search() return array
2015-10-08 21:18:34 +02:00
dd2e887a8d
adjust handling changed return array structure from search() and fetchList()
2015-10-08 20:32:15 +02:00
4a5cecd6fa
allow an attribute to return more than one value
2015-10-07 18:57:49 +02:00
c8021441d0
Merge pull request #19489 from owncloud/fix-18297
...
fix possible infinite loop when reading groups in the wizard
2015-10-07 14:55:48 +02:00
0385a62363
Merge pull request #19597 from owncloud/update-license-headers
...
update licence headers via script
2015-10-06 11:18:35 +02:00
b945d71384
update licence headers via script
2015-10-05 21:15:52 +02:00
353a8e442f
fix possible infinite loop when reading groups in the wizard
2015-10-05 19:10:30 +02:00
fc273ac88c
trim by default, add unit tests
2015-10-05 13:42:20 +02:00
70ffa2f9f8
Spaces -> Tabs, Update PHP-Doc and function logic
2015-10-05 13:42:20 +02:00
b47d15cd20
Remove whitespace from base-DNs
2015-10-05 13:42:20 +02:00
6d06d1c5a4
LDAP Wizard: do not be picky about credentials when only looking for the port
2015-10-03 00:35:24 +02:00
0dde79b75b
memberOf resembles a DN as well and is actively used
2015-09-28 18:40:01 +02:00
002b6bf059
do not throw exception when no attribute is specified
2015-09-23 17:27:40 +02:00
9d03b7c6b7
read all relevant user attributes on login and user search, in one query. saves us some.
2015-09-23 16:38:39 +02:00
36e26c6f09
Use "json_encode" and "json_decode" instead of unserialize
2015-09-02 12:26:37 +02:00
642ec8e3ba
Merge pull request #18244 from owncloud/fix-issue-17677
...
Fix 17677 - Remove LDAP case sensitive checkbox
2015-08-24 13:45:15 +02:00
d9172a1907
Merge pull request #14401 from owncloud/ux-s2s-ldap
...
allow login names to be used for s2s with LDAP users
2015-08-19 08:31:27 +02:00
b91186c503
Fix 17677
2015-08-12 22:18:28 +02:00
3c53a0da27
if define, check the userfilter if the user is still allowed
2015-08-11 11:55:38 -04:00
332492548f
Merge pull request #17923 from owncloud/fix-17921
...
Remove Log info when no group filter is set, fixes #17921
2015-07-29 16:12:08 +02:00
e0d5eb8989
remove unused var
2015-07-29 12:10:33 +02:00
81f5672393
Remove Log info when no group filter is set, fixes #17921
...
The log message is superfluous and too noisy. If an admin decides not to use groups, he does not need to be reminded about it on almost every request.
2015-07-28 11:41:21 +02:00
b37d62d9d3
fix uncaught exception on not permitted file types when setting avatar, fixes #17232
2015-07-27 17:27:00 +02:00
933f087d21
Merge pull request #17526 from owncloud/fix-17516
...
LDAP: when checking group for matching filter, also take base DN into…
2015-07-27 08:38:45 +02:00
4f910221c4
fix runtime caching in ldap's user manager, fixes #17631
2015-07-17 18:57:56 +02:00
bfb90d10ed
Merge pull request #17046 from nicolas-grekas/fix-16654
...
Do not use OC*::mb_*_replace(), they are useless
2015-07-16 11:35:25 +02:00
472d48f6e3
Do not use OC*::mb_*_replace(), they are useless
2015-07-16 11:00:04 +02:00
bfdf39b9bd
LDAP: when checking group for matching filter, also take base DN into consideration. Fixes #17516
2015-07-09 12:19:04 +02:00
0a23d566ba
Merge pull request #17255 from owncloud/fix-17119
...
[LDAP] Filter user groups obtained by memberof
2015-07-01 00:33:39 +02:00
8625a8cf23
ensure groups match filter when using memberOf to read users group, refs #17119
2015-06-26 16:42:11 +02:00
f63915d0c8
update license headers and authors
2015-06-25 14:13:49 +02:00
4747c7f509
Merge pull request #16736 from owncloud/utilize-member-of
...
Utilize memberOf to boost loading time on users page (depending on LDAP server config)
2015-06-10 08:47:53 +02:00
6f69fab384
port detection needs to take care of now thrown exceptions when LDAP server is not available
2015-06-04 16:28:48 +02:00
090478a95e
if possible, getUserGroups should get memberships using memberOf virtual attribute
2015-06-03 17:38:27 +02:00
91841bb25d
Implement a faster way for checking availability of memberOf. Users tab in the wizard benefits.
2015-06-03 15:23:37 +02:00
cf2c599218
Merge pull request #16200 from owncloud/kill-globalfilecache
...
Drop file caching
2015-06-02 09:11:33 +02:00
cdb0689334
handle unallowed auth exception on port detection
2015-05-18 18:14:05 +02:00
5a56393657
throw exception on LDAP error 1, which we usually do not see and is pretty generic. AD uses is for uses not enlisted in the RFC, like on issues with anonymous binds. we also try to guess this case and show a hint.
2015-05-18 18:14:05 +02:00
b9e5309757
catch unallowed anonymous auth attempt and show specific error
2015-05-18 18:14:05 +02:00
8e61ad0872
Merge pull request #15811 from owncloud/exception-on-lost-ldap-connection
...
throw exception when LDAP Connection was lost
2015-05-15 17:32:07 +02:00
90611e6594
only use memcache, if available
2015-05-08 13:27:27 +02:00
57e8b76f48
drop global file cache support, fixes #15621
2015-05-07 14:52:44 +02:00
0e7fd82e89
cleanup
2015-05-05 14:21:12 +02:00
b96b0063f6
throw exception when LDAP Connection was lost
2015-04-22 15:39:28 +02:00
66bc8145a9
allow login names to be used for s2s with LDAP users
2015-04-13 11:50:09 +02:00
fafecd1c05
fix cherrypicking
2015-04-10 11:08:24 +02:00
1427ea78d4
fix typo and comment
2015-04-10 09:12:37 +02:00
5626a02d69
throw exception if setup is incomplete
2015-04-10 09:12:37 +02:00
077ab27281
fix_tests
...
Conflicts:
apps/user_ldap/tests/user_ldap.php
2015-04-10 09:12:37 +02:00
488405d1ec
do not hide exception when ldap server has a hiccup
2015-04-10 09:12:37 +02:00
60bf934e6f
change default value of ldap_tls to 0. It will be detected anyway, but starting with 0 will lead to errors and unconfigurability
2015-04-09 21:05:20 +02:00
b4c96e6ba0
cleanup
2015-04-09 14:01:39 +02:00
5355c285fc
LDAP Wizard Overhaul
...
wizard refactor
reimplement save spinners and cursor
implement Port detector
introduced detector queue, added base dn detector
disable input fields when detectors are running
introduce spinners for fields that are being updated by detector
cache jq element objects
consolidate processing of detector results in generic / abstract base class
display notification if a detector discovered a problem
don't run base dn detector if a base is configured
reset detector queue on configuration switch
implement functionality check and update of status indicator
document ConfigModel
jsdoc for controller and main view
more documentation
implement the user filter tab view
so far the multiselects get initialized (not filled yet) and the mode can be switched.
mode is also restored.
reintroduce filter switch confirmation in admin XP mode
new detector for user object classes. so we also load user object classes if necessary and are able to save and show the setting.
multiselect trigger save actions now on close only
show spinners automatically, when a detector is running
20k limit for object classes preselection test
adjust wordings, fix grammar
add group (for users tab) detector
also includes wording fixes
error presentation moved from detectors to view, where it belongs
add info label to users page
missing wording changes
show effective LDAP filter in Assisted Mode
add user filter detector
implement count button for users and limit all count actions to 1001 for performance reasons
make port field a bit bigger. not perfect though.
do not detect port automatically
implement login filter tab view
only load features in assisted mode and don't enable assisted fields while in raw mode
add tooltips on login filter checkbox options for better understanding
permanently show filter on login tab
and also compile login filter in assisted mode
test/verify button on login attributes tab, with backend changes.
only run wizard requests if your an active tab. also run compile filter requests when switching to assisted mode
underline toggle filter links to stress that they are clickable
unity user and group tab functionality in common abstract class, add group filter tab view. only detectors and template adjustments left to have group tab implementation complete
add object class and group detector for groups as well as filter composer
show ldap filter permanently on groups tab
introduce input element that can deal better with many groups, will be used with > 40
fix disabling complex group chooser while detection is running
hide complex group chooser on config switch
fix few more issues with complex chooser
make complex group chooser available on Users tab as well
detect base dn improvements/changes:
- do not look for Base DN automatically, offer a button instead
- fix for alternative way to detect a base dn (if agent dn is not given)
- do not trigger filter composers on config switch
Changes with configuration chooser controls
- "New" was removed out of the configuration list
- and split into buttons "add" and "copy"
- delete button is also now an icon
add test button for Base DN
reimplement advanced tab. The save button is gone.
reimplement expert tab
remove unused methods
implement mail attribute detector
implement user display name attribute detection
implement member group association detector
replace text input with textarea for raw filter input
finish functionality check
auto-enable good configurations, as it was before
cleanup
move save confirmation handling to base class, reduces code duplication
enable tabs only if no running save processes are left.
move onConfigLoaded to base class, avoids code duplication
simplify, save LOCs
Test Configuration button to be dealt with in main view as it is a cross-tab element
require detectorQueue in constructor
cleanup
put bootstrap into a function and thus make it testable
get rid of old stuff
2015-04-09 09:47:49 +02:00
b585d87d9d
Update license headers
2015-03-26 11:44:36 +01:00
f28f7754ae
support paged results against 389ds.
2015-03-12 22:47:20 +01:00
42d3ed47e2
set up paged search when limit is 0
2015-03-05 13:15:21 +01:00
06aef4e8b1
Revert "Updating license headers"
...
This reverts commit 6a1a4880f0
2015-02-26 11:37:37 +01:00
52495dc995
Merge pull request #13740 from owncloud/fix-12190-2
...
Include primary groups in user and login filter when restricting group access and also fix user counting in primary groups
2015-02-24 16:37:49 +01:00
6a1a4880f0
Updating license headers
2015-02-23 12:13:59 +01:00
1bb6de7c1b
Merge pull request #13425 from owncloud/phpdoc_cleanup
...
Cleanup of PHPDoc return types
2015-02-10 01:14:00 +01:00
166c4e266f
Reduce log level of bind failed to WARN - fixes #11624
2015-02-03 11:44:28 +01:00
73600cfdd8
and escape the search term
2015-01-29 00:27:05 +01:00
323af55b50
inlcude AD primary group in user filter, if a group is selected. fixes #12190
2015-01-28 14:12:12 +01:00
9cb1ef5675
this must be larger then (>), since buggy behaviour occurs when the parameter is a small number
2015-01-20 17:50:53 +01:00
2b99fc76ec
Cleanup of PHPDoc return types
2015-01-16 20:30:43 +00:00
f28235a7ef
fix retrieval of user groups
2015-01-12 16:25:11 +01:00
a5099b01f9
Merge pull request #12984 from owncloud/ldap-user-cleanup-master
...
Ldap user cleanup master
2015-01-09 10:47:02 +01:00
c1a79d24c5
fix order of initalizing instance properties, and paremeter order in a method call
2015-01-08 17:45:07 +01:00
c7f273040e
fix table name for getList
2015-01-08 14:21:40 +01:00
9668405ec7
doc fixes and removal of unnecessary use statements
2015-01-07 13:28:56 +01:00
b9235e2a24
inject DB Connection to user manager
2015-01-07 00:52:18 +01:00
40ecd30fba
inject oc config to User_LDAP
2015-01-06 23:28:49 +01:00
e724b78694
smaller fixes: coding style, PHPdoc, typos and few for DI
2015-01-06 17:50:06 +01:00
f94b300602
Be less verbose when using a paged search
...
Lower the priority from INFO to DEBUG
2014-12-24 16:35:36 +01:00
5a00b33a90
Be less verbose when disabling SSL cert validation
...
change log level from WARN to DEBUG
2014-12-24 16:32:27 +01:00
61ed363f82
planned refactorings for OC 8
2014-12-20 18:28:29 +01:00
3ca70d647a
move from \OC\Preferences to \OCP\IConfig
2014-12-20 16:33:37 +01:00
144d95de7d
basic adjustments for OC 8. I.e. no visible issues, LDAP tests pass.
2014-12-20 16:09:04 +01:00
4fa39250e7
LDAP User Cleanup: Port from stable7 without further adjustements
...
LDAP User Cleanup
background job for user clean up
adjust user backend for clean up
register background job
remove dead code
dependency injection
make Helper non-static for proper testing
check whether it is OK to run clean up job. Do not forget to pass arguments.
use correct method to get the config from server
methods can be private, proper indirect testing is given
no automatic user deletion
make limit readable for test purposes
make method less complex
add first tests
let preferences accept limit and offset for getUsersForValue
DI via constructor does not work for background jobs
after detecting, now we have retrieving deleted users and their details
we need this method to be public for now
finalize export method, add missing getter
clean up namespaces and get rid of unnecessary files
helper is not static anymore
cleanup according to scrutinizer
add cli tool to show deleted users
uses are necessary after recent namespace change
also remove user from mappings table on deletion
add occ command to delete users
fix use statement
improve output
big fixes / improvements
PHP doc
return true in userExists early for cleaning up deleted users
bump version
control state and interval with one config.php setting, now ldapUserCleanupInterval. 0 will disable it. enabled by default.
improve doc
rename cli method to be consistent with others
introduce ldapUserCleanupInterval in sample config
don't show last login as unix epoche start when no login happend
less log output
consistent namespace for OfflineUser
rename GarbageCollector to DeletedUsersIndex and move it to user subdir
fix unit tests
add tests for deleteUser
more test adjustements
Conflicts:
apps/user_ldap/ajax/clearMappings.php
apps/user_ldap/appinfo/app.php
apps/user_ldap/lib/access.php
apps/user_ldap/lib/helper.php
apps/user_ldap/tests/helper.php
core/register_command.php
lib/private/preferences.php
lib/private/user.php
add ldap:check-user to check user existance on the fly
Conflicts:
apps/user_ldap/lib/helper.php
forgotten file
PHPdoc fixes, no code change
and don't forget to adjust tests
2014-12-19 19:47:54 +01:00
ec0f80fee9
Split mapping from Access and Helper classes into it's own. Fully test them, too.
...
remove unused methods
split mapping methods off from Access class
fix DB query handling
move 'clear mapping' methods from static helper to new mapping class
add tests
test directly with DB
finishing tests and fix return value from setDNbyUUID
add corresponding class for groups and make abstract test class neutral. helper tests is now obsolete as the tested functions were moved to the new mapper class.
add missing info to PHPDoc
add unmap method
fix namespaces
fix test inheritance
PHPDoc and a small code restructure for scrutinizer, no effective changes
PostgreSQL does not accept LIMIT in DELETE queries
phpdoc fixes, no code changes
2014-12-19 18:26:12 +01:00
d41082f4d6
first step to drop \OCP\Config:: in favour of IConfig
2014-12-17 11:12:37 +01:00
0577bb569a
add doc
2014-12-08 17:22:52 +01:00
45443ee28c
preserve an asterisk at the start when escaping a search term
2014-12-08 17:19:57 +01:00
ee168a121d
Forward port of #12493
...
add ldap-search command to occ
Conflicts:
apps/user_ldap/appinfo/register_command.php
LDAP search filter creation changes:
1. do not prepend * wildcard to search terms. Will result in faster search, but
you don't find "foobar" when looking for "bar"
2. advanced behaviour when search string contains a space and multiple search
attributes are present. The search string is split into single words. The
resulting filter requires that each word at least appears once in any search
attribute. This is supposed to return better results in big LDAPs.
trim search string before passing it on
2014-12-04 19:02:09 +01:00
c07c338c90
fix counting when ldapPagingSize is 0
2014-11-21 14:51:20 +01:00
6b6147dafd
phpdoc and mixed up letters
2014-11-20 18:31:40 +01:00
4a3fe42b16
a corrected email attribute needs to be saved, not only returned
2014-11-20 18:31:39 +01:00
f9b4f5f4e5
to reassure that selected attributes still work, do not count all matching entries but limit it to 1 in order to make it faster
2014-11-20 18:31:39 +01:00
71944a59a5
detectors (email, displayname..) are now started in one place, triggered from only 2 places. more reliable structure and flow, saves requests
2014-11-20 18:31:39 +01:00
f725cc66a3
consolidate user count filter in wizard and user back end
2014-11-20 18:31:39 +01:00
cb3af1dce2
detect user display name attribute and return user count depending on its presence
2014-11-20 18:31:39 +01:00
081787d6ae
Fix infinite loop if count and limit is 0
...
* otherwise it will always think it hits the limit and need another round to fetch additional results
2014-11-11 12:15:30 +01:00
b26f11c16f
Merge pull request #11362 from mark0n/rm_ldap_conf_cli
...
Add a CLI command that deletes an LDAP config
2014-11-04 13:19:45 +01:00
dc9ea893fd
Merge pull request #11172 from owncloud/user-ldap-no-bcmath
...
Fix ldap convertSID2Str() / Remove BCMath dependency
2014-11-03 14:03:26 +01:00
d1410b46a9
user_ldap: Reimplement convertSID2Str() without BCMath dependency.
...
Also explicitly format sub-id integers as unsigned, which is required for
32-bit systems.
2014-11-03 12:07:53 +01:00
d060180140
Use function outside of loop
...
Otherwise the function is executed n times which is a lot of overhead
2014-10-24 12:27:53 +02:00
4e8c7570d4
make performance less bad. Still far from good, but at least it works
2014-10-17 20:16:04 +02:00
8553e04a78
Merge pull request #11478 from owncloud/fix-11448
...
LDAP: add setting to wizard that disables auto-detection and enables raw mode
2014-10-16 15:35:30 +02:00
ab3535855f
more beautiful white spaces
2014-10-08 15:04:29 +02:00
67292a5345
add checkbox for experienced users to server tab
2014-10-07 16:43:58 +02:00
6c502e11f8
make scrutinizer happy, very minor changes
2014-10-01 11:55:53 +02:00
f9e085b020
init a new paged search on read operations to satisfy OpenLDAP
2014-09-30 17:00:25 +02:00
2b9696efae
abandond paged search only if PHP supports them
2014-09-30 13:13:52 +02:00
53ec32807a
abandon ongoing paged search before starting a new one
2014-09-30 12:42:37 +02:00
9a63693227
properly cancel a Paginated Results operation in order to avoid protocol errors, fixes #10526
2014-09-30 12:42:37 +02:00
fd9b79b218
Add a CLI command that deletes an LDAP config
...
With this change LDAP configurations can be managed completely from
the command line.
2014-09-30 03:23:00 +02:00
6041ae6224
dn needs to be fetched to be able to detect memberOf support
2014-09-26 15:36:49 +02:00
45b17207cc
Merge pull request #10745 from owncloud/fix-10708-doctrine
...
Use Doctrine Platform to generate SQL query for table truncation.
2014-09-16 23:56:20 +02:00
7e2bff8545
adding unit test to truncate the table
2014-09-16 16:17:25 +02:00
3c9668f605
if only one attribute is requested, the returned array has 0 as key instead of attribute name. fixes #10888
2014-09-05 14:05:37 +02:00
d0266c0bf8
Use public api for getting l10n
2014-08-31 10:08:22 +02:00
7458e21f2c
Use Doctrine Platform to generate SQL query for table truncation.
2014-08-29 20:53:51 +02:00
371cab367d
trigger email detection by Wizard upon any user filter filter change. before it happenend only upon user automatic list filter creation, but not on manual editing
2014-08-29 11:14:36 +02:00
34761dabb1
write log message, if original value was changed
2014-08-29 11:14:36 +02:00
f47a4a8c15
add unit test for mail detection
2014-08-29 11:14:35 +02:00
441c600c90
remove Access as hard dependency, inject it instead
2014-08-29 11:14:16 +02:00
baa49cd58a
Wizad: email attribute detection
2014-08-29 11:14:16 +02:00
dbd51d15e1
Port of #8623
...
set result entry identifier earlier, i.e. before a continue for the same level can happen. otherwise will always get the same value and we end up in an infinite loop
add unit test to make sure the infinite loop never comes back
Conflicts:
apps/user_ldap/tests/wizard.php
2014-08-28 11:52:33 +02:00
8f7676c762
Merge pull request #10340 from owncloud/fix-9887
...
better check whether string resembles a DN, fixes #9887
2014-08-18 19:24:41 +02:00
c46b60e822
Merge pull request #9848 from dupondje/master
...
Fix memberOf detection. Fixes : #9835
2014-08-11 16:58:30 +02:00
fc6793f2ae
better check whether string resembles a DN, fixes #9887
2014-08-11 16:40:41 +02:00
e46fc7a18a
Fix initializing in #9848
2014-08-11 13:50:13 +02:00
fc662917e7
Fix remarks in #9848
2014-08-11 09:15:56 +02:00
2676e681e9
ldap_ prefix will be added in invokeLDAPMethod(), having it would lead to a unexisting function, fixes #9829
2014-08-07 17:15:36 +02:00
71f3326035
Fix memberOf detection. Fixes : #9835
2014-07-24 14:18:41 +02:00
1d520108c5
Merge pull request #9576 from owncloud/bcmath-check
...
LDAP Active Directory Primary Groups support depends on bcmath module
2014-07-18 19:15:36 +02:00
537468f4c4
make tests deal with missing bcmath
2014-07-11 14:08:19 +02:00
ebee3543ce
warn and continue gracefully if bcmath is not installed
2014-07-10 21:26:31 +02:00
79a108c116
[Issue #9559 ] identifiers uid=xxx must be considered as user DN and not as owncloud users
2014-07-10 14:27:31 +02:00
da490bdbbe
support for AD primary groups
...
support for primary groups
actually the problem is only known on AD, it is only needed to take care of their attributes
adjust to ADs special behaviour
this change was not intended
cache the SID value so it is not requested over and over again
theres only one, use singular
we are access
add tests for new Access methods
add tests for new Group methods
address scrutinizer findings, mostly doc
call ldap_explode_dn from ldap wrapper, enables tests without php5-ldap
PHP Doc
yo dawg, i heard you like backslashes … php doc fix
PHPDoc updated and typos fixed while reviewing
2014-07-08 21:32:21 +02:00
ef7ab856f6
fix instantiation of Access class
2014-06-27 18:49:11 +02:00
89f2691515
adjust access constructor to master
2014-06-25 11:46:21 +02:00
452efa5fab
Port of LDAP Wizard: get correct total no of users, groups and complete list of groups on big setups #9002
...
fix PHPdoc
Conflicts:
apps/user_ldap/lib/connection.php
add method to count groups on LDAP
Conflicts:
apps/user_ldap/lib/access.php
LDAP Wizard: count users and groups with the power of paged search
Conflicts:
apps/user_ldap/lib/wizard.php
consolidate requirement check
fix PHPdoc
Conflicts:
apps/user_ldap/lib/access.php
Wizard: get really all groups from LDAP by power of Paged Search
Conflicts:
apps/user_ldap/lib/wizard.php
make all this work in an early configuration state in the wizard by marking the config active and ignoring the validation state.
Conflicts:
apps/user_ldap/lib/connection.php
simplify two methods a bit, because they are not used for group search anymore
Conflicts:
apps/user_ldap/lib/wizard.php
remove unused vars; increase scrutinizer happiness
2014-06-25 11:45:55 +02:00
93edacb357
Backport subset of #4179 , re-established Oracle compatibility for LDAP
...
Conflicts:
apps/user_ldap/lib/access.php
2014-06-20 20:49:34 +02:00
928945ec7e
fix typo in var name
2014-06-05 16:16:08 +02:00
9e31118675
Merge pull request #8842 from owncloud/ldap_cli_methods
...
command line tools to see, modify and test existing LDAP configurations
2014-06-04 09:37:04 +02:00
e962999896
get rid of @read in PHP doc after rebase
2014-06-03 13:01:14 +02:00
f9a9085faf
class descriptions
2014-06-03 12:59:10 +02:00
5336e9a156
newlines
2014-06-03 12:59:10 +02:00
342e1fd3bf
port of PR #8038
2014-06-03 12:59:10 +02:00
11f7823e1b
precaution: lowercase string for comparison
2014-06-03 12:59:10 +02:00
6d64d7ec3f
LDAP: put out fetching of user meta data into a fully tested class of its own and update them (mail, quota, etc.) directly after mapping. Fixes #7785 properly on master
2014-06-03 12:59:09 +02:00
4bfb162558
command line tools to see, modify and test existing LDAP configurations
2014-06-03 12:35:18 +02:00
dc36d30953
Remove all occurences of @brief and @returns from PHPDoc
...
* test case added to avoid adding them later
2014-05-19 17:50:53 +02:00
e7aebc5c32
Fix whitespace issues
2014-05-16 22:23:36 +01:00
a17f9111a0
PHPDoc fixes for user_ldap
2014-05-16 22:21:57 +01:00
c4f1de63a8
Fix PHPDoc in /apps
2014-05-16 22:21:57 +01:00
408189b7e4
Merge pull request #8556 from owncloud/kill-legacy-code-master
...
Kill legacy code master
2014-05-12 20:55:24 +02:00
cd7fc5cb80
Use array as type
2014-05-12 19:31:21 +02:00
33987eea83
remove legacy aka deprecated code: OC_Cache
2014-05-12 16:23:33 +02:00
2ae1be762c
That's bool and not always true
2014-05-11 16:29:59 +02:00
57640742af
Use WizardResult|false instead of mixed
2014-05-11 16:28:50 +02:00
416f8b186d
Use @return instead of @returns
2014-05-11 16:27:18 +02:00
fc8be5abc3
Use proper PHPDoc and variable names in the LDAP lib
...
My IDE was so sad about this that it marked the whole file in red and yellow and forced me to fix this.
2014-05-11 15:17:27 +02:00
645ecb7644
Merge pull request #6297 from leo-b/fix_ldap_errors
...
only check ldap_errno if an ldap_* function actually fails
2014-04-23 16:26:43 +02:00
c1c2f2c49e
add additional comments, PHPdoc and check whether it's really applicable
2014-04-22 18:36:43 +02:00
1c71d5c444
LDAP: cache display names immediately on retrieval, saves tens of unecessary queries to LDAP server in the share dialog for example
2014-04-22 18:36:37 +02:00
36c8dec10a
Merge pull request #8220 from owncloud/type-hinting-ldap
...
Fix PHPdoc in user_ldap
2014-04-17 18:15:40 +02:00
81751cb616
Add missing param hint
2014-04-16 17:54:10 +02:00
f6551d214f
Merge pull request #7815 from owncloud/ldap_fix_usercount_master
...
correct LDAP user count on setup with many users (occ user:report)
2014-04-16 10:36:19 +02:00
bad41c05b8
Fix PHPdoc in user_ldap
...
using scrutinizer patch
2014-04-15 21:05:49 +02:00
9feebeaf40
Merge pull request #7837 from owncloud/fix_7530
...
LDAP: fix determining objectclasses takes long
2014-04-09 12:27:17 +02:00
dbebf6bb5e
add comment to clearify when a skip in the foreach happens
2014-04-09 12:25:48 +02:00
ee3368d2ad
replace hardcoded limit of 400 with user controlled ldapPagingSize value
2014-04-09 11:38:51 +02:00
2e5adadad7
Put inner loop into own method, let's see whether it makes scrutinizer happier
2014-04-09 11:31:56 +02:00
bdc418d1f9
var count is assigned in the inner loop so it must be checked inside there to be properly used as part of the exit condition of the outer loop
2014-04-09 11:31:56 +02:00
43402c56dd
initialize variable
2014-04-09 11:31:56 +02:00
40f9875f11
LDAP: fix user report i.e. count for LDAP servers with really many users
2014-04-09 11:31:56 +02:00
8bb27551bd
LDAP: make sure cache key for paged result cookie matches when limit or offset is null or 0
2014-04-09 11:31:56 +02:00
3c9f588449
Merge pull request #6221 from leo-b/ldap_get_all_groups
...
fix updateGroups background job for ldap servers with > 1000 groups
2014-04-07 13:00:32 +02:00
0d9d70b51c
change default ldap paging size to 500
2014-03-28 14:02:19 +01:00
86d479cb28
Use array_key_exists instead of isset, because the latter returns false if the assigned value is null
2014-03-21 15:29:49 +01:00
055a09e487
On clone create a new instance of the Configuration
...
To avide effects on the original instance of Connection when the clone
is modified, for instance on authentication checks.
2014-03-21 15:27:51 +01:00
4230983e69
define var
2014-03-21 10:10:49 +01:00
a085d7715f
fix potential infinite loop when the DN of the first entry was already read.
2014-03-20 22:59:41 +01:00
561d699ca6
Use the LDAP wrapper for checking resources, needs for proper testing
2014-03-20 22:58:57 +01:00
bd881348e8
Fix wildcard handling and check even less DNs per filter, enough will be looked at anyway
2014-03-20 22:57:50 +01:00
7c3da27bf6
Fix duplicate ipauniqueid
2014-03-20 20:38:06 +00:00
057c2638e4
LDAP Wizard: when determining objectclasses, we realy do not need to look at every entry. Fixes #7530
2014-03-20 13:58:08 +01:00
ca595611f5
Add FreeIPA UUID compatibility, fixes #7796
...
Ability to use ipauniqueid for the UUID of a user
2014-03-19 20:30:24 +00:00
f850fcfac5
"reset" ldap pagedSearch control by setting it to a high value
2014-03-06 12:23:20 +01:00
6585bd5a50
"reset" ldap pagedSearch control by setting it to a high value
...
call nextEntry via invokeLDAPMethod
2014-03-06 12:07:03 +01:00
8fcc29ee8b
only check ldap_errno if an ldap_* function actually fails
...
fix wizard errors
reset search paging right after the search, not before some of the possible next search operations
cookie contains binary characters, don't log it
(avoids json_encode(): Invalid UTF-8 sequence in argument errors)
2014-03-06 12:07:03 +01:00
eb59e63c3b
revert updateGroups job to use getGroups() instead of getAllGroups()
2014-03-04 19:47:49 +01:00
15ef3145f8
Merge branch 'ldap_paging_chunksize' into ldap_get_all_groups
2014-03-04 17:24:46 +01:00
a5813acb64
add ldap_paging_size config option
2014-03-04 17:23:04 +01:00
bacda81bf7
use getAllGroup() in the updateGroups background job
...
needed in active directory deployments with > 1000 groups
2014-03-04 14:17:22 +01:00
fd5dec0298
Fixed configkey casing for PostgreSQL
2014-03-03 16:15:23 +01:00
ec9fe3f57f
Merge pull request #6299 from leo-b/ldap_nested_groups
...
Add LDAP nested groups
2014-02-25 15:41:10 +02:00
984ea7b3ff
Merge pull request #7205 from owncloud/fix_7153
...
LDAP: prevent other configuration from being deleted when deleting the f...
2014-02-20 16:22:43 +01:00
c0328b4f0f
LDAP: improve compilation of filters
2014-02-19 13:13:01 +01:00
adaee6a5a1
Scrutinizer Auto-Fixes
...
This patch was automatically generated as part of the following inspection:
https://scrutinizer-ci.com/g/owncloud/core/inspections/cdfecc4e-a37e-4233-8025-f0d7252a8720
Enabled analysis tools:
- PHP Analyzer
- JSHint
- PHP Copy/Paste Detector
- PHP PDepend
2014-02-19 09:31:54 +01:00
9fac95c2ab
Merge branch 'master' into scrutinizer_documentation_patches
...
Conflicts:
lib/private/appconfig.php
2014-02-14 23:03:27 +01:00
d88c6778ff
LDAP: prevent other configuration from being deleted when deleting the first one which has an empty prefix for historical reasons
2014-02-14 15:34:22 +01:00
e156f85bfb
Rephrase and clarify log message
2014-02-10 11:29:08 +01:00
e825a008c9
Wizard: disable LDAP referrals, fixes #6670
2014-02-10 11:28:55 +01:00
a908bd5695
throw an info message, when base dn test failed
2014-02-10 11:28:46 +01:00
bc17b40650
LDAP: extend LDAP wrapper search method for sizelimit, improves performance in wizard
2014-02-10 11:28:38 +01:00
b330d07b51
Fix more documentation failes
...
Issue #7111
2014-02-08 11:47:55 +01:00
2a6a9a8cef
polish documentation based on scrutinizer patches
2014-02-06 17:02:21 +01:00
02aa44d055
Merge branch 'master' into memcache-public
2014-01-22 13:19:49 +01:00
Arthur Schiwon
Morris Jobke
Lukas Reschke
root
Vincent Petry
Thomas Müller
root
Joas Schilling
Aaron Wood
Robin Appelman
felixboehm
Jörn Friedrich Dreyer
Thomas Müller
Roeland Jago Douma
Lukas Reschke
Joas Schilling
Arthur Schiwon
C. Montero Luque
Stefan Weil
Alex Weirig
Scrutinizer Auto-Fixer
Ralph Krimmel
Mario Kolling
Lennart Rosam
Renaud Fortier
Nicolas Grekas
Jenkins for ownCloud
Robin McCorkell
Lyonel Vincent
Andreas Fischer
Martin Konrad
Jean-Louis Dupond
Philippe Jung
Bart Visscher
Alexander Bergolth
VicDeo
Joas Schilling