3baa8d22a6
comment was wrong, block is needed nevertheless
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 17:51:11 +02:00
b71f52f137
fix obsolete usage of OCdialogs
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-24 17:34:00 +02:00
0ab6ee40de
be more clear about the condition
...
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
2020-06-16 10:55:51 +02:00
0cf57d1ed4
getXbyY can still return false, e.g. when using ldap write support
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-15 21:48:27 +02:00
5339d6df02
[tx-robot] updated from transifex
2020-06-15 02:15:55 +00:00
e1e7de43c1
[tx-robot] updated from transifex
2020-06-11 02:15:48 +00:00
959a0be4aa
Merge pull request #21318 from nextcloud/fix/noid/user-delete-clear-ldap-cache
...
clear LDAP cache after user deletion
2020-06-09 10:21:45 +02:00
99e14b5ada
[tx-robot] updated from transifex
2020-06-09 02:15:56 +00:00
4edf8630c4
clear LDAP cache after user deletion
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-08 17:52:43 +02:00
64fe042b0d
tidy up Group_LDAP
...
* remove unused method
* resolve code duplication
* remove usage of deprectad Util::writeLog
* phpDoc updates
* signature updates
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-06-08 13:40:24 +02:00
64c15a15d4
[tx-robot] updated from transifex
2020-05-30 02:16:04 +00:00
1d469fc06e
[tx-robot] updated from transifex
2020-05-28 02:16:38 +00:00
aed6f0f71e
simplify getGroups, fixing wrong chunking logic
...
pagination is taken care of properly in the search logic in Access class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 14:41:10 +02:00
69e2aa029b
Merge pull request #21108 from nextcloud/fix/20745/eor-old-php-api
...
fixes infinitely repeating LDPA search results with PHP <= 7.2
2020-05-26 11:54:20 +02:00
fda71a9979
[tx-robot] updated from transifex
2020-05-26 02:16:03 +00:00
15008a1798
fixes infinitely repeating LDPA search results with PHP <= 7.2
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 00:37:46 +02:00
23080fcd9c
[tx-robot] updated from transifex
2020-05-23 02:16:22 +00:00
4db4d8fc93
Merge pull request #21001 from rubo77/pngs
...
compress some images with tinypng.com
2020-05-22 16:37:58 +02:00
4ad622a720
compress some images with tinypng.com
...
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-22 13:07:11 +00:00
3b519f776a
[tx-robot] updated from transifex
2020-05-22 02:17:20 +00:00
d870e9ece5
[tx-robot] updated from transifex
2020-05-21 02:17:26 +00:00
1b55119c85
[tx-robot] updated from transifex
2020-05-19 02:17:09 +00:00
a8ac6df1d0
[tx-robot] updated from transifex
2020-05-18 02:16:22 +00:00
a84eec88e8
[tx-robot] updated from transifex
2020-05-16 02:17:14 +00:00
d132f81d28
[tx-robot] updated from transifex
2020-05-15 02:17:17 +00:00
ab2df70e3a
[tx-robot] updated from transifex
2020-05-13 02:16:26 +00:00
901110f068
[tx-robot] updated from transifex
2020-05-12 02:16:11 +00:00
10f62eb2a4
[tx-robot] updated from transifex
2020-05-09 02:16:34 +00:00
af1dd9f152
Bump app versions and requirements
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-07 10:29:04 +02:00
9f448d864b
[tx-robot] updated from transifex
2020-05-01 02:16:47 +00:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
297276baba
[tx-robot] updated from transifex
2020-04-29 02:16:55 +00:00
0c701cec56
Merge pull request #20676 from clementhk/ldap-group
...
Don't remove last user in ldap group when limit is -1
2020-04-28 12:58:02 +02:00
ef566a1f40
[tx-robot] updated from transifex
2020-04-28 02:16:22 +00:00
9f5f505acf
Don't remove last user in ldap group when limit is -1
...
Signed-off-by: Clement Wong <git@clement.hk>
2020-04-27 02:33:00 +02:00
39f6f1ba34
[tx-robot] updated from transifex
2020-04-25 02:16:01 +00:00
212138daa1
Merge pull request #19919 from nextcloud/enh/noid/ldpa_group_perf
...
LDAP Group Backend optimizations
2020-04-24 12:27:27 +02:00
4babdc082b
formatting
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-23 21:34:05 +02:00
8ffa762486
Merge pull request #20536 from nextcloud/fix/noid/ldap-73api-read-wo-pagedresults
...
do not run paged results against ldap_read ops on PHP7.3+
2020-04-22 13:37:43 +02:00
8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
...
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
75c686d825
do not run paged results against ldap_read ops on PHP7.3+
...
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-21 15:47:49 +02:00
f0c1041d2e
[tx-robot] updated from transifex
2020-04-21 02:16:40 +00:00
b1a90da347
[tx-robot] updated from transifex
2020-04-20 02:16:12 +00:00
708b4991d9
Fix legacy routes
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
ab550d682f
do not rerun expensive sanitizer against already processed DNs
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:49:47 +02:00
32000dd1af
read records from DB for lists at once, not one by one.
...
Keep a runtime cache of dn-id-mapping
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:39:54 +02:00
cc31c38277
don't circulate with only one backend
...
- saves some overhead costs
- in some occasions saves LDAP requests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:52 +02:00
e8ddb4718c
consolidate groupsMatchFilter in groupsExist
...
- less duplication
- profiting of the same cache entry
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-17 12:38:07 +02:00
d9990b09b8
PHP-CS-Fixer green
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:25:17 +02:00
078ac97939
[tx-robot] updated from transifex
2020-04-16 02:17:30 +00:00
84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
...
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +02:00
6187cea304
[tx-robot] updated from transifex
2020-04-13 02:19:45 +00:00
734c62bee0
Format code according to PSR2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
1584c9ae9c
Add visibility to all methods and position of static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
078b12a9b0
[tx-robot] updated from transifex
2020-04-10 02:18:23 +00:00
008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
...
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
...
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
a8a06a82d2
Remove trailing whitespaces from comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
8146e1988c
[tx-robot] updated from transifex
2020-04-08 02:18:45 +00:00
cac1480bf8
[tx-robot] updated from transifex
2020-04-05 02:18:04 +00:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
9e8ac1d24a
[tx-robot] updated from transifex
2020-03-30 02:18:34 +00:00
89710bbdcf
[tx-robot] updated from transifex
2020-03-29 02:20:14 +00:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
62403d0932
Merge pull request #20123 from lippl/bugfix/ldap-user_count-warning
...
Bugfix - Prevent PHP Warning for count on null on LDAP
2020-03-26 11:28:26 +01:00
8769d97f62
single squashed commit for bug fix
...
Signed-off-by: Philipp Staiger <philipp@staiger.it>
2020-03-26 09:01:35 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
06d1b327ff
[tx-robot] updated from transifex
2020-03-24 02:18:45 +00:00
bacf0d802a
[tx-robot] updated from transifex
2020-03-22 02:18:37 +00:00
5817047c3e
Merge pull request #20039 from nextcloud/fix/19549/fix-uuid-attr-detection
...
fixes auto-detecting UUID attributes
2020-03-20 11:06:37 +01:00
3fa63f2842
[tx-robot] updated from transifex
2020-03-20 02:18:21 +00:00
77c63e3b24
fixes auto-detecting UUID attributes
...
the continue (and later the early return) avoided proper looping over the
attribute candidates.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-03-19 19:42:46 +01:00
150f39ed50
Update autoloaders for composer v1.10.1
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-19 09:48:49 +01:00
4a019ab04c
[tx-robot] updated from transifex
2020-03-09 02:18:09 +00:00
35ccf07ad4
[tx-robot] updated from transifex
2020-03-07 02:17:55 +00:00
a036ca6018
[tx-robot] updated from transifex
2020-03-06 02:18:23 +00:00
351cd95777
[tx-robot] updated from transifex
2020-03-02 02:17:53 +00:00
aaf1cb70a2
Merge pull request #19549 from nextcloud/fix/19418/uuid-attr-log-flood
...
remove noise from detectUuid and cache results
2020-02-24 20:03:53 +01:00
921253033a
[tx-robot] updated from transifex
2020-02-24 02:19:17 +00:00
9d122c39ab
[tx-robot] updated from transifex
2020-02-23 02:19:29 +00:00
6c12d16def
[tx-robot] updated from transifex
2020-02-20 02:18:42 +00:00
407b8fddfc
remove noise from detectUuid and cache results
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-19 16:42:36 +01:00
bdab337313
[tx-robot] updated from transifex
2020-02-15 02:18:10 +00:00
29ec5e6c96
[tx-robot] updated from transifex
2020-02-11 02:18:33 +00:00
a0e57ea6d3
sort prefixes for deterministic LDAP query behaviour
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-02-07 18:10:31 +01:00
1afe8906bc
[tx-robot] updated from transifex
2020-02-07 02:20:10 +00:00
698cfbd9cb
[tx-robot] updated from transifex
2020-02-06 02:18:41 +00:00
23fc654fc4
[tx-robot] updated from transifex
2020-02-05 02:18:06 +00:00
0b710e582b
[tx-robot] updated from transifex
2020-02-04 02:18:05 +00:00
c9af72ec30
Merge pull request #19250 from nextcloud/rakekniven-patch-1
...
l10n: Changed spelling of "user name" to "username"
2020-02-03 10:24:48 +01:00
f39c1a21f8
[tx-robot] updated from transifex
2020-02-02 02:17:40 +00:00
984c757be8
l10n: Changed spelling of "user name" to "username"
...
Using "username" like on > 200 strings over the whole Nextcloud project.
Signed-off-by: rakekniven mark.ziegler@rakekniven.de
2020-02-01 12:58:32 +01:00
69d2893a75
[tx-robot] updated from transifex
2020-01-31 02:17:52 +00:00
0585c76d16
[tx-robot] updated from transifex
2020-01-29 02:18:13 +00:00
78d400cec2
[tx-robot] updated from transifex
2020-01-27 02:17:55 +00:00
22e3a74f90
[tx-robot] updated from transifex
2020-01-24 02:16:52 +00:00
8728eab9d7
Fix app updates
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-21 14:00:58 +01:00
434fd438d9
[tx-robot] updated from transifex
2020-01-19 02:17:21 +00:00
a61bad6ede
[tx-robot] updated from transifex
2020-01-18 02:18:30 +00:00
950856d5bb
Merge pull request #17717 from nextcloud/fix/noid/ldap-relax-getHome
...
relax strict getHome behaviour for LDAP users in a shadow state
2020-01-14 09:57:24 +01:00
489ed878e1
ensure that only valid group members are returned
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-13 17:13:08 +01:00
79667b58a9
cache group existence early to save useless requests to LDAP
...
we do it for users already
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-08 11:02:37 +01:00
f657ded6ec
remove superfluous tests
...
- user_ldap is not exposed to public api, it is always behind ldap_proxy
- this is too much for a unit test
- integration tests cover userExists implicitly
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-08 09:21:22 +01:00
1068b860ff
adjust tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-08 09:21:22 +01:00
5cae135b94
decouple userExists from userExistsOnLDAP check
...
allows to mark users as offline right away, avoids a gap of being not a
user and causing weird side effects
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-08 09:21:22 +01:00
411a47cadb
relax strict getHome behaviour for LDAP users in a shadow state
...
* simplifies deletion process
* less strange behaviour when looking up home storage (as long as it is local)
* thus could enable transfer ownerships after user went invisible on ldap
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-08 09:21:21 +01:00
32f79c9f0c
[tx-robot] updated from transifex
2020-01-06 02:27:21 +00:00
46706d01e0
[tx-robot] updated from transifex
2020-01-05 02:30:34 +00:00
797b603a1f
[tx-robot] updated from transifex
2020-01-04 02:27:44 +00:00
1d8da461d5
[tx-robot] updated from transifex
2019-12-23 02:27:33 +00:00
c81e05db98
[tx-robot] updated from transifex
2019-12-22 02:28:34 +00:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +01:00
9772dbd19e
Fix LDAP application class instance created directly
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-09 10:12:02 +01:00
b41112a023
[tx-robot] updated from transifex
2019-12-07 02:16:37 +00:00
da84b36186
[tx-robot] updated from transifex
2019-12-06 02:16:59 +00:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
cc80339b39
Add typed create user events
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-12-03 08:03:57 +01:00
669302e570
Merge pull request #18064 from nextcloud/feature/php74
...
Add php7.4 support
2019-11-28 08:36:10 +01:00
563f9153a2
[tx-robot] updated from transifex
2019-11-28 02:16:54 +00:00
17a9d5856f
TO REVERT LATER: disable some tests in UserTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:28 +01:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
8d4346d656
Fix more tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:42 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
7015501a74
Merge pull request #18005 from nextcloud/fix/manual-app-instances
...
Remove some more direct app instance creations
2019-11-26 09:20:14 +01:00
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
...
Some php-cs fixes
2019-11-25 14:07:00 +01:00
97385cef33
Remove some more direct app instance creations
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-11-25 08:42:16 +01:00
573c800b00
[tx-robot] updated from transifex
2019-11-25 02:15:54 +00:00
4f2837017c
[tx-robot] updated from transifex
2019-11-23 02:16:07 +00:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
0d7f55aae9
[tx-robot] updated from transifex
2019-11-22 02:16:16 +00:00
e7f225c013
Merge pull request #18016 from nextcloud/fix/noid/ldap-checkup-batchsize
...
make chunksize (used to check for gone LDAP users) configurable
2019-11-21 11:05:54 +01:00
b9dccf5929
uid can be false when the user record does not exit ( #18030 )
...
uid can be false when the user record does not exit
2019-11-21 07:08:33 +01:00
37ef64d24e
[tx-robot] updated from transifex
2019-11-21 02:16:02 +00:00
213016f758
uid can be false when the user record does not exit
...
fixes not loading files app for users who got a share by the gone LDAP user
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-20 19:44:12 +01:00
f990620e6b
make chunksize (used to check for gone LDAP users) configurable
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-20 19:43:53 +01:00
afa0f2c0d8
[tx-robot] updated from transifex
2019-11-20 02:16:19 +00:00
9707fcf4fe
[tx-robot] updated from transifex
2019-11-19 02:17:47 +00:00
c952bec11d
[tx-robot] updated from transifex
2019-11-14 02:16:16 +00:00
Arthur Schiwon
Nextcloud bot
Roeland Jago Douma
Ruben Barkow-Kuder
Joas Schilling
Christoph Wurst
Clement Wong
Morris Jobke
Roeland Jago Douma
Christoph Wurst
Philipp Staiger
rakekniven
John Molakvoæ