Commit Graph

3001 Commits

Author SHA1 Message Date
Robin Appelman 0d6910ac13
disable touch to update mtime for external s3 storage
since updating the mtime requires doing a copy this can have a significant overhead and it messes with versioning

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-07 15:55:38 +02:00
Julius Härtl f5cc34c9c2
Reuse cache for directory mtime/size if filesystem changes can be ignored
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-07 10:22:22 +02:00
Joas Schilling 347ab5241c
Move files_external to migrations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-06 16:42:14 +02:00
Joas Schilling d7c0b9cced
Also always return in app commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 15:12:11 +02:00
Julius Härtl 69f4c50032
Remove rescanDelay from directory mtime
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-06-22 14:15:57 +02:00
Nextcloud bot e324c90a8d
[tx-robot] updated from transifex 2020-06-18 02:16:35 +00:00
Nextcloud bot e1e7de43c1
[tx-robot] updated from transifex 2020-06-11 02:15:48 +00:00
Robin Appelman 892589746d
Merge pull request #21252 from nextcloud/smb-3.2.5
update icewind/smb to 3.2.5
2020-06-09 12:27:46 +00:00
Nextcloud bot 99e14b5ada
[tx-robot] updated from transifex 2020-06-09 02:15:56 +00:00
Joas Schilling 33f6a26a7d
Merge pull request #21091 from nextcloud/sftp-normalize-path
normalize sftp path in read and write stream
2020-06-03 12:17:38 +02:00
Nextcloud bot f62f23ed1d
[tx-robot] updated from transifex 2020-06-03 02:16:18 +00:00
Nextcloud bot 0f4de3d353
[tx-robot] updated from transifex 2020-06-01 02:16:00 +00:00
Nextcloud bot 64c15a15d4
[tx-robot] updated from transifex 2020-05-30 02:16:04 +00:00
Robin Appelman 41fdfc9966
update icewind/smb to 3.2.5
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-27 17:44:54 +02:00
Nextcloud bot b9d17cfdec
[tx-robot] updated from transifex 2020-05-27 02:16:10 +00:00
Robin Appelman 6f2e920a5b
normalize sftp path in read and write stream
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-25 15:26:04 +02:00
Nextcloud bot 23080fcd9c
[tx-robot] updated from transifex 2020-05-23 02:16:22 +00:00
Nextcloud bot 3b519f776a
[tx-robot] updated from transifex 2020-05-22 02:17:20 +00:00
Nextcloud bot 74e577876c
[tx-robot] updated from transifex 2020-05-20 02:16:28 +00:00
Nextcloud bot 1b55119c85
[tx-robot] updated from transifex 2020-05-19 02:17:09 +00:00
Morris Jobke 385b060893
Merge pull request #20941 from nextcloud/smb-3.2.4
update icewind/smb to 3.2.4
2020-05-15 14:32:56 +02:00
Nextcloud bot 75d50a55b8
[tx-robot] updated from transifex 2020-05-14 02:16:36 +00:00
Robin Appelman 42019c0f4f
update icewind/smb to 3.2.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-12 14:39:08 +02:00
Nextcloud bot 901110f068
[tx-robot] updated from transifex 2020-05-12 02:16:11 +00:00
Joas Schilling af1dd9f152
Bump app versions and requirements
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-07 10:29:04 +02:00
Nextcloud bot 97f36e62f2
[tx-robot] updated from transifex 2020-05-07 02:16:14 +00:00
Nextcloud bot d2f165e448
[tx-robot] updated from transifex 2020-05-03 02:16:16 +00:00
Nextcloud bot e77e0b0e2f
[tx-robot] updated from transifex 2020-05-02 02:16:32 +00:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Nextcloud bot ef566a1f40
[tx-robot] updated from transifex 2020-04-28 02:16:22 +00:00
Nextcloud bot 0eeb660679
[tx-robot] updated from transifex 2020-04-26 02:16:12 +00:00
Nextcloud bot 39f6f1ba34
[tx-robot] updated from transifex 2020-04-25 02:16:01 +00:00
Nextcloud bot 84a3536159
[tx-robot] updated from transifex 2020-04-24 02:27:55 +00:00
Robin Appelman 7f32fe6d50
add tooltip to option
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-22 14:25:33 +02:00
Robin Appelman 23e2baeb95
Add option to check share ACL's when listing directories
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Nextcloud bot f0c1041d2e
[tx-robot] updated from transifex 2020-04-21 02:16:40 +00:00
Robin Appelman 9735b5d61f
Add method to storage backends to get directory content with metadata
Currently you need to use `opendir` and then call `getMetadata` for
every file, which adds overhead because most storage backends already
get the metadata when doing the `opendir`.

While storagebackends can (and do) use caching to relief this problem,
this adds cache invalidation dificulties and only a limited number of
items are generally cached (to prevent memory usage exploding when
scanning large storages)

With this new methods storage backends can use the child metadata they
got from listing the folder to return metadata without having to keep
seperate caches.

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-20 15:45:04 +02:00
Joas Schilling 708b4991d9
Fix legacy routes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-18 11:21:28 +02:00
Nextcloud bot 078ac97939
[tx-robot] updated from transifex 2020-04-16 02:17:30 +00:00
Julien Lutran 3e849daf11
Fix issues with Keystone auth v3 in files_external app
Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>
2020-04-15 10:33:08 +02:00
Nextcloud bot bccd13ffae
[tx-robot] updated from transifex 2020-04-15 02:17:12 +00:00
Nextcloud bot 6187cea304
[tx-robot] updated from transifex 2020-04-13 02:19:45 +00:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
John Molakvoæ 732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
Christoph Wurst 85e369cddb
Fix multiline comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
Robin Appelman 2340f4f2d5
update icewind/smb to 3.2.3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 17:30:47 +02:00
Nextcloud bot 8146e1988c
[tx-robot] updated from transifex 2020-04-08 02:18:45 +00:00
Roeland Jago Douma 1d62b9786f
Merge pull request #20276 from nextcloud/files-external-param-tooltop
allow setting tooltips for external storage config options
2020-04-06 16:42:39 +02:00
Nextcloud bot cac1480bf8
[tx-robot] updated from transifex 2020-04-05 02:18:04 +00:00
Robin Appelman 857957b45e
allow setting tooltips for external storage config options
allows explaining non-obvious config options a bit more

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-03 15:44:53 +02:00
Nextcloud bot 4e8bbc4e34
[tx-robot] updated from transifex 2020-04-03 12:08:12 +00:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
John Molakvoæ fa4162e86f
Merge pull request #20208 from nextcloud/smb-folder-contents-normalize-path
normalize smb path while listing folder contents
2020-03-30 10:06:39 +02:00
John Molakvoæ 20ecbd60fd
Merge pull request #20207 from nextcloud/smb-3.2.1
update icewind/smb to 3.2.1
2020-03-30 10:05:48 +02:00
Nextcloud bot 89710bbdcf
[tx-robot] updated from transifex 2020-03-29 02:20:14 +00:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +01:00
Robin Appelman ef7bb5225a
normalize smb path while listing folder contents
currently when listing `'/'`, it will include a double slash in the paths used for the listing logic
this causes unneeeded cache misses in the statCache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 17:04:53 +01:00
Robin Appelman b41e62db99
update icewind/smb to 3.2.1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-27 16:57:55 +01:00
Nextcloud bot f680f19364
[tx-robot] updated from transifex 2020-03-27 02:18:20 +00:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Christoph Wurst 2ee65f177e
Use the shorter phpunit syntax for mocked return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
Christoph Wurst 74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
Nextcloud bot e4d85fa284
[tx-robot] updated from transifex 2020-03-25 02:18:27 +00:00
Nextcloud bot be4cf8992d
[tx-robot] updated from transifex 2020-03-23 02:19:02 +00:00
Christoph Wurst c5cb3bb665
Do not use the deprecated service name
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-19 15:04:23 +01:00
Roeland Jago Douma 0eb3c3ed18
Merge pull request #19932 from nextcloud/remove-placeholder-check
remove the requirement that everything that looks like a placeholder …
2020-03-17 21:34:08 +01:00
Nextcloud bot 82d4bdd770
[tx-robot] updated from transifex 2020-03-17 02:18:42 +00:00
Nextcloud bot 0d6c8a3476
[tx-robot] updated from transifex 2020-03-15 02:19:16 +00:00
Robin Appelman db49ae3cb6
fix external storage controller tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:33:47 +01:00
Robin Appelman 59082661ca
remove the requirement that everything that looks like a placeholder is substituted
While maybe not common, `$` is a valid option in config fields

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 15:29:14 +01:00
Joas Schilling 17bc35e4f1
Merge pull request #19915 from nextcloud/external-storage-password-placeholders
Use placeholder values for password fields in external storage webui
2020-03-13 10:54:40 +01:00
Robin Appelman 0d112d7901
Use placeholder values for password fields in external storage webui
This prevents the password from being sent to the webui.

While an admin will always be able to retrieve the passwords (as they
can do arbitrairy code execution by design) this prevents casual
password snooping

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-12 19:45:23 +01:00
Nextcloud bot 99aa7adaef
[tx-robot] updated from transifex 2020-03-12 02:19:02 +00:00
Robin Appelman 223ee42a53
faster implementation of SFTP write stream
using mostly the same techniques as the read stream

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-10 16:18:40 +01:00
Robin Appelman fe4e80093e
Faster implementation of sftp read stream
- Keeps a single file handle open instead of creating a new one for
every stream_read
- Read from sftp in large chunks instead of the 8k internal php size
- Request a read for the next chunk while we're still processing the
current one

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-06 16:57:18 +01:00
Nextcloud bot 48b374f683
[tx-robot] updated from transifex 2020-03-05 02:18:19 +00:00
Nextcloud bot dccecf822d
[tx-robot] updated from transifex 2020-02-28 02:18:36 +00:00
Nextcloud bot 0e7163c7c1
[tx-robot] updated from transifex 2020-02-26 02:18:20 +00:00
Nextcloud bot 9d122c39ab
[tx-robot] updated from transifex 2020-02-23 02:19:29 +00:00
Nextcloud bot eb28572f9b
[tx-robot] updated from transifex 2020-02-19 02:18:14 +00:00
Nextcloud bot 8a841fc331
[tx-robot] updated from transifex 2020-02-14 02:18:09 +00:00
Nextcloud bot c34570faf8
[tx-robot] updated from transifex 2020-02-13 02:19:26 +00:00
Nextcloud bot 29ec5e6c96
[tx-robot] updated from transifex 2020-02-11 02:18:33 +00:00
Nextcloud bot 6a82bb1f00
[tx-robot] updated from transifex 2020-02-08 02:18:22 +00:00